[Bug 1491071] Re: Xmir doesn't update the screen size until something is actually rendered

[Daniel van Vugt]

*** This bug is a duplicate of bug 1417541 ***
https://bugs.launchpad.net/bugs/1417541

The resize logic in question was rewritten recently to work (better) in
-rootless mode. As for non-rootless mode that's still more broken, but
also already logged as bug 1417541. So we'll track it there.

** This bug has been marked a duplicate of bug 1417541
   Xmir root window does not resize reliably; corruption occurs

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1491071

Title:
  Xmir doesn't update the screen size until something is actually
  rendered

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1491071/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1491071] Re: Xmir doesn't update the screen size until something is actually rendered

[Robert Ancell]

** Changed in: xorg-server (Ubuntu)
   Status: New => Triaged

** Changed in: xorg-server (Ubuntu)
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1491071

Title:
  Xmir doesn't update the screen size until something is actually
  rendered

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1491071/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1491071] Re: Xmir doesn't update the screen size until something is actually rendered

[Robert Ancell]

Hey, you know XMir is on a git branch right?

lp:~xmir-team/xorg-server/+git/xmir

where lp is git+ssh://usern...@git.launchpad.net/

Should be easier to generate diffs - propose merges.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1491071

Title:
  Xmir doesn't update the screen size until something is actually
  rendered

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1491071/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1491071] Re: Xmir doesn't update the screen size until something is actually rendered

[Robert Ancell]

The patch files in the Ubuntu package are just generated from the git
branch using format-patch. I rebase this branch each time I update the
Ubuntu package.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1491071

Title:
  Xmir doesn't update the screen size until something is actually
  rendered

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1491071/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1491071] Re: Xmir doesn't update the screen size until something is actually rendered

[Robert Ancell]

Yeah, it makes sense to me to just call xmir_output_handle_resize after
getting the mir_event_type_resize. I think we could definitely drop the
damage call as well - this will be done inside xmir_output_handle_resize
anyway.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1491071

Title:
  Xmir doesn't update the screen size until something is actually
  rendered

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1491071/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1491071] Re: Xmir doesn't update the screen size until something is actually rendered

[Christopher Townsend]

Well, my patch-foo seems week as I can't seem to generate a good diff.
At any rate, here's what I'm proposing:

Using a fully patched source tree, open hw/xmir/xmir-input.c.  Find the
xmir_handle_input_in_main_thread() function.  In the
mir_event_type_resize case add the following after the ErrorF() line:

xmir_output_handle_resize(ctx->xmir_window,
mir_resize_event_get_width(mir_event_get_resize_event(ev)),
mir_resize_event_get_height(mir_event_get_resize_event(ev)));

such that the code block looks like:

case mir_event_type_resize:
ErrorF("Resize requested to %ix%i\n", 
mir_resize_event_get_width(mir_event_get_resize_event(ev)), 
mir_resize_event_get_height(mir_event_get_resize_event(ev)));
xmir_output_handle_resize(ctx->xmir_window, 
mir_resize_event_get_width(mir_event_get_resize_event(ev)), 
mir_resize_event_get_height(mir_event_get_resize_event(ev)));
if (ctx->xmir_window->damage)
DamageDamageRegion(>xmir_window->window->drawable, 
>xmir_window->region);
break;

I'm thinking since xmir_output_handle_resize() is being called, we might
be able to remove some subsequent calls to it to avoid some overhead.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1491071

Title:
  Xmir doesn't update the screen size until something is actually
  rendered

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1491071/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs