[Bug 1500282]
http://googledrawing.com/ http://4dresult.org/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1500282]
(In reply to Karl Tomlinson (:karlt) from comment #11) > (In reply to Stefan Seidel from comment #8) > > So is there a reason to apply the rounding *in Firefox* where my patch would > > remove it? From a GTK3 point of view, probably, because the reason you > > mentioned that an application can provide hi-res bitmaps etc. From a Firefox > > point of view, I can say that there is no *technical* reason, i.e. setting > > devPixelsPerPx to a float value by hand (as Kai Mast has reported), produces > > the desired result - Firefox scales the content according to the preference. > > There are similar reasons re images from web content. > Firefox will scale, but will only render without interpolation if the web > content supports the resolution. > > See also https://bugzilla.mozilla.org/show_bug.cgi?id=1081142#c10 > > > Comparing this > > to the Windows behaviour: the set scaling it read from the system as is, > > with no rounding applied. > > Windows usually scales in steps, 1, 1.25, 1.5, 2 (and maybe higher). > > Adding a 1.5 step makes sense, I think, especially because this is supported > on Windows, and so has some chance of support from web authors. > > I'm not so keen on adding 1.25 because the benefits of a different size don't > necessarily outweigh the disadvantage of likely interpolation. At 1.25, > Windows defaults (in some versions at least) to XP scaling, which scales > font sizes but not pixels. Doing this in web content broke too many sites. > The goal is to pick what will be best for most and layout.css.devPixelsPerPx > is available for those where this doesn't work out. http://4dresult.org/ http://googledrawing.com/ http://howtohub.co/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1500282] Re: pixel scaling seems to be rounded to integers
Hey, I'm one of the original bug reporters. Thanks for working on this! It works fine for me now too. I also use wayland and a recent Ubuntu (19.10). Feel free to close this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1500282]
> Is there any update on this? On Wayland-enabled Firefox build (Ubuntu and Fedora provide such builds) launched with MOZ_ENABLE_WAYLAND=1 under Gnome Shell Wayland session scaling works correctly. I didn't tested other cases. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1500282] Re: pixel scaling seems to be rounded to integers
Launchpad has imported 46 comments from the remote bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1214470. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2015-10-14T02:19:54+00:00 Kai Mast wrote: User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 Build ID: 20151003161951 Steps to reproduce: Set the scaling vlaue in unity-control-center to a float value, e.g. 1.5. Actual results: Firefox adapts its highdpi settings to the value in unity-control- center. However, it will round the scale to the next higher value, e.g. 2.0. This means everything is much bigger than it should be. If I set devPixelsPerPx to 1.5 manually everything looks fine. So there must be some bug in firefox that is reading this value as an integer. Expected results: Firefox should use the actual floating point value. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1500282/comments/1 On 2015-10-14T02:21:15+00:00 Kai Mast wrote: (If somebody tells me where to look I might be able to submit a patch...) Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1500282/comments/2 On 2016-02-26T20:33:30+00:00 Moz-bugzilla-e wrote: Created attachment 8724197 patch to use actual gtk scaling Here is the patch which fixes this. It basically removes the rounding applied when reading the current DPI from gdk_screen_get_resolution(). I have tested this and it works as expected: the Xft/DPI value is read from XSETTINGS, returned in gdk_screen_get_resolution() and then correctly applied to the content rendering as well. This is consistent with the UI rendering, which already gets scaled correctly at all Xft/DPI values > 96. I hope this can be included. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1500282/comments/3 On 2016-02-26T20:39:18+00:00 Moz-bugzilla-e wrote: Further information: it seems that no-one ever questioned in the initial commit why "We want to set the default CSS to device pixel ratio as the closest _integer_ multiple, so round the ratio of actual dpi to CSS dpi (96)". This probably comes from the fact that GDK_SCALE and GDK_DPI_SCALE only accept integer values (and 0.5). There is no _technical_ requirement for this, though. https://developer.gnome.org/gtk3/unstable/GtkSettings.html#GtkSettings --gtk-xft-dpi accepts granularities of 1/1024th DPI. Also, the "component" of this bug should probably be changed to Gtk:Widget or seomthing else. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1500282/comments/4 On 2016-02-29T10:42:00+00:00 Stransky wrote: Yes, this scale (also editable by GDK_SCALE for debugging purposes) are intended to handle hi-res displays like retina. The DPI scale is just one part of it - the application is supposed to also provide hi-res graphics (pictures, icons, controls) for those modes. IIUC This is also a reason why it's integer scale - to easily scale bitmap images like icons or to provide hi-res icon set. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1500282/comments/5 On 2016-02-29T11:05:55+00:00 Moz-bugzilla-e wrote: But from my (limited) understanding, the problem is that the GDK_SCALE is not the value which is rounded here. As I see it, the DPI (referred to as font scaling, gtk-xft-dpi or Xft/DPI setting) operates independently from the "global" GDK_SCALE setting. If I am reading bug #1131978 correctly, both are used to determine the overall "scale" within Firefox. That is, the font scaling read from gdk_screen_get_resolution is not affected by GDK_SCALE (but maybe by GDK_DPI_SCALE?). In any case, it is obvious that the *UI* (is it called chrome?) part of Firefox scales correctly (as seen for example in the font size in about:settings and the tab font size), but the *content* part doesn't. After applying this patch, both scale consistently. Reply at: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1500282/comments/6 On 2016-02-29T11:47:19+00:00 Stransky wrote: AFAIK the GDK_SCALE is here for debugging purpose only (if you want to emulate hi-res mode on a regular display so if you want to override the fedault) and it's involved unless user set it explicitly by hand (by gnome-tweaking-tool for instance). Reply at: https://bug
[Bug 1500282] Re: pixel scaling seems to be rounded to integers
Weird. I just upgraded to Zesty. Firefox now seems to autodetect changes in the pixel scaling (no restart needed), but it rounds again to integers >.< -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1500282] Re: pixel scaling seems to be rounded to integers
Seems to be fixed for Firefox in xenial but not for Thunderbird. ** Also affects: thunderbird Importance: Undecided Status: New ** Also affects: thunderbird (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1500282] Re: pixel scaling seems to be rounded to integers
** Changed in: firefox Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1500282] Re: pixel scaling seems to be rounded to integers
** Changed in: firefox Status: Unknown => New ** Changed in: firefox Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1500282] Re: pixel scaling seems to be rounded to integers
** Bug watch added: Mozilla Bugzilla #1214470 https://bugzilla.mozilla.org/show_bug.cgi?id=1214470 ** Also affects: firefox via https://bugzilla.mozilla.org/show_bug.cgi?id=1214470 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1500282] [NEW] pixel scaling seems to be rounded to integers
Public bug reported: Firefox adapts its highdpi settings to the value in unity-control- center. However, right now I have it set to 1.5 and firefox seems to scale it to 2.0. I.e. everything is much bigger than it should be. If I set devPixelsPerPx to 1.5 manually everything looks fine. So there must be some bug in firefox that is reading this value as an integer. ** Affects: firefox (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1500282 Title: pixel scaling seems to be rounded to integers To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1500282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
