[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Mathew Hodson]

** Bug watch removed: Debian Bug tracker #832938
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832938

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Launchpad Bug Tracker]

This bug was fixed in the package zfs-linux - 0.6.5.6-0ubuntu12

---
zfs-linux (0.6.5.6-0ubuntu12) xenial; urgency=medium

  * Change to include some important tools in zfsutils-linux build.
  - Add tools : arcstat.py, arc_summary.py & dbufstat.py in /usr/sbin.
  - Change utilities path (bindir) to /usr/sbin per
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/comments/6
  - Add python related dependencies (LP: #1574342)

zfs-linux (0.6.5.6-0ubuntu11) xenial; urgency=medium

  [ Richard Laager ]
  * Set PATH in cron.d job to fix monthly scrubs. (LP: #1548009)

 -- Eric Desrochers   Thu, 28 Jul 2016
16:18:16 -0400

** Changed in: zfs-linux (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

@scotte (lscotte),

The .py removal will come separately, the package found in -proposed
(Xenial) and -update (Yakkety) are for the original issue only:
arcstat.py, arc_summary.py & dbufstat.py not ship in the Ubuntu
zfsutils-linux DEB package.

Another package version will include the .py suffix removal.

Eric

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[scotte]

@slashd Sorry for not being more clear - I already tested from proposed
(see comment #22). As far as I can tell, it hasn't changed since then
but it is unclear to me if the renaming from .py from upstream will
happen separately or as part of this issue. I'm fine with it either way,
it just helps in knowing the plan. Thanks.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

@rlaager,

Thanks for the .debdiff, let's wait and see what will be done in Debian
by Aron, and then cherry-pick what's needed to remove the .py suffix.

Also instead of using "mv" to rename, I wonder if dh-exec can be put to
use for renaming files during the dh_install phase.

example :
usr/sbin/arc_summary.py => usr/sbin/arc_summary
usr/sbin/arcstat.py => usr/sbin/arcstat
usr/sbin/dbufstat.py => usr/sbin/dbufstat

Regards,
Eric

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

Hi scotte (lscotte),

The xenial patched package can be found in the -proposed archive (AKA
Fix Commited : last step before landing into stable release -update) if
positive feedbacks from community.

Here's the instruction on how to enable -proposed archive:

https://wiki.ubuntu.com/Testing/EnableProposed

Regards,
Eric

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[scotte]

OOps, per my last comment regarding tracking issue upstream - that's the
Debian bug you previously mentioned, https://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=832938, not further upstream from ZoL. Sorry for
my misunderstanding. :-/

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[scotte]

That's great news that upstream ZFS will get that fixed up - I didn't
see a an issue for it at the ZoL github, are there plans to do so. Would
be nice from a tracking perspective so this issue is tied in.

Also, I see the Ubuntu update was published for Yakkety, but I'm not
sure where Zenial is - will the same Ubuntu fix go for Xenial, or is it
waiting for validation, fix from upstream, or ? Thanks and let me know
anything I can do to help.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

Following a discussion with a ZFS debian maintainer

He confirmed that he is going to put the python scripts into /usr/sbin
and remove the .py suffix in the Debian package.

Eric

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Launchpad Bug Tracker]

This bug was fixed in the package zfs-linux - 0.6.5.7-0ubuntu5

---
zfs-linux (0.6.5.7-0ubuntu5) yakkety; urgency=medium

  * Change to include some important tools in zfsutils-linux build.
  - Add tools : arcstat.py, arc_summary.py & dbufstat.py in /usr/sbin.
  - Change utilities path (bindir) to /usr/sbin per
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/comments/6
  - Add python related dependencies (LP: #1574342)

 -- Eric Desrochers   Thu, 28 Jul 2016
16:22:58 -0400

** Changed in: zfs-linux (Ubuntu Yakkety)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

Thanks lscotte,

That good to know, not sure if this package is an official Debian
package though, or more something ZoL have build to work Debian ?

https://github.com/zfsonlinux/zfs/wiki/Debian

"Although ZFS On Linux is now officially in the Debian GNU/Linux
repository, we will continue to provide packages for Wheezy and Jessie
(but only in the amd64 architecture). The ZoL packages differ slightly
compared to the official Debian GNU/Linux packages, mostly in that it
provides new, improved sharenfs, sharesmb and shareiscsi options."

But you are right, let's call it the "ZoL Debian package" is build using
/usr/sbin, that should be enough to close the subjet of where theses
scripts should be stored.

$ dpkg -c zfsutils_0.6.5.7-8-jessie_amd64.deb | egrep -i "arc|dbufstat"
-rwxr-xr-x root/root 40751 2016-05-19 18:59 ./usr/sbin/arc_summary.py
-rwxr-xr-x root/root 13057 2016-05-19 18:59 ./usr/sbin/arcstat.py
-rwxr-xr-x root/root 18718 2016-05-19 18:59 ./usr/sbin/dbufstat.py

Eric

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[scotte]

To add to the confusion - arcstat.py and friends are already in
/usr/sbin in the Debian packages I have on Debian Jessie...

$ dpkg -S /usr/sbin/arcstat.py
zfsutils: /usr/sbin/arcstat.py

$ apt show zfsutils
Package: zfsutils
Source: zfs-linux
Version: 0.6.5.7-8-jessie
Maintainer: Debian ZFS on Linux maintainers 

[...]
APT-Sources: http://archive.zfsonlinux.org/debian/ jessie/main amd64 Packages
[...]

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

@lscotte,

Keep in mind that depending on the discussion I'll have with Debian, the
scripts location and naming is susceptible to change from what you see
in "0.6.5.6-0ubuntu12".

I'll update the bug when I have more details.

Regards,
Eric

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

Debian bug :
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832938

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

I have reported a bug to Debian about 2 topics :

* Python script location /usr/sbin or /usr/bin, but not /bin
* Rename python scripts [arcstat, arc_summary * dbufstat] without .py extension 
as per Debian Policy 10.4 [1]

[1] - https://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Eric

** Bug watch added: Debian Bug tracker #832938
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=832938

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Richard Laager]

Sure, but ZoL is not bound by Ubuntu Policy. Ubuntu is. That said, I'll
suggest they be fixed upstream too.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[scotte]

Testing with 0.6.5.6-0ubuntu12 confirms the tools are now available as
expected. Thank you!

As far as names ending in .py - while it should be fixed, currently they
come that way directly from  zfsonlinux.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Richard Laager]

I've attached a .debdiff to fix the filenames to comply with Policy
10.4, as @adconrad and I mentioned.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Richard Laager]

** Patch added: "zfs-fix-filenames.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+attachment/4709820/+files/zfs-fix-filenames.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Adam Conrad]

The scripts shipped to fix this bug still violate Policy 10.4, namely:

"When scripts are installed into a directory in the system PATH, the
script name should not include an extension such as .sh or .pl that
denotes the scripting language currently used to implement it."

Ideally, this should be fixed and upstreamed to Debian (or to zfslinux
upstream) as well.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Andy Whitcroft]

Hello Hajo, or anyone else affected,

Accepted zfs-linux into xenial-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/zfs-
linux/0.6.5.6-0ubuntu12 in a few hours, and then in the -proposed
repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: zfs-linux (Ubuntu Xenial)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Colin Ian King]

These tested OK, so lets get them sponsored and uploaded. I don't have
upload rights, so I can't do that right now.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

@colin-king, I confirmed the correction works, zed is not complaining
anymore :

# Output of apt-get install #

Fetched 905 kB in 2s (320 kB/s)
Selecting previously unselected package zfs-doc.
(Reading database ... 60137 files and directories currently installed.)
Preparing to unpack .../zfs-doc_0.6.5.6-0ubuntu12_all.deb ...
Unpacking zfs-doc (0.6.5.6-0ubuntu12) ...
Selecting previously unselected package libuutil1linux.
Preparing to unpack .../libuutil1linux_0.6.5.6-0ubuntu12_amd64.deb ...
Unpacking libuutil1linux (0.6.5.6-0ubuntu12) ...
Selecting previously unselected package libnvpair1linux.
Preparing to unpack .../libnvpair1linux_0.6.5.6-0ubuntu12_amd64.deb ...
Unpacking libnvpair1linux (0.6.5.6-0ubuntu12) ...
Selecting previously unselected package libzpool2linux.
Preparing to unpack .../libzpool2linux_0.6.5.6-0ubuntu12_amd64.deb ...
Unpacking libzpool2linux (0.6.5.6-0ubuntu12) ...
Selecting previously unselected package libzfs2linux.
Preparing to unpack .../libzfs2linux_0.6.5.6-0ubuntu12_amd64.deb ...
Unpacking libzfs2linux (0.6.5.6-0ubuntu12) ...
Selecting previously unselected package zfsutils-linux.
Preparing to unpack .../zfsutils-linux_0.6.5.6-0ubuntu12_amd64.deb ...
Unpacking zfsutils-linux (0.6.5.6-0ubuntu12) ...
Preparing to unpack .../zfs-zed_0.6.5.6-0ubuntu12_amd64.deb ...
Unpacking zfs-zed (0.6.5.6-0ubuntu12) ...
Processing triggers for libc-bin (2.23-0ubuntu3) ...
Processing triggers for initramfs-tools (0.122ubuntu8) ...
update-initramfs: Generating /boot/initrd.img-4.4.0-21-generic
W: plymouth: The plugin label.so is missing, the selected theme might not work 
as expected.
W: plymouth: You might want to install the plymouth-themes and plymouth-label 
package to fix this.
W: mdadm: /etc/mdadm/mdadm.conf defines no arrays.
Processing triggers for ureadahead (0.100.0-19) ...
Processing triggers for systemd (229-4ubuntu4) ...
Processing triggers for man-db (2.7.5-1) ...
Setting up zfs-doc (0.6.5.6-0ubuntu12) ...
Setting up libuutil1linux (0.6.5.6-0ubuntu12) ...
Setting up libnvpair1linux (0.6.5.6-0ubuntu12) ...
Setting up libzpool2linux (0.6.5.6-0ubuntu12) ...
Setting up libzfs2linux (0.6.5.6-0ubuntu12) ...
Setting up zfsutils-linux (0.6.5.6-0ubuntu12) ...
zfs-import-cache.service is a disabled or a static unit, not starting it.
zfs-import-scan.service is a disabled or a static unit, not starting it.
zfs-mount.service is a disabled or a static unit, not starting it.
Processing triggers for initramfs-tools (0.122ubuntu8) ...
update-initramfs: Generating /boot/initrd.img-4.4.0-21-generic
W: plymouth: The plugin label.so is missing, the selected theme might not work 
as expected.
W: plymouth: You might want to install the plymouth-themes and plymouth-label 
package to fix this.
W: mdadm: /etc/mdadm/mdadm.conf defines no arrays.
Setting up zfs-zed (0.6.5.6-0ubuntu12) ...
zed.service is a disabled or a static unit, not starting it.
Processing triggers for libc-bin (2.23-0ubuntu3) ...
Processing triggers for ureadahead (0.100.0-19) ...
Processing triggers for systemd (229-4ubuntu4) ...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

Debdiff for Xenial V2 (16.04)

** Patch removed: "Debdiff for Xenial V2 (16.04)"
   
https://bugs.launchpad.net/ubuntu/yakkety/+source/zfs-linux/+bug/1574342/+attachment/4708945/+files/zfs-linux-xenial-v2.debdiff

** Patch added: "Debdiff for Xenial V2 (16.04)"
   
https://bugs.launchpad.net/ubuntu/yakkety/+source/zfs-linux/+bug/1574342/+attachment/4708949/+files/zfs-linux-xenial-v2.debdiff

** Patch removed: "Debdiff for Xenial (16.04)"
   
https://bugs.launchpad.net/ubuntu/yakkety/+source/zfs-linux/+bug/1574342/+attachment/4708833/+files/lp574342_xenial.debdiff

** Patch removed: "Debdiff for Yakkety (16.10)"
   
https://bugs.launchpad.net/ubuntu/yakkety/+source/zfs-linux/+bug/1574342/+attachment/4708820/+files/lp1574342_yakkety.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

Debdiff for Xenial V2 (16.10)

** Patch added: "Debdiff for Xenial V2 (16.10)"
   
https://bugs.launchpad.net/ubuntu/yakkety/+source/zfs-linux/+bug/1574342/+attachment/4708946/+files/zfs-linux-yakkety-v2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

Debdiff for Xenial V2 (16.04)

** Patch added: "Debdiff for Xenial V2 (16.04)"
   
https://bugs.launchpad.net/ubuntu/yakkety/+source/zfs-linux/+bug/1574342/+attachment/4708945/+files/zfs-linux-xenial-v2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

@colin-king,

I think I found the problem,

instead of putting usr/sbin in zfsutils-linux.install.

I'll need to specify them per script as follow:

usr/sbin/arcstat.py
usr/sbin/arc_sumamry.py
usr/sbin/dbufstat.py

I'll re-do the debdiff for both "Y" and "X".

Eric

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Colin Ian King]

Hi Eric,

I applied these patches, built them in a ppa and then did a clean
install of zfsutils-linux from -proposed and then upgraded to the
packages in the ppa. However, your patches break the upgrade:

king@ubuntu:~$ dpkg -l | grep zfsutils-linux
ii  zfsutils-linux 0.6.5.6-0ubuntu11   amd64
Native OpenZFS management utilities for Linux
king@ubuntu:~$ sudo add-apt-repository ppa:colin-king/zfs-0.6.5.7-lp1574342
[sudo] password for king: 
 
 More info: 
https://launchpad.net/~colin-king/+archive/ubuntu/zfs-0.6.5.7-lp1574342
Press [ENTER] to continue or ctrl-c to cancel adding it

gpg: keyring `/tmp/tmp3bjyv0sl/secring.gpg' created
gpg: keyring `/tmp/tmp3bjyv0sl/pubring.gpg' created
gpg: requesting key B0F01786 from hkp server keyserver.ubuntu.com
gpg: /tmp/tmp3bjyv0sl/trustdb.gpg: trustdb created
gpg: key X: public key "Launchpad PPA for Colin King" imported
gpg: Total number processed: 1
gpg:   imported: 1  (RSA: 1)
OK
king@ubuntu:~$ sudo apt-get update
Hit:1 http://security.ubuntu.com/ubuntu xenial-security InRelease
Hit:2 http://gb.archive.ubuntu.com/ubuntu xenial InRelease
Get:3 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu xenial 
InRelease [17.6 kB]
Hit:4 http://gb.archive.ubuntu.com/ubuntu xenial-updates InRelease 
Hit:5 http://gb.archive.ubuntu.com/ubuntu xenial-proposed InRelease
Hit:6 http://gb.archive.ubuntu.com/ubuntu xenial-backports InRelease
Get:7 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main amd64 Packages [3,024 B]
Get:8 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main i386 Packages [3,032 B]
Get:9 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main Translation-en [1,584 B]
Fetched 25.2 kB in 1s (21.5 kB/s)  
Reading package lists... Done
king@ubuntu:~$ sudo apt-get dist-upgrade
Reading package lists... Done
Building dependency tree   
Reading state information... Done
Calculating upgrade... Done
The following package was automatically installed and is no longer required:
  linux-image-extra-4.3.0-7-generic
Use 'sudo apt autoremove' to remove it.
The following NEW packages will be installed
  libpython-stdlib python python-minimal python2.7 python2.7-minimal
The following packages will be upgraded:
  libnvpair1linux libuutil1linux libzfs2linux libzpool2linux zfs-doc zfs-zed
  zfsutils-linux
7 to upgrade, 5 to newly install, 0 to remove and 0 not to upgrade.
Need to get 2,610 kB of archives.
After this operation, 4,986 kB of additional disk space will be used.
Do you want to continue? [Y/n] 
Get:1 http://gb.archive.ubuntu.com/ubuntu xenial-updates/main amd64 
python2.7-minimal amd64 2.7.12-1~16.04 [1,294 kB]
Get:2 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main amd64 libuutil1linux amd64 0.6.5.6-0ubuntu12 [27.5 kB]
Get:3 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main amd64 libzpool2linux amd64 0.6.5.6-0ubuntu12 [384 kB]
Get:4 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main amd64 libzfs2linux amd64 0.6.5.6-0ubuntu12 [106 kB]
Get:5 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main amd64 zfs-zed amd64 0.6.5.6-0ubuntu12 [29.8 kB]
Get:6 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main amd64 zfsutils-linux amd64 0.6.5.6-0ubuntu12 [290 kB]
Get:7 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main amd64 libnvpair1linux amd64 0.6.5.6-0ubuntu12 [23.4 kB]
Get:8 http://ppa.launchpad.net/colin-king/zfs-0.6.5.7-lp1574342/ubuntu 
xenial/main amd64 zfs-doc all 0.6.5.6-0ubuntu12 [58.2 kB]
Get:9 http://gb.archive.ubuntu.com/ubuntu xenial/main amd64 python-minimal 
amd64 2.7.11-1 [28.2 kB]
Get:10 http://gb.archive.ubuntu.com/ubuntu xenial-updates/main amd64 python2.7 
amd64 2.7.12-1~16.04 [224 kB]
Get:11 http://gb.archive.ubuntu.com/ubuntu xenial/main amd64 libpython-stdlib 
amd64 2.7.11-1 [7,656 B]
Get:12 http://gb.archive.ubuntu.com/ubuntu xenial/main amd64 python amd64 
2.7.11-1 [137 kB]
Fetched 2,610 kB in 1s (2,399 kB/s)
Selecting previously unselected package python2.7-minimal.
(Reading database ... 128781 files and directories currently installed.)
Preparing to unpack .../python2.7-minimal_2.7.12-1~16.04_amd64.deb ...
Unpacking python2.7-minimal (2.7.12-1~16.04) ...
Selecting previously unselected package python-minimal.
Preparing to unpack .../python-minimal_2.7.11-1_amd64.deb ...
Unpacking python-minimal (2.7.11-1) ...
Selecting previously unselected package python2.7.
Preparing to unpack .../python2.7_2.7.12-1~16.04_amd64.deb ...
Unpacking python2.7 (2.7.12-1~16.04) ...
Selecting previously unselected package libpython-stdlib:amd64.
Preparing to unpack .../libpython-stdlib_2.7.11-1_amd64.deb ...
Unpacking libpython-stdlib:amd64 (2.7.11-1) ...
Processing triggers for man-db (2.7.5-1) ...
Processing 

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

Debdiff for Xenial (16.04)

** Patch added: "Debdiff for Xenial (16.04)"
   
https://bugs.launchpad.net/ubuntu/xenial/+source/zfs-linux/+bug/1574342/+attachment/4708833/+files/lp574342_xenial.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

Debdiff for Yakkety (16.10)

** Patch added: "Debdiff for Yakkety (16.10)"
   
https://bugs.launchpad.net/ubuntu/xenial/+source/zfs-linux/+bug/1574342/+attachment/4708820/+files/lp1574342_yakkety.debdiff

** Tags added: patch sts

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

** Description changed:

  [Impact]
  
  zfsutils-linux missing some important tools.
  
  Python3 compatible scripts : arc_summary.py, arcstat.py and dbufstat.py
  found in src_code/cmd/ are not taken into account during compilation.
  
  * arc_summary.py : Provides a summary of the statistics
  https://github.com/zfsonlinux/zfs/blob/master/cmd/arc_summary
  
  * arcstat.py : Print out ZFS ARC Statistics exported via kstat(1)
  https://github.com/zfsonlinux/zfs/tree/master/cmd/arcstat
  
- * dbufstat.py: Print out statistics for all cached dmu buffers.
- # https://github.com/zfsonlinux/zfs/blob/master/cmd/dbufstat
+ * dbufstat.py: Print out statistics for all cached dmu buffers
+ https://github.com/zfsonlinux/zfs/blob/master/cmd/dbufstat
  
  [Test Case]
  
  # rmadison zfsutils-linux
  ...
   zfsutils-linux | 0.6.5.6-0ubuntu10  | xenial-updates
  ...
  
  # List contents of a deb package.
  $ dpkg -c zfsutils-linux_0.6.5.6-0ubuntu10_amd64.deb | egrep 
"arcstat|arc_summary|dbufstat"
  
  # You will notice there are not present.
  
  [Regression Potential]
  
  None expected, debian package[1] has already made the change to build
  the python scripts.
  
  [1]
  Package: zfsutils-linux
  Source: zfs-linux
  Version: 0.6.5.7-1
  Architecture: amd64
  Maintainer: Debian ZFS on Linux maintainers 

  
  # List contents of a deb package.
  $ dpkg -c zfsutils-linux_0.6.5.7-1_amd64.deb | egrep -i "arc|dbufstat"
  -rwxr-xr-x root/root 40751 2016-05-31 03:40 ./bin/arc_summary.py
  -rwxr-xr-x root/root 13057 2016-05-31 03:40 ./bin/arcstat.py
  -rwxr-xr-x root/root 18718 2016-05-31 03:40 ./bin/dbufstat.py
  
  [Other Info]
  
  * This is based on the following Debian commits :
  
  Debian git commits
  ===
  commit 730989397063955d60a1845003cfb7433eba1e52
  Author: Aron Xu 
  Date: Tue Apr 26 17:01:29 2016 +0800
  
  Add dh-python to b-d
  
  --
  
  commit 814413118fb88de3ce596a87a8a011f50c225fdd
  Author: Aron Xu 
  Date: Sun Nov 22 15:44:16 2015 +0800
  
  Add python related dependencies
  ===
  
- * Despite what Debian did by adding theses script under /bin. 
-   I'll add them under /usr/sbin, which is more appropriate.
+ * Despite what Debian did by adding theses script under /bin.
+   I'll add them under /usr/sbin, which is more appropriate.
  
  * Unfortunately manpage for theses 3 program seems limited.
-   There is none in Debian nor git upstream repo.
+   There is none in Debian nor git upstream repo.
  
  The only manpage I found is for arcstat online :
  
  http://linux.die.net/man/1/arcstat
  
  [Original Description]
  
  arcstat.py and arc_summary.py are valuable tools to determine ZFS' ARC
  usage, it is not obvious why they are not included in zfsutils-linux. As
  ubuntu-minimal already depends on python3 it should be safe to assume
  python is available, or am I mistaken here?
  
  arcstat.py gives an iostat-like overview about ARC reads, hit rate, current 
and target size in regular intervals:
  # ./arcstat.py 1
  time  read  miss  miss%  dmis  dm%  pmis  pm%  mmis  mm%  arcsz c
  19:22:33 0 0  0 00 00 00   2.0G  7.8G
  19:22:34 3 0  0 00 00 00   2.0G  7.8G
  19:22:3521 0  0 00 00 00   2.0G  7.8G
  ^C
  
  arc_summary.py shows a more detailed overview of the current ARC status and 
ZFS tunables:
  # ./arc_summary.py
  
  
  ZFS Subsystem Report  Sun Apr 24 19:23:25 2016
  ARC Summary: (HEALTHY)
   Memory Throttle Count:   0
  
  ARC Misc:
   Deleted: 46
   Mutex Misses:0
   Evict Skips: 0
  
  ARC Size: 25.10%  1.95GiB
   Target Size: (Adaptive)  100.00% 7.78GiB
   Min Size (Hard Limit):   0.40%   32.00   MiB
   Max Size (High Water):   248:1   7.78GiB
  
  ARC Size Breakdown:
   Recently Used Cache Size:50.00%  3.89GiB
   Frequently Used Cache Size:  50.00%  3.89GiB
  
  ARC Hash Breakdown:
   Elements Max:32.31k
   Elements Current:99.78%  32.24k
   Collisions:  40.54k
   Chain Max:   3
   Chains:  240
  
  ARC Total accesses:   4.54m
   Cache Hit Ratio: 99.39%  4.51m
   Cache Miss Ratio:0.61%   27.74k
   Actual Hit Ratio:98.76%  4.48m
  
   Data Demand Efficiency:  99.73%  3.23m
   Data Prefetch Efficiency:11.32%  6.41k
  
   CACHE HITS BY CACHE LIST:
     Anonymously Used:  0.64%   28.65k
     Most Recently Used:21.90%  987.29k
     Most Frequently Used:   

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

@rlaager,

Neither debian src code or upstream (git) src code have manpage for
arcstat.py, arc_summary.py and dbufstat.py.

But arcstat have a manpage that can be found online :

http://linux.die.net/man/1/arcstat

@adconrad,

Yes, my plan was to place them under /usr/sbin, and not like Debian did under 
/bin.
/usr/sbin is more appropriate.

Eric

** Description changed:

  [Impact]
  
  zfsutils-linux missing some important tools.
  
  Python3 compatible scripts : arc_summary.py, arcstat.py and dbufstat.py
  found in src_code/cmd/ are not taken into account during compilation.
  
  * arc_summary.py : Provides a summary of the statistics
  https://github.com/zfsonlinux/zfs/blob/master/cmd/arc_summary
  
  * arcstat.py : Print out ZFS ARC Statistics exported via kstat(1)
  https://github.com/zfsonlinux/zfs/tree/master/cmd/arcstat
  
  * dbufstat.py: Print out statistics for all cached dmu buffers.
  # https://github.com/zfsonlinux/zfs/blob/master/cmd/dbufstat
  
  [Test Case]
  
  # rmadison zfsutils-linux
  ...
   zfsutils-linux | 0.6.5.6-0ubuntu10  | xenial-updates
  ...
  
  # List contents of a deb package.
  $ dpkg -c zfsutils-linux_0.6.5.6-0ubuntu10_amd64.deb | egrep 
"arcstat|arc_summary|dbufstat"
  
  # You will notice there are not present.
  
  [Regression Potential]
  
  None expected, debian package[1] has already made the change to build
  the python scripts.
  
  [1]
  Package: zfsutils-linux
  Source: zfs-linux
  Version: 0.6.5.7-1
  Architecture: amd64
  Maintainer: Debian ZFS on Linux maintainers 

  
  # List contents of a deb package.
  $ dpkg -c zfsutils-linux_0.6.5.7-1_amd64.deb | egrep -i "arc|dbufstat"
  -rwxr-xr-x root/root 40751 2016-05-31 03:40 ./bin/arc_summary.py
  -rwxr-xr-x root/root 13057 2016-05-31 03:40 ./bin/arcstat.py
  -rwxr-xr-x root/root 18718 2016-05-31 03:40 ./bin/dbufstat.py
  
  [Other Info]
  
- This is based on the following Debian commits :
+ * This is based on the following Debian commits :
  
  Debian git commits
  ===
  commit 730989397063955d60a1845003cfb7433eba1e52
  Author: Aron Xu 
  Date: Tue Apr 26 17:01:29 2016 +0800
  
  Add dh-python to b-d
  
  --
  
  commit 814413118fb88de3ce596a87a8a011f50c225fdd
  Author: Aron Xu 
  Date: Sun Nov 22 15:44:16 2015 +0800
  
  Add python related dependencies
  ===
+ 
+ * Despite what Debian did by adding theses script under /bin. 
+   I'll add them under /usr/sbin, which is more appropriate.
+ 
+ * Unfortunately manpage for theses 3 program seems limited.
+   There is none in Debian nor git upstream repo.
+ 
+ The only manpage I found is for arcstat online :
+ 
+ http://linux.die.net/man/1/arcstat
  
  [Original Description]
  
  arcstat.py and arc_summary.py are valuable tools to determine ZFS' ARC
  usage, it is not obvious why they are not included in zfsutils-linux. As
  ubuntu-minimal already depends on python3 it should be safe to assume
  python is available, or am I mistaken here?
  
  arcstat.py gives an iostat-like overview about ARC reads, hit rate, current 
and target size in regular intervals:
  # ./arcstat.py 1
  time  read  miss  miss%  dmis  dm%  pmis  pm%  mmis  mm%  arcsz c
  19:22:33 0 0  0 00 00 00   2.0G  7.8G
  19:22:34 3 0  0 00 00 00   2.0G  7.8G
  19:22:3521 0  0 00 00 00   2.0G  7.8G
  ^C
  
  arc_summary.py shows a more detailed overview of the current ARC status and 
ZFS tunables:
  # ./arc_summary.py
  
  
  ZFS Subsystem Report  Sun Apr 24 19:23:25 2016
  ARC Summary: (HEALTHY)
   Memory Throttle Count:   0
  
  ARC Misc:
   Deleted: 46
   Mutex Misses:0
   Evict Skips: 0
  
  ARC Size: 25.10%  1.95GiB
   Target Size: (Adaptive)  100.00% 7.78GiB
   Min Size (Hard Limit):   0.40%   32.00   MiB
   Max Size (High Water):   248:1   7.78GiB
  
  ARC Size Breakdown:
   Recently Used Cache Size:50.00%  3.89GiB
   Frequently Used Cache Size:  50.00%  3.89GiB
  
  ARC Hash Breakdown:
   Elements Max:32.31k
   Elements Current:99.78%  32.24k
   Collisions:  40.54k
   Chain Max:   3
   Chains:  240
  
  ARC Total accesses:   4.54m
   Cache Hit Ratio: 99.39%  4.51m
   Cache Miss Ratio:0.61%   27.74k
   Actual Hit Ratio:98.76%  4.48m
  
   Data Demand Efficiency:  99.73%  3.23m
   Data Prefetch Efficiency:11.32%  6.41k
  
   CACHE HITS BY CACHE LIST:
     Anonymously Used:  0.64%   28.65k

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

@rlageer,

At least the program have a "--help" argument

Example :
---
$ /usr/sbin/arcstat.py --help
---
Usage: arcstat.py [-hvx] [-f fields] [-o file] [-s string] [interval [count]]

 -h : Print this help message
 -v : List all possible field headers and definitions
 -x : Print extended stats
 -f : Specify specific fields to print (see -v)
 -o : Redirect output to the specified file
 -s : Override default field separator with custom character or string

Examples:
arcstat.py -o /tmp/a.log 2 10
arcstat.py -s "," -o /tmp/a.log 2 10
arcstat.py -v
arcstat.py -f time,hit%,dh%,ph%,mh% 1
---

Eric

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

** Changed in: zfs-linux (Ubuntu Xenial)
   Status: New => In Progress

** Changed in: zfs-linux (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: zfs-linux (Ubuntu Xenial)
 Assignee: (unassigned) => Eric Desrochers (slashd)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Adam Conrad]

These also should be in /usr/bin (or /usr/sbin), not /bin

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Andy Whitcroft]

** Also affects: zfs-linux (Ubuntu Yakkety)
   Importance: Medium
 Assignee: Eric Desrochers (slashd)
   Status: In Progress

** Also affects: zfs-linux (Ubuntu Xenial)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Richard Laager]

@slashd, did Debian drop the .py extensions per Policy? Did they write
man pages?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

I'll be working on fixing this bugs, and then star the SRU for the fix
to make its way to stable release.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

** Description changed:

+ [Impact]
+ 
+ zfsutils-linux missing some important tools.
+ 
+ Python3 compatible scripts : arc_summary.py, arcstat.py and dbufstat.py
+ found in src_code/cmd/ are not taken into account during compilation.
+ 
+ * arc_summary.py : Provides a summary of the statistics
+ * arcstat.py : Print out ZFS ARC Statistics exported via kstat(1)
+ * dbufstat.py: Print out statistics for all cached dmu buffers. # 
https://github.com/zfsonlinux/zfs/blob/master/cmd/dbufstat/dbufstat.py
+ 
+ 
+ [Test Case]
+ 
+ # rmadison zfsutils-linux 
+ ...
+  zfsutils-linux | 0.6.5.6-0ubuntu10  | xenial-updates
+ ...
+ 
+ # List contents of a deb package.
+ $ dpkg -c zfsutils-linux_0.6.5.6-0ubuntu10_amd64.deb | egrep 
"arcstat|arc_summary|dbufstat"
+ 
+ # You will notice there are not present.
+ 
+ 
+ [Regression Potential] 
+ 
+ None expected, debian package[1] has already made the change to build
+ the python scripts.
+ 
+ [1] 
+ Package: zfsutils-linux
+ Source: zfs-linux
+ Version: 0.6.5.7-1
+ Architecture: amd64
+ Maintainer: Debian ZFS on Linux maintainers 

+ 
+ # List contents of a deb package.
+ $ dpkg -c zfsutils-linux_0.6.5.7-1_amd64.deb | egrep -i "arc|dbufstat"
+ -rwxr-xr-x root/root 40751 2016-05-31 03:40 ./bin/arc_summary.py
+ -rwxr-xr-x root/root 13057 2016-05-31 03:40 ./bin/arcstat.py
+ -rwxr-xr-x root/root 18718 2016-05-31 03:40 ./bin/dbufstat.py
+ 
+ 
+ [Other Info]
+  
+ This is based on the following Debian commits :
+ 
+ Debian git commits
+ ===
+ commit 730989397063955d60a1845003cfb7433eba1e52
+ Author: Aron Xu 
+ Date: Tue Apr 26 17:01:29 2016 +0800
+ 
+ Add dh-python to b-d
+ 
+ --
+ 
+ commit 814413118fb88de3ce596a87a8a011f50c225fdd
+ Author: Aron Xu 
+ Date: Sun Nov 22 15:44:16 2015 +0800
+ 
+ Add python related dependencies
+ ===
+ 
+ [Original Description]
+ 
  arcstat.py and arc_summary.py are valuable tools to determine ZFS' ARC
  usage, it is not obvious why they are not included in zfsutils-linux. As
  ubuntu-minimal already depends on python3 it should be safe to assume
  python is available, or am I mistaken here?
  
  arcstat.py gives an iostat-like overview about ARC reads, hit rate, current 
and target size in regular intervals:
  # ./arcstat.py 1
- time  read  miss  miss%  dmis  dm%  pmis  pm%  mmis  mm%  arcsz c  
- 19:22:33 0 0  0 00 00 00   2.0G  7.8G  
- 19:22:34 3 0  0 00 00 00   2.0G  7.8G  
- 19:22:3521 0  0 00 00 00   2.0G  7.8G  
+ time  read  miss  miss%  dmis  dm%  pmis  pm%  mmis  mm%  arcsz c
+ 19:22:33 0 0  0 00 00 00   2.0G  7.8G
+ 19:22:34 3 0  0 00 00 00   2.0G  7.8G
+ 19:22:3521 0  0 00 00 00   2.0G  7.8G
  ^C
  
  arc_summary.py shows a more detailed overview of the current ARC status and 
ZFS tunables:
- # ./arc_summary.py 
+ # ./arc_summary.py
  
  
  ZFS Subsystem Report  Sun Apr 24 19:23:25 2016
  ARC Summary: (HEALTHY)
-   Memory Throttle Count:  0
+  Memory Throttle Count:   0
  
  ARC Misc:
-   Deleted:46
-   Mutex Misses:   0
-   Evict Skips:0
+  Deleted: 46
+  Mutex Misses:0
+  Evict Skips: 0
  
  ARC Size: 25.10%  1.95GiB
-   Target Size: (Adaptive) 100.00% 7.78GiB
-   Min Size (Hard Limit):  0.40%   32.00   MiB
-   Max Size (High Water):  248:1   7.78GiB
+  Target Size: (Adaptive)  100.00% 7.78GiB
+  Min Size (Hard Limit):   0.40%   32.00   MiB
+  Max Size (High Water):   248:1   7.78GiB
  
  ARC Size Breakdown:
-   Recently Used Cache Size:   50.00%  3.89GiB
-   Frequently Used Cache Size: 50.00%  3.89GiB
+  Recently Used Cache Size:50.00%  3.89GiB
+  Frequently Used Cache Size:  50.00%  3.89GiB
  
  ARC Hash Breakdown:
-   Elements Max:   32.31k
-   Elements Current:   99.78%  32.24k
-   Collisions: 40.54k
-   Chain Max:  3
-   Chains: 240
+  Elements Max:32.31k
+  Elements Current:99.78%  32.24k
+  Collisions:  40.54k
+  Chain Max:   3
+  Chains:  240
  
  ARC Total accesses:   4.54m
-   Cache Hit Ratio:99.39%  4.51m
-   

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

I looked at the Debian pkg, and it looks like everything is okay on the
Debian side.

Package: zfsutils-linux
Source: zfs-linux
Version: 0.6.5.7-1
Architecture: amd64
Maintainer: Debian ZFS on Linux maintainers 


---

$ dpkg -c zfsutils-linux_0.6.5.7-1_amd64.deb | egrep -i "arc|dbufstat"
-rwxr-xr-x root/root 40751 2016-05-31 03:40 ./bin/arc_summary.py
-rwxr-xr-x root/root 13057 2016-05-31 03:40 ./bin/arcstat.py
-rwxr-xr-x root/root 18718 2016-05-31 03:40 ./bin/dbufstat.py

I have identified some Debian git commits that may address the situation
:

===
commit 730989397063955d60a1845003cfb7433eba1e52
Author: Aron Xu 
Date: Tue Apr 26 17:01:29 2016 +0800

Add dh-python to b-d

--

commit 814413118fb88de3ce596a87a8a011f50c225fdd
Author: Aron Xu 
Date: Sun Nov 22 15:44:16 2015 +0800

Add python related dependencies

===

I'll be working on a test package, and will ask peoples affected by this
to test and provide feedbacks.

Regards,
Eric

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Eric Desrochers]

** Changed in: zfs-linux (Ubuntu)
 Assignee: Colin Ian King (colin-king) => Eric Desrochers (slashd)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Colin Ian King]

** Changed in: zfs-linux (Ubuntu)
   Status: Confirmed => In Progress

** Changed in: zfs-linux (Ubuntu)
   Importance: Undecided => Medium

** Changed in: zfs-linux (Ubuntu)
 Assignee: (unassigned) => Colin Ian King (colin-king)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: zfs-linux (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1574342] Re: Ship arcstat.py and arc_summary.py with zfsutils-linux

[Richard Laager]

I think it is safe to "assume" python for the purposes of "is this
pulling in more code?". It's not safe to "assume" python for the
purposes of the actual dependencies in debian/control. That is, python
will have to be listed as a dependency, but I don't think adding this
dependency to zfsutils-linux is a problem.

A few questions/comments:

1) Does arc_summary.py actually use these binaries, as listed in the comment at 
the top of the file? I couldn't find any direct calls to them.
# Binaries used are:
#
# dc(1), kldstat(8), sed(1), sysctl(8) & vmstat(8)

2) We need man pages for these commands. (Debian/Ubuntu Policy 12.1). I
don't think upstream ships them, so we'll have to write them first.

3) The commands should have the .py extensions dropped, at least when
they're installed in the PATH on Ubuntu. (Debian/Ubuntu policy 10.4.)

4) Upstream also has dbufstat. Is that worth shipping too?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1574342

Title:
  Ship arcstat.py and arc_summary.py with zfsutils-linux

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1574342/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs