[Bug 1576093] Re: [SRU] block migration fail with libvirt since version 1.2.17

[Rafael David Tinoco]

For Ubuntu Xenial (Mitaka), Yakkety (Newton), Zesty: Commit 0d34fbabc1
fixes the issue for vhost-net kernel. Vhost-net kernel doesn't use
shared log so the verification is not used and apparmor profiles won't
block the live migration. With customers using vhost-user that might
still cause migration problems, but, likely, those are the vast
minority.

commit 0d34fbabc13891da41582b0823867dc5733fffef
Author: Rafael David Tinoco 
Date:   Mon Oct 24 15:35:03 2016 +

vhost: migration blocker only if shared log is used

Commit 31190ed7 added a migration blocker in vhost_dev_init() to
check if memfd would succeed. It is better if this blocker first
checks if vhost backend requires shared log. This will avoid a
situation where a blocker is added inappropriately (e.g. shared
log allocation fails when vhost backend doesn't support it).

Signed-off-by: Rafael David Tinoco 
Reviewed-by: Marc-André Lureau 
Reviewed-by: Michael S. Tsirkin 
Signed-off-by: Michael S. Tsirkin 

diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index 131f164..25bf67f 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -1122,7 +1122,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,
 if (!(hdev->features & (0x1ULL << VHOST_F_LOG_ALL))) {
 error_setg(>migration_blocker,
"Migration disabled: vhost lacks VHOST_F_LOG_ALL 
feature.");
-} else if (!qemu_memfd_check()) {
+} else if (vhost_dev_log_is_shared(hdev) && !qemu_memfd_check()) {
 error_setg(>migration_blocker,
"Migration disabled: failed to allocate shared memory");
 }

The "final" fix for upstream fix is being finished by me, but, might not
be suitable for SRU since it will add features in qemu (and likely to
libvirt) in order for the vhost log file to be passed (by using an
already opened file descriptor). This will require changes in libvirt
and nova-compute but this change will, finally, allow security driver to
apply rules to vhost log file for shared logs (mostly for vhost-user
drivers).

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1576093

Title:
  [SRU] block migration fail with libvirt since version  1.2.17

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1576093/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1576093] Re: [SRU] block migration fail with libvirt since version 1.2.17

[OpenStack Infra]

Reviewed:  https://review.openstack.org/328910
Committed: 
https://git.openstack.org/cgit/openstack/nova/commit/?id=4bc51937a26041fbe38d6ed388942332458905ef
Submitter: Jenkins
Branch:stable/mitaka

commit 4bc51937a26041fbe38d6ed388942332458905ef
Author: Eli Qiao 
Date:   Mon Jun 13 10:58:29 2016 +0200

libvirt: Prevent block live migration with tunnelled flag

libvirt will report "Selecting disks to migrate is not
implemented for tunneled migration" while doing block migration
with VIR_MIGRATE_TUNNELLED flag.

This patch does 2 changes:

1. Raise exception.MigrationPreCheckError if block live migration with
   with mapped volumes and tunnelled flag on.
2. Remove migrate_disks from params of migrateToURI3 in case of
   tunnelled block live migration w/o mapped volumes since we want
   to copy all disks to destination

Co-Authored-By: Pawel Koniszewski 
Closes-bug: #1576093

Conflicts:
nova/tests/unit/virt/libvirt/test_driver.py
nova/virt/libvirt/driver.py

Change-Id: Id6e49f298133c53d21386ea619c83e413ef3117a
(cherry picked from commit 1885a39083776605348523002f4a6aedace12cce)


** Tags added: in-stable-mitaka

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1576093

Title:
  [SRU] block migration fail with libvirt since version  1.2.17

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1576093/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1576093] Re: [SRU] block migration fail with libvirt since version 1.2.17

[James Page]

** Changed in: cloud-archive
   Status: New => Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1576093

Title:
  [SRU] block migration fail with libvirt since version  1.2.17

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1576093/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1576093] Re: [SRU] block migration fail with libvirt since version 1.2.17

[James Page]

This bug was fixed in the package nova - 2:13.0.0-0ubuntu5~cloud0
---

 nova (2:13.0.0-0ubuntu5~cloud0) trusty-mitaka; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 nova (2:13.0.0-0ubuntu5) xenial; urgency=medium
 .
   * d/p/fix-block-migration.patch: Cherry pick and rebase patch from
 stable/mitaka gerrit review to fix block migration (LP: #1576093).
   * Note: Skipping 0ubuntu3/4 because they were yakkety-only releases.


** Changed in: cloud-archive/mitaka
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1576093

Title:
  [SRU] block migration fail with libvirt since version  1.2.17

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1576093/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1576093] Re: [SRU] block migration fail with libvirt since version 1.2.17

[Launchpad Bug Tracker]

This bug was fixed in the package nova - 2:13.0.0-0ubuntu5

---
nova (2:13.0.0-0ubuntu5) xenial; urgency=medium

  * d/p/fix-block-migration.patch: Cherry pick and rebase patch from
stable/mitaka gerrit review to fix block migration (LP: #1576093).
  * Note: Skipping 0ubuntu3/4 because they were yakkety-only releases.

 -- Corey Bryant   Thu, 16 Jun 2016 11:52:04
-0400

** Changed in: nova (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1576093

Title:
  [SRU] block migration fail with libvirt since version  1.2.17

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1576093/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1576093] Re: [SRU] block migration fail with libvirt since version 1.2.17

[Corey Bryant]

Hello Martin and Ryan,

nova 2:13.0.0-0ubuntu5 and nova 2:13.0.0-0ubuntu5~cloud0 have been
successfully tested.

Thanks,
Corey

** Tags removed: verification-mitaka-needed verification-needed
** Tags added: verification-done verification-mitaka-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1576093

Title:
  [SRU] block migration fail with libvirt since version  1.2.17

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1576093/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1576093] Re: [SRU] block migration fail with libvirt since version 1.2.17

[Martin Pitt]

Hello Eli, or anyone else affected,

Accepted nova into xenial-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/nova/2:13.0.0-0ubuntu5
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: nova (Ubuntu Xenial)
   Status: Confirmed => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1576093

Title:
  [SRU] block migration fail with libvirt since version  1.2.17

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1576093/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1576093] Re: [SRU] block migration fail with libvirt since version 1.2.17

[Corey Bryant]

This has been uploaded to yakkety and the xenial review queue, awaiting
sru team review.

** Summary changed:

- block migration fail with libvirt since version  1.2.17
+ [SRU] block migration fail with libvirt since version  1.2.17

** Description changed:

+ [Impact]
+ 
  Try to do block migration but fail and libvirt reports that
  
  "Selecting disks to migrate is not implemented for tunneled migration"
  
  Nova:  a4e15e329f9adbcfe72fbcd6acb94f0743ad02f8
  
  libvirt: 1.3.1
  
+ [Test Case]
+ 
  reproduce:
  
  default devstack setting and do block migration (no shared instance_dir
  and shared instance storage used)
+ 
+ [Regression Potential]
+ 
+ Patch was cherry picked from upstream gerrit review, which was cherry
+ picked with little change from master branch.

** Also affects: nova (Ubuntu Yakkety)
   Importance: Undecided
   Status: Confirmed

** Changed in: nova (Ubuntu Yakkety)
   Status: Confirmed => Fix Released

** Changed in: nova (Ubuntu Yakkety)
   Importance: Undecided => High

** Changed in: nova (Ubuntu Xenial)
   Importance: Undecided => High

** Changed in: nova (Ubuntu Yakkety)
 Assignee: (unassigned) => Corey Bryant (corey.bryant)

** Changed in: nova (Ubuntu Xenial)
 Assignee: (unassigned) => Corey Bryant (corey.bryant)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1576093

Title:
  [SRU] block migration fail with libvirt since version  1.2.17

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1576093/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs