[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
This bug was fixed in the package nova-lxd - 13.3.0-0ubuntu2~cloud0 --- nova-lxd (13.3.0-0ubuntu2~cloud0) trusty-mitaka; urgency=medium . * New update for the Ubuntu Cloud Archive. . nova-lxd (13.3.0-0ubuntu2) xenial; urgency=medium . * d/p/01_bug-1675386-ensure-all-net-devices-added.diff: Returns all network devices to container (LP: #1675386) ** Changed in: cloud-archive/mitaka Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1675386 Title: [SRU] all network devices aren't added to instance profile To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
** Tags removed: verification-xenial-done ** Tags added: verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1675386 Title: [SRU] all network devices aren't added to instance profile To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
This bug was fixed in the package nova-lxd - 13.3.0-0ubuntu2 --- nova-lxd (13.3.0-0ubuntu2) xenial; urgency=medium * d/p/01_bug-1675386-ensure-all-net-devices-added.diff: Returns all network devices to container (LP: #1675386) -- Alex Kavanagh Thu, 31 May 2018 17:21:55 +0100 ** Changed in: nova-lxd (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1675386 Title: [SRU] all network devices aren't added to instance profile To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
Thanks Brian for the help with this; apologies for getting the tags wrong! I'll fix them now. ** Tags removed: verification-done ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1675386 Title: [SRU] all network devices aren't added to instance profile To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
I've confirmed that this function with mitaka/xenial using the amulet test associated with lxd. ** Tags removed: verification-mitaka-needed verification-needed verification-needed-xenial ** Tags added: verification-done verification-mitaka-done verification-xenial-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1675386 Title: [SRU] all network devices aren't added to instance profile To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
Alex, would you be able to verify this bug is fixed? Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1675386 Title: [SRU] all network devices aren't added to instance profile To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
Hello todd, or anyone else affected, Accepted nova-lxd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nova- lxd/13.3.0-0ubuntu2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: nova-lxd (Ubuntu Xenial) Status: Triaged => Fix Committed ** Tags added: verification-needed verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1675386 Title: [SRU] all network devices aren't added to instance profile To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
Thanks Alex. I've uploaded the new version of the package to the xenial unapproved queue [1] where it is awaiting review by the SRU team. [1] https://launchpad.net/ubuntu/xenial/+queue?queue_state=1_text= -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1675386 Title: [SRU] all network devices aren't added to instance profile To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
Updated stable/mitaka patch which includes changelog update. ** Patch added: "Updated patch for stable/mitaka" https://bugs.launchpad.net/nova-lxd/+bug/1675386/+attachment/5147055/+files/01_bug-1675386-ensure-all-net-devices-added.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1675386 Title: [SRU] all network devices aren't added to instance profile To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
stable/mitaka patch as a diff file that fixes the bug.
Note this is only a debian patch diff file; the stable/mitaka source has
not been altered.
** Description changed:
RELEASE: nova-compute-lxd 13.3.0-0ubuntu1
DESCRIPTION:
In config.py the network_devices object should be returned after the
'for vifaddr in network_info:' loop to ensure the network_devices object
includes all network devices.
CURRENT CODE (annotated area of interest with ):
def create_network(self, instance_name, instance, network_info):
"""Create the LXD container network on the host
:param instance_name: nova instance name
:param instance: nova instance object
:param network_info: instance network configuration object
:return:network configuration dictionary
"""
LOG.debug('create_network called for instance', instance=instance)
try:
network_devices = {}
if not network_info:
return
for vifaddr in network_info:
cfg = self.vif_driver.get_config(instance, vifaddr)
key = str(cfg['bridge'])
network_devices[key] = {'nictype': 'bridged', 'hwaddr':
str(cfg['mac_address']), 'parent': key, 'type': 'nic'}
host_device = self.vif_driver.get_vif_devname(vifaddr)
if host_device:
network_devices[key]['host_name'] = host_device
return network_devices
except Exception as ex:
with excutils.save_and_reraise_exception():
LOG.error(
_LE('Fail to configure network for %(instance)s: %(ex)s'),
{'instance': instance_name, 'ex': ex}, instance=instance)
PROPOSED CHANGE (annotated area of interest with ):
def create_network(self, instance_name, instance, network_info):
"""Create the LXD container network on the host
:param instance_name: nova instance name
:param instance: nova instance object
:param network_info: instance network configuration object
:return:network configuration dictionary
"""
LOG.debug('create_network called for instance', instance=instance)
try:
network_devices = {}
if not network_info:
return
for vifaddr in network_info:
cfg = self.vif_driver.get_config(instance, vifaddr)
key = str(cfg['bridge'])
network_devices[key] = {'nictype': 'bridged', 'hwaddr':
str(cfg['mac_address']), 'parent': key, 'type': 'nic'}
host_device = self.vif_driver.get_vif_devname(vifaddr)
if host_device:
network_devices[key]['host_name'] = host_device
return network_devices
except Exception as ex:
with excutils.save_and_reraise_exception():
LOG.error(
_LE('Fail to configure network for %(instance)s: %(ex)s'),
{'instance': instance_name, 'ex': ex}, instance=instance)
-
-
Adding fields for Ubuntu SRU template:
[Impact]
See Description above.
[Test Case]
- TBD
+ Manual test with devstack to ensure no regressions. Manual check to verify
that container gets multiple net devices.
[Regression Potential]
- TBD
+ Low, as virtually all openstack deployments with containers tend to only have
one network device.
** Patch added: "To be applied to stable/mitaka branch"
https://bugs.launchpad.net/nova-lxd/+bug/1675386/+attachment/5146972/+files/01_bug-1675386-ensure-all-net-devices-added.patch
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1675386
Title:
[SRU] all network devices aren't added to instance profile
To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1675386/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1675386] Re: [SRU] all network devices aren't added to instance profile
** Summary changed:
- all network devices aren't added to instance profile
+ [SRU] all network devices aren't added to instance profile
** Also affects: cloud-archive
Importance: Undecided
Status: New
** Also affects: cloud-archive/mitaka
Importance: Undecided
Status: New
** Changed in: cloud-archive
Status: New => Fix Released
** Changed in: cloud-archive
Importance: Undecided => Medium
** Changed in: cloud-archive/mitaka
Importance: Undecided => Medium
** Changed in: cloud-archive/mitaka
Status: New => Triaged
** Description changed:
RELEASE: nova-compute-lxd 13.3.0-0ubuntu1
DESCRIPTION:
In config.py the network_devices object should be returned after the
'for vifaddr in network_info:' loop to ensure the network_devices object
includes all network devices.
CURRENT CODE (annotated area of interest with ):
def create_network(self, instance_name, instance, network_info):
"""Create the LXD container network on the host
:param instance_name: nova instance name
:param instance: nova instance object
:param network_info: instance network configuration object
:return:network configuration dictionary
"""
LOG.debug('create_network called for instance', instance=instance)
try:
network_devices = {}
if not network_info:
return
for vifaddr in network_info:
cfg = self.vif_driver.get_config(instance, vifaddr)
key = str(cfg['bridge'])
network_devices[key] = {'nictype': 'bridged', 'hwaddr':
str(cfg['mac_address']), 'parent': key, 'type': 'nic'}
host_device = self.vif_driver.get_vif_devname(vifaddr)
if host_device:
network_devices[key]['host_name'] = host_device
return network_devices
except Exception as ex:
with excutils.save_and_reraise_exception():
LOG.error(
_LE('Fail to configure network for %(instance)s: %(ex)s'),
{'instance': instance_name, 'ex': ex}, instance=instance)
PROPOSED CHANGE (annotated area of interest with ):
def create_network(self, instance_name, instance, network_info):
"""Create the LXD container network on the host
:param instance_name: nova instance name
:param instance: nova instance object
:param network_info: instance network configuration object
:return:network configuration dictionary
"""
LOG.debug('create_network called for instance', instance=instance)
try:
network_devices = {}
if not network_info:
return
for vifaddr in network_info:
cfg = self.vif_driver.get_config(instance, vifaddr)
key = str(cfg['bridge'])
network_devices[key] = {'nictype': 'bridged', 'hwaddr':
str(cfg['mac_address']), 'parent': key, 'type': 'nic'}
host_device = self.vif_driver.get_vif_devname(vifaddr)
if host_device:
network_devices[key]['host_name'] = host_device
return network_devices
except Exception as ex:
with excutils.save_and_reraise_exception():
LOG.error(
_LE('Fail to configure network for %(instance)s: %(ex)s'),
{'instance': instance_name, 'ex': ex}, instance=instance)
+
+
+ Adding fields for Ubuntu SRU template:
+
+ [Impact]
+ See Description above.
+
+ [Test Case]
+ TBD
+
+ [Regression Potential]
+ TBD
** Description changed:
RELEASE: nova-compute-lxd 13.3.0-0ubuntu1
DESCRIPTION:
In config.py the network_devices object should be returned after the
'for vifaddr in network_info:' loop to ensure the network_devices object
includes all network devices.
CURRENT CODE (annotated area of interest with ):
def create_network(self, instance_name, instance, network_info):
"""Create the LXD container network on the host
:param instance_name: nova instance name
:param instance: nova instance object
:param network_info: instance network configuration object
:return:network configuration dictionary
"""
LOG.debug('create_network called for instance', instance=instance)
try:
network_devices = {}
if not network_info:
return
for vifaddr in network_info:
cfg = self.vif_driver.get_config(instance, vifaddr)
key = str(cfg['bridge'])
network_devices[key] = {'nictype': 'bridged', 'hwaddr':
str(cfg['mac_address']), 'parent': key, 'type': 'nic'}
host_device =
