[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Bug Watch Updater]

** Changed in: logrotate (Debian)
   Status: New => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Edward Hope-Morley]

** Tags removed: sts-sru-needed
** Tags added: sts-sru-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Launchpad Bug Tracker]

This bug was fixed in the package logrotate - 3.8.7-2ubuntu3.1

---
logrotate (3.8.7-2ubuntu3.1) zesty; urgency=medium

  * logrotate does not ever recover from a corrupted statefile (LP: #1709670)
- d/p/do-not-treat-failure-of-readState-as-fatal.patch
(Backported from commit b9d82003002c98370e4131a7e43c76afcd23306a)

 -- Eric Desrochers   Wed, 09 Aug 2017
11:25:51 -0400

** Changed in: logrotate (Ubuntu Zesty)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

### VERIFICATION ZESTY ###

* Couldn't reproduce the above situation using the proposed package
version "3.8.7-2ubuntu3.1" using Zesty/17.04.

* Ran the testsuite against "3.8.7-2ubuntu3.1" "/usr/sbin/logrotate" binary and 
no errors were found, apart from a recurrent one which look to me like it did 
succeed but reported a failure. (false positive).
(It has the exact same report result as previous version "3.8.7-2ubuntu3")

==
Testsuite Full Report
--
# ./test 
setfacl failed on this system. ACL tests will not be executed.
./test: line 33: type: selinuxenabled: not found
SELinux disabled. SELinux tests will not be executed.
Running test 1
Running test 2
Running test 3
Running test 4
Running test 5
Running test 6
Skipping SELinux part of test 6
Running test 7
Running test 8
Running test 9
Running test 10
Skipping SELinux part of test 10
Running test 11
Running test 12
Running test 13
Running test 14
Running test 15
Running test 16
Running test 17
Running test 18
Running test 19
Running test 20
Running test 21
Running test 22
Running test 23
Running test 24
Running test 25
Running test 26
Running test 27
Running test 28
Running test 29
Running test 30
Running test 31
Skipping test 32: no ACL support
Skipping test 33: no ACL support
Running test 34
Skipping test 35: no ACL support
Running test 36
Running test 37
Running test 38
Running test 39
Running test 40
Running test 41
Running test 42
Running test 43
Running test 44
Running test 45
Running test 46
Skipping SELinux part of test 6
Running test 47
Skipping SELinux test 47
Running test 48
Skipping test 48: no ACL support
Running test 49
Running test 50
Running test 51
Running test 52
Running test 53
Running test 72
error: destination /tmp/logrotate-3.8.7/test/test.log.1.gz already exists, 
renaming to /var/tmp/logrotate-3.8.7/test/test.log.1.gz-2017082114.backup
--

- Eric

** Tags removed: verification-needed verification-needed-zesty
** Tags added: verification-done-zesty

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Launchpad Bug Tracker]

This bug was fixed in the package logrotate - 3.8.7-1ubuntu1.2

---
logrotate (3.8.7-1ubuntu1.2) trusty; urgency=medium

  * logrotate does not ever recover from a corrupted statefile (LP: #1709670)
- d/p/do-not-treat-failure-of-readState-as-fatal.patch
(Backported from commit b9d82003002c98370e4131a7e43c76afcd23306a)

 -- Eric Desrochers   Wed, 09 Aug 2017
15:55:36 -0400

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Launchpad Bug Tracker]

This bug was fixed in the package logrotate - 3.8.7-2ubuntu2.16.04.2

---
logrotate (3.8.7-2ubuntu2.16.04.2) xenial; urgency=medium

  * logrotate does not ever recover from a corrupted statefile (LP: #1709670)
- d/p/do-not-treat-failure-of-readState-as-fatal.patch
(Backported from commit b9d82003002c98370e4131a7e43c76afcd23306a)

 -- Eric Desrochers   Wed, 09 Aug 2017
16:02:21 -0400

** Changed in: logrotate (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

** Changed in: logrotate (Ubuntu Trusty)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

** Tags removed: verification-needed-trusty
** Tags added: verification-done-trusty

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Taylor Lewick]

We tested this patched package version on ubuntu 14.04, via instructions
found https://wiki.ubuntu.com/Testing/EnableProposed.

We tested by manually creating a 2.0 GB file via fallocate under the
nginx log directory, and instructing the logrotate nginx config file to
rotate any file > 1.0 GB.

This worked, and then I manually corrupted the logrotate status file by 
1) removing the top line, creating a new test log file, and verifying logrotate 
ran.
2) adding a line break in a file other than the top line, creating a new test 
log file, and verifying logrotate ran.

Patch Behavior appears to be working as designed.

Thank you,
Taylor

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

### VERIFICATION XENIAL ###

* Couldn't reproduce the above situation using the proposed package
version "3.8.7-2ubuntu2.16.04.2" using Xenial/16.04 LTS.

* Ran the testsuite against "3.8.7-2ubuntu2.16.04.2" and no errors were found, 
apart from a recurrent one which look to me like it did succeed but reported a 
failure. (false positive).
(It has the exact same report result as previous version 
"3.8.7-2ubuntu2.16.04.1")

==
Testsuite Full Report
--
# ./test 
setfacl failed on this system. ACL tests will not be executed.
./test: line 33: type: selinuxenabled: not found
SELinux disabled. SELinux tests will not be executed.
Running test 1
Running test 2
Running test 3
Running test 4
Running test 5
Running test 6
Skipping SELinux part of test 6
Running test 7
Running test 8
Running test 9
Running test 10
Skipping SELinux part of test 10
Running test 11
Running test 12
Running test 13
Running test 14
Running test 15
Running test 16
Running test 17
Running test 18
Running test 19
Running test 20
Running test 21
Running test 22
Running test 23
Running test 24
Running test 25
Running test 26
Running test 27
Running test 28
Running test 29
Running test 30
Running test 31
Skipping test 32: no ACL support
Skipping test 33: no ACL support
Running test 34
Skipping test 35: no ACL support
Running test 36
Running test 37
Running test 38
Running test 39
Running test 40
Running test 41
Running test 42
Running test 43
Running test 44
Running test 45
Running test 46
Skipping SELinux part of test 6
Running test 47
Skipping SELinux test 47
Running test 48
Skipping test 48: no ACL support
Running test 49
Running test 50
Running test 51
Running test 52
Running test 53
Running test 72
error: destination /tmp/logrotate-3.8.7/test/test.log.1.gz already exists, 
renaming to /tmp/logrotate-3.8.7/test/test.log.1.gz-2017081520.backup
--

- Eric

** Tags removed: verification-needed-xenial
** Tags added: verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Bug Watch Updater]

** Changed in: logrotate (Debian)
   Status: Unknown => New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Łukasz Zemczak]

Hello Ramon, or anyone else affected,

Accepted logrotate into zesty-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/logrotate/3.8.7-2ubuntu3.1 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-zesty to verification-done-zesty. If it does not fix
the bug for you, please add a comment stating that, and change the tag
to verification-failed-zesty. In either case, details of your testing
will help us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: logrotate (Ubuntu Zesty)
   Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-zesty

** Changed in: logrotate (Ubuntu Xenial)
   Status: In Progress => Fix Committed

** Tags added: verification-needed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

Trusty, Xenial & Zesty has been sponsored by myself in their respective
upload queues.

Now waiting for the SRU verification team approval for the package to
start building in $RELEASE-proposed for the testing phase.

- Eric

** Tags added: sts-sponsor-done

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

Debdiff for stable release : Xenial/16.04 LTS

** Patch added: "lp1709670-logrotate-xenial.debdiff"
   
https://bugs.launchpad.net/ubuntu/trusty/+source/logrotate/+bug/1709670/+attachment/4929989/+files/lp1709670-logrotate-xenial.debdiff

** Changed in: logrotate (Ubuntu Trusty)
   Importance: Undecided => Medium

** Changed in: logrotate (Ubuntu Xenial)
   Importance: Undecided => Critical

** Changed in: logrotate (Ubuntu Xenial)
   Importance: Critical => Medium

** Changed in: logrotate (Ubuntu Zesty)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

Debdiff for stable release : Zesty/17.04

** Patch added: "lp1709670-logrotate-zesty.debdiff"
   
https://bugs.launchpad.net/ubuntu/trusty/+source/logrotate/+bug/1709670/+attachment/4929988/+files/lp1709670-logrotate-zesty.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

Debdiff for stable release : Trusty/14.04 LTS lp1709670-logrotate-
trusty.debdiff

** Patch added: "lp1709670-logrotate-trusty.debdiff"
   
https://bugs.launchpad.net/ubuntu/trusty/+source/logrotate/+bug/1709670/+attachment/4929987/+files/lp1709670-logrotate-trusty.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Launchpad Bug Tracker]

This bug was fixed in the package logrotate - 3.8.7-2ubuntu4

---
logrotate (3.8.7-2ubuntu4) artful; urgency=medium

  * logrotate does not ever recover from a corrupted statefile (LP: #1709670)
- d/p/do-not-treat-failure-of-readState-as-fatal.patch
(Backported from commit b9d82003002c98370e4131a7e43c76afcd23306a)

 -- Eric Desrochers   Wed, 09 Aug 2017
11:39:36 -0700

** Changed in: logrotate (Ubuntu Artful)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

** Description changed:

  [Impact]
  
- logrotate never recovers if the statefile is corrupted unless you remove it 
or fix the corruption by hand.
- System will eventually run out of disk space on /var/log for instance.
+ logrotate never recovers if the statefile is corrupted unless you remove
+ it or fix the corruption by hand.
+ 
+ Impact scenarios :
+ - System could eventually run out of disk space on a separate partition if 
mounted in "/var" or specifically "/var/log" or even worst if "/var/log" is on 
the same partition as "/" it could create even more damage if by any chance the 
partition is running out of free space.
+ 
+ - System keep updating the same files over and over, creating large size 
logfiles.
+ - ...
  
  [Test Case]
  
  - Install logrotate
  - Run "/etc/cron.daily/logrotate" ## The first logrotate run will generate 
the statefile "var/lib/logrotate/status"
  - Modify "/var/lib/logrotate/status" by removing the first line in order to 
corrupt the file
  - Re-run "/etc/cron.daily/logrotate" and one will get the following error : 
"error: bad top line in state file /var/lib/logrotate/status" every time you 
run logrotate
  
  Unless you remove the statefile and start again or fix the corruption by
  hand.
  
  [Regression Potential]
  
   * Risk of potential regression is low, and IMHO couldn't be worst than
  the actual situation where logrotate simply doesn't recover from a
  corrupt statefile.
  
   * The current patch does recover (after verification) and has been
  through some upstream CI validation, community feedbacks, et al.
  
   * Additionally, I will run the /path_to_source/test/test script as a
  dogfooding that does ~72 tests.
  
  [Other Info]
  
  * Upstream commit:
  
https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a
  
  * Upstream bug:
  https://github.com/logrotate/logrotate/issues/45
  
  * Debian bug:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592

** Description changed:

  [Impact]
  
  logrotate never recovers if the statefile is corrupted unless you remove
  it or fix the corruption by hand.
  
  Impact scenarios :
- - System could eventually run out of disk space on a separate partition if 
mounted in "/var" or specifically "/var/log" or even worst if "/var/log" is on 
the same partition as "/" it could create even more damage if by any chance the 
partition is running out of free space.
  
- - System keep updating the same files over and over, creating large size 
logfiles.
+ - System could eventually run out of disk space on a separate partition
+ if mounted in "/var" or specifically "/var/log" or even worst if
+ "/var/log" is on the same partition as "/" it could create even more
+ damage if by any chance the partition is running out of free space.
+ 
+ - System keep updating the same files over and over, creating large size
+ logfiles.
+ 
  - ...
  
  [Test Case]
  
  - Install logrotate
  - Run "/etc/cron.daily/logrotate" ## The first logrotate run will generate 
the statefile "var/lib/logrotate/status"
  - Modify "/var/lib/logrotate/status" by removing the first line in order to 
corrupt the file
  - Re-run "/etc/cron.daily/logrotate" and one will get the following error : 
"error: bad top line in state file /var/lib/logrotate/status" every time you 
run logrotate
  
  Unless you remove the statefile and start again or fix the corruption by
  hand.
  
  [Regression Potential]
  
   * Risk of potential regression is low, and IMHO couldn't be worst than
  the actual situation where logrotate simply doesn't recover from a
  corrupt statefile.
  
   * The current patch does recover (after verification) and has been
  through some upstream CI validation, community feedbacks, et al.
  
   * Additionally, I will run the /path_to_source/test/test script as a
  dogfooding that does ~72 tests.
  
  [Other Info]
  
  * Upstream commit:
  
https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a
  
  * Upstream bug:
  https://github.com/logrotate/logrotate/issues/45
  
  * Debian bug:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592

** Description changed:

  [Impact]
  
  logrotate never recovers if the statefile is corrupted unless you remove
  it or fix the corruption by hand.
  
  Impact scenarios :
  
  - System could eventually run out of disk space on a separate partition
  if mounted in "/var" or specifically "/var/log" or even worst if
  "/var/log" is on the same partition as "/" it could create even more
  damage if by any chance the partition is running out of free space.
  
  - System keep updating the same files over and over, creating large size
  logfiles.
  
  - ...
  
  [Test Case]
  
  - Install logrotate
  - Run "/etc/cron.daily/logrotate" ## The first logrotate run will generate 
the statefile "var/lib/logrotate/status"
  - Modify "/var/lib/logrotate/status" by removing the first line in order to 
corrupt the file
  - Re-run "/etc/cron.daily/logrotate" 

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

** Changed in: logrotate (Ubuntu Artful)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Ramon Grullon]

Tested the patch package (pre-SRU) on trusty  and it works as expected.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

** Changed in: logrotate (Ubuntu Zesty)
   Status: Confirmed => In Progress

** Changed in: logrotate (Ubuntu Trusty)
   Status: Confirmed => In Progress

** Changed in: logrotate (Ubuntu Xenial)
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

** Patch removed: "lp1709670-logrotate-zesty.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+attachment/4929665/+files/lp1709670-logrotate-zesty.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

** Description changed:

  [Impact]
  
  logrotate never recovers if the statefile is corrupted unless you remove it 
or fix the corruption by hand.
  System will eventually run out of disk space on /var/log for instance.
  
  [Test Case]
  
  - Install logrotate
  - Run "/etc/cron.daily/logrotate" ## The first logrotate run will generate 
the statefile "var/lib/logrotate/status"
  - Modify "/var/lib/logrotate/status" by removing the first line in order to 
corrupt the file
  - Re-run "/etc/cron.daily/logrotate" and one will get the following error : 
"error: bad top line in state file /var/lib/logrotate/status" every time you 
run logrotate
  
  Unless you remove the statefile and start again or fix the corruption by
  hand.
  
  [Regression Potential]
  
-  * Risk of potential regression is low, and IMHO couldn't be worst than the 
actual situation where logrotate simply doesn't recover from a corrupt 
statefile.
-  
-  * The current patch does recover (after verification) and has been through 
some upstream CI validation, community feedbacks, et al.
+  * Risk of potential regression is low, and IMHO couldn't be worst than
+ the actual situation where logrotate simply doesn't recover from a
+ corrupt statefile.
+ 
+  * The current patch does recover (after verification) and has been
+ through some upstream CI validation, community feedbacks, et al.
+ 
+  * Additionally, I will run the /path_to_source/test/test script as a
+ dogfooding that does a bunch of tests.
  
  [Other Info]
  
  * Upstream commit:
  
https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a
  
  * Upstream bug:
  https://github.com/logrotate/logrotate/issues/45
  
  * Debian bug:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592

** Description changed:

  [Impact]
  
  logrotate never recovers if the statefile is corrupted unless you remove it 
or fix the corruption by hand.
  System will eventually run out of disk space on /var/log for instance.
  
  [Test Case]
  
  - Install logrotate
  - Run "/etc/cron.daily/logrotate" ## The first logrotate run will generate 
the statefile "var/lib/logrotate/status"
  - Modify "/var/lib/logrotate/status" by removing the first line in order to 
corrupt the file
  - Re-run "/etc/cron.daily/logrotate" and one will get the following error : 
"error: bad top line in state file /var/lib/logrotate/status" every time you 
run logrotate
  
  Unless you remove the statefile and start again or fix the corruption by
  hand.
  
  [Regression Potential]
  
   * Risk of potential regression is low, and IMHO couldn't be worst than
  the actual situation where logrotate simply doesn't recover from a
  corrupt statefile.
  
   * The current patch does recover (after verification) and has been
  through some upstream CI validation, community feedbacks, et al.
  
-  * Additionally, I will run the /path_to_source/test/test script as a
- dogfooding that does a bunch of tests.
+  * Additionally, I will run the /path_to_source/test/test script as a
+ dogfooding that does ~72 tests.
  
  [Other Info]
  
  * Upstream commit:
  
https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a
  
  * Upstream bug:
  https://github.com/logrotate/logrotate/issues/45
  
  * Debian bug:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592

** Tags removed: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Nish Aravamudan]

Sponsored to artful.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

** Description changed:

  [Impact]
  
  logrotate never recovers if the statefile is corrupted unless you remove it 
or fix the corruption by hand.
  System will eventually run out of disk space on /var/log for instance.
  
  [Test Case]
  
  - Install logrotate
  - Run "/etc/cron.daily/logrotate" ## The first logrotate run will generate 
the statefile "var/lib/logrotate/status"
  - Modify "/var/lib/logrotate/status" by removing the first line in order to 
corrupt the file
  - Re-run "/etc/cron.daily/logrotate" and one will get the following error : 
"error: bad top line in state file /var/lib/logrotate/status" every time you 
run logrotate
  
  Unless you remove the statefile and start again or fix the corruption by
  hand.
  
  [Regression Potential]
  
-  * Risk of potential regression is low, and couldn' be worst than the actual 
situation where logrotate doesn't recover from a corrupt statefile.
-    The current patch does recover (after verification)
+  * Risk of potential regression is low, and IMHO couldn't be worst than the 
actual situation where logrotate simply doesn't recover from a corrupt 
statefile.
+  
+  * The current patch does recover (after verification) and has been through 
some upstream CI validation, community feedbacks, et al.
  
  [Other Info]
  
  * Upstream commit:
  
https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a
  
  * Upstream bug:
  https://github.com/logrotate/logrotate/issues/45
  
  * Debian bug:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

Debdiff for stable release : Zesty/17.04

** Patch added: "lp1709670-logrotate-zesty.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+attachment/4929665/+files/lp1709670-logrotate-zesty.debdiff

** Changed in: logrotate (Ubuntu Zesty)
 Assignee: (unassigned) => Eric Desrochers (slashd)

** Changed in: logrotate (Ubuntu Xenial)
 Assignee: (unassigned) => Eric Desrochers (slashd)

** Changed in: logrotate (Ubuntu Trusty)
 Assignee: (unassigned) => Eric Desrochers (slashd)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

Debdiff for devel release Artful.

** Patch added: "lp1709670-logrotate-artful.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+attachment/4929643/+files/lp1709670-logrotate-artful.debdiff

** Tags added: patch

** Changed in: logrotate (Ubuntu Trusty)
   Status: New => Confirmed

** Changed in: logrotate (Ubuntu Zesty)
   Status: New => Confirmed

** Changed in: logrotate (Ubuntu Xenial)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

** Bug watch added: Debian Bug tracker #871592
   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592

** Also affects: logrotate (Debian) via
   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592
   Importance: Unknown
   Status: Unknown

** Description changed:

- - Install logrotate 
+ [Impact]
+ 
+ logrotate never recovers if the statefile is corrupted unless you remove it 
or fix the corruption by hand.
+ System will eventually run out of disk space on /var/log for instance.
+ 
+ [Test Case]
+ 
+ - Install logrotate
  - Run "/etc/cron.daily/logrotate" ## The first logrotate run will generate 
the statefile "var/lib/logrotate/status"
  - Modify "/var/lib/logrotate/status" by removing the first line in order to 
corrupt the file
- - Re-run "/etc/cron.daily/logrotate" and you will get something like this 
"error: bad top line in state file /var/lib/logrotate/status" every time you 
run logrotate
+ - Re-run "/etc/cron.daily/logrotate" and one will get the following error : 
"error: bad top line in state file /var/lib/logrotate/status" every time you 
run logrotate
  
- logrotate never recovers if the statefile is corrupted unless you remove
- it or fix the corruption by hand.
+ [Regression Potential]
  
- System will eventually run out of disk space and crash.
+  * Risk of potential regression is low, and couldn' be worst than the actual 
situation where logrotate doesn't recover from a corrupt statefile.
+The current patch does recover (after verification)
+ 
+ [Other Info]
+  
+ * Upstream commit:
+ 
https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a
+ 
+ * Upstream bug:
+ https://github.com/logrotate/logrotate/issues/45
+ 
+ * Debian bug:
+ https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592

** Description changed:

  [Impact]
  
  logrotate never recovers if the statefile is corrupted unless you remove it 
or fix the corruption by hand.
  System will eventually run out of disk space on /var/log for instance.
  
  [Test Case]
  
  - Install logrotate
  - Run "/etc/cron.daily/logrotate" ## The first logrotate run will generate 
the statefile "var/lib/logrotate/status"
  - Modify "/var/lib/logrotate/status" by removing the first line in order to 
corrupt the file
  - Re-run "/etc/cron.daily/logrotate" and one will get the following error : 
"error: bad top line in state file /var/lib/logrotate/status" every time you 
run logrotate
  
+ Unless you remove the statefile and start again or fix the corruption by
+ hand.
+ 
  [Regression Potential]
  
-  * Risk of potential regression is low, and couldn' be worst than the actual 
situation where logrotate doesn't recover from a corrupt statefile.
-The current patch does recover (after verification)
+  * Risk of potential regression is low, and couldn' be worst than the actual 
situation where logrotate doesn't recover from a corrupt statefile.
+    The current patch does recover (after verification)
  
  [Other Info]
-  
+ 
  * Upstream commit:
  
https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a
  
  * Upstream bug:
  https://github.com/logrotate/logrotate/issues/45
  
  * Debian bug:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871592

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1709670] Re: logrotate never recovers if the statefile is corrupted

[Eric Desrochers]

Using the above reproducer ^ 

I confirm that logrotate never recover if the statefile is corrupted
unless you remove it or fix the corruption by hand.

The upstream fix introduce in 3.12.0-18 [1] is fixing the issue[2]
(tested using Artful so far)

Since all supported|devel releases are lower than 3.12 [3], then all
releases are affected.

[1] -
https://github.com/logrotate/logrotate/commit/b9d82003002c98370e4131a7e43c76afcd23306a

# git describe --contains b9d8200
3.12.0~18


[2] - https://github.com/logrotate/logrotate/issues/45

[3] - rmadison
logrotate | 3.8.7-1ubuntu1 | trusty | source, amd64, arm64, armhf, i386, 
powerpc, ppc64el
logrotate | 3.8.7-1ubuntu1 | vivid | source, amd64, arm64, armhf, i386, 
powerpc, ppc64el
logrotate | 3.8.7-1ubuntu1.1 | trusty-updates | source, amd64, arm64, armhf, 
i386, powerpc, ppc64el
logrotate | 3.8.7-2ubuntu2 | xenial | source, amd64, arm64, armhf, i386, 
powerpc, ppc64el, s390x
logrotate | 3.8.7-2ubuntu2.16.04.1 | xenial-updates | source, amd64, arm64, 
armhf, i386, powerpc, ppc64el, s390x
logrotate | 3.8.7-2ubuntu3 | zesty | source, amd64, arm64, armhf, i386, 
ppc64el, s390x
logrotate | 3.8.7-2ubuntu3 | artful | source, amd64, arm64, armhf, i386, 
ppc64el, s390x

Regards,
Eric


** Tags added: sts sts-sru-needed

** Also affects: logrotate (Ubuntu Artful)
   Importance: Undecided
   Status: New

** Also affects: logrotate (Ubuntu Trusty)
   Importance: Undecided
   Status: New

** Also affects: logrotate (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Also affects: logrotate (Ubuntu Zesty)
   Importance: Undecided
   Status: New

** Bug watch added: github.com/logrotate/logrotate/issues #45
   https://github.com/logrotate/logrotate/issues/45

** Changed in: logrotate (Ubuntu Artful)
   Status: New => In Progress

** Changed in: logrotate (Ubuntu Artful)
   Importance: Undecided => Medium

** Changed in: logrotate (Ubuntu Artful)
 Assignee: (unassigned) => Eric Desrochers (slashd)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1709670

Title:
  logrotate never recovers if the statefile is corrupted

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/logrotate/+bug/1709670/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs