[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Changed in: debian-installer (Ubuntu Zesty) Status: In Progress => Won't Fix ** Changed in: debian-installer (Ubuntu Trusty) Status: In Progress => Won't Fix ** Changed in: debian-installer-utils (Ubuntu Trusty) Status: In Progress => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
xenial debian-installer has been rebuilt and archive.ubuntu.com updated 2018-01-02 and includes this fix: http://archive.ubuntu.com/ubuntu/dists/xenial-updates/main/installer-amd64/20101020ubuntu451.18/ ** Changed in: debian-installer (Ubuntu Xenial) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
This bug was fixed in the package debian-installer-utils - 1.113ubuntu1.16.04.1 --- debian-installer-utils (1.113ubuntu1.16.04.1) xenial; urgency=medium * Make sure udevd internal state is up-to-date before calling trigger & settle. This insures that newly anna-installed udev rules and kernel modules are loaded by udevd for correct processing of the udev rules. LP: #1714505. -- Dimitri John Ledkov Sun, 17 Sep 2017 00:41:44 +0100 ** Changed in: debian-installer-utils (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
> But, specifically about this bug and trusty, are there actual users who are > encountering this > bug on trusty? No, the user who reported this does not encounter it with trusty, but that of course doesn't mean it does not exist there. I am not able to reproduce it on my nvme systems with any release, as this is a specific race condition (with the poorly-designed 3 second window where udev uses stale kernel module info) when using fully automated preseeded install onto a nvme system behind a firewall with a proxy. > When I say users of ISOs I mean the server.iso from cdimage.ubuntu.com When installing to multiple systems, manual ISO installation is rarely used (by experienced sysadmins), for obvious reasons. > It worries me, that we have users reinstalling trusty today Many users - including large companies - still use trusty. In fact some users/companies still use precise, which is why Precise ESM exists. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
This bug was fixed in the package debian-installer-utils - 1.113ubuntu1.17.04.1 --- debian-installer-utils (1.113ubuntu1.17.04.1) zesty; urgency=medium * Make sure udevd internal state is up-to-date before calling trigger & settle. This insures that newly anna-installed udev rules and kernel modules are loaded by udevd for correct processing of the udev rules. LP: #1714505. -- Dimitri John Ledkov Sun, 17 Sep 2017 00:41:44 +0100 ** Changed in: debian-installer-utils (Ubuntu Zesty) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
Dan, I'm not talking about hypothetical users who hypothetically are encountering any bugs. Of course, we fix all the things. But, specifically about this bug and trusty, are there actual users who are encountering this bug on trusty? Specifically, since the hardware in question was released after trusty. And there will be no more point releases for trusty - meaning users of iso's will not get an update. When I say users of ISOs I mean the server.iso from cdimage.ubuntu.com, not the d-i by-products that are published on archive.ubuntu.com those can be updated. It worries me, that we have users reinstalling trusty today, when xenial has been out for so long, and bionic will be generally available in less than 4 months time. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
reporter noted xenial fixed initrd also works. ** Tags removed: verification-needed-xenial ** Tags added: verification-done-xenial ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
in zesty lxd container built initrd without -proposed di-utils and initrd with -proposed di-utils: ubuntu@build-zesty:~/debian-installer-20101020ubuntu504/build$ make USE_UDEBS_FROM_EXTRA="zesty-security zesty-updates" build_netboot ... ubuntu@build-zesty:~/debian-installer-20101020ubuntu504/build$ cp dest/netboot/ubuntu-installer/amd64/initrd.gz ~/initrd-fail.gz ubuntu@build-zesty:~/debian-installer-20101020ubuntu504/build$ make reallyclean ... ubuntu@build-zesty:~/debian-installer-20101020ubuntu504/build$ make build_netboot ... ubuntu@build-zesty:~/debian-installer-20101020ubuntu504/build$ cp dest/netboot/ubuntu-installer/amd64/initrd.gz ~/initrd-fixed.gz person who reported this to me tested both; automated install using their preseed configuration fails on system with nvme drive using initrd-fail.gz, succeeds using initrd-fixed.gz ** Tags removed: verification-needed-zesty ** Tags added: verification-done-zesty -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
Hello Dan, or anyone else affected, Accepted debian-installer-utils into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source /debian-installer-utils/1.113ubuntu1.17.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: debian-installer-utils (Ubuntu Zesty) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-zesty ** Changed in: debian-installer-utils (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
To clarify - if we don't SRU this, what do we tell Ubuntu users (including Canonical customers) who are encountering this problem on trusty, xenial, or zesty? Sorry, we aren't fixing this, you can't use your automated preseed install. Or, sorry, you'll have to upgrade to artful, or wait for the next xenial point release. Neither sound very friendly to the Ubuntu user base. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
> What is the rationale behind requesting a fix for trusty? How do you expect > it to get onto > an .iso? A customized iso? Customers use the initrd provided in our archive, not just isos, e.g.: http://archive.ubuntu.com/ubuntu/dists/trusty-updates/main/installer- amd64/current/images/netboot/ubuntu-installer/amd64/initrd.gz And updated isos can be produced by debian-installer, e.g.: http://archive.ubuntu.com/ubuntu/dists/trusty-updates/main/installer- amd64/current/images/netboot/mini.iso So are you going to SRU this or should I? ** Changed in: debian-installer-utils (Ubuntu Trusty) Status: Won't Fix => In Progress ** Changed in: debian-installer (Ubuntu Trusty) Status: Won't Fix => In Progress ** Changed in: debian-installer (Ubuntu Zesty) Status: Won't Fix => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
Whilst we can upload fixes for zesty and trusty; neither of those will have a point release anymore to include a fix for this. What is the rationale behind requesting a fix for trusty? How do you expect it to get onto an .iso? A customized iso? ** Changed in: debian-installer-utils (Ubuntu Zesty) Status: New => In Progress ** Changed in: debian-installer-utils (Ubuntu Xenial) Status: New => In Progress ** Changed in: debian-installer-utils (Ubuntu Trusty) Assignee: Dan Streetman (ddstreet) => (unassigned) ** Changed in: debian-installer-utils (Ubuntu Xenial) Assignee: Dan Streetman (ddstreet) => (unassigned) ** Changed in: debian-installer-utils (Ubuntu Zesty) Assignee: Dan Streetman (ddstreet) => (unassigned) ** Changed in: debian-installer-utils (Ubuntu Trusty) Status: New => Won't Fix ** Changed in: debian-installer (Ubuntu Trusty) Status: New => Won't Fix ** Changed in: debian-installer (Ubuntu Artful) Status: New => Fix Released ** Changed in: debian-installer (Ubuntu Zesty) Status: New => Won't Fix ** No longer affects: debian-installer (Ubuntu Bionic) ** Changed in: debian-installer (Ubuntu) Status: Fix Committed => Fix Released ** Changed in: debian-installer (Ubuntu) Milestone: ubuntu-17.10 => None ** Changed in: debian-installer (Ubuntu) Assignee: (unassigned) => Dimitri John Ledkov (xnox) ** No longer affects: debian-installer-utils (Ubuntu Bionic) ** No longer affects: systemd (Ubuntu) ** No longer affects: systemd (Ubuntu Artful) ** No longer affects: systemd (Ubuntu Bionic) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Changed in: systemd (Ubuntu Artful) Status: New => Won't Fix ** Description changed: [Impact] udev's rules use a built-in 'kmod' instead of the system modprobe/insmod, and this built-in kmod only validates/refreshes its kmod 'context' every 3 seconds (or longer) during event processing. However, because other parts of the system rely on udev to load modules correctly, it is not acceptable for it to use an out of date module context. For example, during a system installation: -the system boots with kernel and initrd with a reduced set of modules, not including nvme module -udevd starts, and creates its kmod module context, which does not include nvme module -system installer adds 'block-modules' udeb, which adds nvme module to system -system installer immediately calls hw-detect->update-dev->udevadm trigger -udevd sees its kmod module context is not more than 3 seconds old, and does not update it -udevd rule 80-drivers.rules finds NVMe pci modalias and asks kmod builtin to load matching driver -udevd kmod builtin does not find NVMe pci modalias because its context is out of date this results in the system installer complaining to the user that it found no disks, even though there is a NVMe drive in the system, and the nvme module is installed in the system. + The fix is to reload udevadm rules, as per upstream recommendation. + [Test Case] This is reproducable when trying to install using debian-installer and a preseed file that skips all questions, although not on all systems, since other events can cause udevd to reload all its builtins, or the installer may take longer than 3 seconds to call udevadm trigger after installing the nvme module udeb. - However, the bug is easily reproducable on any system with a nvme drive - using this script: - - #!/bin/bash - MOD_DIR=/lib/modules/$( uname -r )/kernel/drivers/nvme/host - modprobe -rq nvme - mv $MOD_DIR/nvme.ko . - depmod -a - sleep 3 - udevadm trigger - sleep 1 - mv nvme.ko $MOD_DIR/ - depmod -a - udevadm trigger - sleep 3 - grep -q nvme /proc/partitions && echo PASS || echo FAIL - - that script does: - 1) remove nvme module from the system, reproducing situation where nvme module had not yet been installed - 2) waits 3 seconds, because the udev kmod validation timeout is 3 seconds - 3) triggers udev, which forces it to reload its kmod context (this could be done with udevadm control -R instead) - 4) waits 1 second for the udev trigger to finish, then puts the nvme module back into the system, reproducing the initial installation of the deb/udeb containing the nvme module - 5) immediately triggers udev, which should load the nvme module when it sees the nvme pci device - 6) wait 3 seconds for udev trigger to finish (plenty of time), and check if the nvme module was loaded - - this script reproduces the error every time, due to the stale kmod - context. With a fixed udev, this should succeed in loading the nvme - module. + Stale context in udevd is expected, and one is supposed to reload rules + via udevadm, which is the fix proposed in debian-installer-utils. + Removing the previous second test case that does not reload via udevadm. [Regression Potential] - The most potential for regression with a fix to this involves slowing - down udev due to validating the kmod context for every kmod load call. - However, slightly higher performance does not make up for broken - operation. - - [Other Info] - - This needs fixing upstream, which I'm in progress on. + Additional calls to udevadm reload will cause all udev rules to be re- + read correctly. This may lead to new devices + discovered/configured/symlink during d-i installer, which were + previously skipped/missed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Also affects: debian-installer (Ubuntu Artful) Importance: Undecided Status: New ** Also affects: debian-installer-utils (Ubuntu Artful) Importance: Undecided Status: New ** Also affects: systemd (Ubuntu Artful) Importance: Undecided Status: New ** Also affects: debian-installer (Ubuntu Bionic) Importance: Undecided Status: Fix Committed ** Also affects: debian-installer-utils (Ubuntu Bionic) Importance: Critical Assignee: Dimitri John Ledkov (xnox) Status: Fix Released ** Also affects: systemd (Ubuntu Bionic) Importance: Medium Assignee: Dan Streetman (ddstreet) Status: Won't Fix ** Changed in: debian-installer-utils (Ubuntu Artful) Status: New => Fix Released ** Changed in: debian-installer-utils (Ubuntu Zesty) Assignee: (unassigned) => Dan Streetman (ddstreet) ** Changed in: debian-installer-utils (Ubuntu Xenial) Assignee: (unassigned) => Dan Streetman (ddstreet) ** Changed in: debian-installer-utils (Ubuntu Trusty) Assignee: (unassigned) => Dan Streetman (ddstreet) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Tags added: sts-sponsor-ddstreet -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Changed in: debian-installer (Ubuntu) Milestone: None => ubuntu-17.10 ** Changed in: debian-installer (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** No longer affects: debian-installer (Ubuntu Artful) ** No longer affects: debian-installer (Ubuntu Zesty) ** No longer affects: debian-installer (Ubuntu Xenial) ** No longer affects: debian-installer (Ubuntu Trusty) ** Also affects: debian-installer (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: debian-installer-utils (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: systemd (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: debian-installer (Ubuntu Zesty) Importance: Undecided Status: New ** Also affects: debian-installer-utils (Ubuntu Zesty) Importance: Undecided Status: New ** Also affects: systemd (Ubuntu Zesty) Importance: Undecided Status: New ** Also affects: debian-installer (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: debian-installer-utils (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: systemd (Ubuntu Xenial) Importance: Undecided Status: New ** No longer affects: systemd (Ubuntu Trusty) ** No longer affects: systemd (Ubuntu Xenial) ** No longer affects: systemd (Ubuntu Zesty) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
This bug was fixed in the package debian-installer-utils - 1.113ubuntu2 --- debian-installer-utils (1.113ubuntu2) artful; urgency=medium * Make sure udevd internal state is up-to-date before calling trigger & settle. This insures that newly anna-installed udev rules and kernel modules are loaded by udevd for correct processing of the udev rules. LP: #1714505. -- Dimitri John Ledkov Sun, 17 Sep 2017 00:41:44 +0100 ** Changed in: debian-installer-utils (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Changed in: debian-installer-utils (Ubuntu) Status: Confirmed => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Changed in: debian-installer-utils (Ubuntu) Status: New => Confirmed ** Changed in: debian-installer-utils (Ubuntu) Milestone: None => ubuntu-17.09 ** Changed in: debian-installer-utils (Ubuntu) Assignee: (unassigned) => Dimitri John Ledkov (xnox) ** Changed in: debian-installer-utils (Ubuntu) Importance: Undecided => Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
@xnox, the person that reported this to me and who can reproduce it, tested with a initrd including your update-dev patch and it does fix the problem. Can you go ahead and merge it and SRU please? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
Also, this upstream udev bug has caused trouble before, e.g.: https://bugs.launchpad.net/ubuntu/+source/hw-detect/+bug/1549456 that does a udev reload too, but only when specific devices are found. Hopefully this change to update-dev will cover more cases where this upstream udev bug will cause failures, but since it's a racy 0-3 second window of stale data that udev uses, and they refuse to fix it upstream, it will be really hard to test for and/or reproduce. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
> Here is a sample patch against debian-installer-utils to try. yes i think it at least needs to go here, to handle this very specific case. It may be better to put it into the if $TRIGGER section, as I don't think it is needed for only the settle case, but either way should work. This was reported to me, so I'll ask the reporter to test with this change to verify it fixes for them; I have not been able to reproduce it myself. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
> Changed in systemd: > status: New → Fix Released for clarification, this is not Fix Released upstream, it has been rejected as Won't Fix upstream, systemd/udev believes it isn't their problem. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
Here is a sample patch against debian-installer-utils to try. Do you need a d-i build for testing? If yes, for which release(s)? ** Patch added: "lp1714505.patch" https://bugs.launchpad.net/ubuntu/+source/debian-installer-utils/+bug/1714505/+attachment/4951445/+files/lp1714505.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
I think we should fix .udeb installation and the d-i to call `udevadm control --reload` after .udeb installation and before (re-)triggering udev. ** Also affects: debian-installer (Ubuntu) Importance: Undecided Status: New ** Changed in: systemd (Ubuntu Artful) Status: In Progress => Won't Fix ** No longer affects: systemd (Ubuntu Zesty) ** No longer affects: systemd (Ubuntu Trusty) ** No longer affects: systemd (Ubuntu Xenial) ** Changed in: systemd (Ubuntu) Status: In Progress => Won't Fix ** No longer affects: systemd (Ubuntu Artful) ** Also affects: debian-installer-utils (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Changed in: systemd Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
opened upstream merge request 6814: https://github.com/systemd/systemd/pull/6814 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Changed in: systemd (Ubuntu Zesty) Assignee: (unassigned) => Dan Streetman (ddstreet) ** Changed in: systemd (Ubuntu Xenial) Assignee: (unassigned) => Dan Streetman (ddstreet) ** Changed in: systemd (Ubuntu Trusty) Assignee: (unassigned) => Dan Streetman (ddstreet) ** Changed in: systemd (Ubuntu Zesty) Status: New => In Progress ** Changed in: systemd (Ubuntu Xenial) Status: New => In Progress ** Changed in: systemd (Ubuntu Zesty) Importance: Undecided => Medium ** Changed in: systemd (Ubuntu Xenial) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Also affects: systemd (Ubuntu Artful) Importance: Medium Assignee: Dan Streetman (ddstreet) Status: In Progress ** Also affects: systemd (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: systemd (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: systemd (Ubuntu Zesty) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Changed in: systemd Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
yep, having up to 3 seconds worth of stale system data is too much time. Also, I think the builtins can just validate themselves - for example the kmod builtin can trivially call kmod_validate_resource(ctx) every time it's asked to load a module, and I think the other builtins that implement .validate probably also can self-validate too, and remove the udev_builtin_validate() call entirely. I have a small draft patch just to the kmod builtin that I'm testing: https://code.launchpad.net/~ddstreet/+git/systemd/+ref/sf149300 I'll take another look next week to see if it can be expanded to cover all the builtins that do validation, and submit something upstream for discussion. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
I guess this is related to the fact that udevd main loop re-reads configs at most every 3 seconds. I find that 3 seconds is a really long time these days. I wonder if the 3s timeout around manager_reload(manager) should be removed in udevd. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
** Also affects: systemd via https://github.com/systemd/systemd/issues/6723 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
slight update to test script, add a check to make sure the nvme module was unloaded - if any nvme partitions are mounted it would cause a false positive result. #!/bin/bash MOD_DIR=/lib/modules/$( uname -r )/kernel/drivers/nvme/host modprobe -rq nvme mv $MOD_DIR/nvme.ko . depmod -a sleep 3 udevadm trigger sleep 1 mv nvme.ko $MOD_DIR/ depmod -a grep -q nvme /proc/partitions && echo FAIL nvme driver still loaded unmount all nvme partitions && exit 1 udevadm trigger sleep 3 grep -q nvme /proc/partitions && echo PASS || echo FAIL -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
grr, please note line wrap in above comment; script should be: #!/bin/bash MOD_DIR=/lib/modules/$( uname -r )/kernel/drivers/nvme/host modprobe -rq nvme mv $MOD_DIR/nvme.ko . depmod -a sleep 3 udevadm trigger sleep 1 mv nvme.ko $MOD_DIR/ depmod -a grep -q nvme /proc/partitions \ && echo FAIL nvme driver still loaded unmount all nvme partitions \ && exit 1 udevadm trigger sleep 3 grep -q nvme /proc/partitions && echo PASS || echo FAIL -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
note that the test script in the description must be run as root on a system that does have a nvme drive that isn't in use (because the nvme module can't be removed if any nvme drive is in use). ** Bug watch added: github.com/systemd/systemd/issues #6723 https://github.com/systemd/systemd/issues/6723 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1714505] Re: systemd kmod builtin uses out of date kmod context
https://github.com/systemd/systemd/issues/6723 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1714505 Title: systemd kmod builtin uses out of date kmod context To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1714505/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
