[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
This bug is believed to be fixed in curtin in version18.1-17-gae48e86f- 0ubuntu1. If this is still a problem for you, please make a comment and set the state back to New Thank you. ** Changed in: curtin Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
SRU: https://bugs.launchpad.net/ubuntu/+source/curtin/+bug/1772044 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
Now that https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1729145 is released, this work to SRU back to xenial can proceed. ** Changed in: curtin (Ubuntu Trusty) Status: New => Won't Fix ** Changed in: curtin (Ubuntu Bionic) Status: New => Fix Released ** Changed in: curtin (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** No longer affects: bcache-tools (Ubuntu) ** Changed in: bcache-tools (Ubuntu Bionic) Status: In Progress => Invalid ** Changed in: bcache-tools (Ubuntu Artful) Status: Confirmed => Invalid ** Changed in: bcache-tools (Ubuntu Xenial) Status: Confirmed => Invalid ** Changed in: bcache-tools (Ubuntu Trusty) Status: Confirmed => Invalid ** Changed in: bcache-tools (Ubuntu Bionic) Assignee: Ryan Harper (raharper) => (unassigned) ** Also affects: curtin (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Merge proposal unlinked: https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/341915 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Changed in: curtin Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Merge proposal linked: https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/341915 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
Ryan forwarded this to bcache-tools upstream on github.
https://github.com/koverstreet/bcache-tools/pull/1
** Description changed:
[Impact]
* Current users of bcache devices may encounter unreliable device
numbering as the Linux kernel does not guarantee that bcache
minor numbers are assigned to the same devices at each boot.
Users who may have used /dev/bcacheN in paths to a specific
device could possible be pointing to a different dataset
altogether. bcache udev rules do provide some mechanism to
generate persistent symlinks in /dev/bcache/by-uuid or
/dev/bcache/by-label which is based on superblock data on
the underlying device. However, the Linux kernel does not
always generate an kernel uevent to trigger the udev rules
to create the symlink.
* The fix adds a udev program which will read bcache superblock
of slave devices and extract the UUID and LABEL, exporting them
to udev for use in the bcache rule files.
* This is affected in upstream bcache-tools, the owning package
of the udev rules. This affects all releases of bcache-tools
as the rules rely upon the kernel to trigger these events,
though that is not a requirement to resolve the lack of
persistent links.
[Test Case]
* Launch and Ubuntu Cloud Image with 3 unused disks
- apt install bcache-tools tree
- make-bcache -C /dev/vdb
- make-bcache -B /dev/vdc
- make-bcache -B /dev/vdd
- echo "vdc" > /sys/class/block/bcache0/bcache/label
- echo "vdd" > /sys/class/block/bcache1/bcache/label
- reboot
- Run this test:
#!/bin/bash
FAIL=0
[ ! -d /dev/bcache ] && {
echo "FAIL: /dev/bcache is not a directory";
exit 1
}
for label in /dev/bcache/by-label/*; do
LABEL_TARGET="$(ls -1 /sys/class/block/`basename $label`/holders/)"
DEVNAME=`readlink -f $label`;
KNAME="${DEVNAME#*/dev/}"
if [ "$LABEL_TARGET" != "$KNAME" ]; then
echo "FAIL: label points to $LABEL_TARGET but symlink points to
$DEVNAME";
FAIL=1
fi;
done
if [ "$FAIL" == "0" ]; then
echo "PASS";
exit 0
fi
exit 1
[Regression Potential]
* As bcache minor numbers and these symlinks have been unreliable in
the past there may be code that makes assumptions about
/dev/bcache* expanded only to the block devices, versus
/dev/bcache which is a directory.
[Original Description]
Bcache device names like /dev/bcache0 are unstable. Bcache does not use
any predictable ordering when assembling bcache devices, so on systems
with multiple bcache devices, a symlink to /dev/bcache0 may end up
pointing do a different device.
the bcache dname symlink should point to the /dev/bcache/by-uuid/
which matches the backing device UUID that's set at creation time.
Related bugs:
- * bug 1729145: /dev/bcache/by-uuid links not created after reboot
+ * bug 1729145: [kernel] /dev/bcache/by-uuid links not created after reboot
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1728742
Title:
curtin dname for bcache uses unstable devname instead of UUID
To manage notifications about this bug go to:
https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Changed in: bcache-tools (Debian) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Description changed:
[Impact]
- * Current users of bcache devices may encounter unreliable device
-numbering as the Linux kernel does not guarantee that bcache
-minor numbers are assigned to the same devices at each boot.
-Users who may have used /dev/bcacheN in paths to a specific
-device could possible be pointing to a different dataset
-altogether. bcache udev rules do provide some mechanism to
-generate persistent symlinks in /dev/bcache/by-uuid or
-/dev/bcache/by-label which is based on superblock data on
-the underlying device. However, the Linux kernel does not
-always generate an kernel uevent to trigger the udev rules
-to create the symlink.
+ * Current users of bcache devices may encounter unreliable device
+ numbering as the Linux kernel does not guarantee that bcache
+ minor numbers are assigned to the same devices at each boot.
+ Users who may have used /dev/bcacheN in paths to a specific
+ device could possible be pointing to a different dataset
+ altogether. bcache udev rules do provide some mechanism to
+ generate persistent symlinks in /dev/bcache/by-uuid or
+ /dev/bcache/by-label which is based on superblock data on
+ the underlying device. However, the Linux kernel does not
+ always generate an kernel uevent to trigger the udev rules
+ to create the symlink.
- * The fix adds a udev program which will read bcache superblock
-of slave devices and extract the UUID and LABEL, exporting them
-to udev for use in the bcache rule files.
+ * The fix adds a udev program which will read bcache superblock
+ of slave devices and extract the UUID and LABEL, exporting them
+ to udev for use in the bcache rule files.
- * This is affected in upstream bcache-tools, the owning package
-of the udev rules. This affects all releases of bcache-tools
-as the rules rely upon the kernel to trigger these events,
-though that is not a requirement to resolve the lack of
-persistent links.
-
+ * This is affected in upstream bcache-tools, the owning package
+ of the udev rules. This affects all releases of bcache-tools
+ as the rules rely upon the kernel to trigger these events,
+ though that is not a requirement to resolve the lack of
+ persistent links.
+
[Test Case]
- * Launch and Ubuntu Cloud Image with 3 unused disks
-- apt install bcache-tools tree
-- make-bcache -C /dev/vdb
-- make-bcache -B /dev/vdc
-- make-bcache -B /dev/vdd
-- echo "vdc" > /sys/class/block/bcache0/bcache/label
-- echo "vdd" > /sys/class/block/bcache1/bcache/label
-- reboot
+ * Launch and Ubuntu Cloud Image with 3 unused disks
+ - apt install bcache-tools tree
+ - make-bcache -C /dev/vdb
+ - make-bcache -B /dev/vdc
+ - make-bcache -B /dev/vdd
+ - echo "vdc" > /sys/class/block/bcache0/bcache/label
+ - echo "vdd" > /sys/class/block/bcache1/bcache/label
+ - reboot
-- Run this test:
+ - Run this test:
- #!/bin/bash
- FAIL=0
- [ ! -d /dev/bcache ] && {
- echo "FAIL: /dev/bcache is not a directory";
- exit 1
- }
- for label in /dev/bcache/by-label/*; do
- LABEL_TARGET="$(ls -1 /sys/class/block/`basename $label`/holders/)"
- DEVNAME=`readlink -f $label`;
- KNAME="${DEVNAME#*/dev/}"
- if [ "$LABEL_TARGET" != "$KNAME" ]; then
- echo "FAIL: label points to $LABEL_TARGET but symlink points to
$DEVNAME";
- FAIL=1
- fi;
- done
- if [ "$FAIL" == "0" ]; then
- echo "PASS";
- exit 0
- fi
- exit 1
+ #!/bin/bash
+ FAIL=0
+ [ ! -d /dev/bcache ] && {
+ echo "FAIL: /dev/bcache is not a directory";
+ exit 1
+ }
+ for label in /dev/bcache/by-label/*; do
+ LABEL_TARGET="$(ls -1 /sys/class/block/`basename $label`/holders/)"
+ DEVNAME=`readlink -f $label`;
+ KNAME="${DEVNAME#*/dev/}"
+ if [ "$LABEL_TARGET" != "$KNAME" ]; then
+ echo "FAIL: label points to $LABEL_TARGET but symlink points to
$DEVNAME";
+ FAIL=1
+ fi;
+ done
+ if [ "$FAIL" == "0" ]; then
+ echo "PASS";
+ exit 0
+ fi
+ exit 1
-
[Regression Potential]
- * As bcache minor numbers and these symlinks have been unreliable in
-the past there may be code that makes assumptions about
-/dev/bcache* expanded only to the block devices, versus
-/dev/bcache which is a directory.
-
+ * As bcache minor numbers and these symlinks have been unreliable in
+ the past there may be code that makes assumptions about
+ /dev/bcache* expanded only to the block devices, versus
+ /dev/bcache which is a directory.
[Original Description]
Bcache device names like /dev/bcache0 are unstable. Bcache does not use
any predictable ordering when assembling bcache devices, so on systems
with multiple bcache devices, a
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Description changed:
+ [Impact]
+
+ * Current users of bcache devices may encounter unreliable device
+numbering as the Linux kernel does not guarantee that bcache
+minor numbers are assigned to the same devices at each boot.
+Users who may have used /dev/bcacheN in paths to a specific
+device could possible be pointing to a different dataset
+altogether. bcache udev rules do provide some mechanism to
+generate persistent symlinks in /dev/bcache/by-uuid or
+/dev/bcache/by-label which is based on superblock data on
+the underlying device. However, the Linux kernel does not
+always generate an kernel uevent to trigger the udev rules
+to create the symlink.
+
+ * The fix adds a udev program which will read bcache superblock
+of slave devices and extract the UUID and LABEL, exporting them
+to udev for use in the bcache rule files.
+
+ * This is affected in upstream bcache-tools, the owning package
+of the udev rules. This affects all releases of bcache-tools
+as the rules rely upon the kernel to trigger these events,
+though that is not a requirement to resolve the lack of
+persistent links.
+
+ [Test Case]
+
+ * Launch and Ubuntu Cloud Image with 3 unused disks
+- apt install bcache-tools tree
+- make-bcache -C /dev/vdb
+- make-bcache -B /dev/vdc
+- make-bcache -B /dev/vdd
+- echo "vdc" > /sys/class/block/bcache0/bcache/label
+- echo "vdd" > /sys/class/block/bcache1/bcache/label
+- reboot
+
+- Run this test:
+
+ #!/bin/bash
+ FAIL=0
+ [ ! -d /dev/bcache ] && {
+ echo "FAIL: /dev/bcache is not a directory";
+ exit 1
+ }
+ for label in /dev/bcache/by-label/*; do
+ LABEL_TARGET="$(ls -1 /sys/class/block/`basename $label`/holders/)"
+ DEVNAME=`readlink -f $label`;
+ KNAME="${DEVNAME#*/dev/}"
+ if [ "$LABEL_TARGET" != "$KNAME" ]; then
+ echo "FAIL: label points to $LABEL_TARGET but symlink points to
$DEVNAME";
+ FAIL=1
+ fi;
+ done
+ if [ "$FAIL" == "0" ]; then
+ echo "PASS";
+ exit 0
+ fi
+ exit 1
+
+
+ [Regression Potential]
+
+ * As bcache minor numbers and these symlinks have been unreliable in
+the past there may be code that makes assumptions about
+/dev/bcache* expanded only to the block devices, versus
+/dev/bcache which is a directory.
+
+
+ [Original Description]
+
Bcache device names like /dev/bcache0 are unstable. Bcache does not use
any predictable ordering when assembling bcache devices, so on systems
with multiple bcache devices, a symlink to /dev/bcache0 may end up
pointing do a different device.
the bcache dname symlink should point to the /dev/bcache/by-uuid/
which matches the backing device UUID that's set at creation time.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1728742
Title:
curtin dname for bcache uses unstable devname instead of UUID
To manage notifications about this bug go to:
https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Merge proposal linked: https://code.launchpad.net/~raharper/ubuntu/+source/bcache-tools/+git/bcache-tools/+merge/337751 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Changed in: bcache-tools (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Bug watch added: Debian Bug tracker #890446 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890446 ** Also affects: bcache-tools (Debian) via https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890446 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
The attachment "fix_bcache_dname.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1728742] Re: curtin dname for bcache uses unstable devname instead of UUID
** Also affects: bcache-tools (Ubuntu) Importance: Undecided Status: New ** Changed in: bcache-tools (Ubuntu) Status: New => Confirmed ** Changed in: bcache-tools (Ubuntu) Importance: Undecided => Medium ** Changed in: bcache-tools (Ubuntu) Status: Confirmed => In Progress ** Changed in: bcache-tools (Ubuntu) Assignee: (unassigned) => Ryan Harper (raharper) ** Also affects: bcache-tools (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: bcache-tools (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: bcache-tools (Ubuntu Bionic) Importance: Medium Assignee: Ryan Harper (raharper) Status: In Progress ** Also affects: bcache-tools (Ubuntu Artful) Importance: Undecided Status: New ** Changed in: bcache-tools (Ubuntu Trusty) Status: New => Confirmed ** Changed in: bcache-tools (Ubuntu Xenial) Status: New => Confirmed ** Changed in: bcache-tools (Ubuntu Artful) Status: New => Confirmed ** Changed in: bcache-tools (Ubuntu Trusty) Importance: Undecided => Medium ** Changed in: bcache-tools (Ubuntu Xenial) Importance: Undecided => Medium ** Changed in: bcache-tools (Ubuntu Artful) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1728742 Title: curtin dname for bcache uses unstable devname instead of UUID To manage notifications about this bug go to: https://bugs.launchpad.net/bcache-tools/+bug/1728742/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
