[Bug 1736556] Re: mount can exit (success) when it fails

2017-12-05 Thread Scott Moser
blkid output was above. and as I said in my first comment the entry in 
/etc/fstab is wrong.
there is no LABEL=METADATA device.  So 'mount' *should* fail, but I would have 
expected it to exit non-zero.

I noticed just now that '/etc/fstab' has 'nofail' for that line.  I
removed that, and it fails as you show and as expected.   So the issue
here is really just 2 things

a.) the Canonical provided image has a bogus and confusing entry in /etc/fstab
b.) mount really should not exit '0' when explicitly asked to mount something 
even if it has 'nofail'.


heres the info you asked for:


$ mount -l -vvv /var/lib/cloud/seed/config_drive; echo $?
0

$ blkid
/dev/xvda1: LABEL="cloudimg-bootfs" UUID="63ea63a7-f64c-493c-90d4-384adc196be9" 
TYPE="ext3" PARTUUID="3276fc6f-01"
/dev/xvda2: LABEL="cloudimg-rootfs" UUID="82ca1e17-8bc2-4895-96bb-3c39e5863238" 
TYPE="ext4" PARTUUID="3276fc6f-02"
/dev/xvdh: SEC_TYPE="msdos" LABEL="config-2" UUID="9796-932E" TYPE="vfat"
/dev/xvdb1: LABEL="SWAP-xvdb1" UUID="d51fcca0-6b10-4934-a572-f3898dfd8840" 
TYPE="swap" PARTUUID="00025cdb-01"

$ cat /proc/mounts 
sysfs /sys sysfs rw,nosuid,nodev,noexec,relatime 0 0
proc /proc proc rw,nosuid,nodev,noexec,relatime 0 0
udev /dev devtmpfs rw,nosuid,relatime,size=483664k,nr_inodes=120916,mode=755 0 0
devpts /dev/pts devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000 0 0
tmpfs /run tmpfs rw,nosuid,noexec,relatime,size=101204k,mode=755 0 0
/dev/xvda2 / ext4 rw,relatime,data=ordered 0 0
securityfs /sys/kernel/security securityfs rw,nosuid,nodev,noexec,relatime 0 0
tmpfs /dev/shm tmpfs rw,nosuid,nodev 0 0
tmpfs /run/lock tmpfs rw,nosuid,nodev,noexec,relatime,size=5120k 0 0
tmpfs /sys/fs/cgroup tmpfs ro,nosuid,nodev,noexec,mode=755 0 0
cgroup /sys/fs/cgroup/systemd cgroup 
rw,nosuid,nodev,noexec,relatime,xattr,release_agent=/lib/systemd/systemd-cgroups-agent,name=systemd
 0 0
pstore /sys/fs/pstore pstore rw,nosuid,nodev,noexec,relatime 0 0
cgroup /sys/fs/cgroup/blkio cgroup rw,nosuid,nodev,noexec,relatime,blkio 0 0
cgroup /sys/fs/cgroup/cpu,cpuacct cgroup 
rw,nosuid,nodev,noexec,relatime,cpu,cpuacct 0 0
cgroup /sys/fs/cgroup/cpuset cgroup rw,nosuid,nodev,noexec,relatime,cpuset 0 0
cgroup /sys/fs/cgroup/net_cls,net_prio cgroup 
rw,nosuid,nodev,noexec,relatime,net_cls,net_prio 0 0
cgroup /sys/fs/cgroup/perf_event cgroup 
rw,nosuid,nodev,noexec,relatime,perf_event 0 0
cgroup /sys/fs/cgroup/devices cgroup rw,nosuid,nodev,noexec,relatime,devices 0 0
cgroup /sys/fs/cgroup/pids cgroup rw,nosuid,nodev,noexec,relatime,pids 0 0
cgroup /sys/fs/cgroup/memory cgroup rw,nosuid,nodev,noexec,relatime,memory 0 0
cgroup /sys/fs/cgroup/hugetlb cgroup rw,nosuid,nodev,noexec,relatime,hugetlb 0 0
cgroup /sys/fs/cgroup/freezer cgroup rw,nosuid,nodev,noexec,relatime,freezer 0 0
debugfs /sys/kernel/debug debugfs rw,relatime 0 0
systemd-1 /proc/sys/fs/binfmt_misc autofs 
rw,relatime,fd=37,pgrp=1,timeout=0,minproto=5,maxproto=5,direct 0 0
mqueue /dev/mqueue mqueue rw,relatime 0 0
none /proc/xen xenfs rw,relatime 0 0
fusectl /sys/fs/fuse/connections fusectl rw,relatime 0 0
/dev/xvda1 /boot ext3 rw,relatime,data=ordered 0 0
lxcfs /var/lib/lxcfs fuse.lxcfs 
rw,nosuid,nodev,relatime,user_id=0,group_id=0,allow_other 0 0
tmpfs /run/user/0 tmpfs rw,nosuid,nodev,relatime,size=101204k,mode=700 0 0
/dev/xvdh /mnt vfat 
rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=iso8859-1,shortname=mixed,errors=remount-ro
 0 0

$ ls -altr /dev/disk/by-label/
total 0
drwxr-xr-x 4 root root  80 Dec  5 15:39 ..
drwxr-xr-x 2 root root 120 Dec  5 15:39 .
lrwxrwxrwx 1 root root  10 Dec  5 15:39 config-2 -> ../../xvdh
lrwxrwxrwx 1 root root  11 Dec  5 15:39 cloudimg-bootfs -> ../../xvda1
lrwxrwxrwx 1 root root  11 Dec  5 15:39 SWAP-xvdb1 -> ../../xvdb1
lrwxrwxrwx 1 root root  11 Dec  5 15:40 cloudimg-rootfs -> ../../xvda2


** Changed in: util-linux (Ubuntu)
   Status: New => Confirmed

** Changed in: util-linux (Ubuntu)
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1736556

Title:
  mount can exit (success) when it fails

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1736556/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1736556] Re: mount can exit (success) when it fails

2017-12-05 Thread Ryan Harper
Can you attach:

  blkid output
  ls -al /dev/disk/by-label
  /proc/mounts

Testing locally on Xenial, and mount always says something isn't found.

% tail -n1 /etc/fstab 
LABEL=METADATA /mnt   vfatdefaults, 0 0
(foudres) ~ % sudo mount -l - /mnt 
mount: can't find LABEL=METADATA

strace of mount shows it consulting blkid for devices with LABEL

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1736556

Title:
  mount can exit (success) when it fails

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1736556/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1736556] Re: mount can exit (success) when it fails

2017-12-05 Thread Scott Moser
I didn't notice initially but just did.  The entry in /etc/fstab is
bogus, containing a LABEL=METADATA but the disk here is LABEL=config-v2.

That is clearly broken, but 'mount' should not exit success.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1736556

Title:
  mount can exit (success) when it fails

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1736556/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs