[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
** Changed in: cloud-archive/rocky Status: Fix Committed => Fix Released ** Changed in: cloud-archive/stein Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
This bug was fixed in the package nova - 2:19.0.0-0ubuntu2.3 --- nova (2:19.0.0-0ubuntu2.3) disco; urgency=medium * d/p/bug_1825882.patch: Cherry-picked from upstream to ensure virsh disk attach does not fail silently (LP: #1825882). * d/p/bug_1826523.patch: Cherry-picked from upstream to ensure always disconnect volumes after libvirt exceptions (LP: #1826523). nova (2:19.0.0-0ubuntu2.2) disco; urgency=medium * d/p/xenapi-agent-change-openssl-error-handling.patch: Cherry-picked from upstream to ensure xenapi agent only raises a RuntimeError exception when openssl returns a non-zero exit code (LP: #1771506). nova (2:19.0.0-0ubuntu2.1) disco; urgency=medium * d/gbp.conf: Create stable/stein branch. * d/p/eventlet-monkey-patching-should-be-as-early-as-possible.patch: Cherry-picked from upstream stable/stein review to fix py3+wsgi+ssl crash (LP: #1808951). -- Sahid Orentino Ferdjaoui Thu, 16 May 2019 10:54:46 +0200 ** Changed in: nova (Ubuntu Disco) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
** Changed in: cloud-archive/queens Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
Reviewed: https://review.opendev.org/656308 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=5b0adaa0ca5f757bb224d1ffac0c6705b03ee2ed Submitter: Zuul Branch:stable/queens commit 5b0adaa0ca5f757bb224d1ffac0c6705b03ee2ed Author: Corey Bryant Date: Thu Feb 7 10:12:54 2019 -0500 xenapi/agent: Change openssl error handling Prior to this patch, if the openssl command returned a zero exit code and wrote details to stderr, nova would raise a RuntimeError exception. This patch changes the behavior to only raise a RuntimeError exception when openssl returns a non-zero exit code. Regardless of the exit code a warning will always be logged with stderr details if stderr is not None. Note that processutils.execute will now raise a processutils.ProcessExecutionError exception for any non-zero exit code since we are passing check_exit_code=True, which we convert to a Runtime error. Thanks to Dimitri John Ledkov and Eric Fried for helping with this patch. Conflicts: nova/virt/xenapi/agent.py NOTE(coreycb): The conflict is due to Ibe2f478288db42f8168b52dfc14d85ab92ace74b not being in stable/queens. Change-Id: I212ac2b5ccd93e00adb7b9fe102fcb70857c6073 Partial-Bug: #1771506 (cherry picked from commit 1da71fa4ab1d7d0f580cd5cbc97f2dfd2e1c378a) (cherry picked from commit 64793cf6f77c5ba7c9ea51662d936c7545ffce8c) (cherry picked from commit 82de38ad4ce86c5398538a8635713a86407216d0) ** Tags added: in-stable-queens -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
This bug was fixed in the package nova - 2:17.0.9-0ubuntu3 --- nova (2:17.0.9-0ubuntu3) bionic; urgency=medium * d/p/bug_1825882.patch: Cherry-picked from upstream to ensure virsh disk attach does not fail silently (LP: #1825882). * d/p/bug_1826523.patch: Cherry-picked from upstream to ensure always disconnect volumes after libvirt exceptions (LP: #1826523). nova (2:17.0.9-0ubuntu2) bionic; urgency=medium * d/p/xenapi-agent-change-openssl-error-handling.patch: Cherry-picked from upstream to ensure xenapi agent only raises a RuntimeError exception when openssl returns a non-zero exit code (LP: #1771506). * d/p/skip-double-word-hacking-test.patch: Cherry-picked from upstream to work-around test_hacking failures with new versions of python (LP: #1782786). -- Sahid Orentino Ferdjaoui Thu, 16 May 2019 11:06:11 +0200 ** Changed in: nova (Ubuntu Bionic) Status: Fix Committed => Fix Released ** Changed in: nova (Ubuntu Cosmic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
This bug was fixed in the package nova - 2:18.1.0-0ubuntu3 --- nova (2:18.1.0-0ubuntu3) cosmic; urgency=medium * d/p/bug_1825882.patch: Cherry-picked from upstream to ensure virsh disk attach does not fail silently (LP: #1825882). * d/p/bug_1826523.patch: Cherry-picked from upstream to ensure always disconnect volumes after libvirt exceptions (LP: #1826523). nova (2:18.1.0-0ubuntu2) cosmic; urgency=medium * d/p/xenapi-agent-change-openssl-error-handling.patch: Cherry-picked from upstream to ensure xenapi agent only raises a RuntimeError exception when openssl returns a non-zero exit code (LP: #1771506). -- Sahid Orentino Ferdjaoui Thu, 16 May 2019 10:58:45 +0200 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
Reviewed: https://review.opendev.org/656304 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=64793cf6f77c5ba7c9ea51662d936c7545ffce8c Submitter: Zuul Branch:stable/stein commit 64793cf6f77c5ba7c9ea51662d936c7545ffce8c Author: Corey Bryant Date: Thu Feb 7 10:12:54 2019 -0500 xenapi/agent: Change openssl error handling Prior to this patch, if the openssl command returned a zero exit code and wrote details to stderr, nova would raise a RuntimeError exception. This patch changes the behavior to only raise a RuntimeError exception when openssl returns a non-zero exit code. Regardless of the exit code a warning will always be logged with stderr details if stderr is not None. Note that processutils.execute will now raise a processutils.ProcessExecutionError exception for any non-zero exit code since we are passing check_exit_code=True, which we convert to a Runtime error. Thanks to Dimitri John Ledkov and Eric Fried for helping with this patch. Change-Id: I212ac2b5ccd93e00adb7b9fe102fcb70857c6073 Partial-Bug: #1771506 (cherry picked from commit 1da71fa4ab1d7d0f580cd5cbc97f2dfd2e1c378a) ** Tags added: in-stable-stein -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
Reviewed: https://review.opendev.org/656307 Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8241b47967adb792a4254eeb58fda1fc55edf314 Submitter: Zuul Branch:stable/rocky commit 8241b47967adb792a4254eeb58fda1fc55edf314 Author: Corey Bryant Date: Thu Feb 7 10:12:54 2019 -0500 xenapi/agent: Change openssl error handling Prior to this patch, if the openssl command returned a zero exit code and wrote details to stderr, nova would raise a RuntimeError exception. This patch changes the behavior to only raise a RuntimeError exception when openssl returns a non-zero exit code. Regardless of the exit code a warning will always be logged with stderr details if stderr is not None. Note that processutils.execute will now raise a processutils.ProcessExecutionError exception for any non-zero exit code since we are passing check_exit_code=True, which we convert to a Runtime error. Thanks to Dimitri John Ledkov and Eric Fried for helping with this patch. Conflicts: nova/virt/xenapi/agent.py NOTE(coreycb): The conflict is due to Ibe2f478288db42f8168b52dfc14d85ab92ace74b not being in stable/rocky. Change-Id: I212ac2b5ccd93e00adb7b9fe102fcb70857c6073 Partial-Bug: #1771506 (cherry picked from commit 1da71fa4ab1d7d0f580cd5cbc97f2dfd2e1c378a) (cherry picked from commit 64793cf6f77c5ba7c9ea51662d936c7545ffce8c) ** Tags added: in-stable-rocky -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
This has also built successfully in the queens cloud archive. ** Tags removed: verification-queens-needed ** Tags added: verification-queens-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
@Dimitri, thanks very much. I've pushed changes to cosmic and disco branches to drop the skip-openssl-1.1.1-tests.patch patch and have built them successfully (locally) for disco, cosmic, bionic-stein, and bionic- rocky. I'm going to hold off on uploads just for that change as nova has a lot of churn and they'll get picked up on the next SRU. ** Tags removed: verification-rocky-needed verification-stein-needed ** Tags added: verification-rocky-done verification-stein-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
Bionic is great, previously it would fail nova.tests.unit.virt.xenapi.test_xenapi.XenAPIDiffieHellmanTestCase tests but now they pass. Cosmic/Disco/Eoan are also correctly fixed at runtime, however the unittests that exercise this runtime issue are force skipped since the skip-openssl-1.1.1-tests.patch is still applied. We should drop skip- openssl-1.1.1-tests.patch from Cosmic/Disco/Eoan in the subsequent uploads. I've now uploaded dropping skip-openssl-1.1.1-tests.patch into Eoan. Pass (with nitpicks on cosmic/disco). ** Tags removed: verification-needed verification-needed-bionic verification-needed-cosmic verification-needed-disco ** Tags added: verification-done verification-done-bionic verification-done-cosmic verification-done-disco -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
Hello Thomas, or anyone else affected, Accepted nova into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nova/2:19.0.0-0ubuntu2.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: nova (Ubuntu Disco) Status: Triaged => Fix Committed ** Tags added: verification-needed verification-needed-disco ** Changed in: nova (Ubuntu Cosmic) Status: Triaged => Fix Committed ** Tags added: verification-needed-cosmic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
New versions of nova with this fix have been uploaded to eoan, disco, cosmic, and bionic. Stable release uploads are awaiting review from the SRU team [1]. [1] https://launchpad.net/ubuntu/disco/+queue?queue_state=1&queue_text=nova https://launchpad.net/ubuntu/cosmic/+queue?queue_state=1&queue_text=nova https://launchpad.net/ubuntu/bionic/+queue?queue_state=1&queue_text=nova -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
This bug was fixed in the package nova - 2:19.0.0-0ubuntu4 --- nova (2:19.0.0-0ubuntu4) eoan; urgency=medium * d/p/xenapi-agent-change-openssl-error-handling.patch: Cherry-picked from upstream to ensure xenapi agent only raises a RuntimeError exception when openssl returns a non-zero exit code (LP: #1771506). -- Corey Bryant Wed, 01 May 2019 17:10:47 -0400 ** Changed in: nova (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
@xnox, thanks for the patch. I've submitted it to the upstream master branch. Once that lands I'll start backporting to stable branches and Ubuntu. ** Also affects: nova (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: nova (Ubuntu Disco) Importance: Undecided Status: New ** Also affects: nova (Ubuntu Cosmic) Importance: Undecided Status: New ** Changed in: nova (Ubuntu Bionic) Status: New => Triaged ** Changed in: nova (Ubuntu Bionic) Importance: Undecided => High ** Changed in: nova (Ubuntu Cosmic) Importance: Undecided => High ** Changed in: nova (Ubuntu Cosmic) Status: New => Triaged ** Changed in: nova (Ubuntu Disco) Importance: Undecided => High ** Changed in: nova (Ubuntu Disco) Status: New => Triaged ** Also affects: cloud-archive Importance: Undecided Status: New ** Also affects: cloud-archive/queens Importance: Undecided Status: New ** Also affects: cloud-archive/stein Importance: Undecided Status: New ** Also affects: cloud-archive/rocky Importance: Undecided Status: New ** Changed in: cloud-archive/queens Status: New => Triaged ** Changed in: cloud-archive/stein Status: New => Triaged ** Changed in: cloud-archive/queens Importance: Undecided => High ** Changed in: cloud-archive/rocky Status: New => Triaged ** Changed in: cloud-archive/stein Importance: Undecided => High ** Changed in: cloud-archive/rocky Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
** Also affects: nova (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1771506] Re: Unit test failure with OpenSSL 1.1.1
Fix proposed to branch: master Review: https://review.openstack.org/635533 ** Changed in: nova Status: Confirmed => In Progress ** Changed in: nova Assignee: (unassigned) => Corey Bryant (corey.bryant) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1771506 Title: Unit test failure with OpenSSL 1.1.1 To manage notifications about this bug go to: https://bugs.launchpad.net/cloud-archive/+bug/1771506/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
