[Bug 1786397] Re: 2ping crashes on non-encrypted session
This bug was fixed in the package 2ping - 4.1-1ubuntu1 --- 2ping (4.1-1ubuntu1) bionic; urgency=medium * SRU: Fix cleanup crash on non-encrypted sessions (LP: #1786397) -- Ryan Finnie Fri, 10 Aug 2018 04:31:04 + ** Changed in: 2ping (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786397 Title: 2ping crashes on non-encrypted session To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786397] Re: 2ping crashes on non-encrypted session
** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786397 Title: 2ping crashes on non-encrypted session To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786397] Re: 2ping crashes on non-encrypted session
Tested 4.1-1ubuntu1 from bionic-proposed which fixes the issue correctly. No regressions observed. ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786397 Title: 2ping crashes on non-encrypted session To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786397] Re: 2ping crashes on non-encrypted session
Hello Ryan, or anyone else affected, Accepted 2ping into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/2ping/4.1-1ubuntu1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: 2ping (Ubuntu Bionic) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-bionic ** Changed in: 2ping (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786397 Title: 2ping crashes on non-encrypted session To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786397] Re: 2ping crashes on non-encrypted session
Sponsorship isn't needed; upload is waiting for bionic-proposed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786397 Title: 2ping crashes on non-encrypted session To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786397] Re: 2ping crashes on non-encrypted session
The attachment "Fix cleanup crash on non-encrypted sessions" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786397 Title: 2ping crashes on non-encrypted session To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786397] Re: 2ping crashes on non-encrypted session
** Changed in: 2ping (Ubuntu) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786397 Title: 2ping crashes on non-encrypted session To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786397] Re: 2ping crashes on non-encrypted session
[ubuntu/bionic-proposed] 2ping 4.1-1ubuntu1 (Waiting for approval) > Redirecting ubuntu bionic to ubuntu bionic-proposed. > This upload awaits approval by a distro manager ** Changed in: 2ping (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786397 Title: 2ping crashes on non-encrypted session To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1786397] Re: 2ping crashes on non-encrypted session
** Description changed: - Originally reported by Github user - joe1981alAPR (https://github.com/rfinnie/2ping/issues/5). + [Impact] - Fixed in commit 4a636763850bcea590fba6066751d13a36c2b28d + * When 2ping is being run as a non-encrypted session between two + affected 4.1 releases, within a few minutes the client and/or server + will crash with "TypeError: 'NoneType' object is not subscriptable" in + scheduled_cleanup_sock_class. + + * Clients cannot sustain a 2ping session for more than a few minutes. + + * When configured as a daemon without respawn, this results in a denial + of service. (Not default in bionic.) + + * SRU fix adds a type check for the encrypted_sessions peer table, + which is not initialized if no encrypted packets have been received. + + * Fixed in commit 4a636763850bcea590fba6066751d13a36c2b28d (https://github.com/rfinnie/2ping/commit/4a636763850bcea590fba6066751d13a36c2b28d) and included in upstream version 4.1.2. - SRU for bionic to be filed once it reaches cosmic. + [Test Case] + + * In one windows, run `2ping --listen` + + * In another, run `2ping 127.0.0.1` + + * Wait up to 5 minutes for TypeError. + + [Regression Potential] + + * SRU might not fix issue. + + * SRU fix might break scheduled cleanup of sessions when encryption + *is* activated, leading to resource exhaustion. + + * SRU fix might break scheduled cleanup of other data unrelated to + encryption. + + * Patch author has tested these scenarios and cannot reproduce any of + them. + + [Other Info] + + * Originally reported by Github user joe1981alAPR (https://github.com/rfinnie/2ping/issues/5). ** Patch added: "Fix cleanup crash on non-encrypted sessions" https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+attachment/5173866/+files/lp1786397.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1786397 Title: 2ping crashes on non-encrypted session To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/2ping/+bug/1786397/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
