[Bug 1786432] Re: Collect DCD file

2018-09-06 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-report - 1.3.0~18.04

---
ubuntu-report (1.3.0~18.04) bionic; urgency=medium

  * Include optional DCD OEM file (LP: #1786432)
  * Collect number of disks and their sizes (LP: #1784383)
  * Misc grammar updates, thanks Robin Hood

 -- Didier Roche   Thu, 30 Aug 2018 14:04:13 +0200

** Changed in: ubuntu-report (Ubuntu Bionic)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-31 Thread Jean-Baptiste Lallement
SRU verification for Bionic:
I have verified that the version of ubuntu-report 1.3.0~18.04 in -proposed 
fixes the issue. Note that if the tracking id contains whitespaces it is 
considered invalid and the field is not present in the report but I think 
that's ok.

Marking as verification-done

** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-30 Thread Brian Murray
Hello Jean-Baptiste, or anyone else affected,

Accepted ubuntu-report into bionic-proposed. The package will build now
and be available at https://launchpad.net/ubuntu/+source/ubuntu-
report/1.3.0~18.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: ubuntu-report (Ubuntu Bionic)
   Status: Triaged => Fix Committed

** Tags added: verification-needed verification-needed-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-30 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-report - 1.3.0

---
ubuntu-report (1.3.0) cosmic; urgency=medium

  * Include optional DCD OEM file (LP: #1786432)
  * Collect number of disks and their sizes (LP: #1784383)
  * Misc grammar updates, thanks Robin Hood

 -- Didier Roche   Thu, 30 Aug 2018 10:05:54 +0200

** Changed in: ubuntu-report (Ubuntu)
   Status: Triaged => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-30 Thread Didier Roche
** Description changed:

+ [Impact] 
+  * OEM images provided by Canonical and other companies use a tracking id 
called Distribution Channel Descriptor (DCD). There is interest of reporting 
this as part of ubuntu-report one.
+ 
+ [Test Case]
+  * Install the new version from -proposed
+  * run `ubuntu-report show`
+-> check there are no DCD field in OEM on the outputed json
+  * Ship a valid DCD file as /var/lib/ubuntu_dist_channel (see below for one)
+  * run `ubuntu-report show`
+-> check that DCD field is part of the OEM stenza, and corresponds to the 
non commented full line string in /var/lib/ubuntu_dist_channel.
+ 
+ 
+ [Regression Potential] 
+  * The only impact is for OEM shipping a DCD file. The field is ommitted if 
empty and have the same logic than other fields (not failing if any bug in that 
code path appears)
+  * Backed up via a lot of new and existing tests, checking corner cases like 
no valid file, empty file, no file, file with only commented, file with extra 
\n…
+ 
+ 
+ 
  OEM use a tracking id called Distribution Channel Descriptor (DCD)
  located in .disk/ubuntu_dist_channel and installed by Ubiquity to
  /var/lib/ubuntu_dist_channel
  
  When this information exists ubuntu-report must collect the tracking id.
  The proposal is to store it in the OEM key:
  
  [...]
  "OEM": {
  "Vendor": "Vendor Name",
  "Product": "4287CTO",
  "DCD": "
    }
  [...]
  
  An example of content of a DCD file is:
  "
  # This is a distribution channel descriptor
  # For more information see 
http://wiki.ubuntu.com/DistributionChannelDescriptor
  canonical-oem-somerville-xenial-amd64-20160624-2
  "
  
  [1] https://wiki.ubuntu.com/FoundationsTeam/Specs/OemTrackingId
  
  ProblemType: Bug
  DistroRelease: Ubuntu 18.10
  Package: ubuntu-report 1.2.0
  ProcVersionSignature: Ubuntu 4.17.0-6.7-generic 4.17.9
  Uname: Linux 4.17.0-6-generic x86_64
  ApportVersion: 2.20.10-0ubuntu7
  Architecture: amd64
  CurrentDesktop: ubuntu:GNOME
  Date: Fri Aug 10 10:23:04 2018
  Dependencies:
   gcc-8-base 8.2.0-1ubuntu2
   libc6 2.27-3ubuntu1
   libgcc1 1:8.2.0-1ubuntu2
  InstallationDate: Installed on 2014-07-15 (1487 days ago)
  InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
  SourcePackage: ubuntu-report
  UpgradeStatus: Upgraded to cosmic on 2018-03-24 (138 days ago)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-30 Thread Didier Roche
** Also affects: ubuntu-report (Ubuntu Bionic)
   Importance: Undecided
   Status: New

** Changed in: ubuntu-report (Ubuntu Bionic)
   Status: New => Triaged

** Changed in: ubuntu-report (Ubuntu Bionic)
 Assignee: (unassigned) => Didier Roche (didrocks)

** Changed in: ubuntu-report (Ubuntu)
 Assignee: (unassigned) => Didier Roche (didrocks)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-28 Thread Didier Roche
** Changed in: ubuntu-report (Ubuntu)
   Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-28 Thread Didier Roche
Sorry for being unclear, the "no need to SRU that" was intended for the
optional ubiquity removal.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-28 Thread Jean-Baptiste Lallement
We need to SRU that to bionic.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-28 Thread Jean-Baptiste Lallement
I'm not sure all the OEM use the DCD file. We can keep the OEM
true/false as it is an installation mode that can be used by anyone
without remastering the entire image.

** Description changed:

  OEM use a tracking id called Distribution Channel Descriptor (DCD)
  located in .disk/ubuntu_dist_channel and installed by Ubiquity to
  /var/lib/ubuntu_dist_channel
  
  When this information exists ubuntu-report must collect the tracking id.
  The proposal is to store it in the OEM key:
  
  [...]
  "OEM": {
- "Vendor": "Vendor Name",
- "Product": "4287CTO",
- "DCD": "
-   }
+ "Vendor": "Vendor Name",
+ "Product": "4287CTO",
+ "DCD": "
+   }
  [...]
+ 
+ An example of content of a DCD file is:
+ "
+ # This is a distribution channel descriptor
+ # For more information see 
http://wiki.ubuntu.com/DistributionChannelDescriptor
+  canonical-oem-somerville-xenial-amd64-20160624-2
+ "
  
  
  [1] https://wiki.ubuntu.com/FoundationsTeam/Specs/OemTrackingId
  
  ProblemType: Bug
  DistroRelease: Ubuntu 18.10
  Package: ubuntu-report 1.2.0
  ProcVersionSignature: Ubuntu 4.17.0-6.7-generic 4.17.9
  Uname: Linux 4.17.0-6-generic x86_64
  ApportVersion: 2.20.10-0ubuntu7
  Architecture: amd64
  CurrentDesktop: ubuntu:GNOME
  Date: Fri Aug 10 10:23:04 2018
  Dependencies:
-  gcc-8-base 8.2.0-1ubuntu2
-  libc6 2.27-3ubuntu1
-  libgcc1 1:8.2.0-1ubuntu2
+  gcc-8-base 8.2.0-1ubuntu2
+  libc6 2.27-3ubuntu1
+  libgcc1 1:8.2.0-1ubuntu2
  InstallationDate: Installed on 2014-07-15 (1487 days ago)
  InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
  SourcePackage: ubuntu-report
  UpgradeStatus: Upgraded to cosmic on 2018-03-24 (138 days ago)

** Description changed:

  OEM use a tracking id called Distribution Channel Descriptor (DCD)
  located in .disk/ubuntu_dist_channel and installed by Ubiquity to
  /var/lib/ubuntu_dist_channel
  
  When this information exists ubuntu-report must collect the tracking id.
  The proposal is to store it in the OEM key:
  
  [...]
  "OEM": {
  "Vendor": "Vendor Name",
  "Product": "4287CTO",
  "DCD": "
    }
  [...]
  
  An example of content of a DCD file is:
  "
  # This is a distribution channel descriptor
  # For more information see 
http://wiki.ubuntu.com/DistributionChannelDescriptor
-  canonical-oem-somerville-xenial-amd64-20160624-2
+ canonical-oem-somerville-xenial-amd64-20160624-2
  "
- 
  
  [1] https://wiki.ubuntu.com/FoundationsTeam/Specs/OemTrackingId
  
  ProblemType: Bug
  DistroRelease: Ubuntu 18.10
  Package: ubuntu-report 1.2.0
  ProcVersionSignature: Ubuntu 4.17.0-6.7-generic 4.17.9
  Uname: Linux 4.17.0-6-generic x86_64
  ApportVersion: 2.20.10-0ubuntu7
  Architecture: amd64
  CurrentDesktop: ubuntu:GNOME
  Date: Fri Aug 10 10:23:04 2018
  Dependencies:
   gcc-8-base 8.2.0-1ubuntu2
   libc6 2.27-3ubuntu1
   libgcc1 1:8.2.0-1ubuntu2
  InstallationDate: Installed on 2014-07-15 (1487 days ago)
  InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140520)
  SourcePackage: ubuntu-report
  UpgradeStatus: Upgraded to cosmic on 2018-03-24 (138 days ago)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1786432] Re: Collect DCD file

2018-08-28 Thread Didier Roche
I just have one question: do we keep the OEM field in ubiquity (the
boolean true/false?). I think once we get DCD, this is of less value.

No need to SRU that, but maybe for bionic, WDYT?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1786432

Title:
  Collect DCD file

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-report/+bug/1786432/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs