[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
I found the problem yesterday. The regression is that the gradient (which didn't appear at all before) now only occupies the middle 50% of the screen. This means it looks squashed and different to the login screen. The top and bottom 25% of the screen are solid colours. It looks like a problem with texture coordinates and GL clamp-to-edge, since the gradient is really only a 1x2 two pixel texture rendered with linear filtering. ** Tags added: regression-release ** Summary changed: - Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced + The wrong background flashes up briefly during the login animation since Yaru was introduced ** Description changed: [Impact] - Dark purple (noise) background flashes up briefly (for a split second) during the login animation. + The wrong background flashes up briefly (for a split second) during the login animation. The login screen and gnome-shell's system background are meant to be the same image so that the login procedure can VT switch without the user noticing. Then the final desktop expands over the system background. However it appears the login background and system background are not the same image any more, causing a visible glitch during login. [Test Case] 1. Install new version, logout 2. Log in into GDM -> Check that at login startup, the background matches GDM ones (same color, same gradient) 3. Logout, install gnome-session 4. Reboot so that GDM takes gnome-session into account 5. Select GNOME session and login -> At login startup, the background will matche the GNOME default one (from the lockscreen: grey noise), which matches GDM one if reset to default GNOME via update-alternatives. [Regression Potential] This code is loaded at session startup, if there is a syntax error, the session wouldn't start at all. This has been of course tested before committed (both on ubuntu and GNOME sessions) ProblemType: Bug DistroRelease: Ubuntu 18.10 Package: yaru-theme-gnome-shell 18.10.2 ProcVersionSignature: Ubuntu 4.17.0-7.8-generic 4.17.12 Uname: Linux 4.17.0-7-generic x86_64 ApportVersion: 2.20.10-0ubuntu9 Architecture: amd64 Date: Tue Aug 28 14:19:48 2018 Dependencies: InstallationDate: Installed on 2018-05-26 (93 days ago) InstallationMedia: Ubuntu 18.10 "Cosmic Cuttlefish" - Alpha amd64 (20180525) PackageArchitecture: all ProcEnviron: TERM=xterm-256color PATH=(custom, no user) XDG_RUNTIME_DIR= LANG=en_AU.UTF-8 SHELL=/bin/bash SourcePackage: yaru-theme UpgradeStatus: No upgrade log present (probably fresh install) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: The wrong background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
** Changed in: gnome-shell (Ubuntu Cosmic) Status: Fix Committed => In Progress ** Changed in: gnome-shell (Ubuntu) Assignee: Didier Roche (didrocks) => Daniel van Vugt (vanvugt) ** Changed in: gnome-shell (Ubuntu) Status: Fix Released => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
I was wrong. I can see the same bug in git builds. It's just not obvious when you're not coming from the login screen. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
Thanks. I have confirmed on a third cosmic machine the same bug in 3.30.1-2ubuntu1.18.10.1 :( However, when I apply the above patch to gnome-shell git (either master or gnome-3-30 branches), there is no bug at all. The patch works fine in my own local builds from git. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
** Changed in: gnome-shell (Ubuntu Cosmic) Assignee: (unassigned) => Daniel van Vugt (vanvugt) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
I don't have the time to do a testround again, but I can give pointers
for whoever has time to have a look:
The patch is
https://git.launchpad.net/~ubuntu-desktop/ubuntu/+source/gnome-shell/commit/?id=ddc4f511abd64d69c1150a41475d0a1ebac01dbb,
in particular:
systemBackground = new Meta.Background({ meta_display: global.display });
[res, topColor] = Clutter.Color.from_string('#6D2169');
[res, bottomColor] = Clutter.Color.from_string('#370026');
systemBackground.set_gradient(GDesktopEnums.BackgroundShading.VERTICAL,
topColor, bottomColor);
This is hardcoded in the Shell code (I made it conditional by session
type). This was made to match what is in the Yaru.css file:
#lockDialogGroup {
background: none;
background-color: none;
background-gradient-direction: vertical;
background-gradient-start: #6D2169;
background-gradient-end: #370026; }
As I don't have bionic/cosmic eyes as yours, for me, for the short while
this screen appeared, ti seemed the same gradient, with the same
VERTICAL transition.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1789356
Title:
Dark purple (noise) background flashes up briefly during the login
animation since Yaru was introduced
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
It does make this bug worse. The original bug was barely noticeable, but with that fix it's really a bright and obvious glitch. What we could do is release the SRU but just keep this bug open. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
Daniel, ok you consider the fix here as problematic. Do we believe it's worth unvalidating the SRU over it though? We have enough difficulties landing gnome-shell SRUs fixing at the moment and the touch event one included in the same update is important to oem. If the background change is not perfect but not worth than we had perhaps we can mark it verified, get that SRU in on the principle that it's not really making things worth and have another go later at fixing it more correctly? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
Yes, I have now tested the proposed fix on two separate fresh installations of cosmic. One HP and one Lenovo laptop. In both cases they show a weird multi-stop gradient after the fix is installed. Looks like the colour goes up-down-up-down instead of just down. ** Changed in: gnome-shell (Ubuntu Cosmic) Assignee: Daniel van Vugt (vanvugt) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
Are you sure it's differently? Look at the diff, it's supposively exactly the same values than Yaru. Please check it and revert the status as needed. ** Changed in: gnome-shell (Ubuntu Cosmic) Assignee: Didier Roche (didrocks) => Daniel van Vugt (vanvugt) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
The proposed fix 3.30.1-2ubuntu1.18.10.1 certainly changes things, but is equally broken as the original bug. Using the proposed fix a weird gradient flashes up briefly that doesn't match the login screen background and is more visually distracting than the original bug. ** Tags removed: verification-needed verification-needed-cosmic ** Tags added: verification-failed verification-failed-cosmic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1789356] Re: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced
** Summary changed: - Dark purple (noise) background flashes up briefly during the login animation + Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1789356 Title: Dark purple (noise) background flashes up briefly during the login animation since Yaru was introduced To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1789356/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
