[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
This bug was fixed in the package librabbitmq - 0.7.1-1ubuntu0.1 --- librabbitmq (0.7.1-1ubuntu0.1) xenial; urgency=medium * d/patches: Add fix-parameter-processing.patch to correct handling of --server, --url, and other options by reorganizing the logic flow. (LP: #1790657) -- Bryce Harrington Mon, 08 Jul 2019 20:19:04 -0700 ** Changed in: librabbitmq (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
This bug was fixed in the package librabbitmq - 0.8.0-1ubuntu0.18.04.1 --- librabbitmq (0.8.0-1ubuntu0.18.04.1) bionic; urgency=medium * d/patches: Add fix-parameter-processing.patch to correct handling of --server, --url, and other options by reorganizing the logic flow. (LP: #1790657) -- Bryce Harrington Tue, 09 Jul 2019 21:19:59 -0700 ** Changed in: librabbitmq (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
$ lxc launch ubuntu:bionic/amd64 librabbitmq-sru-1790657-bionic Creating librabbitmq-sru-1790657-bionic Starting librabbitmq-sru-1790657-bionic $ lxc exec librabbitmq-sru-1790657-bionic -- bash (...) # echo "deb http://archive.ubuntu.com/ubuntu/ bionic-proposed main universe" >> /etc/apt/sources.list # apt-get update && apt-get dist-upgrade # apt-cache policy librabbitmq-dev | grep Installed Installed: 0.8.0-1ubuntu0.18.04.1 # sudo amqp-consume --server=foobar:5672 -q queue cat Specifying the port number with --server is deprecated opening socket to foobar:5672 Correct behavior on bionic after update. ** Tags removed: verification-needed verification-needed-bionic ** Tags added: verification-done verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
Xenial verification: $ lxc launch ubuntu:xenial/amd64 librabbitmq-sru-1790657-xenial Creating librabbitmq-sru-1790657-xenial Starting librabbitmq-sru-1790657-xenial $ lxc exec librabbitmq-sru-1790657-xenial -- bash (...) # echo "deb http://archive.ubuntu.com/ubuntu/ xenial-proposed main universe" >> /etc/apt/sources.list # apt-get update && apt-get dist-upgrade # apt-cache policy librabbitmq-dev | grep Installed Installed: 0.7.1-1ubuntu0.1 # sudo amqp-consume --server=foobar:5672 -q queue cat Specifying the port number with --server is deprecated opening socket to foobar:5672 Correct behavior after update. ** Tags removed: verification-needed-xenial ** Tags added: verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
I'm gathering that the cosmic upload won't be getting accepted due to Cosmic reaching EOL. ** Changed in: librabbitmq (Ubuntu Cosmic) Status: In Progress => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
Hello Max, or anyone else affected, Accepted librabbitmq into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/librabbitmq/0.8.0-1ubuntu0.18.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: librabbitmq (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-bionic ** Changed in: librabbitmq (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
MPs look good, one minor cleanup on the new version numbers. I think you can go on pushing this to -unapproved then. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
Merge proposals for xenial/bionic/cosmic uploads: - xenial: https://code.launchpad.net/~bryce/ubuntu/+source/librabbitmq/+git/librabbitmq/+merge/370166 - bionic: https://code.launchpad.net/~bryce/ubuntu/+source/librabbitmq/+git/librabbitmq/+merge/370168 - cosmic: https://code.launchpad.net/~bryce/ubuntu/+source/librabbitmq/+git/librabbitmq/+merge/370167 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Merge proposal linked: https://code.launchpad.net/~bryce/ubuntu/+source/librabbitmq/+git/librabbitmq/+merge/370166 ** Merge proposal linked: https://code.launchpad.net/~bryce/ubuntu/+source/librabbitmq/+git/librabbitmq/+merge/370167 ** Merge proposal linked: https://code.launchpad.net/~bryce/ubuntu/+source/librabbitmq/+git/librabbitmq/+merge/370168 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Description changed: [Impact] The --server and -url parameters do not function as documented, due to an upstream coding error that was fixed in release 0.8.1. [Test Case] $ sudo apt-get -y install librabbitmq-dev $ sudo apt-get -y install amqp-tools ### Broken behavior: $ sudo amqp-consume --server=foobar:5672 -q queue cat both --server and --url options specify server host ### Fixed behavior: + $ sudo apt-add-repository -y ppa:bryce/librabbitmq-sru-1790657 + $ sudo apt-get -y install librabbitmq-dev $ sudo amqp-consume --server=foobar:5672 -q queue cat - TBD + Specifying the port number with --server is deprecated + opening socket to foobar:5672 [Regression Potential] The patch alters C code to change how command line options are processed. Things to watch for, then, would be mishandling of cli options, or compilation errors during package build. The changes do not alter input handling at all, so static testing should give a high degree of confidence of stability. Also, the alterations are focused on tools, so general operation of librabbitmq should not be affected in any way by the changes. [Fix] The upstream patch corrects handling of --server, --url, and other options by reorganizing the logic flow. [Discussion] The issue appears not to be a regression from a recent change, but a problem that has existed for quite a while: librabbitmq | 0.0.1.hg216-1 | precise/universe | source librabbitmq | 0.4.1-1 | trusty | source librabbitmq | 0.7.1-1 | xenial/universe | source librabbitmq | 0.8.0-1build1 | bionic/universe | source librabbitmq | 0.8.0-1build1 | cosmic/universe | source librabbitmq | 0.9.0-0.2 | disco| source librabbitmq | 0.9.0-0.2 | eoan | source The fix should be backported to bionic and probably cosmic. Earlier releases are probably also affected but probably only worth doing if the patch applies cleanly to them. [Original Report] The version of amqp-tools in 18.04.1 LTS (and 14.04 iirc) has a bug which renders parts of the cli unusable: https://github.com/alanxz/rabbitmq-c/issues/364 1) 18.04.1 LTS bionic 2) 0.8.0-1build1 3) `amqp-consume --server=foobar:5672 -q queue cat` should work 4) amqp-consume complains that you cannot use --server and --url together -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Changed in: librabbitmq (Ubuntu Xenial) Status: New => In Progress ** Changed in: librabbitmq (Ubuntu Xenial) Assignee: (unassigned) => Bryce Harrington (bryce) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Description changed: [Impact] The --server and -url parameters do not function as documented, due to an upstream coding error that was fixed in release 0.8.1. [Test Case] + $ sudo apt-get -y install librabbitmq-dev + $ sudo apt-get -y install amqp-tools + + ### Broken behavior: + $ sudo amqp-consume --server=foobar:5672 -q queue cat + both --server and --url options specify server host + + ### Fixed behavior: + $ sudo amqp-consume --server=foobar:5672 -q queue cat TBD [Regression Potential] + The patch alters C code to change how command line options are processed. Things to watch for, then, would be mishandling of cli options, or compilation errors during package build. The changes do not alter input handling at all, so static testing should give a high degree of confidence of stability. Also, the alterations are focused on tools, so general operation of librabbitmq should not be affected in any way by the changes. [Fix] The upstream patch corrects handling of --server, --url, and other options by reorganizing the logic flow. [Discussion] The issue appears not to be a regression from a recent change, but a problem that has existed for quite a while: - librabbitmq | 0.0.1.hg216-1 | precise/universe | source - librabbitmq | 0.4.1-1 | trusty | source - librabbitmq | 0.7.1-1 | xenial/universe | source - librabbitmq | 0.8.0-1build1 | bionic/universe | source - librabbitmq | 0.8.0-1build1 | cosmic/universe | source - librabbitmq | 0.9.0-0.2 | disco| source - librabbitmq | 0.9.0-0.2 | eoan | source + librabbitmq | 0.0.1.hg216-1 | precise/universe | source + librabbitmq | 0.4.1-1 | trusty | source + librabbitmq | 0.7.1-1 | xenial/universe | source + librabbitmq | 0.8.0-1build1 | bionic/universe | source + librabbitmq | 0.8.0-1build1 | cosmic/universe | source + librabbitmq | 0.9.0-0.2 | disco| source + librabbitmq | 0.9.0-0.2 | eoan | source The fix should be backported to bionic and probably cosmic. Earlier releases are probably also affected but probably only worth doing if the patch applies cleanly to them. [Original Report] The version of amqp-tools in 18.04.1 LTS (and 14.04 iirc) has a bug which renders parts of the cli unusable: https://github.com/alanxz/rabbitmq-c/issues/364 1) 18.04.1 LTS bionic 2) 0.8.0-1build1 3) `amqp-consume --server=foobar:5672 -q queue cat` should work 4) amqp-consume complains that you cannot use --server and --url together ** Changed in: librabbitmq (Ubuntu Cosmic) Status: Triaged => In Progress ** Changed in: librabbitmq (Ubuntu Bionic) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Also affects: librabbitmq (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: librabbitmq (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: librabbitmq (Ubuntu Disco) Importance: Undecided Status: New ** Changed in: librabbitmq (Ubuntu Disco) Status: New => Fix Released ** Changed in: librabbitmq (Ubuntu Disco) Importance: Undecided => Medium ** Changed in: librabbitmq (Ubuntu Xenial) Importance: Undecided => Low ** Changed in: librabbitmq (Ubuntu Cosmic) Importance: Undecided => Medium ** Changed in: librabbitmq (Ubuntu Cosmic) Assignee: (unassigned) => Bryce Harrington (bryce) ** Changed in: librabbitmq (Ubuntu Disco) Assignee: (unassigned) => Bryce Harrington (bryce) ** Changed in: librabbitmq (Ubuntu Cosmic) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Description changed: - The version of amqp-tools in 18.04.1 LTS (and 14.04 iirc) has a bug - which renders parts of the cli unusable: + [Impact] + The --server and -url parameters do not function as documented, due to an upstream coding error that was fixed in release 0.8.1. + + [Test Case] + TBD + + [Regression Potential] + + [Fix] + The upstream patch corrects handling of --server, --url, and other options by reorganizing the logic flow. + + [Discussion] + The issue appears not to be a regression from a recent change, but a problem that has existed for quite a while: + + librabbitmq | 0.0.1.hg216-1 | precise/universe | source + librabbitmq | 0.4.1-1 | trusty | source + librabbitmq | 0.7.1-1 | xenial/universe | source + librabbitmq | 0.8.0-1build1 | bionic/universe | source + librabbitmq | 0.8.0-1build1 | cosmic/universe | source + librabbitmq | 0.9.0-0.2 | disco| source + librabbitmq | 0.9.0-0.2 | eoan | source + + The fix should be backported to bionic and probably cosmic. Earlier + releases are probably also affected but probably only worth doing if the + patch applies cleanly to them. + + [Original Report] + The version of amqp-tools in 18.04.1 LTS (and 14.04 iirc) has a bug which renders parts of the cli unusable: https://github.com/alanxz/rabbitmq-c/issues/364 1) 18.04.1 LTS bionic 2) 0.8.0-1build1 3) `amqp-consume --server=foobar:5672 -q queue cat` should work 4) amqp-consume complains that you cannot use --server and --url together ** Changed in: librabbitmq (Ubuntu Eoan) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Patch added: "Upstream commit 5dfe5d2f2680a4639090a9c239a2b0018d90c789" https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+attachment/5269457/+files/fix-parameter-processing.patch ** Changed in: librabbitmq (Ubuntu Bionic) Importance: Undecided => High ** Changed in: librabbitmq (Ubuntu Bionic) Importance: High => Medium ** Changed in: librabbitmq (Ubuntu Eoan) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Changed in: librabbitmq (Ubuntu Bionic) Assignee: (unassigned) => Bryce Harrington (bryce) ** Changed in: librabbitmq (Ubuntu Eoan) Assignee: (unassigned) => Bryce Harrington (bryce) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1790657] Re: [SRU] amqp-tools server parameter unusable
** Summary changed: - amqp-tools server parameter unusable + [SRU] amqp-tools server parameter unusable -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1790657 Title: [SRU] amqp-tools server parameter unusable To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/librabbitmq/+bug/1790657/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
