[Bug 1812352] Re: Handle the skip return code in kernel_selftests on Bionic
This bug was fixed in the package linux - 4.15.0-72.81
---
linux (4.15.0-72.81) bionic; urgency=medium
* bionic/linux: 4.15.0-72.81 -proposed tracker (LP: #1854027)
* [Regression] Bionic kernel 4.15.0-71.80 can not boot on ThunderX
(LP: #1853326)
- Revert "arm64: Use firmware to detect CPUs that are not affected by
Spectre-v2"
- Revert "arm64: Get rid of __smccc_workaround_1_hvc_*"
* [Regression] Bionic kernel 4.15.0-71.80 can not boot on ThunderX2 and
Kunpeng920 (LP: #1852723)
- SAUCE: arm64: capabilities: Move setup_boot_cpu_capabilities() call to
correct place
linux (4.15.0-71.80) bionic; urgency=medium
* bionic/linux: 4.15.0-71.80 -proposed tracker (LP: #1852289)
* Bionic update: upstream stable patchset 2019-10-29 (LP: #1850541)
- panic: ensure preemption is disabled during panic()
- f2fs: use EINVAL for superblock with invalid magic
- [Config] updateconfigs for USB_RIO500
- USB: rio500: Remove Rio 500 kernel driver
- USB: yurex: Don't retry on unexpected errors
- USB: yurex: fix NULL-derefs on disconnect
- USB: usb-skeleton: fix runtime PM after driver unbind
- USB: usb-skeleton: fix NULL-deref on disconnect
- xhci: Fix false warning message about wrong bounce buffer write length
- xhci: Prevent device initiated U1/U2 link pm if exit latency is too long
- xhci: Check all endpoints for LPM timeout
- usb: xhci: wait for CNR controller not ready bit in xhci resume
- USB: adutux: fix use-after-free on disconnect
- USB: adutux: fix NULL-derefs on disconnect
- USB: adutux: fix use-after-free on release
- USB: iowarrior: fix use-after-free on disconnect
- USB: iowarrior: fix use-after-free on release
- USB: iowarrior: fix use-after-free after driver unbind
- USB: usblp: fix runtime PM after driver unbind
- USB: chaoskey: fix use-after-free on release
- USB: ldusb: fix NULL-derefs on driver unbind
- serial: uartlite: fix exit path null pointer
- USB: serial: keyspan: fix NULL-derefs on open() and write()
- USB: serial: ftdi_sio: add device IDs for Sienna and Echelon PL-20
- USB: serial: option: add Telit FN980 compositions
- USB: serial: option: add support for Cinterion CLS8 devices
- USB: serial: fix runtime PM after driver unbind
- USB: usblcd: fix I/O after disconnect
- USB: microtek: fix info-leak at probe
- USB: dummy-hcd: fix power budget for SuperSpeed mode
- usb: renesas_usbhs: gadget: Do not discard queues in
usb_ep_set_{halt,wedge}()
- usb: renesas_usbhs: gadget: Fix usb_ep_set_{halt,wedge}() behavior
- USB: legousbtower: fix slab info leak at probe
- USB: legousbtower: fix deadlock on disconnect
- USB: legousbtower: fix potential NULL-deref on disconnect
- USB: legousbtower: fix open after failed reset request
- USB: legousbtower: fix use-after-free on release
- staging: vt6655: Fix memory leak in vt6655_probe
- iio: adc: ad799x: fix probe error handling
- iio: adc: axp288: Override TS pin bias current for some models
- iio: light: opt3001: fix mutex unlock race
- efivar/ssdt: Don't iterate over EFI vars if no SSDT override was specified
- perf llvm: Don't access out-of-scope array
- perf inject jit: Fix JIT_CODE_MOVE filename
- CIFS: Gracefully handle QueryInfo errors during open
- CIFS: Force revalidate inode when dentry is stale
- CIFS: Force reval dentry if LOOKUP_REVAL flag is set
- kernel/sysctl.c: do not override max_threads provided by userspace
- firmware: google: increment VPD key_len properly
- gpiolib: don't clear FLAG_IS_OUT when emulating open-drain/open-source
- Staging: fbtft: fix memory leak in fbtft_framebuffer_alloc
- iio: hx711: add delay until DOUT is ready
- iio: adc: hx711: fix bug in sampling of data
- btrfs: fix incorrect updating of log root tree
- NFS: Fix O_DIRECT accounting of number of bytes read/written
- MIPS: Disable Loongson MMI instructions for kernel build
- Fix the locking in dcache_readdir() and friends
- media: stkwebcam: fix runtime PM after driver unbind
- tracing/hwlat: Report total time spent in all NMIs during the sample
- tracing/hwlat: Don't ignore outer-loop duration when calculating
max_latency
- ftrace: Get a reference counter for the trace_array on filter files
- tracing: Get trace_array reference for available_tracers files
- x86/asm: Fix MWAITX C-state hint value
- iio: adc: stm32-adc: fix a race when using several adcs with dma and irq
- cifs: use cifsInodeInfo->open_file_lock while iterating to avoid a panic
- btrfs: fix uninitialized ret in ref-verify
- arm64/sve: Fix wrong free for task->thread.sve_state
- [Config] updateconfigs for USB_RIO500
* Bionic update: upstream stable patchset 2019-11-13 (LP: #1852492)
- zram: fix race between backing_dev_show and backing_dev_store
- dm snapshot: use mutex
[Bug 1812352] Re: Handle the skip return code in kernel_selftests on Bionic
Verified on Bionic. Works as expected. ** Changed in: ubuntu-kernel-tests Status: In Progress => Fix Released ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic ** Tags removed: xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1812352 Title: Handle the skip return code in kernel_selftests on Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1812352/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1812352] Re: Handle the skip return code in kernel_selftests on Bionic
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed- bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed- bionic'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1812352 Title: Handle the skip return code in kernel_selftests on Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1812352/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1812352] Re: Handle the skip return code in kernel_selftests on Bionic
** Changed in: linux (Ubuntu Bionic) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1812352 Title: Handle the skip return code in kernel_selftests on Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1812352/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1812352] Re: Handle the skip return code in kernel_selftests on Bionic
https://lists.ubuntu.com/archives/kernel-team/2019-November/105243.html ** Description changed: == Justification == - In the ubuntu_kernel_selftests, the skipped test will uses return code 4 (KSFT_SKIP). + In the ubuntu_kernel_selftests, the skipped test will uses return code 4 + (KSFT_SKIP). However the code to handle this non-zero return code was not implemented - in the kselftest framework. And this will generate some false-positives + in the kselftest framework. And this will generate some false-positive results as those skipped tests were treated as a failure. For example the raw_skew test in timers on 4.15: - 1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons - not ok 1..7 selftests: raw_skew [FAIL] + 1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons + not ok 1..7 selftests: raw_skew [FAIL] And the test_user_copy.sh test in user (failure could be found in KVM kernels): - user: module test_user_copy is not found [SKIP] - not ok 1..1 selftests: test_user_copy.sh [FAIL] + user: module test_user_copy is not found [SKIP] + not ok 1..1 selftests: test_user_copy.sh [FAIL] + + Xenial is affected by this issue as well. Considering the fact that this + issue in Bionic affects more tests / kernel variants, and it's way + easier to fix this in Bionic, I decided to go for Bionic first. == Fix == 771cbc3b (selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers) a3355440 (selftests: Fix lib.mk run_tests target shell script) 42b44c34 (selftests: lib.mk: cleanup RUN_TESTS define and make it readable) 3f4435b5 (selftests: lib.mk: add SKIP handling to RUN_TESTS define) All these can be cherry-picked into Bionic. - The crucial patch is commit 3f4435b5, the other three patches just paves - the road for it to be cherry-picked. + The crucial patch is commit 3f4435b5, the other three patches are just + some minor fixes that pave the road for it to be cherry-picked. == Test == - Tested on a Bionic amd64 node, the result shows positive outcome. + Tested on a Bionic amd64 node, the result shows positive. A test summary before the patch: - END GOODubuntu_kernel_selftests.setup - END GOODubuntu_kernel_selftests.breakpoints - END GOODubuntu_kernel_selftests.cpu-hotplug - END GOODubuntu_kernel_selftests.efivarfs - END GOODubuntu_kernel_selftests.memfd - END GOODubuntu_kernel_selftests.memory-hotplug - END GOODubuntu_kernel_selftests.mount - END GOODubuntu_kernel_selftests.net - END GOODubuntu_kernel_selftests.ptrace - END GOODubuntu_kernel_selftests.seccomp - END ERROR ubuntu_kernel_selftests.timers - END GOODubuntu_kernel_selftests.powerpc - END GOODubuntu_kernel_selftests.user - END GOODubuntu_kernel_selftests.ftrace + END GOOD ubuntu_kernel_selftests.setup + END GOOD ubuntu_kernel_selftests.breakpoints + END GOOD ubuntu_kernel_selftests.cpu-hotplug + END GOOD ubuntu_kernel_selftests.efivarfs + END GOOD ubuntu_kernel_selftests.memfd + END GOOD ubuntu_kernel_selftests.memory-hotplug + END GOOD ubuntu_kernel_selftests.mount + END GOOD ubuntu_kernel_selftests.net + END GOOD ubuntu_kernel_selftests.ptrace + END GOOD ubuntu_kernel_selftests.seccomp + END ERROR ubuntu_kernel_selftests.timers + END GOOD ubuntu_kernel_selftests.powerpc + END GOOD ubuntu_kernel_selftests.user + END GOOD ubuntu_kernel_selftests.ftrace A test summary after the patch: - END GOODubuntu_kernel_selftests.setup - END GOODubuntu_kernel_selftests.breakpoints - END GOODubuntu_kernel_selftests.cpu-hotplug - END GOODubuntu_kernel_selftests.efivarfs - END GOODubuntu_kernel_selftests.memfd - END GOODubuntu_kernel_selftests.memory-hotplug - END GOODubuntu_kernel_selftests.mount - END GOODubuntu_kernel_selftests.net - END GOODubuntu_kernel_selftests.ptrace - END GOODubuntu_kernel_selftests.seccomp - END GOODubuntu_kernel_selftests.timers - END GOODubuntu_kernel_selftests.powerpc - END GOODubuntu_kernel_selftests.user - END GOODubuntu_kernel_selftests.ftrac + END GOOD ubuntu_kernel_selftests.setup + END GOOD ubuntu_kernel_selftests.breakpoints + END GOOD ubuntu_kernel_selftests.cpu-hotplug + END GOOD ubuntu_kernel_selftests.efivarfs + END GOOD ubuntu_kernel_selftests.memfd + END GOOD ubuntu_kernel_selftests.memory-hotplug + END GOOD ubuntu_kernel_selftests.mount + END GOOD ubuntu_kernel_selftests.net + END GOOD ubuntu_kernel_selftests.ptrace + END GOOD ubuntu_kernel_selftests.seccomp + END GOOD ubuntu_kernel_selftests.timers + END GOOD ubuntu_kernel_selftests.powerpc + END GOOD ubuntu_kernel_selftests.user + END GOOD ubuntu_kernel_selftests.ftrac - The raw_skew test in timers is now marked as [SKIPPED] and no longer - causing failure. + No tests were skipped uninte
[Bug 1812352] Re: Handle the skip return code in kernel_selftests on Bionic
Xenial will require more work, I will split the test report here (see bug 1851486 for X) ** Summary changed: - Handle the skip return code in kernel_selftests + Handle the skip return code in kernel_selftests on Bionic ** Changed in: linux (Ubuntu Xenial) Status: New => Invalid ** Changed in: linux (Ubuntu) Status: Confirmed => Fix Released ** Description changed: == Justification == In the ubuntu_kernel_selftests, the skipped test will uses return code 4 (KSFT_SKIP). However the code to handle this non-zero return code was not implemented in the kselftest framework. And this will generate some false-positives results as those skipped tests were treated as a failure. For example the raw_skew test in timers on 4.15: 1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons not ok 1..7 selftests: raw_skew [FAIL] And the test_user_copy.sh test in user (failure could be found in KVM kernels): user: module test_user_copy is not found [SKIP] not ok 1..1 selftests: test_user_copy.sh [FAIL] == Fix == 771cbc3b (selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers) a3355440 (selftests: Fix lib.mk run_tests target shell script) 42b44c34 (selftests: lib.mk: cleanup RUN_TESTS define and make it readable) 3f4435b5 (selftests: lib.mk: add SKIP handling to RUN_TESTS define) All these can be cherry-picked into Bionic. The crucial patch is commit 3f4435b5, the other three patches just paves the road for it to be cherry-picked. == Test == Tested on a Bionic amd64 node, the result shows positive outcome. A test summary before the patch: END GOODubuntu_kernel_selftests.setup END GOODubuntu_kernel_selftests.breakpoints END GOODubuntu_kernel_selftests.cpu-hotplug END GOODubuntu_kernel_selftests.efivarfs END GOODubuntu_kernel_selftests.memfd END GOODubuntu_kernel_selftests.memory-hotplug END GOODubuntu_kernel_selftests.mount END GOODubuntu_kernel_selftests.net END GOODubuntu_kernel_selftests.ptrace END GOODubuntu_kernel_selftests.seccomp END ERROR ubuntu_kernel_selftests.timers END GOODubuntu_kernel_selftests.powerpc END GOODubuntu_kernel_selftests.user END GOODubuntu_kernel_selftests.ftrace A test summary after the patch: END GOODubuntu_kernel_selftests.setup END GOODubuntu_kernel_selftests.breakpoints END GOODubuntu_kernel_selftests.cpu-hotplug END GOODubuntu_kernel_selftests.efivarfs END GOODubuntu_kernel_selftests.memfd END GOODubuntu_kernel_selftests.memory-hotplug END GOODubuntu_kernel_selftests.mount END GOODubuntu_kernel_selftests.net END GOODubuntu_kernel_selftests.ptrace END GOODubuntu_kernel_selftests.seccomp END GOODubuntu_kernel_selftests.timers END GOODubuntu_kernel_selftests.powerpc END GOODubuntu_kernel_selftests.user END GOODubuntu_kernel_selftests.ftrac The raw_skew test in timers is now marked as [SKIPPED] and no longer causing failure. A complete test report could be found in the bug report attachment. == Regression Potential == Low, this patch set just added support to handle the skip return code and changes are limited to the kselftest framework itself, no actual impact to normal users. - In the selftests tool, we are using a KSFT_SKIP=4 return code for those - skipped tests in the latest upstream kernel tree. + + == Original bug report == + In the selftests tool, we are using a KSFT_SKIP=4 return code for those skipped tests in the latest upstream kernel tree. But the corresponding code to take care of this return value does not exist in Bionic and Xenial kernel, this will cause the test still being marked as failed: selftests: test_user_copy.sh user: module test_user_copy is not found [SKIP] not ok 1..1 selftests: test_user_copy.sh [FAIL] -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1812352 Title: Handle the skip return code in kernel_selftests on Bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/1812352/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
