[Bug 1828282]
Test suite got fixed in master too, all is good: https://git.busybox.net/busybox/commit/?id=b2c123d484dbe261758f27ced213f4649173803b Thanks a lot for the quick fixes! Included in Ubuntu devel series. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/busybox/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
This bug was fixed in the package busybox - 1:1.30.1-4ubuntu4 --- busybox (1:1.30.1-4ubuntu4) eoan; urgency=medium * Revert previous upload, cherrypick upstream fix for the issue. LP: #1828282 * Adjust testsuite expectations. -- Dimitri John Ledkov Thu, 23 May 2019 14:37:05 +0100 ** Changed in: busybox (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/busybox/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
** Changed in: busybox Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/busybox/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282]
Fixed in git, lots of thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/busybox/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282]
Nice! It is valgrind clean now, but the testsuite fails: $ ./bunzip2.tests PASS: bunzip2: doesnt exist PASS: bunzip2: unknown suffix PASS: bunzip2: already exists PASS: bunzip2: stream unpack PASS: bunzip2: delete src PASS: bunzip2: test_bz2 file PASS: bunzip2: pbzip_4m_zeros file PASS: bunzip2: bz2_issue_11.bz2 corrupted example FAIL: bunzip2: bz2_issue_12.bz2 corrupted example Maybe, now that this is fixed, the issue_12 expectation should be changed? It currently expects "bunzip2: bunzip error -3:1", yet we now generate "bunzip2: bunzip error -5:1" (just like issue_11 corrupted example) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/busybox/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
** Changed in: busybox (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/busybox/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
Launchpad has imported 1 comments from the remote bug at https://bugs.busybox.net/show_bug.cgi?id=11896. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2019-05-23T10:56:10+00:00 Dimitri John Ledkov wrote: Originally reported at https://bugs.launchpad.net/ubuntu/+source/busybox/+bug/1828282 with initial suspicion at glibc, however later diagnosed to be a busybox issue. The full analysis is at https://bugs.launchpad.net/ubuntu/+source/busybox/+bug/1828282/comments/1 In short bz2_issue_11.bz2 test case always fails on s390x since bunzip2 depends on uninitialised values, which happen to always be "wrong" on s390x. This is observable with valgrind too: # valgrind busybox bunzip2 &1 >/dev/null ==40965== Memcheck, a memory error detector ==40965== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al. ==40965== Using Valgrind-3.14.0 and LibVEX; rerun with -h for copyright info ==40965== Command: busybox bunzip2 ==40965== ==40965== Conditional jump or move depends on uninitialised value(s) ==40965==at 0x17C1D4: get_next_block (decompress_bunzip2.c:393) ==40965==by 0x17C37F: get_next_block (decompress_bunzip2.c:419) ==40965== bunzip2: bunzip error -5 ==40965== ==40965== HEAP SUMMARY: ==40965== in use at exit: 0 bytes in 0 blocks ==40965== total heap usage: 7 allocs, 7 frees, 4,539,696 bytes allocated ==40965== ==40965== All heap blocks were freed -- no leaks are possible ==40965== ==40965== For counts of detected and suppressed errors, rerun with: -v ==40965== Use --track-origins=yes to see where uninitialised values come from ==40965== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0) For the time being we are skipping the bz2_issue_11.bz2 test case in ubuntu. Reply at: https://bugs.launchpad.net/ubuntu/+source/busybox/+bug/1828282/comments/6 ** Changed in: busybox Status: Unknown => Confirmed ** Changed in: busybox Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/busybox/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
** Bug watch added: Busybox Bugzilla #11896 https://bugs.busybox.net/show_bug.cgi?id=11896 ** Also affects: busybox via https://bugs.busybox.net/show_bug.cgi?id=11896 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/busybox/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Comment bridged from LTC Bugzilla
--- Comment From heinz-werner_se...@de.ibm.com 2019-05-15 10:19 EDT--- IBM Bugzilla status ->closed, tracking will be done via LP only. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
@IBM Please close your LTC bugzilla entry. We will continue to use this LP issue to pursue busybox upstream. Thanks a lot for your input! ** Changed in: busybox (Ubuntu) Status: New => Triaged ** Changed in: glibc (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
** Changed in: ubuntu-z-systems Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Comment bridged from LTC Bugzilla
--- Comment From heinz-werner_se...@de.ibm.com 2019-05-15 08:26 EDT--- @Xnox: due to the fact that this bugzilla is a busybox problem , can I close it on my side. This still is than open in LP for your tracking.. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
Will do! thanks for digging into this even though it's well, busybox issue. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Comment bridged from LTC Bugzilla
return RETVAL_DATA_ERROR;
252// }
253mtfSymbol[0] = selectors[i] = tmp_byte;
254}
=> Note: on the s390x case, selectors[395] == 0 whereas on x86 it was
selectors[395] == 20! This value depends on previous operations on the stack!
Afterwards each selector is processed:
382for (;;) {
383struct group_data *hufGroup;
384int *base, *limit;
385int nextSym;
386uint8_t ngrp;
387
388/* Fetch next Huffman coding group from list. */
389symCount = GROUP_SIZE - 1;
390if (selector >= nSelectors)
391return RETVAL_DATA_ERROR;
392ngrp = selectors[selector++];
393if (ngrp >= groupCount) {
394dbg("%d selectors[%d]:%d groupCount:%d",
395__LINE__, selector-1, ngrp, groupCount);
396return RETVAL_DATA_ERROR;
397}
...
=> In the relevant case, groupCount == 6 and we look at selector == 395:
On x86, ngrp == 20 => RETVAL_DATA_ERROR (=-5) is returned.
On s390x, ngrp == 0 => No error is reported and processing continues
until the input stream comes to end of file and get_bits() is called which
triggers the longjmp with value -3 (see above)!
418if (bd->inbufPos == bd->inbufCount) {
419nextSym = get_bits(bd,
hufGroup->maxLen);
Note: This bug is also observable with valgrind on s390x and x86:
busybox-1.30.1/testsuite$ valgrind ../busybox_unstripped bunzip2
&1 >/dev/null
...
==58836== Conditional jump or move depends on uninitialised value(s)
==58836==at 0x1C3D2C: get_next_block (decompress_bunzip2.c:393)
==58836==by 0x1C3ED7: get_next_block (decompress_bunzip2.c:419)
==58836== Uninitialised value was created by a stack allocation
==58836==at 0x1C392A: get_next_block (decompress_bunzip2.c:158)
@xnox: As mentioned at the beginning: Please report this bug to busybox
and integrate the fix into the ubuntu busybox package!
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1828282
Title:
busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-z-systems/+bug/1828282/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
** Tags added: id-5cc732a8910db44841cff9f0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
** Tags added: architecture-s39064 bugnameltc-177501 severity-high targetmilestone-inin1910 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] Re: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
** Also affects: ubuntu-z-systems Importance: Undecided Status: New ** Changed in: ubuntu-z-systems Importance: Undecided => High ** Changed in: ubuntu-z-systems Assignee: (unassigned) => bugproxy (bugproxy) ** Tags added: reverse-proxy-bugzilla s390x -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1828282] [NEW] busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always
Public bug reported: Steps to reproduce: 1) Get a system with glibc 2.29 2) Get busybox 1.30.1 installed (e.g. eoan, or download busybox package from https://launchpad.net/ubuntu/+source/busybox/1:1.30.1-4ubuntu3/+build/16724246 and use $ apt install ./busybox*.deb to install) 3) Get busybox 1.30.1 source code, e.g. $ pull-lp-source busybox Or like download the orig tarball from https://launchpad.net/ubuntu/+source/busybox/1:1.30.1-4ubuntu3 4) Run the bunzip2 testsuite: cd testsuite/ ECHO=/bin/echo ./bunzip2.tests Observe that with glibc 2.29 the: PASS: bunzip2: bz2_issue_11.bz2 corrupted example is XFAIL or FAIL, on s390x, whereas it passes on all other arches. If one uses glibc 2.28 (ie. use Cosmic, and install busybox & use matching test suite from eoan using links above) one can observe that the testcase always passes. We suspect this might be a glibc 2.29 s390x-specific setjmp regression. Probably due to setjmp usage in ./archival/libarchive/decompress_bunzip2.c The tests were done on a z13 machine. ** Affects: busybox (Ubuntu) Importance: Undecided Status: New ** Affects: glibc (Ubuntu) Importance: Undecided Status: New ** Also affects: glibc (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1828282 Title: busybox 1.30.1 crashes bzip2 test case with glibc 2.29, always To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/busybox/+bug/1828282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
