[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
** Changed in: subiquity Status: Triaged => Fix Released ** Changed in: probert (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
This bug is believed to be fixed in curtin in version 19.3. If this is still a problem for you, please make a comment and set the state back to New Thank you. ** Changed in: curtin Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
This bug is fixed with commit 7a22938d to curtin on branch master. To view that commit see the following URL: https://git.launchpad.net/curtin/commit/?id=7a22938d ** Changed in: curtin Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
** Merge proposal linked: https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/370843 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
** Tags added: id-5d40f920ea9865754db787bb -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
** Changed in: subiquity Status: New => Triaged ** Changed in: subiquity Importance: Undecided => Medium ** Tags added: reuse -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
** Attachment added: "test failures (warning contains sparse disk images)" https://bugs.launchpad.net/curtin/+bug/1835091/+attachment/525/+files/test-failures.tar.gz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
** Attachment added: "logs from testing in KVM" https://bugs.launchpad.net/curtin/+bug/1835091/+attachment/526/+files/logs.tgz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
So https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/369918 now has matching test cases. Will attach failures from the tests (warning, contains sparse disk images) and from my testing in KVM. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
So, no, neither case here is fixed in the latest subiquity :/ I'll try to make vmtest testcases for curtin. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
I fixed subiquity to wipe disks harder, which might well have fixed this. Will check today. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1835091] Re: subiquity crashes upon reusing failed to assemble raid member partition
The shutdown plan requires that the config for a device being cleared to not include the preserve: True config. The "raid" partition, vda3 is explicitly marked as preserved: true: - device: disk-vda size: 20947402752 flag: linux preserve: true type: partition id: partition-vda3 Curtin would not be able to clear raid metadata from this partition without wipe: set and preserve not present. That said, I do think that curtin can do a few things to resolve this: 1) include partial raids in the discovered config, and can either a) add a field to indicate whether the array is healthy/partial/degrated; array_state maybe b) defer to subiquity to use curtin.block.mdadm.md_check to determine if it wants to include or mark members of the array with wipe so they can be used in other configs. 2) Update how we run clear-holders; Currently we only pass in a list of block devices, of type disk which have 'wipe' set and do not have 'preserve' enabled. This fails the case here where we'd like to wipe vda3 but it has a holder. Concretely; I'd curtin discover would return: - type: raid level: 0 name: md127 devices: - partition-vda3 spare_devices: [] array_state: failed Now, to do that, probert will need to also include partial raids as well. Not sure; it's odd that pyudev didn't have a /dev/md127 entry in the context. The alternative for probert is to run some mdadm commands on the devices which have the ID_FSTYPE set to raid. I'll add a probert task for this bug as well. For clear-holders, curtin will also accept type: partition. I expect the final config to set wipe: superblock on vda3 since it's a raid member; and that clear-holders is called with devices=['/dev/vda3'] - device: disk-vda size: 20947402752 flag: linux wipe: superblock type: partition id: partition-vda3 >From there, clear-holders would find /dev/md127 has a holder of type: raid and then the normal curtin shutdown plan would show us stopping md127, wipe each array member (/dev/vda3). ** Also affects: probert (Ubuntu) Importance: Undecided Status: New ** Changed in: probert (Ubuntu) Importance: Undecided => High ** Changed in: probert (Ubuntu) Status: New => Triaged ** Changed in: curtin Importance: Undecided => High ** Changed in: curtin Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1835091 Title: subiquity crashes upon reusing failed to assemble raid member partition To manage notifications about this bug go to: https://bugs.launchpad.net/curtin/+bug/1835091/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
