[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Changed in: grub2 (Ubuntu Focal) Status: Fix Released => Triaged ** Changed in: grub2 (Ubuntu Focal) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Changed in: grub2 (Ubuntu Focal) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
Agreed. It is a multi-line problem (which by its nature includes a '\r') not being handled. Happy to test the solution on my system. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
Actually I think '\r' is a red herring. The problem is that if several devices are used for a pool (raid, log or cache) grub-probe returns several lines. Several are not handled properly when we generate the line of metadata used to create the menu. The patch is to take the first device returned by grub-probe. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
I'll strip the \r as a safety measure but I cannot reproduce this issue. I created a mirror on 2 devices with log and cache devices on separate partitions of a third disk like your setup and the line separator is always a new line character (0x0a) without carriage return (0x0d). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Changed in: grub2 (Ubuntu) Status: Confirmed => Triaged ** Changed in: grub2 (Ubuntu) Assignee: (unassigned) => Jean-Baptiste Lallement (jibel) ** Also affects: grub2 (Ubuntu Focal) Importance: Medium Assignee: Jean-Baptiste Lallement (jibel) Status: Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Changed in: grub2 (Ubuntu) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
The \r is an invisible return character, commonly returned by an echo.
However, here, we are executing grub_probe --target=device /boot
The code in 10_linux_zfs:
initrd_device=$(${grub_probe} --target=device "${boot_dir}")
The results are the same as above. For the specific entry, it is the first
drive in my mirror:
/dev/sdc1 (first drive as defined in my mirror)
/dev/sda1 (second drive as defined in my mirror)
/dev/nvme0n1p2 (zfs logs)
/dev/nvme0n1p4 (zfs cache)
Notice that the results of the output from grub_probe has new lines.
New lines are usually \n but may be \r\n. I don't know what grub_probe
is doing and didn't look to see how it does it. But the return from
there would be what's got the \r (again it isn't visible).
I have nothing special or different from the stock Ubuntu
/etc/default/grub other than I added zswap entries to the
/etc/default/grub and those don't affect this.
The underlying cause may be that because I have a mirrored root using
zfs mirroring, multiple devices show up and may cause the \r to be
returned. It's just a guess.
So, to test, you'd want grub_probe to return multiple devices and the
easiest way would be to just have a mirror for the rpool.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
error
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
Thanks for digging into this and finding your root cause! I'm really wondering what is causing this additional \r on that variable compared to a standard installation, with multiple kernels and initrds, which doesn't get this \r. Do you have any specific grub configuration in /etc/default/grub* or anything in /boot which can lead to this? Could be mirror-related, where grub_probe --target device returns this \r. What's the value of $initrd_device? The reason is that I would like to add this case to the testsuite to ensure we don't regress it in the future and so, trying to find the root cause (we can mock grub_probe in our testsuite to return what you got exactly). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
I tested the fix propossed by jpb in #21 and it works for me. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Attachment added: "10_linux_zfs" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5299059/+files/10_linux_zfs -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
Problem identified. The variable intrd_device contains a \r at the end
of the variable. When concatenating the variable with the subsequent
variables, it effectively truncates the subsequent data in the echo
return.
Preceding the if statement, I inserted the following:
# remove the trailing \r from the variable
initrd_device=$(echo ${initrd_device} | tr -d '\r')
This removed the trailing \r, allowing the full set of data to be
returned.
I tested this fix on my own system by modifying the 10_linux_zfs script
in /etc/grub.d. The grub.cfg is now successfully generated and apt/dpkg
are able to perform an update-grub.
10_linux_zfs attached.
** Attachment added: "10_linux_zfs"
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5299058/+files/10_linux_zfs
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
error
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Tags added: rls-ff-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
The attachment "1848856.debdiff" seems to be a debdiff. The ubuntu- sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
True, grub-probe will produce several lines. On my system it lists my drives as my actual mirrors, followed by my logs and then the cache -- same order as zpool status rpool grub-probe --target=device /boot /dev/sdc1 /dev/sda1 /dev/nvme0n1p2 /dev/nvme0n1p4 I'm not seeing in 10_linux_zfs where having multiple target devices would cause the dropping of the kernel and initrd from what was being generated. It looks to me like data is missing -- lost during the echo action of get_dataset_info(). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
I have a similar setup, a ssd as a cache for the root partition. The problem is grub-probe list multiple disks for the boot folder, which caused the /etc/grub.d/10_linux_zfs script. The 10_linux_zfs is expecting one disk, but the following commands will return several lines. /usr/sbin/grub-probe --target=device /boot -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
Hi Rex - you essentially removed the line that set at_least_one_entry=1.
Yes, that removes an extra "}" but if you look at the generated script, the
linux line specifies no kernel image and the initrd line includes no file.
This will result in an unbootable system.
linux root=ZFS=rpool/ROOT/ubuntu ro intel_iommu=on iommu=pt quiet splash
intel_iommu=on iommu=pt rootdelay=3 zswap.enabled=1 zswap.compressor=lz4
zswap.zpool=z3fold ${vt_handoff}
initrd
}
So, I believe the problem is deeper than a simple syntax error, there is
content missing. Additionally, when you look at the debug output you'll
see there were other kernels installed which should have gone under a
submenu. Content is being truncated or not carried through. This might be
a dash problem -- I can't tell.
But to remove the extra "}" does not resolve the issue.
Thanks,
Jeff
On Sun, Oct 20, 2019 at 9:35 AM Rex Tsai wrote:
> I believe the invalid grub menu is caused by wrong "}", when there is
> only a main section.
>
> ** Patch added: "1848856.debdiff"
>
> https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298611/+files/1848856.debdiff
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1848856
>
> Title:
> Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
> error
>
> Status in grub2 package in Ubuntu:
> Confirmed
>
> Bug description:
> At the end of the upgrade from 19.04 to 19.10, the post process of the
> update-grub reports:
>
> Syntax error at line 185
> Syntax errors are detected in generated GRUB config file.
> Ensure that there are no errors in /etc/default/grub
> and /etc/grub.d/* files or please file a bug report with
> /boot/grub/grub.cfg.new file attached.
> run-parts: /etc/kernel/postinst.d/zz-update-grub exited with return code
> 1
> dpkg: error processing package linux-image-5.3.0-18-generic
> (--configure):
>installed linux-image-5.3.0-18-generic package post-installation script
> subprocess returned error exit status 1
> Errors were encountered while processing:
>friendly-recovery
>grub-efi-amd64
>grub-efi
>grub-efi-amd64-signed
>shim-signed
>linux-image-5.3.0-18-generic
>
> The system used https://github.com/zfsonlinux/zfs/wiki/Ubuntu-18.04
> -Root-on-ZFS to add zfs on root to a 19.04 system.
>
> The syntax error in grub.cfg.new is an extra } on line 185. However,
> comparing the grub.cfg.new to the previously generated grub.cfg under
> 19.04, there is a significant quantity of configuration missing.
>
> Manually running update-grub generates the same error.
> /etc/default/grub is the only file changed from default installation
> to include zswap. This file was not changed prior to upgrade.
>
> The error is reported during the processing of
> /etc/grub.d/10_linux_zfs which is dated October 11. I attempted the
> upgrade on 10/18 and have done multiple updates to get the latest
> kernel and remove old kernels prior to the upgrade. So, I believe the
> problem is with one of the upgrade modules.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions
>
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
error
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
I believe the invalid grub menu is caused by wrong "}", when there is only a main section. ** Patch added: "1848856.debdiff" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298611/+files/1848856.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
My current work around is to manually maintain the grub.cfg in /boot/grub. Using the version that was generated under 19.04, I have simply updated the kernel and initrd to reflect the new modules. This still means that any package I install that needs to regenerate the grub.cfg will fail. So far it is only related to cleanup of the kernel and I expect the same will be true with the add of new kernels. Not ideal but I haven't found the root of the problem with the 10_linux_zfs script. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: grub2 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
Yes, my rpool is mirrored.
pool: rpool
state: ONLINE
status: Some supported features are not enabled on the pool. The pool can
still be used, but some features are unavailable.
action: Enable all features using 'zpool upgrade'. Once this is done,
the pool may no longer be accessible by software that does not support
the features. See zpool-features(5) for details.
scan: scrub repaired 0B in 0 days 05:45:25 with 0 errors on Sun Oct 13
06:09:31 2019
config:
NAME STATE READ WRITE
CKSUM
rpool ONLINE 0 0
0
mirror-0 ONLINE 0 0
0
wwn-0x5000cca24ce19a84-part1 ONLINE 0 0
0
wwn-0x5000c5004e60c802-part1 ONLINE 0 0
0
logs
nvme-eui.01004ce00018dd8c9084-part2 ONLINE 0 0
0
cache
nvme0n1p4ONLINE 0 0
0
errors: No known data errors
In 10_linux_zfs, there is an if statement that echos data:
if [ -n "${initrd_list}" -a -n "${kernel_list}" ]; then
echo
"${dataset}\t${is_zsys}\t${machine_id}\t${pretty_name}\t${last_used}\t${initrd_device}\t${initrd_list}\t${kernel_list}\t${last_booted_kernel}"
else
grub_warn "didn't find any valid initrd or kernel."
fi
The problem is that execution time, the last 3 parameters are dropped
even though they have data.
+ [ -n
/ROOT/ubuntu@/boot/initrd.img-5.3.0-18-generic|/ROOT/ubuntu@/boot/initrd.img-5.0.0-32-generic|/ROOT/ubuntu@/boot/initrd.img-5.0.0-31-generic|/ROOT/ubuntu@/boot/initrd.img-5.0.0-29-generic
-a -n
/ROOT/ubuntu@/boot/vmlinuz-5.3.0-18-generic|/ROOT/ubuntu@/boot/vmlinuz-5.0.0-32-generic|/ROOT/ubuntu@/boot/vmlinuz-5.0.0-31-generic|/ROOT/ubuntu@/boot/vmlinuz-5.0.0-29-generic
]
+ echo rpool/ROOT/ubuntu\t-\t6d41e97f07794e0b9d409db9a99529a5\tUbuntu
19.10\t1571542278\t/dev/sdc1
You can see from the expanded debug of the run (set -xv) that both
initrd_list and kernel_list had data that included the kernel and initrd
but within the if, it gets dropped. That is causing the generated
grub.cfg.new to be missing the kernel, initrd, and the advanced submenu
items that would normally be generated.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
error
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
Is your rpool mirrored? On a test enviroment if I detach one of the drives, I can run update- grub. Reattaching the drive breaks update-grub. I'm currently stuck in 19.04 because of this bug. # zpool status pool: zroot state: ONLINE scan: scrub repaired 0B in 2h59m with 0 errors on Sun Oct 13 03:23:12 2019 config: NAME STATE READ WRITE CKSUM zroot ONLINE 0 0 0 mirror-0ONLINE 0 0 0 sda3 ONLINE 0 0 0 sdb3 ONLINE 0 0 0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
I'm getting closer to finding the problem. It looks like in function get_dataset_info() in 10_linux_zfs the content of initrd_list, kernel_list, and last_booted_kernel are not being echoed back on the call. I don't know why yet. I haven't fully grasp the shell script. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
zsys is currently not installed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
I modified 10_linux_zfs to comment out the set -e and add the variables
for pkgdatadir and the GRUB* variables from /etc/default/grub and ran it
to see the output.
Notice at the end the double brace, lack of initrd value and linux image
even though it was found at the beginning when it correctly identified
the root dataset.
jpb@explorer:~/test$ sudo ./10_linux_zfs
Found linux image: vmlinuz-5.0.0-29-generic in rpool/ROOT/ubuntu
Found initrd image: initrd.img-5.0.0-29-generic in rpool/ROOT/ubuntu
Found linux image: vmlinuz-5.0.0-31-generic in rpool/ROOT/ubuntu
Found initrd image: initrd.img-5.0.0-31-generic in rpool/ROOT/ubuntu
Found linux image: vmlinuz-5.0.0-32-generic in rpool/ROOT/ubuntu
Found initrd image: initrd.img-5.0.0-32-generic in rpool/ROOT/ubuntu
Found linux image: vmlinuz-5.3.0-18-generic in rpool/ROOT/ubuntu
Found initrd image: initrd.img-5.3.0-18-generic in rpool/ROOT/ubuntu
Found linux image: vmlinuz-5.0.0-23-generic in
rpool/ROOT/ubuntu@pyznap_2019-08-18_14:11:36_monthly
Found initrd image: initrd.img-5.0.0-23-generic in
rpool/ROOT/ubuntu@pyznap_2019-08-18_14:11:36_monthly
** removed a ton of snapshots that were listed which found the
linux image and initrd image. *
Found linux image: vmlinuz-5.3.0-18-generic in
rpool/ROOT/ubuntu@apt2019-10-19_08.52.43--1w
Found initrd image: initrd.img-5.3.0-18-generic in
rpool/ROOT/ubuntu@apt2019-10-19_08.52.43--1w
function gfxmode {
set gfxpayload="${1}"
if [ "${1}" = "keep" ]; then
set vt_handoff=vt.handoff=1
else
set vt_handoff=
fi
}
if [ "${recordfail}" != 1 ]; then
if [ -e ${prefix}/gfxblacklist.txt ]; then
if hwmatch ${prefix}/gfxblacklist.txt 3; then
if [ ${match} = 0 ]; then
set linux_gfx_mode=keep
else
set linux_gfx_mode=text
fi
else
set linux_gfx_mode=text
fi
else
set linux_gfx_mode=keep
fi
else
set linux_gfx_mode=text
fi
export linux_gfx_mode
menuentry 'Ubuntu 19.10' --class ubuntu --class gnu-linux --class gnu --class
os ${menuentry_id_option} 'gnulinux-rpool/ROOT/ubuntu-' {
recordfail
load_video
gfxmode ${linux_gfx_mode}
insmod gzio
if [ "${grub_platform}" = xen ]; then insmod xzio; insmod lzopio; fi
insmod part_gpt
insmod zfs
set root='hd2,gpt1'
if [ x$feature_platform_search_hint = xy ]; then
search --no-floppy --fs-uuid --set=root --hint-bios=hd2,gpt1
--hint-efi=hd2,gpt1 --hint-baremetal=ahci2,gpt1 ba04856b80ac4244
else
search --no-floppy --fs-uuid --set=root ba04856b80ac4244
fi
linuxroot=ZFS=rpool/ROOT/ubuntu ro intel_iommu=on iommu=pt quiet
splash intel_iommu=on iommu=pt rootdelay=3 zswap.enabled=1 zswap.compressor=lz4
zswap.zpool=z3fold ${vt_handoff}
initrd
}
}
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1848856
Title:
Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax
error
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
One more piece of information. I have 3 zfs pools defined: rpool for my root dpool for my data (virtualization and other) bpool for my external usb backup device So, my bpool is different than the 19.10 new bpool to support the boot process. I don't know if this is a problem, but thought I'd mention it since it duplicates a pool name. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
Looking closer at the 19.04 grub.cfg and the post19.10 grub.cfg.new I see that the 19.04 version of update-grub was using 10_linux instead of 10_linux_zfs to generate the grub.cfg.new. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Attachment added: "Generaged Grub.cfg prior to 19.10" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298391/+files/grub.cfg.pre1910 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Attachment added: "update-grub.log" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298388/+files/update-grub.log -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Attachment added: "grub.cfg.new" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298389/+files/grub.cfg.new -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1848856] Re: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error
** Attachment added: "grub" https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+attachment/5298390/+files/grub -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1848856 Title: Upgrade from 19.04 to 19.10 with zfs on root fails with grub syntax error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848856/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
