[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
This bug was fixed in the package sip4 - 4.17+dfsg-1ubuntu0.1 --- sip4 (4.17+dfsg-1ubuntu0.1) xenial; urgency=medium * Fixed issues with C/C++ member variable getters and setters. This restores the keeping of a reference to the containing object in the instance of a contained class (LP: #1861601). -- Dmitry Shachnev Sun, 15 Mar 2020 19:23:54 +0300 ** Changed in: sip4 (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
This bug was fixed in the package sip4 - 4.19.7+dfsg-1ubuntu0.1 --- sip4 (4.19.7+dfsg-1ubuntu0.1) bionic; urgency=medium * Fixed issues with C/C++ member variable getters and setters. This restores the keeping of a reference to the containing object in the instance of a contained class (LP: #1861601). -- Dmitry Shachnev Mon, 02 Mar 2020 20:04:07 +0300 ** Changed in: sip4 (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
I have tested the following versions: Xenial: amd64 4.17+dfsg-1ubuntu0.1 Bionic: amd64 4.19.7+dfsg-1ubuntu0.1 Both distributions are now fixed. For reference, my CI setup: Xenial fixed: https://travis-ci.com/github/MatthijsBurgh/orocos_kinematics_dynamics/jobs/308050115 Bionic fixed: https://travis-ci.com/github/MatthijsBurgh/orocos_kinematics_dynamics/jobs/308050672 Xenial before fix: https://travis-ci.com/github/MatthijsBurgh/orocos_kinematics_dynamics/jobs/307568631 ** Tags removed: verification-needed verification-needed-bionic verification-needed-xenial ** Tags added: verification-done verification-done-bionic verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
Hello Matthijs, or anyone else affected, Accepted sip4 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sip4/4.19.7+dfsg- 1ubuntu0.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: sip4 (Ubuntu Bionic) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-bionic ** Changed in: sip4 (Ubuntu Xenial) Status: New => Fix Committed ** Tags added: verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
Hi Dmitry, I have tested the updated Xenial package. Still works! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
I have uploaded an updated Xenial package to https://launchpad.net/~ci- train-ppa-service/+archive/ubuntu/3941. Matthijs, if you have time, please test whether it still works for you. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
Hi Robie, thanks for noticing that! That reordering is not needed for this fix, it is a backporting error. When the reordering happened in upstream 4.19 release, the ABI version was bumped from 11.3 to 12.0, so it is a breaking change. Please reject the current Xenial upload, I will do another upload without any changes to sip.h.in. The Bionic upload does not have that change, so it may be accepted. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
Thank you for working on this. In the proposed upload for Xenial, siplib/sip.h.in reorders a struct but there is no major version bump as suggested required by the comment in that file. This gives me concern that there will be some API or ABI breakage with this change, since there is currently no plan to rebuild reverse dependencies. I don't see any discussion of possible API or ABI breakages in the bug so far. Please could you look into this possibility, both for Xenial and for Bionic? If it's definitely not an issue then that's fine; I'd just like to see an explanation from someone familiar with this package. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
Thanks! I have now uploaded the packages to Ubuntu, they are waiting for review in unapproved queues: - https://launchpad.net/ubuntu/xenial/+queue?queue_state=1 - https://launchpad.net/ubuntu/bionic/+queue?queue_state=1 When they are accepted into -proposed, you will be asked to test the packages from there. Testing is needed before the packages will be accepted into official -updates. I have also uploaded the 16.04 (Xenial) package into the PPA mentioned above, in case you want to test it earlier. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
Hi Dmitry, Please check the attached patch compared to the 4.17 tag. This should provide the solution for 16.04. The diff is in the original mercurial sip repo, https://www.riverbankcomputing.com/hg/sip. But is should be applicable to the git repo. The previous patch missed 2 lines. Therefore the update ** Patch removed: "sip_patch2.txt" https://bugs.launchpad.net/ubuntu/xenial/+source/sip4/+bug/1861601/+attachment/5332696/+files/sip_patch2.txt ** Attachment added: "sip_patch2.txt" https://bugs.launchpad.net/ubuntu/xenial/+source/sip4/+bug/1861601/+attachment/5332707/+files/sip_patch2.txt -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
Hi Dmitry, Also the provided test package for 18.04 does fix the problems for me. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
Hi Dmitry, Please check the attached patch compared to the 4.17 tag. This should provide the solution for 16.04. The diff is in the original mercurial sip repo, https://www.riverbankcomputing.com/hg/sip. But is should be applicable to the git repo. ** Attachment added: "sip_patch2.txt" https://bugs.launchpad.net/ubuntu/xenial/+source/sip4/+bug/1861601/+attachment/5332696/+files/sip_patch2.txt -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
Hi Matthijs! For 20.04 (Focal), this is now fixed, so I am changing the bug status accordingly. For 18.04 (Bionic), I prepared a test package in https://launchpad.net /~ci-train-ppa-service/+archive/ubuntu/3941. Can you please test if it works fine for you? For 16.04 (Xenial), the patches do not apply cleanly. If you managed to backport the fixes, can you attach your backported patch? ** Changed in: sip4 (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1861601] Re: Memory leak and incorrect behaviour of generated bindings
** Also affects: sip4 (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: sip4 (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: sip4 (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1861601 Title: Memory leak and incorrect behaviour of generated bindings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sip4/+bug/1861601/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
