[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Tags removed: server-todo -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
I did some tests, to see what the cluster behavior is when changing node name
and/or id. It all boils down to the fact that whatever is being changed, one
has to be aware that the change is being done to a live real cluster, even
though it's a simple one-node cluster. That's what you get right after the
package is installed: a single node cluster:
- node name is either "node1" or `uname -n`, depending on the ubuntu release.
In the case of focal, topic of this bug, it's "node1" currently
- node id is 1
- ring0_addr is localhost
The charm is doing 3 changes compared to the default config file:
- node name is back to being localhost
- node id is 1000 + application unit id (a juju thing: for example,
postgresql/0 is unit 0 of application postgresql).
- ring0_addr gets the real IP of the application unit, instead of 127.0.0.1
When changing nodeid *AND* node name, this is essentially creating a new
node in the cluster. The old "node1" name and ID will remain around, but
offline because no live host is responding as that anymore.
If you change just one of the two (node name or id), then the cluster
seems to be able to coalesce them together again, and you get a plain
rename, I haven't tested this exhaustively, but it seems to be the case
by inspecting the current cib.raw xml file in each node, and diffing to
a previous one shows the rename.
Let's test a user story, showing how one could deploy 3 nodes manually
from these focal packages.
After installing pacemaker corosync in all 3 nodes, let's call them f1, f2 and
f3, we get:
- f1: node id = 1, node name = node1, cluster name = debian
- f2: node id = 1, node name = node1, cluster name = debian
- f3: node id = 1, node name = node1, cluster name = debian
All with the identical config. These are esssentially 3 isolated
clusters called debian, with one node called node1 in each.
The following set of changes will work and not show a phantom "node1" node at
the end:
- on f1, adjust corosync.conf with this node list:
nodelist {
node {
# name: node1
nodeid: 1
ring0_addr: f1 # (or f1's ip)
}
node {
nodeid: 2
ring0_addr: f2 # (or f2's ip)
}
node {
nodeid: 3
ring0_addr: f3 # (or f3's ip)
}
}
Then scp this file to the other nodes, and restart corosync and
pacemaker there.
We kept the nodeid on f1 as 1, just got rid of its name. That renames that node
to `uname -n`, because the id was kept at 1.
The other nodes also got a new name, but their ids changed. And crucially, node
id 1 still exists in the cluster (it's f1), so it all works out.
If you were to also change the node id range together with the name,
like the charm does, then it's an entirely new node. and you will have
to get rid of node1 with a crm or pcs command, or just " crm_node
--remove node1".
All in all, it's best to either start with the correct configuration (which the
charm does nowadays), or clear everything beforehand (with pcs cluster destroy,
perhaps). "pcs cluster destroy" is quite comprehensive, it does:
- rm -f /etc/corosync/{corosync.conf,authkey} /etc/pacemaker/authkey
/var/lib/pcsd/disaster-recovery
- removes many files from /var/lib/pacemaker (cib, pengine/pe*bz2, hostcache,
cts, others)
- stops the services
One has to be very careful if changing node names and node ids in a live
cluster, and a live cluster is what you get right after installing the
packages.
I still haven't made up my mind about this focal SRU. I definitely
prefer to have the node name default to the hostname (uname -n), but
making such a change via an SRU is debatable. We might have to "bite the
bullet" and live with this different behavior in focal only :/
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1874719
Title:
[SRU] Use the hostname as the node name instead of hardcoded 'node1'
To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
> However, hacluster charm should be handling this situation. There's nothing > special here - > corosync has specific behaviour out of the box. Charms should handle it. I'm trying to understand the sequence of steps that led to this situation on Focal. From what I understand: - install corosync - you get a cluster named "debian", with a single node named "node1" (which does not match the hostname), in each unit. If you deployed 3 principals, and 3 hacluster subordinates, each one will be its own isolated island still. - time passes - some relation gets added, and the charm reacts. It renames each node to the hostname (juju-), and even node id is changed I believe. corosync.conf and other files are propagated to all nodes, and tries to form a cluster. I don't know what it does to the cluster name. Services get restarted - at that point, some nodes (all?) still have "node1" stored somewhere, which was their own old name before So is this a scenario of renaming a node while it's part of a cluster, even when it's a single-node cluster from the default package installation? I would expect that default single-node cluster to be destroyed when the charm takes over. Maybe it's hard to distinguish that scenario from a real-multi-node-cluster-but-degraded one. In general, I prefer the idea of using the hostname as the node name by default. It's what at least has a chance of being unique right after install, whereas "node1" definitely does not. Sounds less surprising behavior. Now, doing an SRU to change this back to hostname, the pro and con balance isn't clear. Fresh installs would be better after the SRU, but existing ones would get a dpkg conf prompt, and risk getting the wrong answer and having the cluster broken. All in all, everyone deploying a more-than-one-node cluster will *definitely* change the conf file anyway for other reasons (or will they?), which also makes the "node1" argument kind of moot. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
Reviewed: https://review.opendev.org/c/openstack/charm-hacluster/+/841587 Committed: https://opendev.org/openstack/charm-hacluster/commit/567e54d87c55f945f222a9ebbe2e9bfc1984ce5e Submitter: "Zuul (22348)" Branch:stable/focal commit 567e54d87c55f945f222a9ebbe2e9bfc1984ce5e Author: Billy Olsen Date: Wed Mar 16 06:50:28 2022 -0700 Render corosync.conf file prior to pkg install Starting in focal, the ubuntu version of corosync package synced in from debian includes node1 as the default name for the local node with a nodeid of 1. This causes the cluster to have knowledge of this extra node1 node, which affects quorum, etc. Installing the charm's corosync.conf file before package installation prevents this conditioning from happening. Additionally this change removes some Xenial bits in the charm and always includes a nodelist in corosync.conf as it is compulsory in focal and newer. It is optional in the bionic packages, so we'll always just render the nodelist. Change-Id: I06b9c23eb57274f0c99a3a05979c0cabf87c8118 Closes-Bug: #1874719 (cherry picked from commit d1191dbcabdfd8684a86825f06c6ede266ba93ba) ** Tags added: in-stable-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Changed in: charm-hacluster Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
Thanks for taking a look at this proposed change Robie. The behavior we are trying to backport to Focal is already present in all supported releases, Focal is the only one that differs at the moment. What you said is indeed true, the default configuration file is not production ready to most of the use cases I believe. I tried to backport it to keep the same behavior across all the releases (the change is just commenting out a single line in the config file) but TBH I also do not think it will benefit many users already running Focal. It might benefit some users upgrading from Bionic to Focal since the behavior would be the same. It'd be great to see James' opinion about this. And after applying this change in Jammy I also needed to add some delta to some other packages fixing DEP-8 tests which were already expecting the hardcoded 'node1' default node name. The Debian maintainer is not willing to accept this change also, so the maintenance cost to keep this change is getting higher. Maybe we should reconsider how useful it is to keep this change as a Ubuntu delta for the future cycles. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
> I'm not sure how to do that in packaging except to try to guide the user into somehow not following the broken installation flow. Maybe, *if* it's never useful to use corosync with the default shipped corosync.conf, we should just not ship it, and add a ConditionPathExists=/etc/corosync/corosync.conf to corosync.service? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
James said: > Setting the pacemaker distro task back to new - it seems very odd that a system designed to manage a cluster of servers would install on every node with a non-unique node id, which is a change in behaviour from older versions of the same software. In Jammy, I think this is still the case? corosync.conf still ships with a default nodeid of 1. It's just the name that's no longer supplied. My understanding of the normal use of corosync in Ubuntu is that the entire file is generally always replaced after the package is installed. I believe the hacluster charm does this too. So am I right in that the issue is that corosync started briefly before being configured by the charm, and is leaving state behind? In that case, I think the charm was possibly buggy in two ways: 1) It should use policy-rc.d to avoid corosync daemon startup before corosync.conf is written out, or maybe write it out in advance. Looks like Billy's commit fixed this in the charm already. FWIW, I find it surprising that charms don't generally always override with policy-rc.d and start services manually. 2) After rewriting corosync configuration, it should clear out corosync state files entirely before restarting the daemon. This is no longer necessary due to the other fix. Both of these apply to anything configuring corosync on Ubuntu, not just the charm. So it's not clear to me that there's a bug in the corosync packaging in Ubuntu in Focal at all. We merely ship a default cluster of size 1 that isn't very useful and needs to be replaced correctly in order to be useful. From an SRU perspective, I have further concerns for existing users. 1) It's a conffile change. Since corosync.conf is almost always modified by users, they're are going to be prompted on upgrade if interactive. This is a little alarming and not useful. Is there any actual case where existing users would realistically be using the default configuration file? Note also that since the issue is with state, changing the configuration file for existing users wouldn't avoid the issue for them anyway. 2) Changing the node name on an existing cluster seems dangerous to me. For the SRU, what problem are we actually solving here then? The charm is fixed and no longer impacted. Are we trying to avoid having dirty state when users follow the broken installation flow of starting corosync with the default configuration and then changing it? In that case, it seems to me that the proposed fix only happens to work by chance in this case. The real fix is to make sure that the state is properly cleaned. I'm not sure how to do that in packaging except to try to guide the user into somehow not following the broken installation flow. Therefore I'm soft-declining this SRU for now, but further discussion welcome if you disagree and I'll look again. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Changed in: charm-hacluster Milestone: None => 22.04 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
Backporting the default config change to Focal breaks pacemaker DEP-8 test. The fix for this can be tracked here: https://bugs.launchpad.net/ubuntu/+source/pacemaker/+bug/1968039 I created a separate bug to block this update in focal-proposed and avoid users updating the package because of a DEP-8 test fix. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Description changed: [Impact] Users upgrading from Bionic to Focal are getting a different default - node name, previously it was the hostname and now it is using a - hardcoded "node1". This issue was already fixed on Impish onward, so now - only Focal is using the hardcoded "node1" node name. + node name. The former is using the hostname (output of "$(uname -n)"), + and the latter uses a hardcoded name "node1". This issue was already + fixed on Impish onward, so now only Focal is using the hardcoded "node1" + node name. [Test Plan] $ lxc launch ubuntu-daily:focal corosync-sru $ lxc shell corosync-sru # apt update && apt upgrade -y # apt install -y corosync pacemaker crmsh # crm status Cluster Summary: - * Stack: corosync - * Current DC: corosync-sru (version 2.0.3-4b1f869f0f) - partition with quorum - * Last updated: Tue Apr 5 20:21:32 2022 - * Last change: Tue Apr 5 20:20:33 2022 by hacluster via crmd on corosync-sru - * 1 node configured - * 0 resource instances configured + * Stack: corosync + * Current DC: corosync-sru (version 2.0.3-4b1f869f0f) - partition with quorum + * Last updated: Tue Apr 5 20:21:32 2022 + * Last change: Tue Apr 5 20:20:33 2022 by hacluster via crmd on corosync-sru + * 1 node configured + * 0 resource instances configured Node List: - * Online: [ corosync-sru ] + * Online: [ corosync-sru ] Full List of Resources: - * No resources + * No resources In the 'Node List' section the node should be called 'corosync-sru' and not 'node1'. [Where problems could occur] This might be a problem if Focal users are already relying in the 'node1' node name, other than that I do not foresee any issue. [Original Message] Testing of masakari on focal zaza tests failed because the test checks that all pacemaker nodes are online. This check failed due the appearance of a new node called 'node1' which was marked as offline. I don't know where that node came from or what is supposed to represent but it seems like an unwanted change in behaviour. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Changed in: corosync (Ubuntu Focal) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Merge proposal linked: https://code.launchpad.net/~lucaskanashiro/ubuntu/+source/corosync/+git/corosync/+merge/418567 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Description changed: + [Impact] + + Users upgrading from Bionic to Focal are getting a different default + node name, previously it was the hostname and now it is using a + hardcoded "node1". This issue was already fixed on Impish onward, so now + only Focal is using the hardcoded "node1" node name. + + [Test Plan] + + $ lxc launch ubuntu-daily:focal corosync-sru + $ lxc shell corosync-sru + # apt update && apt upgrade -y + # apt install -y corosync pacemaker crmsh + # crm status + Cluster Summary: + * Stack: corosync + * Current DC: corosync-sru (version 2.0.3-4b1f869f0f) - partition with quorum + * Last updated: Tue Apr 5 20:21:32 2022 + * Last change: Tue Apr 5 20:20:33 2022 by hacluster via crmd on corosync-sru + * 1 node configured + * 0 resource instances configured + + Node List: + * Online: [ corosync-sru ] + + Full List of Resources: + * No resources + + In the 'Node List' section the node should be called 'corosync-sru' and + not 'node1'. + + [Where problems could occur] + + This might be a problem if Focal users are already relying in the + 'node1' node name, other than that I do not foresee any issue. + + [Original Message] + Testing of masakari on focal zaza tests failed because the test checks that all pacemaker nodes are online. This check failed due the appearance of a new node called 'node1' which was marked as offline. I don't know where that node came from or what is supposed to represent but it seems like an unwanted change in behaviour. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Changed in: corosync (Ubuntu Focal) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
Reviewed: https://review.opendev.org/c/openstack/charm-hacluster/+/834034 Committed: https://opendev.org/openstack/charm-hacluster/commit/d1191dbcabdfd8684a86825f06c6ede266ba93ba Submitter: "Zuul (22348)" Branch:master commit d1191dbcabdfd8684a86825f06c6ede266ba93ba Author: Billy Olsen Date: Wed Mar 16 06:50:28 2022 -0700 Render corosync.conf file prior to pkg install Starting in focal, the ubuntu version of corosync package synced in from debian includes node1 as the default name for the local node with a nodeid of 1. This causes the cluster to have knowledge of this extra node1 node, which affects quorum, etc. Installing the charm's corosync.conf file before package installation prevents this conditioning from happening. Additionally this change removes some Xenial bits in the charm and always includes a nodelist in corosync.conf as it is compulsory in focal and newer. It is optional in the bionic packages, so we'll always just render the nodelist. Change-Id: I06b9c23eb57274f0c99a3a05979c0cabf87c8118 Closes-Bug: #1874719 ** Changed in: charm-hacluster Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
Since this is already in Jammy, I am adding the backport of this fix to Focal to the Server team backlog and it should be tackled "soon". Also setting the Groovy task to Won't Fix because of the end of its standard support. ** Tags added: server-todo ** Changed in: corosync (Ubuntu Groovy) Status: Triaged => Won't Fix ** Changed in: corosync (Ubuntu Hirsute) Assignee: Lucas Kanashiro (lucaskanashiro) => (unassigned) ** Changed in: corosync (Ubuntu Groovy) Assignee: Lucas Kanashiro (lucaskanashiro) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
Fix proposed to branch: master Review: https://review.opendev.org/c/openstack/charm-hacluster/+/834034 ** Changed in: charm-hacluster Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
In the meantime, we keep having to add a post-deployment cleanup step to our deployment guides: Delete node1 crm resources (LP#1874719): $ juju run -m openstack --all -- sudo crm node delete node1 Which is overkill but works. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
Both DD's and Lucas' PoV has merits, imho. There's no right and wrong here. I would even prefer if we reduce the delta with Debian. However, hacluster charm should be handling this situation. There's nothing special here - corosync has specific behaviour out of the box. Charms should handle it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
The Hirsute Hippo has reached End of Life, so this bug will not be fixed for that release. ** Changed in: corosync (Ubuntu Hirsute) Status: Triaged => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
You are right, I did not backport the fix to the older LTS releases yet, it is still in my todo list. I was trying to convince the Debian maintainer to accept the change but he refused to do that. I was not willing to carry this as a delta and force us to do merges from now on, I'd prefer to keep it as a sync. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
Just to clarify, this is fixed in impish but is still a problem on older releases. Is that correct? And since the problem is fixed/fixable in corosync, this bug is probably invalid for charm-hacluster, right? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Merge proposal linked: https://code.launchpad.net/~mirespace/ubuntu/+source/corosync/+git/corosync/+merge/414116 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Merge proposal linked: https://code.launchpad.net/~mirespace/ubuntu/+source/corosync/+git/corosync/+merge/414030 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Merge proposal linked: https://code.launchpad.net/~lucaskanashiro/ubuntu/+source/corosync/+git/corosync/+merge/406171 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
This bug was fixed in the package corosync - 3.1.0-2ubuntu4 --- corosync (3.1.0-2ubuntu4) impish; urgency=medium * d/p/Make-the-example-config-valid.patch: comment out the node name in config file (LP: #1874719). With this, we will keep the same behavior as we have in Bionic which is using the output of "uname -n" as the node name. * d/t/quorumtool: search for localhost instead of node1. -- Lucas Kanashiro Thu, 17 Jun 2021 10:38:07 -0300 ** Changed in: corosync (Ubuntu) Status: Triaged => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1874719] Re: [SRU] Use the hostname as the node name instead of hardcoded 'node1'
** Merge proposal linked: https://code.launchpad.net/~lucaskanashiro/ubuntu/+source/corosync/+git/corosync/+merge/404328 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1874719 Title: [SRU] Use the hostname as the node name instead of hardcoded 'node1' To manage notifications about this bug go to: https://bugs.launchpad.net/charm-hacluster/+bug/1874719/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
