[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
I'm not able to create a python 3.7 virtualenv on ubuntu20 with python3-virtualenv 20.0.17-1ubuntu0.3 installed. Downgrading to 20.0.17-1 did the job. Probably this issue is introduced in this issue? virtualenv -p /home/laurens/projects/tcit/cpython/out/bin/python3 venv created virtual environment CPython3.7.10.final.0-64 in 63ms creator CPython3Posix(dest=/xxx/venv, clear=False, global=False) seeder FromAppData(download=False, pip=latest, setuptools=latest, wheel=latest, pkg_resources=latest, via=copy, app_data_dir=/home/laurens/.local/share/virtualenv/seed-app-data/v1.0.1.debian.1) activators BashActivator,CShellActivator,FishActivator,PowerShellActivator,PythonActivator,XonshActivator Traceback (most recent call last): File "/xxx/venv/bin/pip", line 5, in from pip._internal.cli.main import main File "/xxx/venv/lib/python3.7/site-packages/pip/_internal/cli/main.py", line 10, in from pip._internal.cli.autocompletion import autocomplete File "/xxx/venv/lib/python3.7/site-packages/pip/_internal/cli/autocompletion.py", line 9, in from pip._internal.cli.main_parser import create_main_parser File "/xxx/venv/lib/python3.7/site-packages/pip/_internal/cli/main_parser.py", line 7, in from pip._internal.cli import cmdoptions File "/xxx/venv/lib/python3.7/site-packages/pip/_internal/cli/cmdoptions.py", line 24, in from pip._internal.exceptions import CommandError File "/xxx/venv/lib/python3.7/site-packages/pip/_internal/exceptions.py", line 10, in from pip._vendor.six import iteritems ModuleNotFoundError: No module named 'pip._vendor.six' I've built python 3.7.10 from source because I'm running on a platform that uses 3.7 instead of the built-in 3.8. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
This bug was fixed in the package python-virtualenv - 20.0.17-1ubuntu0.3 --- python-virtualenv (20.0.17-1ubuntu0.3) focal; urgency=medium * Bump the seed-app-data version, because we changed the bundled wheels in LP: #1880749. -- Stefano Rivera Fri, 26 Feb 2021 18:09:22 -0800 ** Changed in: python-virtualenv (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
This bug was fixed in the package python-pip - 20.0.2-5ubuntu1.3 --- python-pip (20.0.2-5ubuntu1.3) focal; urgency=medium * Add Breaks: python3-virtualenv (<< 20.0.17-1ubuntu0.3) to python-pip-whl, which bumps the seed-app-data version. Our LP: #1880749 change broke existing seed-app-data caches. python-pip (20.0.2-5ubuntu1.2) focal; urgency=medium * Switch from vendoring pytoml to toml, following pep517's dependency. (LP: #1880749) * Use sys.base_prefix instead of sys.prefix in debundle.patch. Back-ported from 20.1-1 to allow virtualenvs to avoid needing to install pip's dependencies in new venvs. (LP: #1904945) -- Stefano Rivera Fri, 26 Feb 2021 18:38:56 -0800 ** Changed in: python-pip (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
Nobody has reported any more issues, and the tests we've got pass for me, so marking verification-done ** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
Hello Rick, or anyone else affected, Accepted python-virtualenv into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python- virtualenv/20.0.17-1ubuntu0.3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: python-virtualenv (Ubuntu Focal) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
Hello Rick, or anyone else affected, Accepted python-pip into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python- pip/20.0.2-5ubuntu1.3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Tags removed: verification-failed verification-failed-focal ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** No longer affects: python-pip (Ubuntu Groovy) ** No longer affects: python-virtualenv (Ubuntu) ** Also affects: python-virtualenv (Ubuntu) Importance: Undecided Status: New ** No longer affects: python-pip (Ubuntu Focal) ** Also affects: python-virtualenv (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: python-pip (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: python-pip (Ubuntu Focal) Status: New => Fix Committed ** Changed in: python-virtualenv (Ubuntu) Status: New => Fix Released ** Changed in: python-pip (Ubuntu) Importance: Undecided => Low ** Changed in: python-pip (Ubuntu Focal) Importance: Undecided => Low ** Changed in: python-virtualenv (Ubuntu) Importance: Undecided => Low ** Changed in: python-virtualenv (Ubuntu Focal) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** Patch added: "python-virtualenv_20.0.17-1ubuntu0.3.incremental.debdiff" https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1880749/+attachment/5467786/+files/python-virtualenv_20.0.17-1ubuntu0.3.incremental.debdiff ** Also affects: python-virtualenv (Ubuntu) Importance: Undecided Status: New ** Changed in: python-virtualenv (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** Patch added: "python-pip_20.0.2-5ubuntu1.3.incremental.debdiff" https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1880749/+attachment/5467785/+files/python-pip_20.0.2-5ubuntu1.3.incremental.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
After Rick's failed verification comment I had been wondering if we'd run into trouble with stale seed-app-data, and yes we have 2 different regressions: 1. The new python-pip-whl breaks new virtualenv creation if you have existing seed-app-data. This was James's issue. Traceback ends with: File "lib/python3.8/site-packages/pip/_internal/pyproject.py", line 8, in from pip._vendor import pytoml, six ImportError: cannot import name 'pytoml' from 'pip._vendor' (lib/python3.8/site-packages/pip/_vendor/__init__.py) 2. The new virtualenv breaks new virtualenv creation if you have existing seed-app-data. File "lib/python3.8/site-packages/pip/_internal/exceptions.py", line 10, in from pip._vendor.six import iteritems ModuleNotFoundError: No module named 'pip._vendor.six' Attached is my script to reproduce. This is all pretty horrible. I'm tempted to patch out seed-app-data entirely for our use-case. But I see the whole seed-app-data mechanism was re-done in 20.0.24, hopefully it will be more friendly to patching... My solution is: 1. Bump the seed-app-data version in python3-virtualenv, to cache-bust. 2. Add a Breaks: python3-virtualenv (<< 20.0.17-1ubuntu0.3) (the version in 1) to the new python-pip-whl. ** Attachment added: "Reproducer script" https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1880749/+attachment/5467765/+files/upgrade.sh -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
Thank you for flagging this regression. @Stefano, can you take a look at these issues? I think we might need to drop this update from -proposed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
Full error in attached logfile -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
I've marked the verification tags as 'failed' as releasing this update to -updates will have a major impact on charm deployments on focal. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** Attachment added: "pip-failures.log" https://bugs.launchpad.net/pip/+bug/1880749/+attachment/5464096/+files/pip-failures.log -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
We have -proposed enabled in one of our focal OpenStack deployments and this update appears to have regressed the setup of virtualenv's for reactive charms (which ship with a wheelhouse of python module dependencies including pip) - we see this error as new charms attempt to setup a venv using pip: ImportError: cannot import name 'pytoml' from 'pip._vendor' Downgrading the python3-pip + hard versioned depends resolves this issue for us. ** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-failed verification-failed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
@Rick: Thanks for the response. A few things: 1. I don't think you're using the current wheels. Try with --clear-app-data (added to the SRU instructions in the description). 2. What this still doesn't tell me is how *pip* is impacted by this breakage. LP: #1904945 means that we won't expose pep517 to the virtualenv outside of pip, any more. So, pep517 being broken outside of pip wouldn't be an issue. ** Description changed: [Impact] * The pep517 module vendored in pip is missing its toml dependency. * No specific examples of what that breaks, but it seems worth fixing -while we deal with LP: #1912248. + while we deal with LP: #1912248. * This upload backports upstream's 20.1 patch, replacing pytoml with toml, following pep517. [Test Case] # apt install python3 virtualenv - # virtualenv -p python3 foo + # virtualenv --clear-app-data -p python3 foo # foo/bin/python -m pep517.build Note: ModuleNotFoundError: No module named 'toml' Ideally the virtualenv wouldn't even contain pep517, it would be internal to pip. See LP: #1904945 [Where problems could occur] * Anybody who was expecting pytoml to be installed in Ubuntu Focal virtualenvs will have their expectation broken. They really shouldn't be expecting that, though. [Original Bug Report] On a clean 20.04 machine (or container), observe the following: apt-get update apt-get install -y python3-virtualenv python3 -m virtualenv foo && source foo/bin/activate pip list You will notice there are a plethora of extra packages in the virtual environment that should not normally be there, resulting in a dirty virtual environment. The packages listed here are those that are bundled with pip: https://github.com/pypa/pip/tree/master/src/pip/_vendor To make matters worse, the latest release of pip bundles incompatible versions of libraries. The net result is that `pip install pep517` will show that it is already installed, and but `import pep517` will result in an ImportError. This problem has been fixed in the Debian Testing/Unstable python- virtualenv package. Could the Ubuntu package backport these fixes? This is blocking Ansible supporting 20.04 officially, since the dirty virtualenvs are causing our tests to fail. https://github.com/ansible/ansible/issues/69203 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** No longer affects: python-virtualenv (Ubuntu) ** No longer affects: python-virtualenv (Ubuntu Focal) ** No longer affects: python-virtualenv (Ubuntu Groovy) ** Bug watch removed: github.com/ansible/ansible/issues #69203 https://github.com/ansible/ansible/issues/69203 ** Project changed: virtualenv => pip -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/pip/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
> What is the impact of this? It seems to happily install PEP 517 packages as-is. @Stefano sorry for the delay here. Installing PEP517 packages is fine without the patch, but building them (building a wheel) is where the issue comes in. If you need a concrete example, download the .tar.gz of any project that is normally capable of producing wheels, such as 'sampleproject' from pypi (https://pypi.org/project/sampleproject/#files). Activate a fresh virtualenv, untar it the .tar.gz, cd into the project, and run: python -m pep517.build --binary --out-dir dist . Before the patch mentioned above, it will fail with: ModuleNotFoundError: No module named 'toml' The .deb's from the SRU above get us a step closer but seem to still have an issue/traceback (see attachment which includes the commands to reproduce). It looks to be due to the vendored pytoml being listed in `lib/python3.8/site-packages/pip/_vendor/__init__.py` in the virtualenv. Whereas doing similar steps in a ubuntu:20.10 container (and installing pep517 explicitly in the virtualenv) produces a successful result. ** Attachment added: "reproducer using latest SRU build above" https://bugs.launchpad.net/ubuntu/+source/python-virtualenv/+bug/1880749/+attachment/5462853/+files/pep517.build.out -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
Re-tried the armhf autopkgtest and it passed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
It's always a bit tricky reviewing SRUs without a visible user impact. But I would say that since the vendoring of pytoml instead of toml *is* a bug, let's get it included in the SRU for fixing the dirty venvs. I can't think of any use-cases this could break. Let's see how it goes. ** Changed in: python-pip (Ubuntu Focal) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** Description changed: [Impact] - * The pep517 module vendored in pip is missing its toml dependency. -This is used to ... - * An explanation of the effects of the bug on users and -justification for backporting the fix to the stable release. - * This upload backports upstream's 20.1 patch, replacing pytoml with -toml, following pep517. + * The pep517 module vendored in pip is missing its toml dependency. + * No specific examples of what that breaks, but it seems worth fixing +while we deal with LP: #1912248. + * This upload backports upstream's 20.1 patch, replacing pytoml with + toml, following pep517. [Test Case] # apt install python3 virtualenv - # virtualenv -p python3 foo + # virtualenv -p python3 foo # foo/bin/python -m pep517.build Note: ModuleNotFoundError: No module named 'toml' Ideally the virtualenv wouldn't even contain pep517, it would be internal to pip. See LP: #1904945 [Where problems could occur] - * Anybody who was expecting pytoml to be installed in Ubuntu Focal -virtualenvs will have their expectation broken. -They really shouldn't be expecting that, though. - + * Anybody who was expecting pytoml to be installed in Ubuntu Focal + virtualenvs will have their expectation broken. + They really shouldn't be expecting that, though. + [Original Bug Report] On a clean 20.04 machine (or container), observe the following: apt-get update apt-get install -y python3-virtualenv python3 -m virtualenv foo && source foo/bin/activate pip list You will notice there are a plethora of extra packages in the virtual environment that should not normally be there, resulting in a dirty virtual environment. The packages listed here are those that are bundled with pip: https://github.com/pypa/pip/tree/master/src/pip/_vendor To make matters worse, the latest release of pip bundles incompatible versions of libraries. The net result is that `pip install pep517` will show that it is already installed, and but `import pep517` will result in an ImportError. This problem has been fixed in the Debian Testing/Unstable python- virtualenv package. Could the Ubuntu package backport these fixes? This is blocking Ansible supporting 20.04 officially, since the dirty virtualenvs are causing our tests to fail. https://github.com/ansible/ansible/issues/69203 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
@Rick Elrod: It would be useful if you could describe something that's concretely broken by toml being missing? I haven't been able to trigger any issue, installing packages with pip. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** Patch added: "python-pip_20.0.2-5ubuntu1.2.debdiff" https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1880749/+attachment/5457222/+files/python-pip_20.0.2-5ubuntu1.2.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** Description changed: + [Impact] + + * The pep517 module vendored in pip is missing its toml dependency. +This is used to ... + * An explanation of the effects of the bug on users and +justification for backporting the fix to the stable release. + * This upload backports upstream's 20.1 patch, replacing pytoml with +toml, following pep517. + + [Test Case] + + # apt install python3 virtualenv + # virtualenv -p python3 foo + # foo/bin/python -m pep517.build + + Note: + ModuleNotFoundError: No module named 'toml' + + Ideally the virtualenv wouldn't even contain pep517, it would be + internal to pip. See LP: #1904945 + + [Where problems could occur] + + * Anybody who was expecting pytoml to be installed in Ubuntu Focal +virtualenvs will have their expectation broken. +They really shouldn't be expecting that, though. + + [Original Bug Report] + On a clean 20.04 machine (or container), observe the following: apt-get update apt-get install -y python3-virtualenv python3 -m virtualenv foo && source foo/bin/activate pip list You will notice there are a plethora of extra packages in the virtual environment that should not normally be there, resulting in a dirty virtual environment. The packages listed here are those that are bundled with pip: https://github.com/pypa/pip/tree/master/src/pip/_vendor To make matters worse, the latest release of pip bundles incompatible versions of libraries. The net result is that `pip install pep517` will show that it is already installed, and but `import pep517` will result in an ImportError. This problem has been fixed in the Debian Testing/Unstable python- virtualenv package. Could the Ubuntu package backport these fixes? This is blocking Ansible supporting 20.04 officially, since the dirty virtualenvs are causing our tests to fail. https://github.com/ansible/ansible/issues/69203 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** Also affects: python-pip (Ubuntu) Importance: Undecided Status: New ** Changed in: python-pip (Ubuntu Groovy) Status: New => Fix Released ** Changed in: python-pip (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1880749] Re: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs
** Changed in: virtualenv Status: Unknown => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1880749 Title: Ubuntu 20.04: virtualenv: pep517 requires toml, but it isn't bundled in venvs To manage notifications about this bug go to: https://bugs.launchpad.net/virtualenv/+bug/1880749/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
