[Bug 1883315] Re: Showing esm update as installable when esm is disabled
Ubuntu 20.10 (Groovy Gorilla) has reached end of life, so this bug will not be fixed for that specific release. ** Changed in: update-notifier (Ubuntu Groovy) Status: New => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
This bug was fixed in the package update-notifier - 3.168.14 --- update-notifier (3.168.14) xenial; urgency=medium * data/apt_check.py: - Add support to handle packages from ESM Apps in addition to ESM Infra and only display alerts if the distro is ESM. (LP: #1924766) - Do not display a count of ESM packages if the system does not have ESM enabled. (LP: #1883315) - Make distinction betweem standard security updates and ESM updates when performing package counts. (LP: #1926208) - use 'applied' instead of 'installed', redact 0 of these updates are security updates, and correct singular messages * debian/control: Add a dependency on python3-distro-info. -- Lucas Moura Tue, 20 Apr 2021 10:20:21 -0300 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
This bug was fixed in the package update-notifier - 3.192.30.7 --- update-notifier (3.192.30.7) focal; urgency=medium * data/apt_check.py: - Add support to handle packages from ESM Apps in addition to ESM Infra and only display alerts if the distro is ESM. (LP: #1924766) - Do not display a count of ESM packages if the system does not have ESM enabled. (LP: #1883315) - Make distinction between standard security updates and ESM updates when performing package counts. (LP: #1926208) - use 'applied' instead of 'installed', redact 0 of these updates are security updates, and correct singular messages * data/backend_helper.py: - fix pyflakes test * debian/control: Add a dependency on python3-distro-info. -- Lucas Moura Thu, 22 Apr 2021 18:56:22 -0300 ** Changed in: update-notifier (Ubuntu Focal) Status: Fix Committed => Fix Released ** Changed in: update-notifier (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
This bug was fixed in the package update-notifier - 3.192.1.10 --- update-notifier (3.192.1.10) bionic; urgency=medium * data/apt_check.py: - Add support to handle packages from ESM Apps in addition to ESM Infra and only display alerts if the distro is ESM. (LP: #1924766) - Do not display a count of ESM packages if the system does not have ESM enabled. (LP: #1883315) - Make distinction between standard security updates and ESM updates when performing package counts. (LP: #1926208) - use 'applied' instead of 'installed', redact 0 of these updates are security updates, and correct singular messages * debian/control: Add a dependency on python3-distro-info. -- Lucas Moura Thu, 22 Apr 2021 18:39:19 -0300 ** Changed in: update-notifier (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
This bug was fixed in the package update-notifier - 3.192.40.1 --- update-notifier (3.192.40.1) hirsute; urgency=medium [ Lucas Moura ] * data/apt_check.py: - Add support to handle packages from ESM Apps in addition to ESM Infra and only display alerts if the distro is ESM. (LP: #1924766) - Do not display a count of ESM packages if the system does not have ESM enabled. (LP: #1883315) - Make distinction between standard security updates and ESM updates when performing package counts. (LP: #1926208) - use 'applied' instead of 'installed', redact 0 of these updates are security updates, and correct singular messages * debian/control: Add a dependency on python3-distro-info. -- Chad Smith Thu, 22 Apr 2021 17:47:19 -0600 ** Changed in: update-notifier (Ubuntu Hirsute) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
This bug was fixed in the package update-notifier - 3.192.41 --- update-notifier (3.192.41) impish; urgency=medium [ Lucas Moura ] * data/apt_check.py: - Add support to handle packages from ESM Apps in addition to ESM Infra and only display alerts if the distro is ESM. (LP: #1924766) - Do not display a count of ESM packages if the system does not have ESM enabled. (LP: #1883315) - Make distinction between standard security updates and ESM updates when performing package counts. (LP: #1926208) - use 'applied' instead of 'installed', redact 0 of these updates are security updates, and correct singular messages * debian/control: Add a dependency on python3-distro-info. -- Chad Smith Thu, 22 Apr 2021 17:47:19 -0600 ** Changed in: update-notifier (Ubuntu Impish) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
By reusing the same script in this launchpad bug: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1924766 I can confirm that the xenial, bionic, focal and hirsute proposed packages are working as expected ** Tags removed: verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute verification-needed-xenial ** Tags added: verification-done verification-done-bionic verification-done-focal verification-done-hirsute verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
Hello Andreas, or anyone else affected, Accepted update-notifier into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update- notifier/3.168.14 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-xenial. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: update-notifier (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
Hello Andreas, or anyone else affected, Accepted update-notifier into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update- notifier/3.192.40.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: update-notifier (Ubuntu Hirsute) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-hirsute -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
** Merge proposal linked: https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401826 ** Merge proposal linked: https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401662 ** Merge proposal linked: https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401657 ** Merge proposal linked: https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401653 ** Merge proposal linked: https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/401473 ** Changed in: update-notifier (Ubuntu Bionic) Status: New => In Progress ** Changed in: update-notifier (Ubuntu Focal) Status: New => In Progress ** Changed in: update-notifier (Ubuntu Hirsute) Status: New => In Progress ** Changed in: update-notifier (Ubuntu Impish) Status: New => In Progress ** Changed in: update-notifier (Ubuntu Bionic) Importance: Undecided => High ** Changed in: update-notifier (Ubuntu Focal) Importance: Undecided => High ** Changed in: update-notifier (Ubuntu Hirsute) Importance: Undecided => High ** Changed in: update-notifier (Ubuntu Impish) Importance: Undecided => High ** Description changed: - I came across a scenario where the output of `/usr/lib/update-notifier - /apt-check --human-readable` is showing some (not all) esm updates as - being installable when esm itself is disabled: + [Impact] + when users are getting the message update-notifier message through apt-check they may find inconsistent behavior regarding ESM products. This is misleading since we will say to the users that they don't have ESM Infra, but they do have ESM infra packages that can be installed. This is poor marketing of our products + + [Test case] + + To reproduce the issue, you can: + + 1. Launch the following old version of a xenial container: +lxc launch ubuntu:f4c4c60a6b752a381288ae72a1689a9da00f8e03b732c8d1b8a8fcd1a8890800 dev-x + + 2. Run apt update and install the updated version of update-notifier-common + 3. Add the ubuntu-advantage-tools ppa: +https://code.launchpad.net/~ua-client/+archive/ubuntu/daily + 4. Install ubuntu-advantage-tools + 5. Install the latest version of uaclient from the stable ppa: +https://launchpad.net/~ua-client/+archive/ubuntu/stable/ + 6. Comment out all mentions of xenial-security in /etc/apt/source.list + 7. Run apt update + 8. Run /usr/lib/update-notifier/apt-check --human-readable + 9. See a message like this: + + UA Infra: Extended Security Maintenance (ESM) is not enabled. + + 256 packages can be updated. + 5 of these updates are fixed through UA Infra: ESM. + 5 of these updates are security updates. + To see these additional updates run: apt list --upgradable + + Enable UA Infra: ESM to receive 5 additional security updates. + See https://ubuntu.com/security/esm or run: sudo ua status + + + To verify that the error is fixed: + + 1.Perform all the stages above until step 8 + 2 Install the new update-notifier from this ppa: + https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa + 3. Run /usr/lib/update-notifier/apt-check --human-readable + 4. See a message like this: + + 256 updates can be installed immediately. + 5 of these updates are security updates. + To see these additional updates run: apt list --upgradable + + 5. We are now only showing ESM infra specific message if the distro is + ESM. To enforce that behavior, make the `is_esm_distro` function in + `/usr/lub/update-notifier/apt-check` return True, then you will see this + message: + + UA Infra: Extended Security Maintenance (ESM) is not enabled. + + 256 updates can be installed immediately. + 5 of these updates are security updates. + To see these additional updates run: apt list --upgradable + + 5 additional security updates can be applied with UA Infra: ESM + Learn more about enabling UA Infra: ESM service at https://ubuntu.com/esm + + That is now correct. + + [Where problems could occur] + + The changes in this package should only be seen when MOTD is getting a + new message. If that script fails for some reason, it seems that MOTD + will only not present the message, which is doesn't seem to be a system + critical issue. Additionally, we would potentially have tracebacks in + the update-notifier logs. Finally, if the logic is also incorrect, we + would be displying incorrect ESM messages to the user. But since we are + doing this now, as this bug shows, I don't think this is critical as + well. + + [Discussion] + + With ESM Apps going to production soon, we have decided to update the + messages delivered by update-notifier apt-check to address the package + count of ESM Apps and the possibility of installing more upgrades if the + user has ESM Apps disabled. + + We are also updating other parts of the messaging as well. First, we only
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
** Changed in: update-notifier (Ubuntu Bionic) Assignee: (unassigned) => Lucas Albuquerque Medeiros de Moura (lamoura) ** Changed in: update-notifier (Ubuntu Focal) Assignee: (unassigned) => Lucas Albuquerque Medeiros de Moura (lamoura) ** Changed in: update-notifier (Ubuntu Hirsute) Assignee: (unassigned) => Chad Smith (chad.smith) ** Changed in: update-notifier (Ubuntu Impish) Assignee: (unassigned) => Chad Smith (chad.smith) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
** Also affects: update-notifier (Ubuntu Impish) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
** Changed in: update-notifier (Ubuntu Xenial) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
** Changed in: update-notifier (Ubuntu Xenial) Assignee: (unassigned) => Lucas Albuquerque Medeiros de Moura (lamoura) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
[Impact] when users are getting the message update-notifier message through apt-check they may find inconsistent behavior regarding ESM products. This is misleading since we will say to the users that they don't have ESM Infra, but they do have ESM infra packages that can be installed. This is poor marketing of our products [Test case] To reproduce the issue, you can: 1. Launch the following old version of a xenial container: lxc launch ubuntu:f4c4c60a6b752a381288ae72a1689a9da00f8e03b732c8d1b8a8fcd1a8890800 dev-x 2. Run apt update and install the updated version of update-notifier-common 3. Add the ubuntu-advantage-tools ppa: https://code.launchpad.net/~ua-client/+archive/ubuntu/daily 4. Install ubuntu-advantage-tools 5. Install the latest version of uaclient from the stable ppa: https://launchpad.net/~ua-client/+archive/ubuntu/stable/ 6. Comment out all mentions of xenial-security in /etc/apt/source.list 7. Run apt update 8. Run /usr/lib/update-notifier/apt-check --human-readable 9. See a message like this: UA Infra: Extended Security Maintenance (ESM) is not enabled. 256 packages can be updated. 5 of these updates are fixed through UA Infra: ESM. 5 of these updates are security updates. To see these additional updates run: apt list --upgradable Enable UA Infra: ESM to receive 5 additional security updates. See https://ubuntu.com/security/esm or run: sudo ua status To verify that the error is fixed: 1.Perform all the stages above until step 8 2 Install the new update-notifier from this ppa: https://launchpad.net/~lamoura/+archive/ubuntu/update-notifier-test-ppa 3. Run /usr/lib/update-notifier/apt-check --human-readable 4. See a message like this: 256 updates can be installed immediately. 5 of these updates are security updates. To see these additional updates run: apt list --upgradable 5. We are now only showing ESM infra specific message if the distro is ESM. To enforce that behavior, make the `is_esm_distro` function in `/usr/lub/update-notifier/apt-check` return True, then you will see this message: UA Infra: Extended Security Maintenance (ESM) is not enabled. 256 updates can be installed immediately. 5 of these updates are security updates. To see these additional updates run: apt list --upgradable 5 additional security updates can be applied with UA Infra: ESM Learn more about enabling UA Infra: ESM service at https://ubuntu.com/esm That is now correct. [Where problems could occur] The changes in this package should only be seen when MOTD is getting a new message. If that script fails for some reason, it seems that MOTD will only not present the message, which is doesn't seem to be a system critical issue. Additionally, we would potentially have tracebacks in the update-notifier logs. Finally, if the logic is also incorrect, we would be displying incorrect ESM messages to the user. But since we are doing this now, as this bug shows, I don't think this is critical as well. [Discussion] With ESM Apps going to production soon, we have decided to update the messages delivered by update-notifier apt-check to address the package count of ESM Apps and the possibility of installing more upgrades if the user has ESM Apps disabled. We are also updating other parts of the messaging as well. First, we only display ESM Infra status on ESM distros. However, we will keep showing the ESM Infra package count on all of them. For ESM Apps, we are only performing the alerts (For example, that you might have x packages updates if ESM Apps is installed) if the user is on a LTS distro. Since we going to perform that change, we decided to also address this bit in the SRU, since it could harm the message we are delivering -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1883315] Re: Showing esm update as installable when esm is disabled
** Also affects: update-notifier (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: update-notifier (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: update-notifier (Ubuntu Hirsute) Importance: Undecided Status: New ** Also affects: update-notifier (Ubuntu Groovy) Importance: Undecided Status: New ** Also affects: update-notifier (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: update-notifier (Ubuntu Xenial) Status: New => Triaged ** Changed in: update-notifier (Ubuntu Xenial) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1883315 Title: Showing esm update as installable when esm is disabled To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/update-notifier/+bug/1883315/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
