[Bug 1887144] Re: autopkgtest failures on ppc64el with nodejs 12.18.1
Some progress: running one of the failing tests through nodejs with the --no-opt flag (for no optimizations) makes it consistently pass. It looks like V8 is optimizing too aggressively, and incorrectly. I can observe that when values start diverging, ft() is being called with s===2, and despite that the "other" code path is run (return b ^ c ^ d). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887144 Title: autopkgtest failures on ppc64el with nodejs 12.18.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1887144] Re: autopkgtest failures on ppc64el with nodejs 12.18.1
Some notes while I continue investigating the problem: - while I used the last test in test/test.js to highlight the problem, it isn't the only one that is failing - both sha.js and sha1.js are affected (unsurprisingly, as they have very similar implementations), other algorithms (sha224, sha256, sha384 and sha512) behave correctly - I don't have a good understanding of what's going on yet, but successive calls to the update() method on the hash object start diverging values when calling ft(s, b, c, d), and the divergence happens only when s === 2. Inlining the function doesn't fix the problem. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887144 Title: autopkgtest failures on ppc64el with nodejs 12.18.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1887144] Re: autopkgtest failures on ppc64el with nodejs 12.18.1
Unfortunately no, the patch doesn't affect the outcome of tests on ppc64el (I did try reverting it, and the problem has also been reported upstream, which doesn't carry the patch). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887144 Title: autopkgtest failures on ppc64el with nodejs 12.18.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1887144] Re: autopkgtest failures on ppc64el with nodejs 12.18.1
Could it have anything to do with the patch being applied in node- sha.js, 0002-Fix-FTBFS-in-32-bits-arch.patch? var hash = new Sha1() - var bigData = Buffer.alloc(0x1 / 8) + var bigData = Buffer.alloc(0x1fff8 / 8) I wonder if this patch were disabled for ppc64el, if the test would then pass? If so, then perhaps the patch needs to test if its uint32 or uint64 first. (There appears to be code doing a 32/64 support check in hash.js' Hash.prototype.digest that might be pertinent.) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887144 Title: autopkgtest failures on ppc64el with nodejs 12.18.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1887144] Re: autopkgtest failures on ppc64el with nodejs 12.18.1
(the above comment applies to the last test in test/test.js with the label "call digest for more than MAX_UINT32 bits of data". -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887144 Title: autopkgtest failures on ppc64el with nodejs 12.18.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1887144] Re: autopkgtest failures on ppc64el with nodejs 12.18.1
Added some logging to the Sha1._update() method which is called repeatedly, and the problem doesn't appear to be deterministic: it doesn't always start diverging at the same place (although it's always early, within the first 100 iterations). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887144 Title: autopkgtest failures on ppc64el with nodejs 12.18.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1887144] Re: autopkgtest failures on ppc64el with nodejs 12.18.1
** Description changed: Since nodejs 12.18.1 entered groovy-proposed, autopkgtests that rely on - node-sha to compute SHA-1 hashes started failing reliably on ppc64el. + node-sha.js to compute SHA-1 hashes started failing reliably on ppc64el. This affects the following packages: - node-sha.js - node-crypto-browserify - node-create-hash Other architectures do not appear to be affected, and it's only the SHA-1 hashes that are incorrect, other hashing algorithm are not affected. For reference, I'm attaching the full log for the last failed run of node-create-hash on ppc64el (see https://autopkgtest.ubuntu.com/packages/n/node-create- hash/groovy/ppc64el). Upstream bug report: https://github.com/crypto- browserify/sha.js/issues/66 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887144 Title: autopkgtest failures on ppc64el with nodejs 12.18.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1887144] Re: autopkgtest failures on ppc64el with nodejs 12.18.1
** Package changed: node-sha (Ubuntu) => node-sha.js (Ubuntu) ** Description changed: Since nodejs 12.18.1 entered groovy-proposed, autopkgtests that rely on node-sha to compute SHA-1 hashes started failing reliably on ppc64el. This affects the following packages: - - node-sha - - node-crypto-browserify - - node-create-hash + - node-sha.js + - node-crypto-browserify + - node-create-hash Other architectures do not appear to be affected, and it's only the SHA-1 hashes that are incorrect, other hashing algorithm are not affected. For reference, I'm attaching the full log for the last failed run of node-create-hash on ppc64el (see https://autopkgtest.ubuntu.com/packages/n/node-create- hash/groovy/ppc64el). Upstream bug report: https://github.com/crypto- browserify/sha.js/issues/66 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887144 Title: autopkgtest failures on ppc64el with nodejs 12.18.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1887144] Re: autopkgtest failures on ppc64el with nodejs 12.18.1
And testing in a ppc64el cloud instance, I reverted nodejs to 10.19.0 ~dfsg-3ubuntu1 and the tests reliably pass. This confirms that something in node-sha broke with the update to nodejs 12.18.1~dfsg-1ubuntu1. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1887144 Title: autopkgtest failures on ppc64el with nodejs 12.18.1 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/node-create-hash/+bug/1887144/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
