[Bug 1896638] Re: Path to swapfile doesn't use a static device path
The Groovy Gorilla has reached end of life, so this bug will not be fixed for that release ** Changed in: hibagent (Ubuntu Groovy) Status: New => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
Hibagent is affected as well. https://github.com/aws/ec2-hibernate-linux-agent/issues/8 ** Also affects: hibagent (Ubuntu) Importance: Undecided Status: New ** Bug watch added: github.com/aws/ec2-hibernate-linux-agent/issues #8 https://github.com/aws/ec2-hibernate-linux-agent/issues/8 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
This bug was fixed in the package ec2-hibinit-agent - 1.0.0-0ubuntu4~18.04.5 --- ec2-hibinit-agent (1.0.0-0ubuntu4~18.04.5) bionic; urgency=medium * Always set resume device by PARTUUID instead of by device name. Based on patch by Francis Ginther. (LP: #1896638) -- Balint Reczey Tue, 03 Nov 2020 19:41:35 +0100 ** Changed in: ec2-hibinit-agent (Ubuntu Bionic) Status: Fix Committed => Fix Released ** Changed in: ec2-hibinit-agent (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
This bug was fixed in the package ec2-hibinit-agent - 1.0.0-0ubuntu4~16.04.4 --- ec2-hibinit-agent (1.0.0-0ubuntu4~16.04.4) xenial; urgency=medium * Always set resume device by PARTUUID instead of by device name. Based on patch by Francis Ginther. (LP: #1896638) -- Balint Reczey Tue, 03 Nov 2020 19:43:33 +0100 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
Verified 1.0.0-0ubuntu4~18.04.5 on Bionic: ubuntu@ip-172-31-0-42:~$ dpkg -l ec2-hibinit-agent | cat Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name VersionArchitecture Description +++-=-==--= ii ec2-hibinit-agent 1.0.0-0ubuntu4~18.04.5 all Amazon EC2 hibernation agent ubuntu@ip-172-31-0-42:~$ service hibinit-agent status ● hibinit-agent.service - EC2 instance hibernation setup agent Loaded: loaded (/lib/systemd/system/hibinit-agent.service; enabled; vendor preset: enabled) Active: inactive (dead) since Fri 2020-11-20 18:26:20 UTC; 2min 18s ago Docs: file:/usr/share/doc/ec2-hibinit-agent/README Main PID: 3496 (code=exited, status=0/SUCCESS) Nov 20 18:26:20 ip-172-31-0-42 hibinit-agent[20133]: Will check if swap is at least: 4000 megabytes Nov 20 18:26:20 ip-172-31-0-42 hibinit-agent[20133]: There's sufficient swap available (have 4194304000, need 4194304000) Nov 20 18:26:20 ip-172-31-0-42 hibinit-agent[20133]: Running: swapon /swap-hibinit Nov 20 18:26:20 ip-172-31-0-42 hibinit-agent[20133]: Updating the kernel offset for the swapfile: /swap-hibinit Nov 20 18:26:20 ip-172-31-0-42 hibinit-agent[20133]: Updating GRUB to use the device PARTUUID=e9adeae8-01 with offset 362496 for resume Nov 20 18:26:20 ip-172-31-0-42 hibinit-agent[20133]: GRUB configuration is updated Nov 20 18:26:20 ip-172-31-0-42 hibinit-agent[20133]: Setting swap device to 51713 with offset 362496 Nov 20 18:26:20 ip-172-31-0-42 hibinit-agent[20133]: Done updating the swap offset. Turning swapoff Nov 20 18:26:20 ip-172-31-0-42 hibinit-agent[20133]: Running: swapoff /swap-hibinit Nov 20 18:26:20 ip-172-31-0-42 systemd[1]: Started EC2 instance hibernation setup agent. ubuntu@ip-172-31-0-42:~$ cat /etc/default/grub.d/99-set-swap.cfg GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT no_console_suspend=1 resume_offset=362496 resume=PARTUUID=e9adeae8-01" ubuntu@ip-172-31-0-42:~$ Verified 1.0.0-0ubuntu4~16.04.4 on Xenial: ubuntu@ip-172-31-13-97:~$ dpkg -l ec2-hibinit-agent | cat Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name VersionArchitecture Description +++-=-==--= ii ec2-hibinit-agent 1.0.0-0ubuntu4~16.04.4 all Amazon EC2 hibernation agent ubuntu@ip-172-31-13-97:~$ service hibinit-agent status ● hibinit-agent.service - EC2 instance hibernation setup agent Loaded: loaded (/lib/systemd/system/hibinit-agent.service; enabled; vendor preset: enabled) Active: inactive (dead) since Fri 2020-11-20 18:15:31 UTC; 12min ago Docs: file:/usr/share/doc/ec2-hibinit-agent/README Main PID: 10521 (code=exited, status=0/SUCCESS) Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: Allocating 4194304000 bytes in /swap-hibinit Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: Swap pre-heating is skipped, the swap blocks won't be touched during to ensure they are ready Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: Running: mkswap /swap-hibinit Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: Running: swapon /swap-hibinit Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: Updating the kernel offset for the swapfile: /swap-hibinit Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: Updating GRUB to use the device PARTUUID=1c2bf25c-01 with offset 509952 for resume Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: GRUB configuration is updated Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: Setting swap device to 51713 with offset 509952 Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: Done updating the swap offset. Turning swapoff Nov 20 18:15:31 ip-172-31-13-97 hibinit-agent[10516]: Running: swapoff /swap-hibinit ubuntu@ip-172-31-13-97:~$ cat /etc/default/grub.d/99-set-swap.cfg GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT no_console_suspend=1 resume_offset=509952 resume=PARTUUID=1c2bf25c-01" ubuntu@ip-172-31-13-97:~$ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
For the record with the not fixed packages: ubuntu@ip-172-31-0-42:~$ cat /etc/default/grub.d/99-set-swap.cfg GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT no_console_suspend=1 resume_offset=1716224 resume=/dev/xvda1" ubuntu@ip-172-31-0-42:~$ dpkg -l ec2-hibinit-agent Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-=-===-===- ii ec2-hibinit-agent 1.0.0-0ubuntu4~18.04.4 all Amazon EC2 hibernation agent ubuntu@ip-172-31-13-97:~$ cat /etc/default/grub.d/99-set-swap.cfg GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT no_console_suspend=1 resume_offset=1652736 resume=/dev/xvda1" ubuntu@ip-172-31-13-97:~$ dpkg -l ec2-hibinit-agent Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description +++-=-===-===- ii ec2-hibinit-agent 1.0.0-0ubuntu4~16.04.3 all Amazon EC2 hibernation agent ** Tags removed: verification-needed verification-needed-bionic verification-needed-xenial ** Tags added: verification-done verification-done-bionic verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
This bug was fixed in the package ec2-hibinit-agent - 1.0.0-0ubuntu9.1 --- ec2-hibinit-agent (1.0.0-0ubuntu9.1) focal; urgency=medium * Disable suspending the system (LP: #1898087) * Always set resume device by PARTUUID instead of by device name. Based on patch by Francis Ginther. (LP: #1896638) -- Balint Reczey Fri, 02 Oct 2020 18:07:48 +0200 ** Changed in: ec2-hibinit-agent (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
Hello Francis, or anyone else affected, Accepted ec2-hibinit-agent into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ec2 -hibinit-agent/1.0.0-0ubuntu4~18.04.5 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: ec2-hibinit-agent (Ubuntu Bionic) Status: Confirmed => Fix Committed ** Tags removed: verification-done ** Tags added: verification-needed verification-needed-bionic ** Changed in: ec2-hibinit-agent (Ubuntu Xenial) Status: Confirmed => Fix Committed ** Tags added: verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
I ran this through our automated hibernation testing. On spot checking the logs, I do see the resume path being set to the PARTUUID as expected by this SRU. I consider this to cover `verification-done-focal` for our testing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
Verified 1.0.0-0ubuntu9.1 on Focal: ubuntu@ip-172-31-1-183:~$ sudo apt purge ec2-hibinit-agent Reading package lists... Done Building dependency tree Reading state information... Done The following packages will be REMOVED: ec2-hibinit-agent* 0 upgraded, 0 newly installed, 1 to remove and 22 not upgraded. After this operation, 65.5 kB disk space will be freed. Do you want to continue? [Y/n] (Reading database ... 87759 files and directories currently installed.) Removing ec2-hibinit-agent (1.0.0-0ubuntu9) ... (Reading database ... 87744 files and directories currently installed.) Purging configuration files for ec2-hibinit-agent (1.0.0-0ubuntu9) ... Sourcing file `/etc/default/grub' Sourcing file `/etc/default/grub.d/40-force-partuuid.cfg' Sourcing file `/etc/default/grub.d/50-cloudimg-settings.cfg' Sourcing file `/etc/default/grub.d/init-select.cfg' Generating grub configuration file ... Found linux image: /boot/vmlinuz-5.4.0-1029-aws Found initrd image: /boot/initrd.img-5.4.0-1029-aws Found linux image: /boot/vmlinuz-5.4.0-1024-aws Found initrd image: /boot/initrd.img-5.4.0-1024-aws Found Ubuntu 20.04.1 LTS (20.04) on /dev/xvda1 done ubuntu@ip-172-31-1-183:~$ sudo apt install ec2-hibinit-agent Reading package lists... Done Building dependency tree Reading state information... Done The following NEW packages will be installed: ec2-hibinit-agent 0 upgraded, 1 newly installed, 0 to remove and 22 not upgraded. Need to get 11.5 kB of archives. After this operation, 66.6 kB of additional disk space will be used. Get:1 http://us-east-2.ec2.archive.ubuntu.com/ubuntu focal-proposed/main amd64 ec2-hibinit-agent all 1.0.0-0ubuntu9.1 [11.5 kB] Fetched 11.5 kB in 0s (297 kB/s) Selecting previously unselected package ec2-hibinit-agent. (Reading database ... 87738 files and directories currently installed.) Preparing to unpack .../ec2-hibinit-agent_1.0.0-0ubuntu9.1_all.deb ... Unpacking ec2-hibinit-agent (1.0.0-0ubuntu9.1) ... Setting up ec2-hibinit-agent (1.0.0-0ubuntu9.1) ... Created symlink /etc/systemd/system/multi-user.target.wants/hibinit-agent.service → /lib/systemd/system/hibinit-agent.service. ubuntu@ip-172-31-1-183:~$ service hibinit-agent status ● hibinit-agent.service - EC2 instance hibernation setup agent Loaded: loaded (/lib/systemd/system/hibinit-agent.service; enabled; vendor preset: enabled) Active: inactive (dead) since Thu 2020-10-29 20:14:43 UTC; 15s ago Docs: file:/usr/share/doc/ec2-hibinit-agent/README Main PID: 29451 (code=exited, status=0/SUCCESS) Oct 29 20:14:43 ip-172-31-1-183 hibinit-agent[29451]: Swap pre-heating is skipped, the swap blocks won't be touched during to ensure they are ready Oct 29 20:14:43 ip-172-31-1-183 hibinit-agent[29451]: Running: mkswap /swap-hibinit Oct 29 20:14:43 ip-172-31-1-183 hibinit-agent[29451]: Running: swapon /swap-hibinit Oct 29 20:14:43 ip-172-31-1-183 hibinit-agent[29451]: Updating the kernel offset for the swapfile: /swap-hibinit Oct 29 20:14:43 ip-172-31-1-183 hibinit-agent[29451]: Updating GRUB to use the device PARTUUID=a2f52878-01 with offset 1687552 for resume Oct 29 20:14:43 ip-172-31-1-183 hibinit-agent[29451]: GRUB configuration is updated Oct 29 20:14:43 ip-172-31-1-183 hibinit-agent[29451]: Setting swap device to 51713 with offset 1687552 Oct 29 20:14:43 ip-172-31-1-183 hibinit-agent[29451]: Done updating the swap offset. Turning swapoff Oct 29 20:14:43 ip-172-31-1-183 hibinit-agent[29451]: Running: swapoff /swap-hibinit Oct 29 20:14:43 ip-172-31-1-183 systemd[1]: hibinit-agent.service: Succeeded. ubuntu@ip-172-31-1-183:~$ date Thu Oct 29 20:15:13 UTC 2020 ubuntu@ip-172-31-1-183:~$ cat /etc/default/grub.d/99-set-swap.cfg GRUB_CMDLINE_LINUX_DEFAULT="$GRUB_CMDLINE_LINUX_DEFAULT no_console_suspend=1 resume_offset=1687552 resume=PARTUUID=a2f52878-01" ubuntu@ip-172-31-1-183:~$ ** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
Hello Francis, or anyone else affected, Accepted ec2-hibinit-agent into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ec2 -hibinit-agent/1.0.0-0ubuntu9.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: ec2-hibinit-agent (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
I've uploaded the fix for Focal. ** Changed in: ec2-hibinit-agent (Ubuntu Focal) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
** Description changed: [Impact] * Using the device name on the kernel cmdline in the resume= option leads to failure to resume from hibernation when the device name is not stable, which can be the case for nvme drives. [Test Case] * Set up an EC2 instance to allow hibernation * Wait for hibinit-agent.service fully started * /etc/default/grub.d/99-set-swap.cfg should refer to the resume= partition by PARTUUID [Regression Potential] * Failure to discover PARTUUID makes the system unable to resume. A potential crash would cause the system unable to set up hibernation or - unable to resume. + unable to resume. (On Focal PARTUUID is already in use, even without + this fix.) [Original Bug Text] When the agent inserts the resume device path and offset into the kernel cmdline, it uses device names such as the following: `resume_offset=223232 resume=/dev/nvme1n1p1` The issue is that `/dev/nvme1n1p1` is not static. On the reboot, the block device may appear at `/dev/nvme0n1p1` resulting in failure to find the swapfile used to suspend. The solution should be to use a persistent block device naming scheme. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
** Description changed: + [Impact] + + * Using the device name on the kernel cmdline in the resume= option + leads to failure to resume from hibernation when the device name is not + stable, which can be the case for nvme drives. + + [Test Case] + + * Set up an EC2 instance to allow hibernation + * Wait for hibinit-agent.service fully started + * /etc/default/grub.d/99-set-swap.cfg should refer to the resume= partition by PARTUUID + + [Regression Potential] + + * Failure to discover PARTUUID makes the system unable to resume. A + potential crash would cause the system unable to set up hibernation or + unable to resume. + + [Original Bug Text] + When the agent inserts the resume device path and offset into the kernel cmdline, it uses device names such as the following: `resume_offset=223232 resume=/dev/nvme1n1p1` The issue is that `/dev/nvme1n1p1` is not static. On the reboot, the block device may appear at `/dev/nvme0n1p1` resulting in failure to find the swapfile used to suspend. The solution should be to use a persistent block device naming scheme. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
This bug was fixed in the package ec2-hibinit-agent - 1.0.0-0ubuntu11 --- ec2-hibinit-agent (1.0.0-0ubuntu11) groovy; urgency=medium * Disable suspending the system (LP: #1898087) * Always set resume device by PARTUUID instead of by device name. Based on patch by Francis Ginther. (LP: #1896638) -- Balint Reczey Wed, 14 Oct 2020 20:49:52 +0200 ** Changed in: ec2-hibinit-agent (Ubuntu Groovy) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
** Changed in: ec2-hibinit-agent (Ubuntu Xenial) Status: New => Confirmed ** Changed in: ec2-hibinit-agent (Ubuntu Groovy) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
** Changed in: ec2-hibinit-agent (Ubuntu Focal) Status: New => Invalid ** Changed in: ec2-hibinit-agent (Ubuntu Groovy) Status: New => Invalid ** Changed in: ec2-hibinit-agent (Ubuntu Bionic) Status: New => Confirmed ** Changed in: ec2-hibinit-agent (Ubuntu Focal) Status: Invalid => Confirmed ** Changed in: ec2-hibinit-agent (Ubuntu Groovy) Status: Invalid => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
I've updated the find_device_for_file() function in /usr/bin/hibinit-
agent to:
def find_device_for_file(filename):
# Find the mount point for the swap file ('df -P /swap')
df_out = check_output(['df', '-P', filename]).decode('ascii')
dev_str = df_out.split("\n")[1].split()[0]
lsblk_out = check_output(['lsblk', '-dno', 'PARTUUID',
dev_str]).decode('ascii')
uuid_str = lsblk_out.strip()
return "PARTUUID=%s" % (uuid_str)
I've tested this on xenial and bionic. With xenial, I would see 2-3% failures
on certain instance types due to this issue. Now I see none.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1896638
Title:
Path to swapfile doesn't use a static device path
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
I was unable to get either the by-uuid or by-label paths to work in my initial hacking. The kernel cmdline looked like what I would expect, for example '... resume_offset=225280 resume=/dev/disk/by-label/cloudimg- rootfs', but the hibernation image was not restored. Not currently seeing anything in the dmesg that indicates what failed. This was with the 4.15 kernel on xenial. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
although, our cloud images normally boot by-label, thus potentially we should use the same LABEL= device, as specified in fstab of our cloud- images. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
i.e. ext4 /dev/disk/by-uuid/9958d086-4f20-4807-8976-58807a5bc7e0 or some such, if it will be accepted by our initrd. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1896638] Re: Path to swapfile doesn't use a static device path
please use by-id with uuid path as listed in https://wiki.ubuntu.com/FSTAB -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1896638 Title: Path to swapfile doesn't use a static device path To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ec2-hibinit-agent/+bug/1896638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
