[Bug 1897785] Re: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT
** Changed in: grub2 (Ubuntu) Status: Triaged => Opinion -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897785 Title: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1897785/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1897785] Re: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT
So you suggest to break several hundred scripts written on/for standard conforming platforms (i.e. not only for Linux) within the last 30 years just because of bogus grub scripts? IMHO not a smart idea. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897785 Title: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1897785/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1897785] Re: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT
Don't set that variable, then. Nobody tests that thing, so you can't reasonably expect it to just work. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897785 Title: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1897785/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1897785] Re: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT
FWIW: /usr/sbin/grub-probe is also posixly incorrect, e.g.: # export POSIXLY_CORRECT=1 # /usr/sbin/grub-probe --device /dev/sda2 --target=partmap /usr/sbin/grub-probe: error: cannot find a GRUB drive for /dev/sda2. Check your device.map. # unset POSIXLY_CORRECT # /usr/sbin/grub-probe --device /dev/sda2 --target=partmap gpt So e.g. if one has POSIXLY_CORRECT set, but not GRUB_TERMINAL (the default in /etc/default/grub), /etc/grub.d/00_header assumes gfxterm and therefore indirectly calls /usr/share/grub/grub-mkconfig_lib:prepare_grub_to_access_device() - which in turn fails, because it calls /usr/sbin/grub-probe w/o unsetting POSIXLY_CORRECT before. Since this aborts grub.cfg generation, a disaster recovery is needed on the next reboot if there is not already an old grub.cfg which is able to boot a kernel ... If one sets GRUB_TERMINAL=console , mkconfig_lib:prepare_grub_to_access_device() doesn't get invoked and update-grub and in turn grub-mkconfig -o /boot/grub/grub.cfg generates a valid/usable config. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897785 Title: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1897785/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1897785] Re: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT
juliank: unset right before and restore after the call. It would not screw up anything. The user does not know, what the script does (and IIRC it didn't call zfs.mount in pre-focal versions). So the script has to take care of what it does. xnox: I do not think, that this fixed the problem. Just export POSIXLY_CORRECT=1 and run a zfs create command - it will fail to mount the new fs for the same reason. IIRC linux mount (used by zfs mount last time I digged the code) requires arguments to be in a non-posix compatible order. So ZFS can't do anything about it, except to unset POSIXLY_CORRECT or to rewrite the mount code to avoids the linux-mount invocation ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897785 Title: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1897785/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1897785] Re: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT
Yeah, this seems to be up to the individual mount helpers to fix, hence like zfsutils package. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897785 Title: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1897785/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1897785] Re: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT
Want's zfs mount, fixed in https://github.com/openzfs/zfs/issues/4222 & https://github.com/openzfs/zfs/commit/d93b45aefc74b9c345ba3cdf3a227ee979a990cd ? Is there anything missing in your description? Which calls to mount are wrong? ** Bug watch added: github.com/openzfs/zfs/issues #4222 https://github.com/openzfs/zfs/issues/4222 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897785 Title: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1897785/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1897785] Re: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT
Note it seems you may encounter incorrect behaviour when using mount.nfs sshfs too, because those too expect non-posixly argument order. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897785 Title: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1897785/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1897785] Re: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT
I think I disagree here, scripts should not unset POSIXLY_CORRECT. Accounts should not set POSIXLY_CORRECT, it's going to wreak havoc in a lot of places. Having to accomodate for such unusual end user configurations in every shell scripts seems out of scope. ** Changed in: grub2 (Ubuntu) Importance: Undecided => Low ** Changed in: grub2 (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1897785 Title: 10_linux_zfs: empty bootmenu if POSIXLY_CORRECT To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1897785/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
