[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
I was about to file a new BUG Report. I did a quick fix and uploaded to one of my Repositories: https://github.com/luckylinux/grub- scripts/commit/59f90b0f751fb1241b0243dc5700522ffe73bf8e Basically you need to add one mount / umount command for the /usr Dataset whenever the / and/or /etc Dataset is mounted. One Command is probably NOT needed as it generates an "unmount Error", but the other seems to be. Any change of getting this (FINALLY !) Fixed and Upstreamed ? Thanks Before Fix: root@LiveUbuntu02:/# update-grub Sourcing file `/etc/default/grub' Sourcing file `/etc/default/grub.d/lubuntu-grub-theme.cfg' Generating grub configuration file ... /etc/grub.d/10_linux_zfs: 403: .: cannot open /tmp/zfsmnt.NYQsLe/etc/os-release: No such file Warning: os-prober will not be executed to detect other bootable partitions. Systems on them will not be added to the GRUB boot configuration. Check GRUB_DISABLE_OS_PROBER documentation entry. Adding boot menu entry for UEFI Firmware Settings ... done After Fix: root@LiveUbuntu02:/# update-grub Sourcing file `/etc/default/grub' Sourcing file `/etc/default/grub.d/lubuntu-grub-theme.cfg' Sourcing file `/etc/default/grub.d/zfs.cfg' Generating grub configuration file ... Found linux image: vmlinuz-6.8.0-35-generic in rpool/ROOT/ubuntu Found initrd image: initrd.img-6.8.0-35-generic in rpool/ROOT/ubuntu Found linux image: vmlinuz-6.5.0-14-generic in rpool/ROOT/ubuntu Found initrd image: initrd.img-6.5.0-14-generic in rpool/ROOT/ubuntu umount: /tmp/zfsmnt.Q0TA2T/usr: not mounted. Found linux image: vmlinuz-6.8.0-35-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1715 Found initrd image: initrd.img-6.8.0-35-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1715 Found linux image: vmlinuz-6.5.0-14-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1715 Found initrd image: initrd.img-6.5.0-14-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1715 umount: /tmp/zfsmnt.Q0TA2T/usr: not mounted. Found linux image: vmlinuz-6.8.0-35-generic in rpool/ROOT/ubuntu@zfs-auto-snap_hourly-2023-12-31-1717 Found initrd image: initrd.img-6.8.0-35-generic in rpool/ROOT/ubuntu@zfs-auto-snap_hourly-2023-12-31-1717 Found linux image: vmlinuz-6.5.0-14-generic in rpool/ROOT/ubuntu@zfs-auto-snap_hourly-2023-12-31-1717 Found initrd image: initrd.img-6.5.0-14-generic in rpool/ROOT/ubuntu@zfs-auto-snap_hourly-2023-12-31-1717 umount: /tmp/zfsmnt.Q0TA2T/usr: not mounted. Found linux image: vmlinuz-6.8.0-35-generic in rpool/ROOT/ubuntu@install Found initrd image: initrd.img-6.8.0-35-generic in rpool/ROOT/ubuntu@install Found linux image: vmlinuz-6.5.0-14-generic in rpool/ROOT/ubuntu@install Found initrd image: initrd.img-6.5.0-14-generic in rpool/ROOT/ubuntu@install umount: /tmp/zfsmnt.Q0TA2T/usr: not mounted. Found linux image: vmlinuz-6.8.0-35-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1730 Found initrd image: initrd.img-6.8.0-35-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1730 Found linux image: vmlinuz-6.5.0-14-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1730 Found initrd image: initrd.img-6.5.0-14-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1730 umount: /tmp/zfsmnt.Q0TA2T/usr: not mounted. Found linux image: vmlinuz-6.8.0-35-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1745 Found initrd image: initrd.img-6.8.0-35-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1745 Found linux image: vmlinuz-6.5.0-14-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1745 Found initrd image: initrd.img-6.5.0-14-generic in rpool/ROOT/ubuntu@zfs-auto-snap_frequent-2023-12-31-1745 umount: /tmp/zfsmnt.Q0TA2T/usr: not mounted. /etc/grub.d/10_linux_zfs: 406: .: cannot open /.zfs/snapshot/20240619_fix_nested_zfs_datasets/etc/os-release: No such file Warning: os-prober will not be executed to detect other bootable partitions. Systems on them will not be added to the GRUB boot configuration. Check GRUB_DISABLE_OS_PROBER documentation entry. Adding boot menu entry for UEFI Firmware Settings ... done EDIT 1: on one system, my proposed fix performed correctly. On another one, it failed with /etc/grub.d/10_linux_zfs: 406: .: cannot open /.zfs/snapshot/20240619_fix_nested_zfs_datasets/etc/os-release: No such file --
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
I think it's an important use case to support, since it's more than likely going to be needed once Ubuntu supports ZFS on server installs. the zfs tools and scripts should definitely be bulletproof'd to handle any zfs fs configuration, especially around something like this where it should be easy to fix. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
I can confirm, I also has this bug: /etc/grub.d/10_linux_zfs: 404: .: Can't open /tmp/zfsmnt.stGSQC/etc/os-release I mounted the root partition under /target when I hit into this problem. I simply modified the 404 line to use /etc. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: grubzfs-testsuite (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
I think the question is whether there is documentation that states that zsys supports split /usr, and the answer for that is no. Also, um, the installer does not support installing like this - there's only one experimental ZFS option, on desktop anyway. So this bug in essence will answer the question whether this is something we want to support or not. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
/usr is a separate ZFS file system, separate from /. My system boots and operates normally. The only issue is with the grub script, /etc/grub.d/10_linux_zfs. I had to do some hacking of this script for it to parse the Linux images properly. If you think /usr is not supported as a separate ZFS file system, can you point me to the documentation that states so? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
So, /etc/os-release is an obsolete file location, which is normally a symlink to /usr/lib/os-release. When mounting snapshots, the grub script doesn't parse /etc/fstab; to mount the snapshots of where the /usr is, and mount that. However, I don't know how having /usr as a subvolumen (if that is the right term) even supported or usable with zsys. What do you mean by /usr is a separate filesystem? which filesystem is it? We only support zsys when everything is managed by it. ** Changed in: grub2 (Ubuntu) Status: Confirmed => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
** Changed in: grub2 (Ubuntu) Importance: Undecided => Low ** Tags removed: rls-ff-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
** Also affects: grubzfs-testsuite (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
** Tags added: rls-ff-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1899372] Re: update-grub 10_linux_zfs fails when /usr is a separate filesystem
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: grub2 (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1899372 Title: update-grub 10_linux_zfs fails when /usr is a separate filesystem To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1899372/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
