[Bug 1913187] Re: iproute2 segfaults when filtering sockets
This bug was fixed in the package iproute2 - 4.15.0-2ubuntu1.3 --- iproute2 (4.15.0-2ubuntu1.3) bionic; urgency=medium * Fix: NULL dereference when rendering without header (LP: #1913187) - d/p/lp1913187-ss-fix-NULL-dereference-when-rendering.patch -- Rafael David Tinoco Tue, 26 Jan 2021 13:33:08 + ** Changed in: iproute2 (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
postgresql-common amd64 and i386: passed after a retry ubuntu-fan: see previous comment, known flaky test, and analysis of the test output shows that the test actually passed. I retried both amd64 and s390x, but I ask the SRU team to consider those runs green if they failed again (update: amd64 just passed, s390x still pending results). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
ubuntu-fan dep8 failures are due to https://bugs.launchpad.net/ubuntu/+source/ubuntu-fan/+bug/1830180. It was fixed in focal+, but in bionic it remains flaky. Explanation is in https://bugs.launchpad.net/ubuntu/+source/ubuntu- fan/+bug/1830180/comments/1 I'll retry it once or twice, but we can see from the test output that the test worked, and the stderr text is just noise that happened because systemd-resolve was called too soon: Starting fanatic-test lxd test: Waiting for addresses on eth0 ... lxd test: Waiting for addresses on eth0 ... lxd test: Waiting for addresses on eth0 ... lxd test: Waiting for addresses on eth0 ... lxd test: Waiting for addresses on eth0 ... slave: detected primary route through eth0 [0;1;31msd_bus_open_system: No such file or directory[0m <-- too soon slave: waiting for systemd resolver... slave: DNS: systemd(250.40.8.1) <--- now it worked, and the test continues ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
What about the autopkgtest regressions as marked by comment #8? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
# verfication $ dpkg -l iproute2 | grep ii ii iproute2 4.15.0-2ubuntu1.3 amd64networking and traffic control tools $ ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst 127.0.0.1 && echo worked worked good to migrate. thank you. -rafaeldtinoco ** Tags removed: verification-needed verification-needed-bionic ** Tags added: verification-done verification-done-bionic ** Changed in: iproute2 (Ubuntu Bionic) Assignee: Rafael David Tinoco (rafaeldtinoco) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
Hello Rafael, or anyone else affected, Accepted iproute2 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/iproute2/4.15.0-2ubuntu1.3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: iproute2 (Ubuntu Bionic) Status: Confirmed => Fix Committed ** Tags added: verification-needed verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
$ git-ubuntu tag --upload $ git describe upload/4.15.0-2ubuntu1.3 $ git push pkg upload/4.15.0-2ubuntu1.3 Counting objects: 11, done. Delta compression using up to 24 threads. Compressing objects: 100% (11/11), done. Writing objects: 100% (11/11), 2.07 KiB | 176.00 KiB/s, done. Total 11 (delta 7), reused 0 (delta 0) To ssh://git.launchpad.net/ubuntu/+source/iproute2 * [new tag] upload/4.15.0-2ubuntu1.3 -> upload/4.15.0-2ubuntu1.3 $ debdiff *.dsc | diffstat changelog | 7 +++ patches/lp1913187-ss-fix-NULL-dereference-when-rendering.patch | 40 patches/series | 1 + 3 files changed, 48 insertions(+) [rafaeldtinoco@iproute2issue ubuntu]$ dput ubuntu ./iproute2_4.15.0-2ubuntu1.3_source.changes Checking signature on .changes gpg: ./iproute2_4.15.0-2ubuntu1.3_source.changes: Valid signature from A93E0E0AD83C0D0F Checking signature on .dsc gpg: ./iproute2_4.15.0-2ubuntu1.3.dsc: Valid signature from A93E0E0AD83C0D0F Uploading to ubuntu (via ftp to upload.ubuntu.com): Uploading iproute2_4.15.0-2ubuntu1.3.dsc: done. Uploading iproute2_4.15.0-2ubuntu1.3.debian.tar.xz: done. Uploading iproute2_4.15.0-2ubuntu1.3_source.buildinfo: done. Uploading iproute2_4.15.0-2ubuntu1.3_source.changes: done. Successfully uploaded packages. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
** Merge proposal linked: https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/iproute2/+git/iproute2/+merge/396921 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
MP:
https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/iproute2/+git/iproute2/+merge/396921
PPA: https://launchpad.net/~rafaeldtinoco/+archive/ubuntu/lp1913187
** Description changed:
+ [Impact]
+
+ * The ss tool crashes when a query returns no results (seg fault)
+
+ [Test Case]
+
+ * $ sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst
127.0.0.1
+ Segmentation fault
+
+ [Where problems could occur]
+
+ * The ss tool is impacted and it has its code changed for the fix.
+
+ * The fix is a clean cherry-pick and straightforward (moving
+ declaration after a NULL check).
+
+ [Other Info]
+
When in Ubuntu Bionic, if one calls:
$ sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst 127.0.0.1
tcp 00
127.0.0.1:58910 127.0.0.1:22
users:(("ssh",pid=11672,fd=3)) timer:(keepalive,119min,0)
it works. Just like when in Groovy:
$ sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst 127.0.0.1
tcp 00
127.0.0.1:58908 127.0.0.1:22
users:(("ssh",pid=1488591,fd=3)) timer:(keepalive,119min,0)
but.. if there is nothing to show, in Bionic we get a segfault:
$ sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst 127.0.0.1
Segmentation fault
** Description changed:
[Impact]
- * The ss tool crashes when a query returns no results (seg fault)
+ * The ss tool crashes when a query returns no results (seg fault)
[Test Case]
- * $ sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst
127.0.0.1
- Segmentation fault
+ * $ sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst
127.0.0.1
+ Segmentation fault
+
+ * PPA with the fix:
+ https://launchpad.net/~rafaeldtinoco/+archive/ubuntu/lp1913187
[Where problems could occur]
- * The ss tool is impacted and it has its code changed for the fix.
+ * The ss tool is impacted and it has its code changed for the fix.
- * The fix is a clean cherry-pick and straightforward (moving
+ * The fix is a clean cherry-pick and straightforward (moving
declaration after a NULL check).
[Other Info]
-
+
When in Ubuntu Bionic, if one calls:
$ sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst 127.0.0.1
tcp 00
127.0.0.1:58910 127.0.0.1:22
users:(("ssh",pid=11672,fd=3)) timer:(keepalive,119min,0)
it works. Just like when in Groovy:
$ sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst 127.0.0.1
tcp 00
127.0.0.1:58908 127.0.0.1:22
users:(("ssh",pid=1488591,fd=3)) timer:(keepalive,119min,0)
but.. if there is nothing to show, in Bionic we get a segfault:
$ sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst 127.0.0.1
Segmentation fault
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1913187
Title:
iproute2 segfaults when filtering sockets
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
[rafaeldtinoco@iproute2issue iproute2]$ git unfixed eb8559eff124221bfbafe934c4dbfe30f20604c0 is the first bad commit commit eb8559eff124221bfbafe934c4dbfe30f20604c0 Author: Jean-Philippe Brucker Date: Sat Mar 3 16:59:44 2018 + ss: fix NULL dereference when rendering without header When ss is invoked with the no-header flag, if the query doesn't return any result, render() is called with 'buffer' uninitialized. This currently leads to a segfault. Ensure that buffer is initialized before rendering. The bug can be triggered with: ss -H sport = 10 Signed-off-by: Jean-Philippe Brucker Acked-by: Stefano Brivio Signed-off-by: Stephen Hemminger :04 04 bf8f626f1c0b85bd690dab60d4f74db292ac8e65 6174ebf0728edab46c62b713f6aee495eef81cb5 M misc -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
It only affects Bionic: [rafaeldtinoco@iproute2issue iproute2]$ git describe eb8559eff124221bfbafe934c4dbfe30f20604c0 v4.15.0-103-geb8559ef [rafaeldtinoco@iproute2issue ~]$ rmadison iproute2 iproute2 | 3.12.0-2 | trusty | source iproute2 | 3.12.0-2ubuntu1.2 | trusty-updates | source iproute2 | 4.3.0-1ubuntu3| xenial | source iproute2 | 4.3.0-1ubuntu3.16.04.5| xenial-updates | source iproute2 | 4.15.0-2ubuntu1 | bionic | source iproute2 | 4.15.0-2ubuntu1.1 | bionic-security | source iproute2 | 4.15.0-2ubuntu1.2 | bionic-updates | source iproute2 | 4.18.0-1ubuntu2~ubuntu18.04.1 | bionic-backports | source iproute2 | 5.5.0-1ubuntu1| focal| source iproute2 | 5.7.0-1ubuntu1| groovy | source iproute2 | 5.9.0-1ubuntu1| hirsute | source iproute2 | 5.10.0-2ubuntu1 | hirsute-proposed | source -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
workaround: sudo ss -Hnp -o state established 'dport = 22' src 127.0.0.1 dst 127.0.0.1 | cat - by not trying to control terminal WIDTH, segfault does not occur. ** Changed in: iproute2 (Ubuntu Bionic) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1913187] Re: iproute2 segfaults when filtering sockets
Issues comes from: (gdb) bt #0 render (screen_width=144) at ss.c:1204 #1 main (argc=, argv=) at ss.c:4974 render (screen_width=144) at ss.c:1204 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1913187 Title: iproute2 segfaults when filtering sockets To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/iproute2/+bug/1913187/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
