[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
This bug was fixed in the package linux - 5.4.0-67.75 --- linux (5.4.0-67.75) focal; urgency=medium * focal/linux: 5.4.0-67.75 -proposed tracker (LP: #1916169) * Please trust Canonical Livepatch Service kmod signing key (LP: #1898716) - [Config] enable CONFIG_MODVERSIONS=y - [Packaging] build canonical-certs.pem from branch/arch certs - [Config] add Canonical Livepatch Service key to SYSTEM_TRUSTED_KEYS - [Config] add ubuntu-drivers key to SYSTEM_TRUSTED_KEYS - [Config] Allow ASM_MODVERSIONS and MODULE_REL_CRCS * geneve overlay network on vlan interface broken with offload enabled (LP: #1914447) - net/mlx5e: Fix SWP offsets when vlan inserted by driver * Add support for selective build of special drivers (LP: #1912789) - [Packaging] Fix ODM support in actual build * devlink: don't do reporter recovery if the state is healthy (LP: #1915403) - devlink: don't do reporter recovery if the state is healthy * Missing device id for Intel TGL-H ISH [8086:43fc] in intel-ish-hid driver (LP: #1914543) - HID: intel-ish-hid: ipc: Add Tiger Lake H PCI device ID * Focal update: v5.4.94 upstream stable release (LP: #1915200) - gpio: mvebu: fix pwm .get_state period calculation - futex: Ensure the correct return value from futex_lock_pi() - futex: Replace pointless printk in fixup_owner() - futex: Provide and use pi_state_update_owner() - rtmutex: Remove unused argument from rt_mutex_proxy_unlock() - futex: Use pi_state_update_owner() in put_pi_state() - futex: Simplify fixup_pi_state_owner() - futex: Handle faults correctly for PI futexes - HID: wacom: Correct NULL dereference on AES pen proximity - io_uring: Fix current->fs handling in io_sq_wq_submit_work() - tracing: Fix race in trace_open and buffer resize call - arm64: mm: use single quantity to represent the PA to VA translation - SMB3.1.1: do not log warning message if server doesn't populate salt - tools: Factor HOSTCC, HOSTLD, HOSTAR definitions - dm integrity: conditionally disable "recalculate" feature - writeback: Drop I_DIRTY_TIME_EXPIRE - fs: fix lazytime expiration handling in __writeback_single_inode() - Linux 5.4.94 * Focal update: v5.4.93 upstream stable release (LP: #1915195) - i2c: bpmp-tegra: Ignore unknown I2C_M flags - platform/x86: ideapad-laptop: Disable touchpad_switch for ELAN0634 - ALSA: seq: oss: Fix missing error check in snd_seq_oss_synth_make_info() - ALSA: hda/via: Add minimum mute flag - ACPI: scan: Make acpi_bus_get_device() clear return pointer on error - btrfs: don't get an EINTR during drop_snapshot for reloc - btrfs: fix lockdep splat in btrfs_recover_relocation - btrfs: don't clear ret in btrfs_start_dirty_block_groups - btrfs: send: fix invalid clone operations when cloning from the same file and root - mmc: core: don't initialize block size from ext_csd if not present - mmc: sdhci-xenon: fix 1.8v regulator stabilization - dm: avoid filesystem lookup in dm_get_dev_t() - dm integrity: fix a crash if "recalculate" used without "internal_hash" - drm/atomic: put state on error path - drm/syncobj: Fix use-after-free - drm/i915/gt: Prevent use of engine->wa_ctx after error - ASoC: Intel: haswell: Add missing pm_ops - dm integrity: select CRYPTO_SKCIPHER - scsi: ufs: Correct the LUN used in eh_device_reset_handler() callback - scsi: qedi: Correct max length of CHAP secret - scsi: sd: Suppress spurious errors when WRITE SAME is being disabled - riscv: Fix kernel time_init() - riscv: Fix sifive serial driver - HID: logitech-dj: add the G602 receiver - HID: Ignore battery for Elan touchscreen on ASUS UX550 - clk: tegra30: Add hda clock default rates to clock driver - arm64: make atomic helpers __always_inline - xen: Fix event channel callback via INTX/GSI - x86/xen: Add xen_no_vector_callback option to test PCI INTX delivery - dts: phy: fix missing mdio device and probe failure of vsc8541-01 device - riscv: defconfig: enable gpio support for HiFive Unleashed - drm/amdgpu/psp: fix psp gfx ctrl cmds - drm/amd/display: Fix to be able to stop crc calculation - drm/nouveau/bios: fix issue shadowing expansion ROMs - drm/nouveau/privring: ack interrupts the same way as RM - drm/nouveau/i2c/gm200: increase width of aux semaphore owner fields - drm/nouveau/mmu: fix vram heap sizing - drm/nouveau/kms/nv50-: fix case where notifier buffer is at offset 0 - powerpc: Use the common INIT_DATA_SECTION macro in vmlinux.lds.S - pinctrl: aspeed: g6: Fix PWMG0 pinctrl setting - scsi: megaraid_sas: Fix MEGASAS_IOC_FIRMWARE regression - powerpc: Fix alignment bug within the init sections - i2c: octeon: check correct size of maximum RECV_LEN packet - platform/x86: intel-vbtn: Drop HP Stream x360 Convertible PC 11 from allow-
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed- focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
** Changed in: linux (Ubuntu Focal) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
** Description changed: Hi, [Impact] Currently in focal, devices reporter recovery is enabled even if state is healthy. + + [fix] + 402818205c9e devlink: don't do reporter recovery if the state is healthy + this upstream commit from kernel v5.5-rc1 which is cleanly applied on focal tree. + the commit prevents reporter recovery when device in healthy state. + when applied, issuing + # devlink health recover pci/:05:00.0 reporter fw_fatal + on healthy state reporter return successfully, but dmesg is clean and recover counter do not change. [test case] 1) display devlink health status # devlink health show pci/:05:00.0 reporter fw_fatal pci/:05:00.0: reporter fw_fatal state healthy error 0 recover 0 grace_period 120 auto_recover true 2) perform reporter recovery using devlink, # devlink health recover pci/:05:00.0 reporter fw_fatal 3)see that recovery was performed. # dmesg [776733.438708] mlx5_core :05:00.0: mlx5_health_try_recover:316:(pid 563178): handling bad device here [776733.438717] mlx5_core :05:00.0: mlx5_handle_bad_state:278:(pid 563178): Expected to see disabled NIC but it is full driver [776735.591522] mlx5_core :05:00.0: mlx5_health_try_recover:328:(pid 563178): starting health recovery flow ... # devlink health show pci/:05:00.0 reporter fw_fatal pci/:05:00.0: reporter fw_fatal state healthy error 0 recover 1 grace_period 120 auto_recover true - [fix] - 402818205c9e devlink: don't do reporter recovery if the state is healthy - this upstream commit from kernel v5.5-rc1 which is cleanly applied on focal tree. - the commit prevents reporter recovery when device in healthy state. - when applied, issuing - # devlink health recover pci/:05:00.0 reporter fw_fatal - on healthy state reporter return successfully, but dmesg is clean and recover counter do not change. - [Regression Potential] - very small as it is a very minor change, also this patch has been tested internally on upstream setups for a while and no degradation has been found. - one obvious change is that a user cannot force devlink recovery when state is healthy but I'm not aware of such use case. + Very small as it is a very minor change, also this patch has been tested internally on upstream setups for a while and no degradation has been found. + One obvious change is that a user cannot force devlink recovery when state is healthy but I'm not aware of such use case. Thanks, Amir -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
** Changed in: linux (Ubuntu Focal) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
** Description changed: Hi, [Impact] Currently in focal, devices reporter recovery is enabled even if state is healthy. [test case] 1) display devlink health status # devlink health show pci/:05:00.0 reporter fw_fatal pci/:05:00.0: reporter fw_fatal state healthy error 0 recover 0 grace_period 120 auto_recover true 2) perform reporter recovery using devlink, # devlink health recover pci/:05:00.0 reporter fw_fatal 3)see that recovery was performed. # dmesg [776733.438708] mlx5_core :05:00.0: mlx5_health_try_recover:316:(pid 563178): handling bad device here [776733.438717] mlx5_core :05:00.0: mlx5_handle_bad_state:278:(pid 563178): Expected to see disabled NIC but it is full driver [776735.591522] mlx5_core :05:00.0: mlx5_health_try_recover:328:(pid 563178): starting health recovery flow ... # devlink health show pci/:05:00.0 reporter fw_fatal pci/:05:00.0: reporter fw_fatal state healthy error 0 recover 1 grace_period 120 auto_recover true [fix] 402818205c9e devlink: don't do reporter recovery if the state is healthy this upstream commit from kernel v5.5-rc1 which is cleanly applied on focal tree. the commit prevents reporter recovery when device in healthy state. when applied, issuing # devlink health recover pci/:05:00.0 reporter fw_fatal on healthy state reporter return successfully, but dmesg is clean and recover counter do not change. [Regression Potential] - very small as it is a very minor change. + very small as it is a very minor change, also this patch has been tested internally on upstream setups for a while and no degradation has been found. + one obvious change is that a user cannot force devlink recovery when state is healthy but I'm not aware of such use case. Thanks, Amir -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
I tested the kernel It works as expected and meets our needs thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
Test kernels are available here: https://kernel.ubuntu.com/~kmously /kernel-kmously-92dc8ac-EqeO/ Please test and let us know if these meet your needs. ** Changed in: linux (Ubuntu Focal) Status: In Progress => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
Not applicable to "ubuntu" in general, patch is already in every release after Focal. Just need to pick back to 5.4 in this case. Branch w/ patch applied: https://code.launchpad.net/~bladernr/ubuntu/+source/linux/+git/focal/+ref/1915403 -devlink-disable-report-if-healthy Will get some test kernels soon. ** Changed in: linux (Ubuntu) Status: Confirmed => In Progress ** Changed in: linux (Ubuntu) Assignee: (unassigned) => Jeff Lane (bladernr) ** Changed in: linux (Ubuntu) Importance: Undecided => Medium ** Also affects: linux (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: linux (Ubuntu Focal) Assignee: (unassigned) => Jeff Lane (bladernr) ** Changed in: linux (Ubuntu Focal) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Focal) Status: New => In Progress ** Changed in: linux (Ubuntu) Status: In Progress => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
Patch pull request, Bot stuff not needed. ** Changed in: linux (Ubuntu) Status: Incomplete => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1915403] Re: devlink: don't do reporter recovery if the state is healthy
** Description changed: Hi, [Impact] - Currently in focal, mlx5 devices reporter recovery is enabled even if state is healthy. + Currently in focal, devices reporter recovery is enabled even if state is healthy. [test case] 1) display devlink health status # devlink health show pci/:05:00.0 reporter fw_fatal pci/:05:00.0: reporter fw_fatal state healthy error 0 recover 0 grace_period 120 auto_recover true 2) perform reporter recovery using devlink, # devlink health recover pci/:05:00.0 reporter fw_fatal 3)see that recovery was performed. # dmesg [776733.438708] mlx5_core :05:00.0: mlx5_health_try_recover:316:(pid 563178): handling bad device here [776733.438717] mlx5_core :05:00.0: mlx5_handle_bad_state:278:(pid 563178): Expected to see disabled NIC but it is full driver [776735.591522] mlx5_core :05:00.0: mlx5_health_try_recover:328:(pid 563178): starting health recovery flow ... # devlink health show pci/:05:00.0 reporter fw_fatal pci/:05:00.0: reporter fw_fatal state healthy error 0 recover 1 grace_period 120 auto_recover true [fix] 402818205c9e devlink: don't do reporter recovery if the state is healthy this upstream commit from kernel v5.5-rc1 which is cleanly applied on focal tree. the commit prevents reporter recovery when device in healthy state. when applied, issuing # devlink health recover pci/:05:00.0 reporter fw_fatal on healthy state reporter return successfully, but dmesg is clean and recover counter do not change. [Regression Potential] very small as it is a very minor change. Thanks, Amir -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1915403 Title: devlink: don't do reporter recovery if the state is healthy To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1915403/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
