[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
This bug was fixed in the package ldb - 2:2.2.0-3ubuntu1 --- ldb (2:2.2.0-3ubuntu1) hirsute; urgency=medium * Fix symbols generation (LP: #1920825). On hirsute, dh-exec is showing different behavior based on the value of DEB_BUILD_PROFILES. This is causing it to sometimes generate a file with the leading whitespace removed, which is resulting in a bad symbols file. Set DEB_BUILD_PROFILES to empty gives a good symbols file. -- Matthias Klose Tue, 30 Mar 2021 16:11:59 +0200 ** Changed in: ldb (Ubuntu Hirsute) Status: Fix Committed => Fix Released ** Changed in: talloc (Ubuntu Hirsute) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
This bug was fixed in the package talloc - 2.3.1-2ubuntu1 --- talloc (2.3.1-2ubuntu1) hirsute; urgency=medium * Fix symbols generation (LP: #1920825). On hirsute, dh-exec is showing different behavior based on the value of DEB_BUILD_PROFILES. This is causing it to sometimes generate a file with the leading whitespace removed, which is resulting in a bad symbols file. Set DEB_BUILD_PROFILES to empty gives a good symbols file, but what does this matter? -- Dan Bungert Mon, 29 Mar 2021 17:23:59 -0600 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
** Tags removed: rls-ff-incoming ** Also affects: ldb (Ubuntu Hirsute) Importance: High Status: Fix Committed ** Also affects: talloc (Ubuntu Hirsute) Importance: High Status: Fix Committed ** Also affects: dh-exec (Ubuntu Hirsute) Importance: High Status: Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
Unsubscribing ubuntu sponsors, there doesn't seems to be anything left to upload there -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
This bug was fixed in the package dh-exec - 0.23.4 --- dh-exec (0.23.4) unstable; urgency=medium * QA upload. [ Daniel Bungert ] * Fix unintended whitespace removal (LP: #1920825) Per the tests it's desired to remove the whitespace following a build profile - such as " B" resulting in "B", but leave lines with no build profile alone. -- Matthias Klose Wed, 31 Mar 2021 15:00:30 +0200 ** Changed in: dh-exec (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
** Changed in: ldb (Ubuntu) Status: Confirmed => Fix Committed ** Changed in: dh-exec (Ubuntu) Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
patch #7 looks good to me! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
I have run some 40-odd packages that build-depend on dh-exec thru autopkgtest with my modified dh-exec and everything seems fine, including talloc using the version prior to my workaround. If my approach is agreeable I suggest uploading. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
Here is my proposal: * dh-exec today desires to remove whitespace after a profile, so preserve that * dh-exec also removes trailing whitespace, which might be OK and is current behavior, so preserve that * remove leading whitespace for lines that don't have the profile My perl is rusty (to say the least) but nonetheless here is my proposal. I have not given this regression test yet beyond the built-in tests. ** Patch added: "dh-exec-1-0.23.3ubuntu1.debdiff" https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+attachment/5482432/+files/dh-exec-1-0.23.3ubuntu1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
somehow settings --with / --without did not help, to exclude the filter commands. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
If we only want to replace environment variables and nothing else, we can use #!/usr/share/dh-exec/dh-exec-subst-env then even with DEB_BUILD_PROFILES set, the lines preserve the leading whitespace. It would be nice for DEB_BUILD_PROFILES to preserve leading whitespace and/or only strip it for files where it matters and not others. I guess .symbols is one of the few special ones where leading whitespace is required. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
dh-exec's lib/dh-exec-filter-build-profiles has some line trimming ... [...] s/(^\s+|\s+$)//; [...] which is done unconditionally, removing all leading spaces. Apparently nobody thought about using dh-exec for symbols files. Not sure what will happen if we remove that substitution. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
** Also affects: dh-exec (Ubuntu) Importance: Undecided Status: New ** Changed in: dh-exec (Ubuntu) Status: New => Confirmed ** Changed in: dh-exec (Ubuntu) Importance: Undecided => High ** Changed in: talloc (Ubuntu) Status: Confirmed => Fix Committed ** Tags added: rls-ff-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/dh-exec/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
I appreciate the feedback Matthias. Please see my new patch. I have seen some unexpected behavior from dh-exec, and this patch provides a workaround. Tomorrow I plan to play with dh-exec more and expect to be filing a bug. ** Patch added: "2-2.3.1-2ubuntu1.debdiff" https://bugs.launchpad.net/ubuntu/+source/talloc/+bug/1920825/+attachment/5482239/+files/2-2.3.1-2ubuntu1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ldb/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
so the patch writes a python3-talloc.symbols.common file which then isn't used. I don't think that's the correct fix. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ldb/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
Change the generated filename. ** Patch added: "1-2.3.1-2ubuntu1.debdiff" https://bugs.launchpad.net/ubuntu/+source/talloc/+bug/1920825/+attachment/5482162/+files/1-2.3.1-2ubuntu1.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ldb/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1920825] Re: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files)
** Tags added: fr-1247 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1920825 Title: FTBFS and autopkgtest failure in Hirsute (badly generated symbols files) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ldb/+bug/1920825/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
