[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
This bug was fixed in the package ubiquity - 20.04.15.18 --- ubiquity (20.04.15.18) focal; urgency=medium * ubi-partman.py: Do not display a restart button in the advanced partitioning screen when installing alongside Windows Boot Manager. Thanks to Sam van Kampen for the patch. (LP: #1942648) * tests/test_timezone.py: The Bahamas moved their DST rules to sync with the U.S. in 2007 but tzdata only recently incorporated this change. (LP: #1951519) * Automatic update of included source packages: shim-signed 1.40.7. -- Brian Murray Mon, 10 Jan 2022 10:39:31 -0800 ** Changed in: ubiquity (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
I repeated the test based on the package from proposed and things still look good. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
Hello Sam, or anyone else affected, Accepted ubiquity into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubiquity/20.04.15.18 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: ubiquity (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
** Description changed: + [Impact] On a system where BitLocker is enabled, when choosing "Install Ubuntu - alongside Windows Boot Manager", a page is shown instructing us to turn - off BitLocker. On this page, a green restart button is shown. + alongside Windows Boot Manager", a page is shown instructing us to + turn off BitLocker. On this page, a green "Restart" button is shown. If we now go back and pick "Something else", the advanced partitioning - screen still displays the green restart button, even though clicking on - it acts like the expected "Install Now" button. + screen still displays the green restart button, even though clicking + on it acts like the expected "Install Now" button. - I've attached a proposed patch which makes the button look as expected. + Whereas a user could think they are just restarting, but actually + clicking an "Install Now" button, the present state risks users losing + data. - Ubuntu release: 20.04.3 LTS - Package version: 20.04.15.17 + [Test Plan] + * Acquire a VM or machine with a partition that is BitLockered. + * Run thru the Ubiquity installer: + * Install Ubuntu + * Appropriate keyboard layout and Continue + * Accept defaults at "Updates and other software" Install screen, + and Continue + * At the Installation type screen, ensure that "Install Ubuntu + alongside Windows Boot Manager" is selected, and Continue + * The "Turn off bitlocker" screen should now be showing. Click the + "Back" button + * Select "Something else" and Continue + * 3 buttons should be visible in the Bottom row. When the defect is + present, the rightmost button is green and says "Restart". When + the defect has been corrected, the rightmost button says "Install + now" and is the same color as the other buttons. + + [Where problems could occur] + * Any change to the installer must be treated with the highest level + of care, as this is a place where users with less experience make + changes to a system and can lose data if mistakes are made. + + * Are there other code flows where the state variables are incorrect? + Since the current code depends on the back button to reset the + state, is it doing so completely? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
** Changed in: ubiquity (Ubuntu Focal) Status: New => In Progress ** Changed in: ubiquity (Ubuntu Focal) Importance: Undecided => Medium ** Changed in: ubiquity (Ubuntu Focal) Assignee: (unassigned) => Brian Murray (brian-murray) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
I ran this through my kvm test and it behaved as expected. LGTM. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
This bug was fixed in the package ubiquity - 21.10.10 --- ubiquity (21.10.10) impish; urgency=medium * ubi-partman.py: Do not display a restart button in the advanced partitioning screen when installing alongside Windows Boot Manager. Thanks to Sam van Kampen for the patch. (LP: #1942648) -- Brian Murray Tue, 12 Oct 2021 05:52:59 -0700 ** Changed in: ubiquity (Ubuntu Impish) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
** Changed in: ubiquity (Ubuntu Impish) Assignee: (unassigned) => Brian Murray (brian-murray) ** Changed in: ubiquity (Ubuntu Impish) Status: Confirmed => In Progress ** Changed in: ubiquity (Ubuntu Impish) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
** Also affects: ubiquity (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: ubiquity (Ubuntu Focal) Milestone: None => ubuntu-20.04.4 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
I have verified the patch and it looks good to me. I suggest merging. Note that when verifying this, it seems necessary in the manual partitioning step to select a disk to format in order to enable the green 'Restart' button that is functionally the 'Install Now' button. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
** Changed in: ubiquity (Ubuntu Impish) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
** Tags removed: rls-ff-incoming ** Also affects: ubiquity (Ubuntu Impish) Importance: Undecided Status: New ** Changed in: ubiquity (Ubuntu Impish) Milestone: None => ubuntu-21.10 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
** Tags added: fr-1706 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
** Tags added: focal rls-ff-incoming -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1942648] Re: restart button remains visible in the advanced partitioner after the bitlocker page is shown
The attachment "Patch which makes the button look as expected." seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1942648 Title: restart button remains visible in the advanced partitioner after the bitlocker page is shown To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1942648/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
