[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
** Changed in: oem-priority Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
This bug was fixed in the package modemmanager - 1.16.6-2~20.04.1 --- modemmanager (1.16.6-2~20.04.1) focal; urgency=medium * Support manual firmware upgrading for Foxconn and Quectel modems. (LP: #1946096) -- Jerry Lee Thu, 21 Oct 2021 10:29:18 +0800 ** Changed in: modemmanager (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
This bug was fixed in the package modemmanager - 1.16.6-2~21.04.1 --- modemmanager (1.16.6-2~21.04.1) hirsute; urgency=medium * Support manual firmware upgrading for Foxconn and Quectel modems. (LP: #1946096) -- Jerry Lee Thu, 21 Oct 2021 10:43:42 +0800 ** Changed in: modemmanager (Ubuntu Hirsute) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
Regression test results: (1) Test passed with Lenovo T14s (Tiger-2) on Hirsute: * The version of the packages tested: ModemManager: 1.16.6-2~21.04.1 (2) Test passed with Lenovo X13 AMD (Servel-AMD-1) on Focal: * The version of the packages tested: ModemManager: 1.16.6-2~20.04.1 The detail testing procedure and result is provided as the attached file : "RegressionTestReportFor-proposedPackages-1946096.pdf" ** Attachment added: "RegressionTestReportFor-proposedPackages-1946096.pdf" https://bugs.launchpad.net/oem-priority/+bug/1946096/+attachment/5545834/+files/RegressionTestReportFor-proposedPackages-1946096.pdf.pdf ** Tags removed: verification-needed-focal verification-needed-hirsute ** Tags added: verification-done-focal verification-done-hirsute -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
(1) Test passed with Lenovo ThinkEdge SE30(11ND) and Lenovo ThinkEdge SE30(11NE) on Hirsute: * The version of the packages tested: ModemManager: 1.16.6-2~21.04.1 (2) Test passed with Lenovo ThinkEdge SE30(11ND) and Lenovo ThinkEdge SE30(11NE) on Focal: * The version of the packages tested: ModemManager: 1.16.6-2~20.04.1 The detail testing procedure and result is provided as the attached file : "TestReportForHirsuteAndFocal-proposed-1946096.pdf" The regression test report will be provided. ** Attachment added: "TestReportForHirsuteAndFocal-proposed-1946096.pdf" https://bugs.launchpad.net/oem-priority/+bug/1946096/+attachment/5545449/+files/TestReportForHirsuteAndFocal-proposed-1946096.pdf -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
(and in Impish in 1.16.6-2ubuntu1) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
Fixed in Jammy in 1.18.2-0ubuntu1. ** Changed in: modemmanager (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
I think all concerns raised have now been addressed so I'm accepting the upload into Hirsute and Focal. ** Changed in: modemmanager (Ubuntu Hirsute) Status: New => Fix Committed ** Tags added: verification-needed verification-needed-hirsute -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
** Description changed: [Impact] The modem certification requires that different modem firmware is used for different network carrier. This needs the firmware upgrading capability during the modem certification process. The modem manufacture vendors (Foxconn and Quectel) provided utilities to do modem's firmware upgrading manually.(LP#1943774, LP#1943780) These utilities are verified to be working when the recent versions(> v 1.18.2) of ModemManager are used with. To support manual firmware upgrading on the current Focal release which is using ModemManager v 1.16.6, we need to apply some patches from v 1.18.2. The requested upstream patches are listed as below: * for Quectel EM160 4G ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/83ac82470589a3672092a0ba0be855093b1cf5e2 * for Foxconn T99W175 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/21ae558fe3600c84b3ca7dcd9bf50a3ba576c7c9 **https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/76e700f4fd703f952208993330ab098305c13d6b ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/52bf2c641171ded9e617022f40497c8984520371 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/33e2b023ef01bea9da37ae2beb192f7d92bce47a ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/f72046701659073fbfa97516e155865647acb154 The firmware upgrading was verified using the patched ModemManager v 1.16.6 with the following 2 modems: * Foxconn SDX55 T99W175 5G sub6 PCIE Modem * Quectel SDX24 EM160R-GL 4G LTE CAT16 PCIE Modem [Test Plan] 1. Install the Ubuntu image. 2. Boot and login the system. - 3. Prepare the modem’s firmware and install the firmware upgrading application provided by Foxconn and Quectel - 4. Using the firmware upgrading application to upgrade the modem’s firmware - 5. Verify if the modem’s firmware upgrading is successful - 6. Reboot - 7. Verify if the upgraded modem firmware is still working + 3. Verify if the modem is working + 4. Prepare the modem’s firmware and install the firmware upgrading application provided by Foxconn and Quectel + 5. Using the firmware upgrading application to upgrade the modem’s firmware + 6. Verify if the modem’s firmware upgrading is successful + 7. Reboot + 8. Verify if the upgraded modem firmware is still working --- Regression test --- Verify if one USB modem are still working with these patches for PCIe modems. [Where problems could occur] The requested update has 2 parts: 1. Informative 1.1 Provide more information about modems whose drivers use WWAN subsystem in kernel 5.13 1.2 Modem manufacture's private utilities can use this information to do modem's FW upgrading manually 2. Changes are specific to Foxconn and Quectel modems 2.1 Modified code are only used by Foxconn and Quectel modems during their FW upgrading. (matched by vendor_id and product_id) In current Ubuntu's certification records for modem: * No other modem uses WWAN subsystem in kernel 5.13 * Modem's FW update is not supported via ModemManager ( < v1.18 ) There is no certificated modems can do the firmware upgrading flow for the regression test. This update should not affect existing modems. The problem would be limited to these two mentioned modems. Each carrier mapping .conf file is for a specific modem. ModemManager will load one of the carrier mapping conf files via the modem manufacturer’s plugin ( if the PCIe VID & PID is matched by the plugin.) We cannot verify if the carrier mapping is correct. This relies on the manufacturer to provide the correct mapping. The carrier mapping .conf files is verified by modem’s manufacture according to the tested SIM card published by different countries. Modem manufacturer confirmed that the content in the .conf file is absolutely correct. [Other Info] The firmware and the upgrading utilities can be downloaded from the following link: * LP#1943774 for Quectel modems * LP#1943780 for Foxconn modems -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
The .debdiff file “modemmanager_1-1.16.6-2~21.10.1-impish.debdiff” is attached for impish(21.10). ** Patch added: "modemmanager_1-1.16.6-2~21.10.1-impish.debdiff" https://bugs.launchpad.net/oem-priority/+bug/1946096/+attachment/5544543/+files/modemmanager_1-1.16.6-2~21.10.1-impish.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
The "01_modem-quectel.patch" extends the quectel:plugin to provide firmware setting status during the FW upgrading process. EM120/160 PCIe modules have been already supported without this patch. I got the confirmation from Quectel engineers about the above. For the regression test, we found 2 laptops having Quectel USB modems and did the test on these laptops. The Quectel USB modems worked with the patched ModemManager. The regression test report is attached here: "RegressionTestReport_ EM05-CE.pdf". ** Description changed: [Impact] The modem certification requires that different modem firmware is used for different network carrier. This needs the firmware upgrading capability during the modem certification process. The modem manufacture vendors (Foxconn and Quectel) provided utilities to do modem's firmware upgrading manually.(LP#1943774, LP#1943780) These utilities are verified to be working when the recent versions(> v 1.18.2) of ModemManager are used with. To support manual firmware upgrading on the current Focal release which is using ModemManager v 1.16.6, we need to apply some patches from v 1.18.2. The requested upstream patches are listed as below: * for Quectel EM160 4G ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/83ac82470589a3672092a0ba0be855093b1cf5e2 * for Foxconn T99W175 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/21ae558fe3600c84b3ca7dcd9bf50a3ba576c7c9 **https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/76e700f4fd703f952208993330ab098305c13d6b ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/52bf2c641171ded9e617022f40497c8984520371 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/33e2b023ef01bea9da37ae2beb192f7d92bce47a ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/f72046701659073fbfa97516e155865647acb154 The firmware upgrading was verified using the patched ModemManager v 1.16.6 with the following 2 modems: * Foxconn SDX55 T99W175 5G sub6 PCIE Modem * Quectel SDX24 EM160R-GL 4G LTE CAT16 PCIE Modem [Test Plan] 1. Install the Ubuntu image. 2. Boot and login the system. 3. Prepare the modem’s firmware and install the firmware upgrading application provided by Foxconn and Quectel 4. Using the firmware upgrading application to upgrade the modem’s firmware 5. Verify if the modem’s firmware upgrading is successful 6. Reboot 7. Verify if the upgraded modem firmware is still working + --- Regression test --- + + Verify if one USB modem are still working with these patches for PCIe + modems. + [Where problems could occur] The requested update has 2 parts: 1. Informative 1.1 Provide more information about modems whose drivers use WWAN subsystem in kernel 5.13 1.2 Modem manufacture's private utilities can use this information to do modem's FW upgrading manually 2. Changes are specific to Foxconn and Quectel modems 2.1 Modified code are only used by Foxconn and Quectel modems during their FW upgrading. (matched by vendor_id and product_id) In current Ubuntu's certification records for modem: * No other modem uses WWAN subsystem in kernel 5.13 * Modem's FW update is not supported via ModemManager ( < v1.18 ) There is no certificated modems can do the firmware upgrading flow for the regression test. This update should not affect existing modems. The problem would be limited to these two mentioned modems. Each carrier mapping .conf file is for a specific modem. ModemManager will load one of the carrier mapping conf files via the modem manufacturer’s plugin ( if the PCIe VID & PID is matched by the plugin.) We cannot verify if the carrier mapping is correct. This relies on the manufacturer to provide the correct mapping. - The carrier mapping .conf files is verified by modem’s manufacture according to the tested SIM card published by different countries. - Modem manufacturer confirmed that the content in the .conf file is absolutely correct. - + The carrier mapping .conf files is verified by modem’s manufacture according to the tested SIM card published by different countries. + Modem manufacturer confirmed that the content in the .conf file is absolutely correct. [Other Info] The firmware and the upgrading utilities can be downloaded from the following link: * LP#1943774 for Quectel modems * LP#1943780 for Foxconn modems ** Attachment added: "USB modem regression test" https://bugs.launchpad.net/oem-priority/+bug/1946096/+attachment/5544542/+files/RegressionTestReport_%20EM05-CE.pdf -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to:
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
Before I was relying on the information presented here and the changelog in the upload to consider regression risk. Today I reviewed the patches in more detail expecting to find what has been described. What's going on in 01_modem-quectel.patch? This says "add support for EM120/160 PCIe modules" and it seems to be adding support for a PCIe variant of a modem in the code that already supports a USB variant. But your changelog just says "Support manual firmware upgrading" with no mention of support for additional modems. Are you actually additionally adding support for this modem hardware where support didn't exist previously? I see no mention of additional additional modem support anywhere in this bug so far. If so, then will you be able to test the regular functionality of these modems - both USB and PCIe - during SRU verification please? Do you have these two modems available? This would be to ensure that 1) the changes to modemmanager that relate to the USB variant haven't regressed; and 2) the changes to add support for the PCIe variant is actually working. If you can do this, then please add this to the Test Plan. If not, then further discussion is needed. It looks like Impish no longer carries this patch as 1.16.6-2ubuntu1 was removed, so we also need an upload of this to Impish please. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
Hello, is there anything needs me to provide for moving to the next step? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
[Where problems could occur] is updated ** Description changed: [Impact] The modem certification requires that different modem firmware is used for different network carrier. This needs the firmware upgrading capability during the modem certification process. The modem manufacture vendors (Foxconn and Quectel) provided utilities to do modem's firmware upgrading manually.(LP#1943774, LP#1943780) These utilities are verified to be working when the recent versions(> v 1.18.2) of ModemManager are used with. To support manual firmware upgrading on the current Focal release which is using ModemManager v 1.16.6, we need to apply some patches from v 1.18.2. The requested upstream patches are listed as below: * for Quectel EM160 4G ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/83ac82470589a3672092a0ba0be855093b1cf5e2 * for Foxconn T99W175 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/21ae558fe3600c84b3ca7dcd9bf50a3ba576c7c9 **https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/76e700f4fd703f952208993330ab098305c13d6b ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/52bf2c641171ded9e617022f40497c8984520371 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/33e2b023ef01bea9da37ae2beb192f7d92bce47a ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/f72046701659073fbfa97516e155865647acb154 The firmware upgrading was verified using the patched ModemManager v 1.16.6 with the following 2 modems: * Foxconn SDX55 T99W175 5G sub6 PCIE Modem * Quectel SDX24 EM160R-GL 4G LTE CAT16 PCIE Modem [Test Plan] 1. Install the Ubuntu image. 2. Boot and login the system. 3. Prepare the modem’s firmware and install the firmware upgrading application provided by Foxconn and Quectel 4. Using the firmware upgrading application to upgrade the modem’s firmware 5. Verify if the modem’s firmware upgrading is successful 6. Reboot 7. Verify if the upgraded modem firmware is still working [Where problems could occur] The requested update has 2 parts: 1. Informative -1.1 Provide more information about modems whose drivers use WWAN subsystem in kernel 5.13 -1.2 Modem manufacture's private utilities can use this information to do modem's FW upgrading manually + 1.1 Provide more information about modems whose drivers use WWAN subsystem in kernel 5.13 + 1.2 Modem manufacture's private utilities can use this information to do modem's FW upgrading manually 2. Changes are specific to Foxconn and Quectel modems -2.1 Modified code are only used by Foxconn and Quectel modems during their FW upgrading. (matched by vendor_id and product_id) + 2.1 Modified code are only used by Foxconn and Quectel modems during their FW upgrading. (matched by vendor_id and product_id) In current Ubuntu's certification records for modem: * No other modem uses WWAN subsystem in kernel 5.13 * Modem's FW update is not supported via ModemManager ( < v1.18 ) There is no certificated modems can do the firmware upgrading flow for the regression test. This update should not affect existing modems. + The problem would be limited to these two mentioned modems. + Each carrier mapping .conf file is for a specific modem. + ModemManager will load one of the carrier mapping conf files via the modem manufacturer’s plugin ( if the PCIe VID & PID is matched by the plugin.) + We cannot verify if the carrier mapping is correct. This relies on the manufacturer to provide the correct mapping. + + The carrier mapping .conf files is verified by modem’s manufacture according to the tested SIM card published by different countries. + Modem manufacturer confirmed that the content in the .conf file is absolutely correct. + + [Other Info] The firmware and the upgrading utilities can be downloaded from the following link: * LP#1943774 for Quectel modems * LP#1943780 for Foxconn modems -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
I don't see how your updated "Where problems could occur" addresses my comment 22 at all. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
[Where problems could occur] is updated ** Description changed: [Impact] The modem certification requires that different modem firmware is used for different network carrier. This needs the firmware upgrading capability during the modem certification process. The modem manufacture vendors (Foxconn and Quectel) provided utilities to do modem's firmware upgrading manually.(LP#1943774, LP#1943780) These utilities are verified to be working when the recent versions(> v 1.18.2) of ModemManager are used with. To support manual firmware upgrading on the current Focal release which is using ModemManager v 1.16.6, we need to apply some patches from v 1.18.2. The requested upstream patches are listed as below: * for Quectel EM160 4G ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/83ac82470589a3672092a0ba0be855093b1cf5e2 * for Foxconn T99W175 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/21ae558fe3600c84b3ca7dcd9bf50a3ba576c7c9 **https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/76e700f4fd703f952208993330ab098305c13d6b ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/52bf2c641171ded9e617022f40497c8984520371 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/33e2b023ef01bea9da37ae2beb192f7d92bce47a ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/f72046701659073fbfa97516e155865647acb154 The firmware upgrading was verified using the patched ModemManager v 1.16.6 with the following 2 modems: * Foxconn SDX55 T99W175 5G sub6 PCIE Modem * Quectel SDX24 EM160R-GL 4G LTE CAT16 PCIE Modem [Test Plan] 1. Install the Ubuntu image. 2. Boot and login the system. 3. Prepare the modem’s firmware and install the firmware upgrading application provided by Foxconn and Quectel 4. Using the firmware upgrading application to upgrade the modem’s firmware 5. Verify if the modem’s firmware upgrading is successful 6. Reboot 7. Verify if the upgraded modem firmware is still working [Where problems could occur] - The requested upstream patches are for these 2 specific modems. - This should not affect existing generic functions and other modems. + The requested update has 2 parts: + + 1. Informative +1.1 Provide more information about modems whose drivers use WWAN subsystem in kernel 5.13 +1.2 Modem manufacture's private utilities can use this information to do modem's FW upgrading manually + + 2. Changes are specific to Foxconn and Quectel modems +2.1 Modified code are only used by Foxconn and Quectel modems during their FW upgrading. (matched by vendor_id and product_id) + + In current Ubuntu's certification records for modem: + * No other modem uses WWAN subsystem in kernel 5.13 + * Modem's FW update is not supported via ModemManager ( < v1.18 ) + + There is no certificated modems can do the firmware upgrading flow for the regression test. + This update should not affect existing modems. [Other Info] The firmware and the upgrading utilities can be downloaded from the following link: * LP#1943774 for Quectel modems * LP#1943780 for Foxconn modems -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
OK, so you currently have nothing in your Test Plan to verify this part of the changes you're proposing? Please either fix the Test Plan, or if testing this is impractical for some reason then we can discuss that and decide what mitigation might be appropriate, but in this case the omission and conclusion should be documented in this bug - presumably in the "Where problems could occur" section. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
By investigating the mentioned patches directly, the existing behavior should not be changed: * The patch for Quectel EM160 4G There is only one patch, all changes are for the Quectel modems. * Patches for Foxconn T99W175 There are 5 patches, (patch#1): Modify the command line tool to get additional scan report for WWAN subsystem (patch#2): Move methods between 2 files (patch#3): Add more 15 seconds wait for the firmware upgrading (patch#4): Rename an existed carrier mapping configuration file for Foxconn modem (patch#5): Add a new carrier mapping configuration file for Foxconn modem From the code review, it's clear that changes only affect Foxconn and Quectel modems. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
How do you intend to verify that (3) has worked correctly? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
> 3) Add a bunch of mappings from SIM->Carrier > Assuming (3) is not expected to change existing behaviour this looks like it would be acceptable under the hardware-enablement SRU policy. Agreed, but I would expect SRU information against every change being made, that would then receive separate SRU verification. This helps us mitigate risk by 1) actually considering each change in the first place, rather than it "slipping past" review; and 2) reducing the potential number of SRUs, and therefore user time, bandwidth and regression risk, by actually verifying that things are being changed as expected so we don't have to do it twice. I'm disappointed that this has now gone through two SRU review rounds, and it is Chris who has extracted the actual nature of the changes that you are looking to land here. This detail should have been laid out in the bug (or multiple bugs) and in the SRU information in the first place. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
Yes, (3) is not expected to change existing behavior. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
Ok. For clarity, my understanding of these patches are that they do the following things: 1) Add a feature to ModemManager to support uploading firmware to these modems 2) Increase a timeout that was found to be insufficient when doing a firmware update 3) Add a bunch of mappings from SIM->Carrier And then in response to potential concerns: (1) is a straight feature addition, and the associated code will only be called if an external component connects to modemmanager requesting a firmware upload. This is not expected to change any existing behaviours. (2) is low-risk It's not clear to me whether (3) is expected to change existing behaviours at all. Is this understanding correct? Assuming (3) is not expected to change existing behaviour this looks like it would be acceptable under the hardware-enablement SRU policy. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
** Changed in: modemmanager (Ubuntu) Status: Incomplete => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
These patches are used for newer Foxconn/Quectel modems : * whose drivers are using the WWAN subsystem in the kernel 5.13. ( this OEM project uses customized kernel ) * communicated to the ModemManager service via the MBIM protocol These patches will not be used if the modem can't meet the above requirements. After checking Ubuntu certificated modems, there is no modem can meet these 2 requirement to do the regression test. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
Applying these changes should have no risk: * These changes are only for specific modems.(Foxconn and Quecktel) * These changes are used when the platform's vendors do the firmware upgrading for specific modems "manually". We can try to find other modems then provide the regression test report later. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
Is there a risk that applying these changes will regress the behavior of these modems on systems which have NOT applied the firmware updates? Can the testcase include a check for this? ** Changed in: modemmanager (Ubuntu) Status: Fix Committed => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
Sponsored both the focal and hirsute versions. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
** Description changed: [Impact] + + The modem certification requires that different modem firmware is used for different network carrier. + This needs the firmware upgrading capability during the modem certification process. The modem manufacture vendors (Foxconn and Quectel) provided utilities to do modem's firmware upgrading manually.(LP#1943774, LP#1943780) These utilities are verified to be working when the recent versions(> v 1.18.2) of ModemManager are used with. To support manual firmware upgrading on the current Focal release which is using ModemManager v 1.16.6, we need to apply some patches from v 1.18.2. The requested upstream patches are listed as below: * for Quectel EM160 4G ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/83ac82470589a3672092a0ba0be855093b1cf5e2 * for Foxconn T99W175 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/21ae558fe3600c84b3ca7dcd9bf50a3ba576c7c9 **https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/76e700f4fd703f952208993330ab098305c13d6b ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/52bf2c641171ded9e617022f40497c8984520371 ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/33e2b023ef01bea9da37ae2beb192f7d92bce47a ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/f72046701659073fbfa97516e155865647acb154 The firmware upgrading was verified using the patched ModemManager v 1.16.6 with the following 2 modems: * Foxconn SDX55 T99W175 5G sub6 PCIE Modem * Quectel SDX24 EM160R-GL 4G LTE CAT16 PCIE Modem [Test Plan] 1. Install the Ubuntu image. 2. Boot and login the system. 3. Prepare the modem’s firmware and install the firmware upgrading application provided by Foxconn and Quectel 4. Using the firmware upgrading application to upgrade the modem’s firmware 5. Verify if the modem’s firmware upgrading is successful 6. Reboot 7. Verify if the upgraded modem firmware is still working [Where problems could occur] The requested upstream patches are for these 2 specific modems. This should not affect existing generic functions and other modems. [Other Info] The firmware and the upgrading utilities can be downloaded from the following link: * LP#1943774 for Quectel modems * LP#1943780 for Foxconn modems -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
The .debdiff file “modemmanager_1-1.16.6-2~21.04.1-hirsute.debdiff” is attached for hirsute(21.04). The pre-built package : https://launchpad.net/~jerry-lee- tpe/+archive/ubuntu/packages/+packages ** Patch added: "modemmanager_1-1.16.6-2~21.04.1-hirsute.debdiff" https://bugs.launchpad.net/oem-priority/+bug/1946096/+attachment/5534867/+files/modemmanager_1-1.16.6-2~21.04.1-hirsute.debdiff ** Patch removed: "modemmanager_1-1.16.6-3-hirsute.debdiff" https://bugs.launchpad.net/oem-priority/+bug/1946096/+attachment/5530707/+files/modemmanager_1-1.16.6-3~hirsute.debdiff ** Patch removed: "modemmanager_1-1.16.6-3-focal.debdiff" https://bugs.launchpad.net/oem-priority/+bug/1946096/+attachment/5530706/+files/modemmanager_1-1.16.6-3-focal.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
The .debdiff file “modemmanager_1-1.16.6-2~20.04.1-focal.debdiff” is attached for focal(20.04). The pre-built package : https://launchpad.net/~jerry-lee- tpe/+archive/ubuntu/packages/+packages ** Patch added: "modemmanager_1-1.16.6-2~20.04.1-focal.debdiff" https://bugs.launchpad.net/oem-priority/+bug/1946096/+attachment/5534868/+files/modemmanager_1-1.16.6-2~20.04.1-focal.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
** Description changed: [Impact] - The following 2 modems need the ModemManager v1.16.6 suite to be patched from v1.18.2 to fix some problems(LP#1943774, LP#1943780): - * Foxconn SDX55 T99W175 5G sub6 PCIE Modem - * Quectel SDX24 EM160R-GL 4G LTE CAT16 PCIE Modem + The modem manufacture vendors (Foxconn and Quectel) provided utilities to do modem's firmware upgrading manually.(LP#1943774, LP#1943780) + These utilities are verified to be working when the recent versions(> v 1.18.2) of ModemManager are used with. + To support manual firmware upgrading on the current Focal release which is using ModemManager v 1.16.6, we need to apply some patches from v 1.18.2. The requested upstream patches are listed as below: * for Quectel EM160 4G - ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/83ac82470589a3672092a0ba0be855093b1cf5e2 + ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/83ac82470589a3672092a0ba0be855093b1cf5e2 * for Foxconn T99W175 - ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/21ae558fe3600c84b3ca7dcd9bf50a3ba576c7c9 - **https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/76e700f4fd703f952208993330ab098305c13d6b - ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/52bf2c641171ded9e617022f40497c8984520371 - ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/33e2b023ef01bea9da37ae2beb192f7d92bce47a - ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/f72046701659073fbfa97516e155865647acb154 + ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/21ae558fe3600c84b3ca7dcd9bf50a3ba576c7c9 + **https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/76e700f4fd703f952208993330ab098305c13d6b + ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/52bf2c641171ded9e617022f40497c8984520371 + ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/33e2b023ef01bea9da37ae2beb192f7d92bce47a + ** https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/f72046701659073fbfa97516e155865647acb154 + The firmware upgrading was verified using the patched ModemManager v 1.16.6 with the following 2 modems: + * Foxconn SDX55 T99W175 5G sub6 PCIE Modem + * Quectel SDX24 EM160R-GL 4G LTE CAT16 PCIE Modem [Test Plan] 1. Install the Ubuntu image. 2. Boot and login the system. 3. Prepare the modem’s firmware and install the firmware upgrading application provided by Foxconn and Quectel - 4. Using the firmware upgrading application to upgrade the modem’s firmware + 4. Using the firmware upgrading application to upgrade the modem’s firmware 5. Verify if the modem’s firmware upgrading is successful - 6. Reboot + 6. Reboot 7. Verify if the upgraded modem firmware is still working - [Where problems could occur] - The requested upstream patches are for these 2 specific modems and the status information. + The requested upstream patches are for these 2 specific modems. This should not affect existing generic functions and other modems. - [Other Info] - The firmware and the upgrading application can be downloaded from the following link: + The firmware and the upgrading utilities can be downloaded from the following link: * LP#1943774 for Quectel modems * LP#1943780 for Foxconn modems -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1946096] Re: Support manual firmware upgrading for Foxconn and Quectel modems.
** Summary changed: - Apply upstream patches to fix problems for Foxconn and Quectel modems. + Support manual firmware upgrading for Foxconn and Quectel modems. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1946096 Title: Support manual firmware upgrading for Foxconn and Quectel modems. To manage notifications about this bug go to: https://bugs.launchpad.net/oem-priority/+bug/1946096/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
