[Bug 19482] Re: speexenc segfaults on amd64

[Marco Rodrigues]

** Changed in: edubuntu-addon-cd
   Importance: Unknown = Undecided
 Bugwatch: Ubuntu.com Bug Tracker #ubuntu = None
   Status: Unknown = New

** Changed in: edubuntu-addon-cd
   Status: New = Invalid

-- 
speexenc segfaults on amd64
https://bugs.launchpad.net/bugs/19482
You received this bug notification because you are a member of Ubuntu
Bugs, which is a direct subscriber.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Martin Pitt]

Accepted into dapper-updates, thank you!

** Changed in: speex (Ubuntu)
   Status: Fix Committed = Fix Released

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Daniel T Chen]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Format: 1.7
Date: Wed,  7 Mar 2007 00:54:29 -0500
Source: speex
Binary: speex-doc libspeex-dev speex libspeex1
Architecture: source
Version: 1.1.11.1-1ubuntu0.2
Distribution: dapper-updates
Urgency: low
Maintainer: Debian VoIP Team [EMAIL PROTECTED]
Changed-By: Daniel T Chen [EMAIL PROTECTED]
Description: 
 libspeex-dev - The Speex Speech Codec
 libspeex1  - The Speex Speech Codec
 speex  - The Speex Speech Codec
 speex-doc  - Documentation for speex
Launchpad-Bugs-Fixed: 19482
Changes: 
 speex (1.1.11.1-1ubuntu0.2) dapper-updates; urgency=low
 .
   * No-change upload propagating to dapper-updates.
   * LP: #19482
   * Thanks to testing by Tollef Fog Heen, Simon Law, Chris Halse Rogers
 and Michael Rimbert.
 .
 speex (1.1.11.1-1ubuntu0.1) dapper-proposed; urgency=low
 .
   * Apply patch from https://trac.xiph.org/changeset/10684 fixing
 speexenc segfault on AMD64 (Closes Ubuntu: #19482).
Files: 
 3a408e57d55d69ad975a679131dc0112 892 sound optional speex_1.1.11.1-1ubuntu0.2.d
sc
 6f7065145e19013c1ff50e74d14a0cdf 16157 sound optional speex_1.1.11.1-1ubuntu0.2
.diff.gz

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFF7lSde9GwFciKvaMRAl0dAJ9V1+sLaXjjiIcmDRiaQjl6vO66BwCeKL8J
s6eml19NtmtF2Wux6XFLaFU=
=7BGM
-END PGP SIGNATURE-

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Daniel T Chen]

** Tags added: verification-motu-done

** Tags removed: verification-motu-needed

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Michael Rimbert]

Also works for me in an updated/upgraded amd64 Dapper LiveCD session:

[EMAIL PROTECTED]:~$ dpkg -l speex|grep ^ii|awk '{print $3}'
1.1.11.1-1ubuntu0.1
[EMAIL PROTECTED]:~$ speexenc /usr/share/sounds/startup.wav /tmp/startup.spx
Warning: Speex is only optimized for 8, 16 and 32 kHz. It will still work at 
44100 Hz but your mileage may vary
Encoding 44100 Hz audio using ultra-wideband (sub-band CELP) mode (stereo)
[EMAIL PROTECTED]:~$ ls -l /tmp/startup.spx
-rw-r--r-- 1 ubuntu ubuntu 74729 2007-02-22 21:59 /tmp/startup.spx

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Daniel T Chen]

Works for me in a [current] amd64 Dapper chroot:

[EMAIL PROTECTED]:/# dpkg -l speex|grep ^ii|awk '{print $3}'
1.1.11.1-1ubuntu0.1
[EMAIL PROTECTED]:/# speexenc /usr/share/sounds/startup.wav /tmp/startup.spx ; 
echo $?
Warning: Speex is only optimized for 8, 16 and 32 kHz. It will still work at 
44100 Hz but your mileage may vary
Encoding 44100 Hz audio using ultra-wideband (sub-band CELP) mode (stereo)
0
[EMAIL PROTECTED]:/# ls -l /tmp/startup.spx
-rw-r--r-- 1 root root 74729 Feb 22 05:56 /tmp/startup.spx

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Chris Halse Rogers]

Also Works for me in a [current] amd64 Dapper chroot:

[EMAIL PROTECTED]:/root# dpkg -l speex | grep ^ii| awk '{print $3}'
1.1.11.1-1ubuntu0.1
[EMAIL PROTECTED]:/root# speexenc lugradioshort.wav lugradioshort.spx
Encoding 8000 Hz audio using narrowband mode (mono)
[EMAIL PROTECTED]:/root# ls -l lugradioshort.spx
-rw-r--r-- 1 root root 1212 Feb 22 06:14 lugradioshort.spx

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Tollef Fog Heen]

I can verify that jmspeex's test completes (well, it never completes
until C-c-ed) successfully for me, using the package in -proposed.

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Simon Law]

This package is available in -proposed.

** Changed in: speex (Ubuntu)
   Status: In Progress = Fix Committed

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Simon Law]

According to https://wiki.ubuntu.com/MOTU/Processes/SRU

Works for me.

Tested on a Dapper AMD64 machine.  Verified that the package in
-proposed fixed the breakage, while not causing any regressions from
previous behaviour.  Also, speexenc appears to actually encode files,
which makes it work better than before.

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Simon Law]

** Tags added: verification-motu-needed

** Tags removed: verification-needed

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[jmspeex]

Considering that the patch has been in the main Speex tree for over a
year without complaints and the previous behaviour was totally broken
anyway, I say go for it now.

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Daniel T Chen]

** Tags added: verification-needed

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[jmspeex]

I don't have a Dapper64 machine, but if anyone has, the test is really
simple:

% speexenc /dev/zero /dev/null

If it doesn't crash after a millisecond or so, then the bug is fixed.

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[Ming Hua]

To update a package in dapper, the procedures in
https://wiki.ubuntu.com/StableReleaseUpdates needs to be followed.
Although speex is in universe, as speex and libspeex1 are built from the
same source package, and libspeex1 is in main, I believe this update
needs to follow main's stable release update procedure.

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[jmspeex]

Considering the refusal to fix the speex encoder 6 months after a patch
was posted, I request (as the Speex maintainer) that package speex
(not libspeex1) be removed from the amd64 version of Dapper. The package
is broken beyond any use on that system, so all it does is give people a
bad impression of Ubuntu and/or Speex. Thank you.

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[jmspeex]

Based on what I see at http://packages.ubuntulinux.org/edgy/source/speex
it seems like Edgy is not affected by the bug (which was fixed in
1.1.12). Now will someone finally apply the 4-line fix (above) to
Dapper... or does LTS just stand for Long Time to get Support?

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[jmspeex]

Just saw this today. I'm the maintainer of Speex (for some reason the
Speex project no longer appears on launchpad). I'll fix the problem in
Speex for the next release. In the mean time, I suggest simply doing the
following change instead:

-  op.packet = (unsigned char *)speex_header_to_packet(header, 
(int*)(op.bytes));
+  int bytes;
+  op.packet = (unsigned char *)speex_header_to_packet(header, bytes);
+  op.bytes = bytes;

It's much simpler and the Speex header size is guaranteed to fit in an
int (actually, it would even fit in a char), so no need to change
anything to size_t.

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[jmspeex]

Bit off-topic, but I just noticed that Speex is listed as an Ubuntu
package instead of an individual project. In any case, how can I get
automatically notified of bugs filed against Speex?

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[jmspeex]

I talked too soon. The patch I was proposing was actually applied on
01/01/06 19:21:21 (see http://trac.xiph.org/changeset/10684) and
actually made it into 1.1.12. You probably want to apply the same patch
in Dapper.

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 19482] Re: speexenc segfaults on amd64

[[EMAIL PROTECTED]]

** Bug watch added: Ubuntu.com bugzilla #ubuntu
   https://bugzilla.ubuntu.com/show_bug.cgi?id=ubuntu

** Also affects: edubuntu-addon-cd (upstream) via
   https://bugzilla.ubuntu.com/show_bug.cgi?id=ubuntu
   Importance: Unknown
   Status: Unknown

-- 
speexenc segfaults on amd64
https://launchpad.net/bugs/19482

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs