[Bug 1962170] Re: DEP8 failure with samba 4.15.5
This bug was fixed in the package adsys - 0.8.1 --- adsys (0.8.1) jammy; urgency=medium * Change chown logic on script directory and parents to avoid potential vulnerability. (LP: #1961458) * Separate readiness from session running to avoid unrefreshed user script directories after a logout without any new logins. * pam_adsys: Fix memory leak and identation. (LP: #1961459) * Adapt to newer samba, while keeping backward compatilibity for CI. Thanks Michael. (LP: #1962170) * Try to stabilize configuration detection change test by calling sync() to sync FHS to disk, and then, hoping we get the inotify update. Seems to fix flakyness on armhf. (LP: #1962510) * Enforce closing stderr on ppcel64 in tests with new samba to avoid hangs in race. * Fix linting issues discovered by new golangci-lint. * Misc syntax polish. * Dependencies update: - github.com/godbus/dbus/v5 - github.com/golangci/golangci-lint - gopkg.in/ini.v1 -- Didier Roche Tue, 08 Mar 2022 09:49:08 +0100 ** Changed in: adsys (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
For reference, fixed in https://github.com/ubuntu/adsys/pull/289. Thanks Michael for the initial work on this! ** Changed in: adsys (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
Didier merged a better version of the fix I uploaded so presumably he'll upload that soon and we can see where things fall. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
There are two bugs, which may be duplicates, or not: - this one, which apparently became an FTBFS on ppc64el due to a test failure (the same test? Unclear to me) - #1962510 which is an armhf failure, also due to tests failing during build Maybe a no-change rebuild should be uploaded, to confirm what's the current status -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
Fixed in https://launchpad.net/ubuntu/+source/adsys/0.8ubuntu1 via the quick fix by Michael (thanks). AFAIU you wanted to keep the bug open for a better solution down the road? ** Tags removed: server-todo -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
Unassigning from me, as I don't know how to make more progress here. ** Changed in: adsys (Ubuntu) Assignee: Andreas Hasenack (ahasenack) => (unassigned) ** Changed in: adsys (Ubuntu) Status: In Progress => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
Hm no, if I apply this patch (or something like it) https://paste.ubuntu.com/p/vVTyzHMqvr/ the build succeeds. Wtf. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
So fwiw the build failure on ppc64el is hanging on the the call to io.ReadAll(stderr) in SetupSmb (i.e. here: https://github.com/ubuntu/adsys/blob/v0.8/internal/testutils/samba.go#L38). No idea why, but my sense from poking around is that the test has already failed when the hang occurs so maybe it's some pipe buffer being full nonsense. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
It passed in s390x, finger crossed about the rest: https://autopkgtest.ubuntu.com/packages/a/adsys/jammy/s390x -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
Oh, in my link it was using samba 4.13, need to trigger it with proposed samba. I'll do that. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
Even where the build passed, the DEP8 tests are failing again (https://autopkgtest.ubuntu.com/results/autopkgtest- jammy/jammy/amd64/a/adsys/20220228_024008_ead55@/log.gz) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
Hum, it seems your patch makes sense and should work on most arch. I saw Michael did an upload with this: https://launchpad.net/ubuntu/+source/adsys/0.8ubuntu1 But it’s failing only on ppcel64: https://launchpadlibrarian.net/588289907/buildlog_ubuntu-jammy-ppc64el.adsys_0.8ubuntu1_BUILDING.txt.gz and passing on other architectures. The issue may be related to the signal installed on libsmbclient: https://github.com/ubuntu/adsys/blob/main/internal/smbsafe/smbsafe.go#L4. This workaround is the only reason of smbsafe (you can’t then exec concurrently subprocesses without cleaning up those signals and the library is doing that at every smb call on your behalf). Another idea is that stderr is not allocated for whatever reason https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L38 but why only on ppcel64? I reastically won’t have the time this week with the sprint to look at this. I hope this gives some hints if you need urgently to have it fixed before next one. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
Hum, it seems your patch makes sense and should work on most arch. I saw Michael did an upload with this: https://launchpad.net/ubuntu/+source/adsys/0.8ubuntu1 But it’s failing only on ppcel64: https://launchpadlibrarian.net/588289907/buildlog_ubuntu-jammy-ppc64el.adsys_0.8ubuntu1_BUILDING.txt.gz and passing on other architectures. The issue may be related to the signal installed on libsmbclient: https://github.com/ubuntu/adsys/blob/main/internal/smbsafe/smbsafe.go#L4. This workaround is the only reason of smbsafe (you can’t then exec concurrently subprocesses without cleaning up those signals and the library is doing that at every smb call on your behalf). Another idea is that stderr is not allocated for whatever reason https://github.com/ubuntu/adsys/blob/main/internal/testutils/samba.go#L38 but why only on ppcel64? I reastically won’t have the time this week with the sprint to look at this. I hope this gives some hints if you need urgently to have it fixed before next one. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
My last idea is that maybe adsys got caught in the same bug as backuppc[1], and is trying to send empty username/password for anonymous authentication. I tried to catch it doing so, but couldn't find a good spot in the test for that. I think the auth is handled by https://github.com/mvo5/libsmbclient-go, and I managed to crash that standalone demo utility even. @didrocks, could you give a hand on this one? 1. https://code.launchpad.net/~sergiodj/ubuntu/+source/backuppc/+git/backuppc/+merge/416111 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
I applied this simple patch, but the tests still fail. The log output is
hard to parse, I'm attaching it.
--- a/internal/testutils/samba.go
+++ b/internal/testutils/samba.go
@@ -18,7 +18,7 @@ func SetupSmb(port int, sysvolDir string) func() {
dir, cleanup := mkSmbDirWithConf(smbPort, sysvolDir)
// #nosec:G204 - we control the directory we run smbd on (on tests)
- cmd := exec.Command("smbd", "-FS", "-s", filepath.Join(dir,
"smbd.conf"))
+ cmd := exec.Command("smbd", "-F", "--debug-stdout", "-s",
filepath.Join(dir, "smbd.conf"))
stderr, err := cmd.StderrPipe()
if err != nil {
log.Fatalf("Setup: can’t get smb output: %v", err)
** Attachment added: "log"
https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+attachment/5563894/+files/log
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1962170
Title:
DEP8 failure with samba 4.15.5
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
commit 3467214cf967641f4e4001a9dfea870f933fc2a3 Author: Andreas Schneider Date: Mon Jan 11 09:52:36 2021 +0100 s3: Remove --log-stdout from daemons The common cmdline parser provides --debug-stdout. Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett i.e., use --debug-stdout instead of -S -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
I'll check smbd to see what happened with -S, and if it was intentional. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
I capture calls to smbd: PCOMMPIDPPID RET ARGS smbd 9605 9598 0 /usr/sbin/smbd -FS -s /tmp/adsys_smbd_3503406889/smbd.conf smbd 9699 9460 0 /usr/sbin/smbd -FS -s /tmp/adsys_smbd_3503406889/smbd.conf Ran them by hand: # /usr/sbin/smbd -FS -s /tmp/adsys_smbd_3503406889/smbd.conf Invalid option -FS: unknown option -F still exists, but not -S apparently. The manpage confirms -S is gone. It is mentioned in the context of -i, but -S itself is no longer there. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1962170] Re: DEP8 failure with samba 4.15.5
** Changed in: adsys (Ubuntu) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1962170 Title: DEP8 failure with samba 4.15.5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/adsys/+bug/1962170/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
