[Bug 1967924] Re: One overlayfs fix has not been backported to the 5.13 branch
** Also affects: linux-azure (Ubuntu Impish) Importance: Undecided Status: New ** Also affects: linux-azure (Ubuntu Jammy) Importance: Undecided Status: Confirmed ** Also affects: linux (Ubuntu) Importance: Undecided Status: New ** No longer affects: linux-azure (Ubuntu Jammy) ** No longer affects: linux-azure (Ubuntu Impish) ** No longer affects: linux-azure (Ubuntu) ** Changed in: linux (Ubuntu Jammy) Status: New => Fix Committed ** Summary changed: - One overlayfs fix has not been backported to the 5.13 branch + re-apply missing overlayfs SAUCE patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967924 Title: re-apply missing overlayfs SAUCE patch To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1967924/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967924] Re: One overlayfs fix has not been backported to the 5.13 branch
We have a minimal reproducer test for this issue prepared by Andrei in the original commit description https://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20210426081121.37363-1-alexan...@mihalicyn.com/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967924 Title: One overlayfs fix has not been backported to the 5.13 branch To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-azure/+bug/1967924/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967924] Re: One overlayfs fix has not been backported to the 5.13 branch
** Description changed:
+ [Impact]
+
+ Starting with 5.13 we've incorrectly dropped the following sauce patch:
+
+ UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from
+ map_files
+
+ This patch seems to be required to use overlayfs on top of shiftfs and
+ without this patch we may break containers that rely on shiftfs (using
+ zfs/ceph as storage pool w/ shiftfs enabled).
+
+ [Test case]
+
+ No specific test case provided.
+
+ [Fix]
+
+ The original SAUCE patch relies on AUFS in order to use vma->vm_prfile,
+ but we're not providing AUFS anymore in jammy,.
+
+ The fix consists of re-apply this patch with a little refactoring to be
+ dependent on CONFIG_AUFS_FS.
+
+ [Regression potential]
+
+ This patch is touching overlayfs, so we may see potential regressions in
+ overlayfs.
+
+ [Original bug report]
+
The next patch has not been ported to the the 5.13 branch:
$ git show Ubuntu-azure-5.8-5.8.0-1033.35_20.04.1~656
commit 5f5716d1f7ece06c66d7d8145dd6b3a5886b3e56
Author: Alexander Mikhalitsyn
Date: Mon Apr 26 10:11:00 2021 +0200
- UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from
map_files
-
- BugLink: https://bugs.launchpad.net/bugs/1857257
+ UBUNTU: SAUCE: overlayfs: fix incorrect mnt_id of files opened from
+ map_files
+
+ BugLink: https://bugs.launchpad.net/bugs/1857257
...
- Fixes: d24b8a5 ("UBUNTU: SAUCE: overlayfs: allow with shiftfs as
+ Fixes: d24b8a5 ("UBUNTU: SAUCE: overlayfs: allow with shiftfs as
underlay")
-
But it isn't in the 5.13 branch:
- $ git log --pretty=oneline origin/azure-5.13-next fs/overlayfs/file.c
+ $ git log --pretty=oneline origin/azure-5.13-next fs/overlayfs/file.c
1e6145d8708c831d2aa5c26aa15eb98e1a1683b9 ovl: fix use after free in struct
ovl_aio_req
7b5bda27d1fc4d7bde20cf6ed203fe88c458169a ovl: fix IOCB_DIRECT if underlying
fs doesn't support direct IO
1626e7f7ab7eb74e142fec7fe6b7c9614972a56b ovl: fix deadlock in splice write
1443bc4a25ca84d60d39a8ae1dc6215abdd637a4 UBUNTU: SAUCE: overlayfs: allow with
shiftfs as underlay
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1967924
Title:
One overlayfs fix has not been backported to the 5.13 branch
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux-azure/+bug/1967924/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967924] Re: One overlayfs fix has not been backported to the 5.13 branch
Hello, Andrea! Thanks a lot for your attention to this problem! This patch lightly relies on AUFS. All that we need is https://github.com/JPyke3/mbp-manjaro-kernel/blob/master/aufs5-mmap.patch to bring needed helpers. Can we keep these changes in ubuntu sauce after AUFS will be dropped? Please, reach me if it's needed to prepare some patches to the Ubuntu kernel and send it from our (CRIU project) side. Regards, Alex -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967924 Title: One overlayfs fix has not been backported to the 5.13 branch To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-azure/+bug/1967924/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967924] Re: One overlayfs fix has not been backported to the 5.13 branch
Thanks for pointing this out Andrew. It looks like this patch is relying on AUFS that has been dropped/disabled in jammy, but it's still available in focal, so we should definitely re-apply this patch. I'll make sure this is re-applied to 5.13 and 5.15 (changing the code to properly depend on AUFS). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967924 Title: One overlayfs fix has not been backported to the 5.13 branch To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-azure/+bug/1967924/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967924] Re: One overlayfs fix has not been backported to the 5.13 branch
Any update? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967924 Title: One overlayfs fix has not been backported to the 5.13 branch To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-azure/+bug/1967924/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1967924] Re: One overlayfs fix has not been backported to the 5.13 branch
** Summary changed: - One overlayfs fix has not been backported to the 5.13 bracnh + One overlayfs fix has not been backported to the 5.13 branch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1967924 Title: One overlayfs fix has not been backported to the 5.13 branch To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux-azure/+bug/1967924/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
