[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
This bug is awaiting verification that the linux/5.15.0-36.37 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'. If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you! ** Tags added: verification-needed-jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
** Changed in: ubuntu-z-systems Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
** Changed in: linux (Ubuntu Focal) Status: In Progress => Fix Committed ** Changed in: linux (Ubuntu Impish) Status: In Progress => Fix Committed ** Changed in: linux (Ubuntu Jammy) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
SRU request submitted to the Ubuntu kernel team mailing list for jammy, impish and focal: https://lists.ubuntu.com/archives/kernel-team/2022-May/thread.html#130537 Changing status to 'In Progress' for jammy, impish and focal. ** Changed in: linux (Ubuntu Focal) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Impish) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Jammy) Importance: Undecided => Medium ** Changed in: linux (Ubuntu Focal) Assignee: (unassigned) => Canonical Kernel Team (canonical-kernel-team) ** Changed in: linux (Ubuntu Impish) Assignee: (unassigned) => Canonical Kernel Team (canonical-kernel-team) ** Changed in: linux (Ubuntu Jammy) Assignee: (unassigned) => Canonical Kernel Team (canonical-kernel-team) ** Changed in: linux (Ubuntu Jammy) Status: New => In Progress ** Changed in: linux (Ubuntu Impish) Status: New => In Progress ** Changed in: linux (Ubuntu Focal) Status: New => In Progress ** Changed in: ubuntu-z-systems Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
Hi Thomas, I've noticed that the commit: c9311de71635d3eaa158df8516b9b99a92d60a0c "s390/cpumf: add new extended counter set for IBM z16" already landed in linux-next, and cherry-picked directly from there, which worked on focal, impish and also jammy. This is for us the preferable way in terms of maintenance and traceability. I hope that's okay for you - let me know in case you object. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
A PPA with kernel builds for jammy, impish and focal to test are available here: https://launchpad.net/~fheimes/+archive/ubuntu/lp1974433 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
** Changed in: linux (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
** Description changed: SRU Justification: == [Impact] - * This is a hardware enablement SRU + * This is a hardware enablement SRU - * and adds support for (new) IBM z16 counters + * and adds support for (new) IBM z16 counters - * by exporting the extended counter set counters of the IBM z16 via + * by exporting the extended counter set counters of the IBM z16 via sysfs. [Fix] - * c9311de71635 c9311de71635d3eaa158df8516b9b99a92d60a0c -"s390/cpumf: add new extended counter set for IBM z16" + * c9311de71635 c9311de71635d3eaa158df8516b9b99a92d60a0c + "s390/cpumf: add new extended counter set for IBM z16" [Test Case] - * Prepare an IBM z16 LPAR with Ubuntu 20.04, 21.10 or 22.04 (incl. this + * Prepare an IBM z16 LPAR with Ubuntu 20.04, 21.10 or 22.04 (incl. this patch). - * At LPARs activation profile, navigate to the Security page -and within the counter facility options, select each counter set you want to use. -(One may just select all for testing purposes.) + * At LPARs activation profile, navigate to the Security page + and within the counter facility options, select each counter set you want to use. + (One may just select all for testing purposes.) - * Use 'perf list' to determine if the new counters are listed. -For comparing the new counters see: -https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git\ -/commit/?id=c9311de71635d3eaa158df8516b9b99a92d60a0c + * Use 'perf list' to determine if the new counters are listed. + For comparing the new counters see: + https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git\ + /commit/?id=c9311de71635d3eaa158df8516b9b99a92d60a0c - * Use 'perf stat -e' to enable and make use of these counters. + * Use 'perf stat -e' to enable and make use of these counters. [What can go wrong] - * Only new code is added by this commit - none is changed nor removed. + * Only new code is added by this commit - none is changed nor removed. - * The new code may have syntactical errors, -which would become visible during a test compile. + * The new code may have syntactical errors, + which would become visible during a test compile. - * Initialization of the new struct cpumcf_z16_pmu_event_attr could be + * Initialization of the new struct cpumcf_z16_pmu_event_attr could be wrong. - * The hex code for the counters could be wrong or mixed up, -or the names might be wrong or mixed up, -in which case one will get wrong or unexpected results. + * The hex code for the counters could be wrong or mixed up, + or the names might be wrong or mixed up, + in which case one will get wrong or unexpected results. - * The expansion of the case statement to determine the correct (z16) hardware -might be wrong, using wrong case hex numbers. -Which would lead to potentially counters, -that may not match to the underlying hardware. + * The expansion of the case statement to determine the correct (z16) hardware + might be wrong, using wrong case hex numbers. + Which would lead to potentially counters, + that may not match to the underlying hardware. + + [ Other info] + + * The commit will be upstream accepted with 5.18. +(It's was brought upstream 'next-20220517'.) + + * Since the planned target kernel for kinetic is 5.19, +this will be included. + + * Hence the SRU is for Focal, Impish and Jammy only. __ For IBM z16 machine the extended counter set needs to be exported by the PMU device driver CPU MF. The upstream commit from linux-next is commit-id: c9311de71635 s390/cpumf: add new extended counter set for IBM z16 The same patch will be imported into linux repo in the next merge window. Required patches are attached. They apply cleanly and compile without errors on focal (20.04) and jammy (22.04). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
** Description changed: + SRU Justification: + == + + [Impact] + + * This is a hardware enablement SRU + + * and adds support for (new) IBM z16 counters + + * by exporting the extended counter set counters of the IBM z16 via + sysfs. + + [Fix] + + * c9311de71635 c9311de71635d3eaa158df8516b9b99a92d60a0c +"s390/cpumf: add new extended counter set for IBM z16" + + [Test Case] + + * Prepare an IBM z16 LPAR with Ubuntu 20.04, 21.10 or 22.04 (incl. this + patch). + + * At LPARs activation profile, navigate to the Security page +and within the counter facility options, select each counter set you want to use. +(One may just select all for testing purposes.) + + * Use 'perf list' to determine if the new counters are listed. +For comparing the new counters see: +https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git\ +/commit/?id=c9311de71635d3eaa158df8516b9b99a92d60a0c + + * Use 'perf stat -e' to enable and make use of these counters. + + [What can go wrong] + + * Only new code is added by this commit - none is changed nor removed. + + * The new code may have syntactical errors, +which would become visible during a test compile. + + * Initialization of the new struct cpumcf_z16_pmu_event_attr could be + wrong. + + * The hex code for the counters could be wrong or mixed up, +or the names might be wrong or mixed up, +in which case one will get wrong or unexpected results. + + * The expansion of the case statement to determine the correct (z16) hardware +might be wrong, using wrong case hex numbers. +Which would lead to potentially counters, +that may not match to the underlying hardware. + + __ + For IBM z16 machine the extended counter set needs to be exported by the PMU device driver CPU MF. The upstream commit from linux-next is commit-id: c9311de71635 s390/cpumf: add new extended counter set for IBM z16 The same patch will be imported into linux repo in the next merge window. Required patches are attached. They apply cleanly and compile without errors on focal (20.04) and jammy (22.04). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
** Also affects: linux (Ubuntu Jammy) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Kinetic) Importance: Medium Assignee: Skipper Bug Screeners (skipper-screen-team) Status: New ** No longer affects: linux (Ubuntu Kinetic) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
** Summary changed: - [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 + [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1974433] Re: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16
** Also affects: ubuntu-z-systems Importance: Undecided Status: New ** Changed in: ubuntu-z-systems Assignee: (unassigned) => Skipper Bug Screeners (skipper-screen-team) ** Changed in: ubuntu-z-systems Importance: Undecided => Medium ** Changed in: linux (Ubuntu) Importance: Undecided => Medium ** Also affects: linux (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: linux (Ubuntu Impish) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1974433 Title: [UBUNTU 20.04] CPU-MF: add extended counter set definitions for new IBM z16 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-z-systems/+bug/1974433/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
