[Bug 2056099] Re: [MIR] tree
Someone please sponsor, this fixes a clitest autopkgtest regression caused by the introduction of the test framework patch. ** Patch added: "tree-1-2.1.1-2ubuntu3.diff" https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+attachment/5762166/+files/tree-1-2.1.1-2ubuntu3.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2056099] Re: [MIR] tree
Thanks. I can see `dh_auto_test` being executed in the latest build logs. Package has a team-bug-subscriber (~foundations-bugs, comment #2). No other MIR requirements (comment #3). Please move ahead and deploy the seed/dependency change to pull "tree" into main. ** Changed in: tree (Ubuntu) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2056099] Re: [MIR] tree
Uploaded debdiff adding a basic unit test framework from upstream gitlab merge proposal to noble as tree 2.1.1-2ubuntu1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2056099] Re: [MIR] tree
Here is a proposition of testsuite introduction with https://gitlab.com/OldManProgrammer/unix-tree/-/merge_requests/19/diffs ** Patch added: "Debdiff" https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+attachment/5760629/+files/add_tree_testsuite.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2056099] Re: [MIR] tree
Bypassing security-review, as per "This does not need a security review". So we'd still need the tests fixed before this is ready. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2056099] Re: [MIR] tree
Security is not asking to review this for NN, but this might have odd code. ``` /* Should probably use strdup(), but we like our xmalloc() */ #define scopy(x)strcpy(xmalloc(strlen(x)+1),(x)) ``` -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2056099] Re: [MIR] tree
Review for Source Package: tree [Summary] This is mature software and the pacakge is in pretty good state. They only problem is missing tests at build time. MIR team ACK under the constraint to resolve the below listed required TODOs and as much as possible having a look at the recommended TODOs. This does not need a security review List of specific binary packages to be promoted to main: tree Specific binary packages built, but NOT to be promoted to main: Notes: Required TODOs: 1. There are no tests running at build time. Could you please add some ? This could be the same tests with autopackage test, but running at build time, and fail the build in case of an error. - The package should get a team bug subscriber before being promoted [Rationale, Duplication and Ownership] There are other packages in main providing the same functionality, however tree is better and makes sense to have it in main. Foundations team is committed to own long term maintenance of this package. The rationale given in the report seems valid and useful for Ubuntu [Dependencies] OK: - no other Dependencies to MIR due to this - SRCPKG checked with `check-mir` - all dependencies can be found in `seeded-in-ubuntu` (already in main) - none of the (potentially auto-generated) dependencies (Depends and Recommends) that are present after build are not in main - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: None [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have unexpected Built-Using entries - not a go package, no extra constraints to consider in that regard - not a rust package, no extra constraints to consider in that regard Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not parse data formats (files [images, video, audio, xml, json, asn.1], network packets, structures, ...) from an untrusted source. - does not expose any external endpoint (port/socket/... or similar) - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) - does not deal with cryptography (en-/decryption, certificates, signing, ...) Problems: None [Common blockers] OK: - does not FTBFS currently - does have a non-trivial test suite that runs as autopkgtest - This does not need special HW for build or test - no new python2 dependency Problems: - does not have a test suite that runs at build time [Packaging red flags] OK: - Ubuntu does not carry a delta - symbols tracking not applicable for this kind of code. - debian/watch is present and looks ok (if needed, e.g. non-native) - Upstream update history is good - Debian/Ubuntu update history is good - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - debian/rules is rather clean - It is not on the lto-disabled list Problems: None [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (as far as we can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside tests) - no use of user nobody - no use of setuid / setgid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit, seed or libgoa-* - not part of the UI for extra checks - no translation present, but none needed for this case Problems: None ** Changed in: tree (Ubuntu) Status: New => Incomplete ** Changed in: tree (Ubuntu) Assignee: Ioanna Alifieraki (joalif) => (unassigned) ** Changed in: tree (Ubuntu) Assignee: (unassigned) => Alexandre Esse (ahresse) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2056099] Re: [MIR] tree
** Changed in: tree (Ubuntu) Assignee: (unassigned) => Ioanna Alifieraki (joalif) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2056099] Re: [MIR] tree
I think it makes sense for the Foundations team to own this package. I have subscribed foundations-bugs to the source package already. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2056099] Re: [MIR] tree
Github issue related to this MIR: https://github.com/canonical/ubuntu- mir/issues/52 ** Bug watch added: github.com/canonical/ubuntu-mir/issues #52 https://github.com/canonical/ubuntu-mir/issues/52 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2056099 Title: [MIR] tree To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/tree/+bug/2056099/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
