[Bug 2058133] Re: update-manager applet does exit successfully
The ubuntu-advantage-tools side had been discussed internally and "invalid" concluded as the best state because the best that could be done is to improve the error message, so I'm setting that back. ** Changed in: ubuntu-advantage-tools (Ubuntu) Status: Confirmed => Invalid ** Summary changed: - update-manager applet does exit successfully + update-manager crashes when ua security-status response is an error -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058133 Title: update-manager crashes when ua security-status response is an error To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2058133/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058133] Re: update-manager applet does exit successfully
Giacomo or anyone else getting "Unexpected error(s) occurred." from 'ua security-status --format=json', can you please also attach the output of python3 -c 'import uaclient.api.u.pro.packages.updates.v1 as ua;print(ua.updates().updates)' > The output of `pro security-status --format=json` and the internal error look correct, so I'm going to mark the ubuntu-advantage-tools bit as invalid. I don't understand this bit. I wouldn't say that "Unexpected error(s) occurred." looks correct, quite on the contrary, so I'm reverting the task but please let me know if you disagree. In any case, update-manager is also "to blame" insofar as it doesn't validate the output of that command and just directly tries to parse it as a JSON. For it, there are two possible ways forward: 1. If the output of the command is not a JSON, just skip all the Pro logic. Positive: Keep changes to a minimal for a backport to the LTS series. Negative: Buries the error and so we will not realize that the Pro logic was disabled, which is unintended behavior. 2. Use the API[1] as shown above. Positive: No exception is raised by the end point, and possibly it also gives the correct output even when the pro command would fail reported. This looks quite probable by the way, as from the log the command failed because of Livepatch, which update-manager has no interest in, but let's see if the affected users come back with that information. Negative: Changes are more encompassing as to see in [2]. [1] https://canonical-ubuntu-pro-client.readthedocs-hosted.com/en/latest/references/api/#u-pro-packages-updates-v1 [2] https://code.launchpad.net/~nteodosio/update-manager/+git/update-manager/+merge/459172 ** Changed in: ubuntu-advantage-tools (Ubuntu) Status: Invalid => Confirmed ** Changed in: update-manager (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058133 Title: update-manager applet does exit successfully To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2058133/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058133] Re: update-manager applet does exit successfully
** Changed in: update-manager (Ubuntu) Importance: Undecided => High ** Changed in: update-manager (Ubuntu) Assignee: (unassigned) => Nathan Teodosio (nteodosio) ** Changed in: update-manager (Ubuntu) Importance: High => Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058133 Title: update-manager applet does exit successfully To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2058133/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058133] Re: update-manager applet does exit successfully
Thanks for the logs. The output of `pro security-status --format=json` and the internal error look correct, so I'm going to mark the ubuntu-advantage-tools bit as invalid. It feels like this is something that should be handled and fixed in update-manager. https://bugs.launchpad.net/ubuntu/+source/update- manager/+bug/2049785 sounds very similar to this. ** Changed in: ubuntu-advantage-tools (Ubuntu) Status: Confirmed => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058133 Title: update-manager applet does exit successfully To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2058133/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058133] Re: update-manager applet does exit successfully
Hi, I've reported duplicate bug 2058158. I post the output of `pro security-status --format=json` below and attach as text file my ubuntu- avantage log. Unexpected error(s) occurred. For more details, see the log: /var/log/ubuntu-advantage.log To file a bug run: ubuntu-bug ubuntu-advantage-tools ** Attachment added: "ubuntu-advantage.log" https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2058133/+attachment/5757859/+files/ubuntu-advantage.log -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058133 Title: update-manager applet does exit successfully To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2058133/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058133] Re: update-manager applet does exit successfully
** Tags removed: need-amd64-retrace -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058133 Title: update-manager applet does exit successfully To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2058133/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 2058133] Re: update-manager applet does exit successfully
** Information type changed from Private to Public -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/2058133 Title: update-manager applet does exit successfully To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/2058133/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
