[Bug 314436] Re: package-diff can generate infinite output

[Launchpad QA Bot]

Fixed in stable r17862 .

** Tags added: qa-needstesting

** Changed in: launchpad
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/314436

Title:
  package-diff can generate infinite output

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpad/+bug/314436/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Colin Watson]

** Tags removed: qa-needstesting
** Tags added: qa-ok

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/314436

Title:
  package-diff can generate infinite output

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpad/+bug/314436/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Colin Watson]

** Changed in: launchpad
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/314436

Title:
  package-diff can generate infinite output

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpad/+bug/314436/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Launchpad Bug Tracker]

** Branch linked: lp:~cjwatson/launchpad/limit-debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/314436

Title:
  package-diff can generate infinite output

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpad/+bug/314436/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Colin Watson]

This happened again today with cordova-cli, twice.  I'm going to arrange
to kill debdiff after ten minutes, which should provide fairly
reasonable headroom for large packages; 99.9% of successful
PackageDiffJobs in 2015 finished inside 09:02, with the maximum being
33:31.  I'll make it a configuration option so that we can easily tweak
it if need be.

** Changed in: launchpad
 Assignee: (unassigned) => Colin Watson (cjwatson)

** Changed in: launchpad
   Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/314436

Title:
  package-diff can generate infinite output

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpad/+bug/314436/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Colin Watson]

This happened again today with a different package:

2015-09-17 15:41:12 INFORunning  to 

https://launchpad.net/~cordova-ubuntu/+archive/ubuntu/ppa/+packages

I think we probably need to put some kind of resource limits on this.

** Changed in: launchpad
   Importance: High => Critical

** Changed in: launchpad
   Status: Fix Released => Triaged

** Changed in: launchpad
Milestone: 3.0 => None

** Changed in: launchpad
 Assignee: Julian Edwards (julian-edwards) => (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/314436

Title:
  package-diff can generate infinite output

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpad/+bug/314436/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Ryan Finnie]

Same result with the 15.04 variant of the package in that PPA:

root 19040  0.0  0.0  41620  1824 ?S18:52   0:00  \_ CRON
lp_queue 19045  0.0  0.0   4396   608 ?Ss   18:52   0:00  |   \_ 
/bin/sh -c nice -n 10 
/srv/launchpad.net/production/launchpad/cronscripts/process-job-source.py 
IPackageDiffJobSource -q 
--log-file=DEBUG:/srv/launchpad.net/production-logs/lp_queue/process-job-source.IPackageDiffJobSource.log
lp_queue 19049  0.4  5.6 993456 689984 ?   SN   18:52   0:46  |   \_ 
/usr/bin/python -S 
/srv/launchpad.net/production/launchpad/cronscripts/process-job-source.py 
IPackageDiffJobSource -q 
--log-file=DEBUG:/srv/launchpad.net/production-logs/lp_queue/process-job-source.IPackageDiffJobSource.log
lp_queue 32223 64.9  0.0  42240  7100 ?RN   18:59 111:39  |   
\_ /usr/bin/perl -w /usr/bin/debdiff 
from/cordova-cli_5.0.0~ubuntu14.04.1-ubuntu2.dsc 
to/cordova-cli_5.3.1-ubuntu2~ubuntu14.04.1~ppa1.dsc

debdiff   32223lp_queue5u  REG8,1 163627839256
4063260 /tmp/debdifftU0kxW.diff
debdiff   32223lp_queue6r  REG8,1 163627839256
4063260 /tmp/debdifftU0kxW.diff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/314436

Title:
  package-diff can generate infinite output

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpad/+bug/314436/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Colin Watson]

Possibly more than just this commit, but this seems to be the main one:

http://git.savannah.gnu.org/cgit/diffutils.git/commit/?id=e3324651cc1f9f116754a4713e08bfb0bac50150

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/314436

Title:
  package-diff can generate infinite output

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpad/+bug/314436/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Colin Watson]

** Changed in: diffutils (Ubuntu)
 Assignee: Colin Watson (cjwatson) = (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/314436

Title:
  package-diff can generate infinite output

To manage notifications about this bug go to:
https://bugs.launchpad.net/launchpad/+bug/314436/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Curtis Hovey]

** Tags added: tech-debt

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Julian Edwards]

** Changed in: soyuz
   Status: Fix Committed = Fix Released

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Scott James Remnant]

** Changed in: diffutils (Ubuntu)
 Assignee: Scott James Remnant (scott) = Colin Watson (cjwatson)

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Launchpad Bug Tracker]

** Branch linked: lp:~julian-edwards/launchpad/no-udev-diff

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Julian Edwards]

** Changed in: soyuz
   Status: Triaged = In Progress

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Julian Edwards]

db-devel/ r8504

** Changed in: soyuz
   Status: In Progress = Fix Committed

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Colin Watson]

Here's a straightforward recipe that shows off the problem. Run this in
an empty scratch directory.

  mkdir a b
  for x in `seq 1 8`; do mkdir b/$x; for y in `seq 1 8`; do ln -s ../$(($y + 
1)) b/$x/$y; done; done
  diff -Nru a b

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Julian Edwards]

I will kill Soyuz's diff generation for udev until the diffutils fix
makes it back to hardy.

** Changed in: soyuz
 Assignee: Celso Providelo (cprov) = Julian Edwards (julian-edwards)

** Changed in: soyuz
Milestone: pending = 3.0

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Colin Watson]

I've forwarded this upstream:

  http://lists.gnu.org/archive/html/bug-gnu-utils/2009-09/msg00013.html

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Colin Watson]

I don't think it's *actually* infinite, as it doesn't appear to be
repeating itself directly - but it is producing output that's
exponentially large in the number of upward-pointing symlinks.

diff's recursion check right now is merely whether a symlink points to a
direct parent. However, an interlocking farm of symlinks of the form
../../sibling or similar defeats this check while permitting pairwise
(or worse) recursion that only gets broken once diff encounters a link
that resolves to a direct parent.

I've only looked at this relatively briefly, and it's late, but my gut
feel is that the best way to fix this would be to check for symlinks
pointing up in the directory tree but not pointing to a direct parent,
and skip them if they're underneath a directory which we intend to
compare recursively anyway. The latter check is slightly hairy, as it
interacts oddly with -N or lack thereof and whether the directory is
present in the other tree being compared, but I think it would only go
wrong in examples even more pathological than this. The only alternative
I could think of is to keep a note of all directories we've looked at
rather than just the parent chain, and I'm definitely not happy about
the unbounded space consumption that would involve.

This is a delicate one, and if we come up with something we should
definitely run it by upstream.

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Robbie Williamson]

** Changed in: diffutils (Ubuntu)
   Importance: Undecided = High

** Changed in: diffutils (Ubuntu)
 Assignee: (unassigned) = Scott James Remnant (scott)

** Changed in: diffutils (Ubuntu)
   Status: New = Confirmed

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[James Westby]

This appears to be a diff bug.

Thanks,

James


** Package changed: devscripts (Ubuntu) = diffutils (Ubuntu)

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 314436] Re: package-diff can generate infinite output

[Celso Providelo]

** Also affects: devscripts (Ubuntu)
   Importance: Undecided
   Status: New

-- 
package-diff can generate infinite output
https://bugs.launchpad.net/bugs/314436
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs