[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Changed in: tomboy Status: Confirmed => Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-ubuntu/+bug/386893/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Changed in: tomboy (Ubuntu) Assignee: Abhinav Upadhyay (er-abhinav-upadhyay) = John Kim (epikvision) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-ubuntu/+bug/386893/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
Hi John, You are welcome to work on this issue, but be aware that a patch for this issue has already been merged upstream, although there is a slight regression. You might want to check the upstream bug report on bugzilla. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-ubuntu/+bug/386893/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
I am not certain this needs fixing in Ubuntu, rather I believe it should be fixed upstream. This is in agreement with the opinions of Julian Taylor (jtaylor on freenode), during the brief discussion on this bug which was brought up on the MOTU IRC channel on freenode. This should really be left to be fixed upstream, and not fixed specifically in Ubuntu at this time. -- Thomas BugSquad Member -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-ubuntu/+bug/386893/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
Actually Abhinav, you can be assignee again. I'm very new to the bug fixing scene anyway. ** Changed in: tomboy (Ubuntu) Assignee: John Kim (epikvision) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-ubuntu/+bug/386893/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
John: I contributed a patch upstream but the bug has not been closed there because of a slight regression. I can't work on it because of lack of time, so you are welcome to work on this and make sure the bug gets closed upstream. :-) Thomas: I agree with you. The issue has been addressed upstream to a large extent but left open to fix a corner case. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-ubuntu/+bug/386893/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
Right, and the usual procedure in these sort of circumstances is to wait
until upstream releases a version with the patch included, then when you
push the package update for Ubuntu for that version you can just add
(LP: {this bug number}) to the changelog and this'll be autoclosed.
Regardless, I'm happy about the work going on :)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/386893
Title:
Searching within a notebook should inform the user that no results
were found within that notebook
To manage notifications about this bug go to:
https://bugs.launchpad.net/ayatana-ubuntu/+bug/386893/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Branch linked: lp:~er-abhinav-upadhyay/ubuntu/natty/tomboy/bug-386893 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
Hi, I made some additions to the code. So now, in case if there are no search results found in the selected Notebook, the user will be shown a Messagebox, where he is asked if he would like to search in All the Notebooks. If the user's response is Yes, then the search is performed again, with All Notes selected. It is working fine on my system. I am running Ubuntu 10.10 Architecture: x86 Package: tomboy (1.5.2) uname -a : Linux 2.6.35-27-generic #48-Ubuntu SMP i686 GNU/Linux ** Patch added: debdiff for the bug-386893 of Tomboy https://bugs.launchpad.net/ubuntu/+source/tomboy/+bug/386893/+attachment/1882754/+files/tomboy-bug-386893.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
I guess, the message box solution is too obtrusive. It unnecessarily takes away the focus. Scott suggested to display a message in the search results area along with a button to search again in all the notes. But I am not a gtk# hacker. So I don't know if something like that can be done without too much changes. The search results are displayed in a Gtk.Tree view. If there is a more elegant solution possible, then please suggest, I will try to make the changes and resubmit the patch :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
Abhinav, since you said you are going to take a shot at improving your submitted patch, I'll assign this bug to you and mark it in progress. I have also sent your patch to upstream, and it can be found in the bug link to the GNOME bug tracker on this page. Thanks for your work. ** Changed in: tomboy (Ubuntu) Status: Triaged = In Progress ** Changed in: tomboy (Ubuntu) Assignee: (unassigned) = Abhinav Upadhyay (er-abhinav-upadhyay) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/386893 Title: Searching within a notebook should inform the user that no results were found within that notebook -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Changed in: tomboy Importance: Unknown = Wishlist -- Searching within a notebook should inform the user that no results were found within that notebook https://bugs.launchpad.net/bugs/386893 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Also affects: ayatana-ubuntu Importance: Undecided Status: New -- Searching within a notebook should inform the user that no results were found within that notebook https://bugs.launchpad.net/bugs/386893 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Changed in: tomboy Status: New = Confirmed -- Searching within a notebook should inform the user that no results were found within that notebook https://bugs.launchpad.net/bugs/386893 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Bug watch added: GNOME Bug Tracker #588730 http://bugzilla.gnome.org/show_bug.cgi?id=588730 ** Also affects: tomboy via http://bugzilla.gnome.org/show_bug.cgi?id=588730 Importance: Unknown Status: Unknown -- Searching within a notebook should inform the user that no results were found within that notebook https://bugs.launchpad.net/bugs/386893 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Changed in: tomboy Status: Unknown = New -- Searching within a notebook should inform the user that no results were found within that notebook https://bugs.launchpad.net/bugs/386893 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 386893] Re: Searching within a notebook should inform the user that no results were found within that notebook
** Attachment added: Dependencies.txt http://launchpadlibrarian.net/27887942/Dependencies.txt ** Changed in: tomboy (Ubuntu) Importance: Undecided = Wishlist ** Changed in: tomboy (Ubuntu) Status: New = Triaged -- Searching within a notebook should inform the user that no results were found within that notebook https://bugs.launchpad.net/bugs/386893 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
