[Bug 390062] Re: Organise Files dialog, keywords aren't translated
Fixed in Saucy and Trusty ** Changed in: amarok (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/390062 Title: Organise Files dialog, keywords aren't translated To manage notifications about this bug go to: https://bugs.launchpad.net/amarok/+bug/390062/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
Launchpad has imported 16 comments from the remote bug at https://bugs.kde.org/show_bug.cgi?id=200516. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2009-07-17T08:23:19+00:00 Andrew Ash wrote: Version: amarok 2:2.1.1mysql5.1.30-0ubuntu1~jaunty1 (using KDE 4.2.4) OS:Linux Installed from:Ubuntu Packages [Forwarded from Ubuntu bug 390062 -- https://bugs.edge.launchpad.net/ubuntu/+source/amarok/+bug/390062] When organizing files using the Organise Files dialog (right click in any file in your collection) with a Spanish locale (I guess is the same in other locales) and in the avanced mode, there's a summary of keywords I can use. They are all translated in Spanish ( %artista, %año, etc), but the field only accepts English keywords (%artist, %year, etc). See http://launchpadlibrarian.net/28156768/amarok_organise_dialog.jpeg The solution would be to have the keywords in the QLineEdit be translated when they are used to determine paths to organize files to. Reply at: https://bugs.launchpad.net/amarok/+bug/390062/comments/3 On 2009-07-17T09:45:59+00:00 Myriam Schweingruber wrote: Not sure if this is an issue with KDE, I suspect a downstream problem... Reply at: https://bugs.launchpad.net/amarok/+bug/390062/comments/5 On 2009-07-22T01:58:37+00:00 Albert Astals Cid wrote: I'm wondering why this was re-assigned to me, from my POV it seems quite possible that you are letting people translate the keywords but you are not accepting them translated when the user inputs them. Is this re-assignement a strange way to ask for help or it's just a we don't care about i18n let put the bugs under a carpet? Reply at: https://bugs.launchpad.net/amarok/+bug/390062/comments/6 On 2009-07-22T03:10:34+00:00 Andrew Ash wrote: C++ is not my primary programming language, so take these comments with a grain of salt, but I think I've found where in the code the issue is occurring. /src/collection/sqlcollection/OrganizeCollectionDialog.cpp In the OrganizeCollectionDialog::buildDestination method, a map is created from a string to a string, called args. The first string is the key, and the second is the value. By giving the map a key, you can look up the value associated with that key. Semantically, it is being used such that the key is the short keyword used in the dialog (like %artist, %year, etc), and the value is what that keyword represents (like Pavarotti, or 2009). Towards the end of the method, the .namedOptArgs method is called, which I presume replaces the keywords with their values. The issue comes about in that the keys are not wrapped in the i18n() method required for internationalization when they are used in the code as keys. (For that matter they aren't either when displayed in the dialog box during the buildFormatTip() method, but I think that's just a change between SVN and the release last used in Ubuntu -- 2.1.1). With the i18n() wrapper, those strings would be translated to their local language equivalents, so when local language equivalents come through in the QString format argument those keys would be correctly replaced with the value the key represents. So then we need to decide what correct behavior should be. Do we want users to (A) be able to internationalize their keywords when building the organize files string, or (B) use the English versions as a standard for all languages? I think the first is preferable, unless there issues with using UTF8 QStrings as keys in QMaps, which I don't think there will be. In that case, simply throwing i18n() around every time that a string is used as a key to the QMap would probably change our behavior closer to (A). I would include a patch but don't have a dev box handy for generating one. Real developers, please comment :) Reply at: https://bugs.launchpad.net/amarok/+bug/390062/comments/7 On 2009-08-24T00:50:10+00:00 Lydia Pintscher wrote: Teo: reping about this :) Reply at: https://bugs.launchpad.net/amarok/+bug/390062/comments/8 On 2009-09-15T00:49:07+00:00 Teo-x wrote: This is not trivial, if these strings are not translated and handled consistently in the parser there could be issues. Andrew, if you're still interested feel free to prepare a patch for (A), also taking into consideration that this stuff will reflect on the guess tags dialog too. Target for merging would be post-2.2. Reply at:
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
** Changed in: amarok Status: Fix Released = Confirmed -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to amarok in ubuntu. https://bugs.launchpad.net/bugs/390062 Title: Organise Files dialog, keywords aren't translated -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
** Changed in: amarok Importance: Unknown = Medium -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to amarok in ubuntu. https://bugs.launchpad.net/bugs/390062 Title: Organise Files dialog, keywords aren't translated -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
Using Amarok 2.3.2 and the Organise Files dialog does still exists, dunno... reopening as keywords are still unstranslated. ** Changed in: amarok (Ubuntu) Status: Invalid = Confirmed -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to amarok in ubuntu. https://bugs.launchpad.net/bugs/390062 Title: Organise Files dialog, keywords aren't translated -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
Organise Files dialog no longer exists, so closing this report ** Changed in: amarok (Ubuntu) Status: Triaged = Invalid -- Organise Files dialog, keywords aren't translated https://bugs.launchpad.net/bugs/390062 You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to amarok in ubuntu. -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
** Changed in: amarok Status: Confirmed = Fix Released -- Organise Files dialog, keywords aren't translated https://bugs.launchpad.net/bugs/390062 You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to amarok in ubuntu. -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
** Changed in: amarok (Ubuntu) Status: Confirmed = Triaged ** Tags added: i18n kubuntu -- Organise Files dialog, keywords aren't translated https://bugs.launchpad.net/bugs/390062 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
** Changed in: amarok Status: New = Confirmed -- Organise Files dialog, keywords aren't translated https://bugs.launchpad.net/bugs/390062 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
Thanks for the bug report, m4v. This internationalization bug should be reported upstream on bugs.kde.org I'm confirming this bug in Ubuntu now. ** Changed in: amarok (Ubuntu) Importance: Undecided = Medium ** Changed in: amarok (Ubuntu) Status: New = Confirmed -- Organise Files dialog, keywords aren't translated https://bugs.launchpad.net/bugs/390062 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
** Bug watch added: KDE Bug Tracking System #200516 http://bugs.kde.org/show_bug.cgi?id=200516 ** Also affects: amarok via http://bugs.kde.org/show_bug.cgi?id=200516 Importance: Unknown Status: Unknown -- Organise Files dialog, keywords aren't translated https://bugs.launchpad.net/bugs/390062 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
** Changed in: amarok Status: Unknown = New -- Organise Files dialog, keywords aren't translated https://bugs.launchpad.net/bugs/390062 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
Andrew, I very much doubt this is a problem in KDE itself, more likely to be a bad translation import in Kubuntu, so reporting translation issues upstream is not really useful in this case AFAICT. This should change in 9.10, hopefully. -- Organise Files dialog, keywords aren't translated https://bugs.launchpad.net/bugs/390062 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 390062] Re: Organise Files dialog, keywords aren't translated
** Attachment added: amarok_organise_dialog.jpeg http://launchpadlibrarian.net/28156768/amarok_organise_dialog.jpeg ** Attachment added: Dependencies.txt http://launchpadlibrarian.net/28156769/Dependencies.txt -- Organise Files dialog, keywords aren't translated https://bugs.launchpad.net/bugs/390062 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
