[Bug 459164] Re: FTBFS with GCC 4.4
** Changed in: gnoemoe (Debian) Status: New = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/459164 Title: FTBFS with GCC 4.4 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gnoemoe/+bug/459164/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
** Branch linked: lp:ubuntu/gnoemoe -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
** Branch linked: lp:ubuntu/gnoemoe -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
** Changed in: gnoemoe (Debian) Status: Unknown = New -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
** Bug watch added: Debian Bug tracker #552635 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=552635 ** Changed in: gnoemoe (Debian) Importance: Undecided = Unknown ** Changed in: gnoemoe (Debian) Status: New = Unknown ** Changed in: gnoemoe (Debian) Remote watch: None = Debian Bug tracker #552635 -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
Implemented. Please see the merge proposal for details. Thanks Simon ** Changed in: gnoemoe (Ubuntu) Status: Incomplete = Confirmed -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
[09:43:14] ScottK Would someone that knows C please review https://code.edge.launchpad.net/~simono/ubuntu/karmic/gnoemoe/fixes-bug-459164/+merge/13854 [09:53:48] joaopinto ScottK, gint count = (strlen(no_ansi) - written); it could use just len no need to call strlen() again [09:54:17] ScottK joaopinto: Could you fix it and make a proper debbdiff? [09:55:15] joaopinto well, it's a very small improvement, doesn't worth a debdiff at this time, the code looks sane [09:56:20] zooko ScottK: something looks wrong to me. [09:57:04] zooko Suppose strlen(no_ansi) is 20 at the start. written gets initialized to 0. First pass of the loop, count = 20 [09:57:20] zooko suppose partial write, written = 5, then [09:57:41] zooko second pass of the loop, count = 15 [09:57:58] zooko so far so good -- it invokes write(fd, no_ansi+5, 15) [09:58:10] zooko but if there is a second partial write, let's say this time written = 6 [09:58:33] zooko so 3rd pass of the loop, count = 14 [09:58:35] joaopinto oh written is not cumulative :\ ** Changed in: gnoemoe (Ubuntu) Status: Confirmed = Incomplete -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
** Changed in: gnoemoe (Ubuntu) Status: Incomplete = Confirmed -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
https://code.edge.launchpad.net/~simono/ubuntu/karmic/gnoemoe/fixes- bug-459164/+merge/13854 -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
Patch is good. Uploaded. Thanks Simon for you work there. -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
This bug was fixed in the package gnoemoe - 2.2.0+dfsg-2ubuntu1 --- gnoemoe (2.2.0+dfsg-2ubuntu1) karmic; urgency=low * Fix FTBFS with GCC 4.4 (LP: #459164) -- Simon Olofsson si...@olofsson.de Mon, 26 Oct 2009 16:28:47 +0100 ** Changed in: gnoemoe (Ubuntu) Status: Confirmed = Fix Released -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
** Branch linked: lp:~simono/ubuntu/karmic/gnoemoe/fixes-bug-459164 -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
** Also affects: gnoemoe (Debian) Importance: Undecided Status: New -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
The above branch contains a fix. You can find the diff here: https://code.edge.launchpad.net/~simono/ubuntu/karmic/gnoemoe/fixes-bug-459164/+merge/13854 ** Changed in: gnoemoe (Ubuntu) Status: New = Confirmed -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 459164] Re: FTBFS with GCC 4.4
Hi, As stated by James Westby in the merge review: Please see https://wiki.ubuntu.com/CompilerFlags for a recipe for checking the return code of write fully. So I'll put the bug report as incomplete. Please put back as Confirmed when this is fixed. Fabrice ** Changed in: gnoemoe (Ubuntu) Importance: Undecided = Low ** Changed in: gnoemoe (Ubuntu) Status: Confirmed = Incomplete -- FTBFS with GCC 4.4 https://bugs.launchpad.net/bugs/459164 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
