[Bug 66566]

2019-02-22 Thread cousteau
I don't see how removing shift-enter and ctrl-shift-enter is even remotely 
related to the original request of making ctrl-enter open URLs in a new tab.  
In addition, it breaks a preexisting functionality of having shift-enter 
automatically add www. .net and ctrl-shift-enter add www. .org.
Personally, if this feature were really necessary (in which case it should have 
been opened as a separate bug), I would rather have it moved to an unused 
combination.  For example, Windows-enter could be "open in new window" and 
Windows-alt-enter for "open in new tab, but on the background".
Or, if it is really that important to have these shortcuts on shift and 
ctrl-shift, even despite of breaking preexisting behavior and getting a lot of 
users upset, at least make windows-enter and ctrl-windows-enter the new .net 
and .org shortcuts so that this functionality is not lost.
(Or going further: use alt for .com, windows for .net, and alt-windows for 
.org, so that ctrl is left for opening on a new tab, be it from the URL bar or 
from a link on the page; now THAT would solve the inconsistency issue the bug 
originally complained about.)

Ultimately, removing the shortcut for .net and .org but keeping it for
.com somehow suggests that .net and .org sites are "less important" than
.com ones.  I could expect that from a browser developed by google.com
or microsoft.com, but not from one developed by mozilla.org.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2019-02-22 Thread Bmorrison025
My Apple laptop has a Ctrl key on the left side only, which means this
functionality is no longer a one-handed operation. For me this is a
frustrating downgrade, but for others I expect it's an accessibility
issue. No? I'd also like an option to restore the longstanding behavior.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2019-02-22 Thread Gijskruitbosch+bugs
(In reply to cousteau from comment #163)

> I don't see how removing shift-enter and ctrl-shift-enter is even
remotely related to the original request of making ctrl-enter open URLs
in a new tab.

The point of the bug as filed was to make link opening modifiers work
the same between the url bar and other usecases. That applies to shift
and ctrl-shift as much as it does to just ctrl.

> Personally, if this feature were really necessary (in which case it
should have been opened as a separate bug), I would rather have it moved
to an unused combination.  For example, Windows-enter could be "open in
new window" and Windows-alt-enter for "open in new tab, but on the
background".

We don't use any windows+ shortcuts inside Firefox and doing
so would be going against platform convention, which we wouldn't do
without very good reasons, so this is a non-starter.

> Ultimately, removing the shortcut for .net and .org but keeping it for
.com somehow suggests that .net and .org sites are "less important" than
.com ones.  I could expect that from a browser developed by google.com
or microsoft.com, but not from one developed by mozilla.org.

In the global alexa top 50 there is 1 .org site (wikipedia), 1 .net site
(a Chinese site), and 48 .com sites, and so .com sites are pretty
conclusively more commonly used. Not to mention the fact that, if for
whatever reason .net (or any other suffix) is more common in your own
browsing habits, you can configure the default suffix in about:config
(both before and after this change), and it was never possible to
configure the suffix for shift-enter and ctrl-shift-enter.


I'm going to restrict comments here. The recent history of comments is just 
repeated complaints that reiterate ground that has already been covered, and as 
such isn't productive anymore. To reiterate:

- we won't (add a pref to) revert this behavior change. See comment #143. There 
are always trade-offs when making changes to frequently-used parts of the 
browser like the URL bar. We considered these trade-offs carefully before 
making the change. That doesn't mean we believe there are no negative 
side-effects, or that we don't regret people having to retrain muscle memory - 
it means we made the change despite those side-effects, because we believe the 
upsides outweigh those negative side-effects.
- yes, there's remaining ground to cover in terms of fixing up shortcuts to be 
even more consistent with other browsers and/or with other uses of modifier 
keys within Firefox. See bug 1513830, bug 1506203, bug 1506247 . If there's 
other inconsistencies that got missed, please file separate follow-up bugs.
- you can already change the default completion for ctrl-enter to something 
else in about:config using browser.fixup.alternate.suffix , if that's 
preferable over .com .
- there are extant bugs on file for improving webextension control over 
shortcuts via bug 1215061 and deps.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2019-02-07 Thread Bastien-l
(In reply to :Gijs (he/him) from comment #153)
> (In reply to Abhro from comment #152)
> > I do have history turned off, but visit previously visited sites that I do
> > know that TLD for and do not need to search for, thus pressing
> > [Ctrl+]Shift+Enter for .net / .org directly. I see the usefulness in being
> > able to open new windows from the awesome bar, but the .net / .org is still
> > widely enough used TLDs
> 
> IME, less so across the globe - that is, if I'm in (say) France, I'd
> probably prefer `.fr`, in South Africa, .za, etc.
> 
> The .net/.org shortcut was always hardcoded, and as noted before, no other
> browser has shortcuts for any other domains.
>From a Belgian guy living in Luxembourg and Australia: Nope, you're wrong. 
>.com, .net and .org are the most common extensions I type.
> 
> > that such autocomplete is desired behavior for some.
> > Any advice on reverting the behavior, or making a toggle between 'TLD
> > autocomplete' and 'open address in new window' possible?
> 
> You can control the suffix of `.com` and change it to something else using
> the `browser.fixup.alternate.suffix` pref in about:config , if you like. You
> could also use bookmarks for the sites you use regularly enough that you
> know the TLD, so that you don't need a modifier key at all and can probably
> hit enter sooner (TBH, I suspect this is likely to be an improvement for
> your usecase). As I already said in comment #150, I don't think we'll bring
> back (an option to use) separate modifier keys for .net/.org. Marco, can you
> confirm?
This is still bad.

I all liked the 3 shortcuts. Bring them back. There was no reason to
disable them.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2019-01-17 Thread Msisaac
Here's my situation:  I use a Mac, but I use a Windows keyboard.  I
changed my modifier keys in MacOS system preferences so that Control is
now Cmd and Cmd is now Control.  This means that I can use ctrl + key on
my keyboard for shortcuts, just like I would use in Windows (ctrl + c to
copy, ctrl + v to paste).  If I didn't make that change in system
preferences, I'd have to use the Windows key for those same shortcuts
(win + c to copy, win + v to paste), which is not how the shortcuts work
in Windows.  Before Firefox 64, ctrl + enter on my Windows keyboard
would autocomplete the URL with www. and .com, because I changed my
modifier keys in system preferences.  This behavior is consistent with
how it would work using the same keyboard in Windows.  Because of this
change to Firefox 64, I now have to use win + enter in Firefox, or I
have to change my system preferences modifier keys back to defaults,
which means Firefox would again use ctrl + enter on the keyboard to
autocomplete, but for everything else in the OS, I'd have to use the Win
key.  So Firefox is now the odd program on my Mac.  I have to retrain my
fingers to use win + enter on the Mac, but continue to use ctrl + enter
on Windows.

So while this is really more of a nuisance than a true show-stopper, it
would be nice if you offered a config that would revert the changes on
Macs if the user isn't using a Mac keyboard.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2019-01-17 Thread Anthony Sottile
this change is really unfortunate -- I just phished myself due to
relying on muscle memory that dates back at least 10 years.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2019-01-17 Thread Rhmzgx56
Actually, it's not the change that is unfortunate, but that it took 15
years for it to happen. Back then, there were far fewer people who had
developed the "wrong" muscle memory around it.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2019-01-17 Thread Boobox
Is there another thread where we can upvote a possible feature to change
this via an option?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2019-01-03 Thread Etienne Rastoul
Wow, I realized a few days ago that Shift+Enter and Ctrl+Shift+Enter
didn't work anymore, I thought it was a bug in my Linux distribution...
I'm surprised to see that this was a deliberate decision. I've been
using these keyboard shortcuts for years (probably more than a decade)
and I've always missed them when using another browser (they're one of
the reasons I've kept using Firefox all these years, when a lot of
people I know moved to Chrome for example)

I do a lot of browsing in a private browsing window, so some websites I
sometimes use are not (and never have been) in my navigation history or
in my bookmarks. Neither do I want some of these websites in my history
or bookmarks. It's almost become muscle memory after all these years to
type the domain and Ctrl+Enter, Shift+Enter or Ctrl+Shift+Enter :)

I guess someone will make an extension to bring back that feature :) Or
maybe I'll take the time to figure out how to do it myself, or I'll
patch and compile my own Firefox to bring it back... but given that I'm
too lazy to simply type .net or .org it doesn't look like any of this
will happen haha

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-22 Thread Mak77
(In reply to :Gijs (he/him) from comment #153)
> As I already said in comment #150, I don't think we'll bring
> back (an option to use) separate modifier keys for .net/.org. Marco, can you
> confirm?

No plain in sight.
You can star a page and use autofill for it though, if you access it often 
enough.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-22 Thread Abhro-r-dev
(In reply to :Gijs (he/him) from comment #151)
> (In reply to smmalis37 from comment #150)
> > > What happened so shift+enter and ctrl+shift+enter?
> > > Up to know shift+enter did .net and ctrl+shift+enter did .org.. now it 
> > > does
> > > open a new window or simply use .com.
> > 
> > I've been a Firefox user for years now. I use these keyboard shortcuts
> > daily. net and org are still extremely common TLDs, even with others
> > becoming more common. This change is annoying enough for me to seriously
> > consider downgrading to 63. I ask the Firefox team to please consider
> > reverting this change until there is a way for this functionality to be
> > supported by an extension.
> 
> I don't see this happening. Consistency both with other browsers and other
> shortcuts trumps the need for alternative domain autocompleting (and really,
> without the other browsers it would probably have trumped .com autocomplete,
> too).
> 
> I'm also really quite confused by the .net / .org case - do you turn off
> autocomplete and/or history (in the location bar), or something? Why can't
> you just hit "normal" enter when the domain you want gets autocompleted? Do
> you just visit new .net/.org domains (where you somehow do know the exact
> TLD you want, so you don't use a search engine, but you have never visited
> before) every day? That seems like a very niche usecase...
> 
> In terms of add-ons, it'd be pretty trivial to write an add-on that just
> provided you a toolbar button that, when clicked (or activated via a new
> shortcut of the add-on's choosing), provided an alternative input, where you
> could type anything and it'd just suffix '.net' or '.org' and navigate the
> current URL to it. I accept that's quite kludgy, but if you really can't use
> autocomplete / history for this and are annoyed at typing '.net' or '.org'
> after URLs, I think that might currently be your best option.

I do have history turned off, but visit previously visited sites that I
do know that TLD for and do not need to search for, thus pressing
[Ctrl+]Shift+Enter for .net / .org directly. I see the usefulness in
being able to open new windows from the awesome bar, but the .net / .org
is still widely enough used TLDs that such autocomplete is desired
behavior for some. Any advice on reverting the behavior, or making a
toggle between 'TLD autocomplete' and 'open address in new window'
possible?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-22 Thread Joshua Bell
This change made me a little sad. I used the old hotkeys about a quarter
or a third of every time I used the URL bar.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-22 Thread Gijskruitbosch+bugs
(In reply to Abhro from comment #152)
> I do have history turned off, but visit previously visited sites that I do
> know that TLD for and do not need to search for, thus pressing
> [Ctrl+]Shift+Enter for .net / .org directly. I see the usefulness in being
> able to open new windows from the awesome bar, but the .net / .org is still
> widely enough used TLDs

IME, less so across the globe - that is, if I'm in (say) France, I'd
probably prefer `.fr`, in South Africa, .za, etc.

The .net/.org shortcut was always hardcoded, and as noted before, no
other browser has shortcuts for any other domains.

> that such autocomplete is desired behavior for some.
> Any advice on reverting the behavior, or making a toggle between 'TLD
> autocomplete' and 'open address in new window' possible?

You can control the suffix of `.com` and change it to something else
using the `browser.fixup.alternate.suffix` pref in about:config , if you
like. You could also use bookmarks for the sites you use regularly
enough that you know the TLD, so that you don't need a modifier key at
all and can probably hit enter sooner (TBH, I suspect this is likely to
be an improvement for your usecase). As I already said in comment #150,
I don't think we'll bring back (an option to use) separate modifier keys
for .net/.org. Marco, can you confirm?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-18 Thread smmalis37
> What happened so shift+enter and ctrl+shift+enter?
> Up to know shift+enter did .net and ctrl+shift+enter did .org.. now it does
> open a new window or simply use .com.

I've been a Firefox user for years now. I use these keyboard shortcuts
daily. net and org are still extremely common TLDs, even with others
becoming more common. This change is annoying enough for me to seriously
consider downgrading to 63. I ask the Firefox team to please consider
reverting this change until there is a way for this functionality to be
supported by an extension. I'll even write the extension myself, but
judging by https://bugzilla.mozilla.org/show_bug.cgi?id=1215061 such an
extension isn't possible yet.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-18 Thread Gijskruitbosch+bugs
(In reply to smmalis37 from comment #150)
> > What happened so shift+enter and ctrl+shift+enter?
> > Up to know shift+enter did .net and ctrl+shift+enter did .org.. now it does
> > open a new window or simply use .com.
> 
> I've been a Firefox user for years now. I use these keyboard shortcuts
> daily. net and org are still extremely common TLDs, even with others
> becoming more common. This change is annoying enough for me to seriously
> consider downgrading to 63. I ask the Firefox team to please consider
> reverting this change until there is a way for this functionality to be
> supported by an extension.

I don't see this happening. Consistency both with other browsers and
other shortcuts trumps the need for alternative domain autocompleting
(and really, without the other browsers it would probably have trumped
.com autocomplete, too).

I'm also really quite confused by the .net / .org case - do you turn off
autocomplete and/or history (in the location bar), or something? Why
can't you just hit "normal" enter when the domain you want gets
autocompleted? Do you just visit new .net/.org domains (where you
somehow do know the exact TLD you want, so you don't use a search
engine, but you have never visited before) every day? That seems like a
very niche usecase...

In terms of add-ons, it'd be pretty trivial to write an add-on that just
provided you a toolbar button that, when clicked (or activated via a new
shortcut of the add-on's choosing), provided an alternative input, where
you could type anything and it'd just suffix '.net' or '.org' and
navigate the current URL to it. I accept that's quite kludgy, but if you
really can't use autocomplete / history for this and are annoyed at
typing '.net' or '.org' after URLs, I think that might currently be your
best option.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread Gpy98671
(In reply to :Gijs (he/him) from comment #147)
> No other browser implements these

That's my point!
It's extremely usefull for fast navigation, at least for me or my colls at work.
Of course you can type in .net or .org, use favorites, or something else.
But I don't the point in linking opening URLs in a new window with that - even 
if its old - feature.
It might be a relic and not know to many users, but I would like at least have 
the chance to decide if I want the new or the old feature.

Now I'm pretty upset about the latest Firefox, there were already a lot
things I missed during the latest versions, but that one is a real
issue.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread Gijskruitbosch+bugs
(In reply to uhr80386 from comment #146)
> What happened so shift+enter and ctrl+shift+enter?
> Up to know shift+enter did .net and ctrl+shift+enter did .org.. now it does
> open a new window or simply use .com.

They were removed to enable support for opening URLs in a new window. No
other browser implements these, and with the current set of available
TLDs being rather different from those of the late 90s, there didn't
seem a good reason to keep this behaviour. There isn't a pref to revert
that change.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread avada
(In reply to Marco Bonardo [::mak] from comment #141)
> (In reply to Anthony Ramine [:nox] from comment #140)
> > The keyboard shortcut cmd-enter opens links in new *background* tabs in
> > Chrome and Safari, Firefox is now opening them in new *foreground* tabs. Is
> > there any way to change this behaviour?
> 
> Please file a new bug, if the behavior is inconsistent with Chrome and
> Safari we'll look into it.

I think it's also inconsistent with Firefox itself.
"browser.tabs.loadDivertedInBackground;true" should apply for this too
at least.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread Mak77
(In reply to Jesse Peden from comment #138)
> I suppose it is, but it seems to be counter-productive to get users used to
> having it be CMD-Enter for all of these years and then change it out of the
> middle of nowhere.  They could have at least added an option to allow people
> to opt out of it.

We must evolve, and on certain things that means also reaching consensus and 
coherence with the other browsers, so that users can easily find themselves 
comfortable moving across them (even if just for development, testing, 
web-compat issues). Unfortunately in some cases this means changing behaviors 
that have been with us from a long time (I'm here from 11 years, I know well).
If we'd add a pref for each change, in a few years the code would become 
totally unmanageable. Surely adding one pref here looks like a no-brainer, but 
if you multiple that by the hundreds of times I heard someone asking for a 
pref, you can easily see it's not sustainable long term.
Breaking habits and muscle memory is bad, we don't do that often and we try to 
avoid it, but when an habit hurts a part of our users and it's inconsistent 
with the rest of the browsers world, we may actually look into it. This was one 
case, there have been others, there will be others.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread Alexander-kern
(In reply to gpy98671 from comment #148)

gpy98671 until the team changes it's opinion on this, which doesn't look
likely, there would need to be an extension to get your desired
functionality back. However AFAIK webextensions do not have this
capability right now. You can join the conversation here to follow the
progress and/or help/get help:
https://bugzilla.mozilla.org/show_bug.cgi?id=1215061

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread J-nox
It's kinda the topic of this bug, though, see its title:

> for Windows/Linux users where it interferes with opening URLs in
(background) tabs

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread Uhr80386
What happened so shift+enter and ctrl+shift+enter?
Up to know shift+enter did .net and ctrl+shift+enter did .org.. now it does 
open a new window or simply use .com.

That's not how it should be.
How can I change it back?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread Mak77
(In reply to Anthony Ramine [:nox] from comment #140)
> The keyboard shortcut cmd-enter opens links in new *background* tabs in
> Chrome and Safari, Firefox is now opening them in new *foreground* tabs. Is
> there any way to change this behaviour?

Please file a new bug, if the behavior is inconsistent with Chrome and
Safari we'll look into it.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread Gijskruitbosch+bugs
(In reply to alexander.kern from comment #139)
> :Gijs, I don't know how to tag people here so I hope posting here again is
> ok to contact you. Could you show me the lines where you changed this code
> so I can have a look at it? Because on the issue I created

I commented on bug 1506203.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread Alexander-kern
Jesse, you can follow the progress of the issue/bug for better keyboard 
shortcut control here https://bugzilla.mozilla.org/show_bug.cgi?id=1215061
When it's done there can be extensions that change this behavior. It is a bit 
unfortunate the change to webextensions was rushed and now we are missing some 
features.

:Gijs, I don't know how to tag people here so I hope posting here again
is ok to contact you. Could you show me the lines where you changed this
code so I can have a look at it? Because on the issue I created it was
said that it might be too much development effort to fix the issue
(resolving the inconsistency of pressing multiple modifiers and enter in
the navbar). Thank you!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-14 Thread J-nox
The keyboard shortcut cmd-enter opens links in new *background* tabs in
Chrome and Safari, Firefox is now opening them in new *foreground* tabs.
Is there any way to change this behaviour?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to Jesse Peden from comment #136)
> On macOS, how can I bring back CMD-Enter for URL completion?  I do not want
> CTRL-Enter on macOS, and I can't seem to find the option in about:config to
> change it back.

There isn't one. Ctrl-Return is consistent with Safari and Chrome on
mac.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread SyKoTiK
On macOS, how can I bring back CMD-Enter for URL completion?  I do not
want CTRL-Enter on macOS, and I can't seem to find the option in
about:config to change it back.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to David Balažic from comment #134)
> How exactly is this fixed? Where?
> 
> The https://www.mozilla.org/en-US/firefox/64.0/releasenotes/ doesn't mention
> it.

It does:

"The macOS keyboard shortcut to add "www" and ".com" to a URL is now
ctrl-enter instead of [apple]-enter"

This is the only by-default change here. See the end of comment 124.

> (In reply to Julien Cristau [:jcristau] from comment #132)
> > Added to 64beta release notes: 
> > Changes to URL bar autocomplete keyboard shortcuts: use ctrl-enter for URL
> > canonicalization on all platforms, and offer an opt-out for Windows/Linux
> > users where it interferes with opening URLs in (background) tabs
> 
> Was this dropped for the final release?

No, the relnote just got repeatedly rewritten to simplify it and make it
understandable/relevant for people who hadn't followed this bug.

> What is the opt-out mechanism?

On Windows/Linux you can change this by setting
`browser.urlbar.ctrlCanonizesURLs` to false.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Julien Cristau
Added to 64beta release notes: 
Changes to URL bar autocomplete keyboard shortcuts: use ctrl-enter for URL 
canonicalization on all platforms, and offer an opt-out for Windows/Linux users 
where it interferes with opening URLs in (background) tabs

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread David-balazic
How exactly is this fixed? Where?

The https://www.mozilla.org/en-US/firefox/64.0/releasenotes/ doesn't
mention it.

(In reply to Julien Cristau [:jcristau] from comment #132)
> Added to 64beta release notes: 
> Changes to URL bar autocomplete keyboard shortcuts: use ctrl-enter for URL
> canonicalization on all platforms, and offer an opt-out for Windows/Linux
> users where it interferes with opening URLs in (background) tabs

Was this dropped for the final release?

What is the opt-out mechanism?

PS: Bugzilla needs a "final summary" field where things like this are
documented.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread SyKoTiK
(In reply to :Gijs (he/him) from comment #137)
> (In reply to Jesse Peden from comment #136)
> > On macOS, how can I bring back CMD-Enter for URL completion?  I do not want
> > CTRL-Enter on macOS, and I can't seem to find the option in about:config to
> > change it back.
> 
> There isn't one. Ctrl-Return is consistent with Safari and Chrome on mac.

I suppose it is, but it seems to be counter-productive to get users used
to having it be CMD-Enter for all of these years and then change it out
of the middle of nowhere.  They could have at least added an option to
allow people to opt out of it.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Alexander-kern
Followup issues for inconsistencies of combinations and search input added:
https://bugzilla.mozilla.org/show_bug.cgi?id=1506203
https://bugzilla.mozilla.org/show_bug.cgi?id=1506247
respectively.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to alexander.kern from comment #128)
> Oh and it's not possible with the search bar right now! They don't seem to
> share the code. Is that considered as a bug? :Gijs?

Could you file a separate issue, and we can work out if it's fixable
there? IIRC there are some other subtleties with how search behaves
(e.g. defaults for whether tabs open in the foreground or not when you
use the page context menu to search are governed by a different pref to
the one governing "normal" links opened in tabs). So I'm not sure off-
hand how easy it would be to fix. Either way we usually try to fix 1
thing per bug to avoid confusion about what is/isn't fixed. So fixing
the search bar, given that it's not using the same code as per your
comment, will need to have its own bug.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Alexander-kern
Hey all, I think opening a new tab in background in a fast way/without
leaving the current page is very useful. I had an extension for that but
it's no longer possible because webext API does not offer that
possibility. That's why I'm following this bug closely. However now I'm
surprised. Here are all the things that happen on Firefox nightly 64.0a1
(2018-09-06) (64-Bit):

ctrl: add www..com
ctrl shift: www.com (should be add www..com in new window?)
shift: new window foreground
alt: new tab foreground
alt ctrl: add www..com and open in new tab foreground
alt shift: nothing happens, should be default action in tab background or new 
window background?
alt shift ctrl: www.com new tab background

The name/description of this bug is "Inconsistent "open in new tab"
shortcuts (Ctrl+Enter for links, but Alt+Enter in address bar and search
bar)"

So I think the changes now are useful, but do they solve the original
issue? Ctrl+Enter still doesn't open a new tab in background, like it
does everywhere else. I suggest:

ctrl: open in new tab in background
shift: open in new window in foreground
alt: Doesn't matter to me, maybe add www..com so people who want it still have 
it or keep it as new tab in foreground (but what's the advantage of that? just 
hit ctrl+t)
ctrl shift: open in new window in background
alt shift: like alt but in new window in foreground
alt ctrl: like alt but in new background tab
alt shift ctrl: like alt but in new window in background

What do you think? Sorry, I don't want to stand in the way of closing
this or marking it as fixed, but it doesn't seem to address the original
point to me. Anyway thanks for the changes and reading this.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Alexander-kern
Hi! Yes it is possible! Well no to be exact, not possible with
ctrl+enter but with ctrl+shift+enter instead. You can try the newest
nightly/alpha/Aurora version of Firefox and test it out yourself. So you
could use it right now :-)

So if Webextensions can modify about:config settings you could revive your 
extension but with ctrl+shift+enter instead. I don't think it's possible for 
Webextensions to edit that keyboard command (some others like ctrl+f are 
possible to rewrite though). If you want to track progress on that issue, it is 
https://bugzilla.mozilla.org/show_bug.cgi?id=1215061
However enter is not even a keyboard shortcut I suppose so it is probably not 
affected by that issue, right?

Oh and it's not possible with the search bar right now! They don't seem
to share the code. Is that considered as a bug? :Gijs?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Stanley Chan
(In reply to Marco Bonardo [::mak] from comment #106)
> So, we apparently do:
> ctrl => .com
> shift => .net
> ctrl + shift => .org
> 
> First, I'm not convinced .net and .org are more important than the other
> many tlds around, for example in a localized build it would be far more
> interesting to canonize to the local tld (for example .it for italian). I'd
> totally support ctrl+shift to complete to the localized tld rather than .org
> (though this would require localization support).
> Second, I'd like if ctrl would be the necessary key to activate canonization
> in general, so all the shortcuts should required ctrl to be pressed. Shift
> is far too common when typing and as I said it's already used by
> tab/tabshifted, it's just confusing.
> I understand changing this we could break muscle memory of a minority, but
> it's for a totally undiscoverable feature on less critical tlds than .com.
> and we're changing cmd on Mac already, for which we'll want a relnote.
> I'd honestly propose to drop the shift and ctrl+shift behaviors completely.

Color me surprised when I updated to Nightly 64.0 and found out that the
keyboard shortcuts that I've relied on Firefox having for the past 15
years apparently requires some rewiring of muscle memory. This change
does make sense and does indeed make it more consistent all around --
but will definitely catch A LOT of long-time macOS Firefox users off-
guard if not announced gracefully. This goes the same for keybord-
shortcut aficionados/ power users.

It will also require documentation updates (i.e.
https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-
tasks-quickly#w_miscellaneous_2 and https://blog.mozilla.org/firefox
/keyboard-shortcuts-command-qwerty/) since this is literally 15 year old
behavior that is changing. It's also been blogged about over the years
throughout various websites that cater to the power user (such as
LifeHacker and How-To-Geek), but that's nothing that Mozilla controls.

That being said, can we get about:config options to configure the Ctrl-
Shift and Shift-Enter shortcuts in the address bar? When this feature
was first added, .com, .net. and .org were the most popular of TLD
suffixes. Today, I can see how that is different, and I will admit that
I do not complete .net and .org domains as often. I agree that not many
people used it, but perhaps it can be more accessible if a user can
configure those prefixes and suffixes directly.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Maruf-rahman-95
I have reproduced this bug with Nightly version 1.0+ (2004-12-14)[] on Windows 
7, 64 Bit!
User agent- Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.8a6) 
Gecko/20041224 Firefox/1.0+

Thus bug's fix is verified with latest Nightly!

Build ID20180927220034
User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:64.0) 
Gecko/20100101 Firefox/64.0

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to alexander.kern from comment #125)
> (Yeah, but not using the URL bar is just not as nice. For example look &
> feel, use search & bookmarks keywords, afaik.)

Yep... perhaps there's room for webextensions to have a larger scope for 
interaction with the URL bar - you could file a bug in the webextensions 
product.
 
> Ah thanks, I missed the mention of that pref! Well I'd rather have it not be
> consistent, but I understand your reasoning and gave my opinion.

Likewise! It's a tricky problem - I was joking on IRC the other day that
really we need like 10 modifier keys instead of just 3, then it wouldn't
be so hard to come up with a way to make things not conflict...

> Still, should the combinations not stack like ctrl+shift canonize and open
> in new window? alt+ctrl does already stack as expected (canonize and open
> new tab). Why does only that stack? And alt+shift to open in new background
> tab would be incredibly useful for users who don't want to mess with
> about:config or don't know about it. They can just find it by trying it out
> or understanding how stacking should work.
> 
> Anyway this is a followup issue and you said you wanted this bug to be
> closed, so if I don't hear back soon I'll submit a new ticket. Thanks!

Yes, please submit a new bug for alt-shift / ctrl-shift. :-)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mozdev-l
That's fantastic, thanks for attending to it! I'll miss ctrl-enter, but
ctrl-shift-enter is a perfectly reasonably compromise. :-)

I filed bug #1490138 for the search bar (hopefully I got the details
right).

I probably won't bother making a new extension just for the about:config
pref. If the search bar implements something similar as well, Background
Tabs will be happily obsolete!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Alexander-kern
(Yeah, but not using the URL bar is just not as nice. For example look &
feel, use search & bookmarks keywords, afaik.)

Ah thanks, I missed the mention of that pref! Well I'd rather have it
not be consistent, but I understand your reasoning and gave my opinion.

Still, should the combinations not stack like ctrl+shift canonize and
open in new window? alt+ctrl does already stack as expected (canonize
and open new tab). Why does only that stack? And alt+shift to open in
new background tab would be incredibly useful for users who don't want
to mess with about:config or don't know about it. They can just find it
by trying it out or understanding how stacking should work.

Anyway this is a followup issue and you said you wanted this bug to be
closed, so if I don't hear back soon I'll submit a new ticket. Thanks!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mozdev-l
Hi -- I developed (an overstatement, maybe) the now-defunct extension
Background Tabs which allowed ctrl-enter to open URL bar and search bar
items in a background tab. I was excited to see this:

> This behavior is now possible, but it's behind a pref (about:config,
browser.urlbar.ctrlCanonizesURLs)

...does that mean that a user will be able to change that pref and then
ctrl-enter in the URL bar will open a background tab without switching
to it?

Will there be a similar option for the search bar? (Consistency would
seem to dictate that there should be?)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread avada
(In reply to :Gijs (he/him) from comment #114)
> (In reply to avada from comment #113)
> > (In reply to Marco Bonardo [::mak] from comment #111)
> > > It should, yes. Overall the idea is that CTRL will be the canonization 
> > > key,
> > > and it should be possible to disable it, as well as it should imo be
> > > possible to set what to canonize to (if one prefers .it to .com, for
> > > example).
> > > Then on Mac, CMD will open in a new tab, rather trying to canonize.
> > 
> > Will this finally work with the normal find bar an not just the quickfind
> > bar?
> 
> I don't understand - this bug has nothing to do with the find bar, it's
> about the location bar. The 'search bar' in the summary is about the bar
> that searches on your default search engine (e.g. duckduckgo, google, bing,
> ...), not the find-in-page feature. Did you mean to comment on a different
> bug?

Not at all. With the quickfind bar you can press enter to open a link,
or press ctrl+enter to open it in a new tab. But you can not do this
with the normal findbar.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mak77
Comment on attachment 8996717
Bug 237027 - allow turning off URL canonization, remove shift support, and move 
the remainder from 'cmd' to 'ctrl' on mac, r?mak

Marco Bonardo [::mak] has approved the revision.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to Marco Bonardo [::mak] (Away 9-26 Aug) from comment #103)
> I made a small sheet to better understand what changes here, please check
> and comment if something doesn't look correct.
> https://docs.google.com/spreadsheets/d/
> 1VVEVjyIYRZIFteM71j5bJhENa2xXT82gaikr0WgpKLA/edit#gid=0
> 
> I didn't test the patch, I just assumed, on IRC Gijs said it's likely
> different.
> Anyway, I added a row with the behavior I'm suggesting, that is pretty much
> the same as Chromium, apart ALT+Enter on the Mac.

I think I implemented this in the updated patch, though I left out the
support for downloads using 'alt-enter' on mac. I'm not convinced people
want that behaviour, and in any case it'd re-introduce per-platform
checks and some redundant calls to whereToOpenLink that I'm not super-
fond of.

Note that the spreadsheet doesn't cover shift-enter, which also
canonifies today. I left that as-is, though of course that now also
comes under the pref, and can therefore be turned off (at which point
we'll open a new window instead).

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mak77
And, we could make canonize complete to browser.fixup.alternate.prefix
and browser.fixup.alternate.suffix, so the user can adapt it to his
needs.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Aryx-bugmail
https://hg.mozilla.org/mozilla-central/rev/6b31860ce710

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to alexander.kern from comment #123)
> Hey all, I think opening a new tab in background in a fast way/without
> leaving the current page is very useful. I had an extension for that but
> it's no longer possible because webext API does not offer that possibility.

Not from the URL bar, but extensions can definitely open background
tabs, so an add-on could still do this using a page/browser action or a
sidebar to offer you UI.

> That's why I'm following this bug closely. However now I'm surprised. Here
> are all the things that happen on Firefox nightly 64.0a1 (2018-09-06)
> (64-Bit):
> 
> ctrl: add www..com
> ctrl shift: www.com (should be add www..com in new window?)
> shift: new window foreground
> alt: new tab foreground
> alt ctrl: add www..com and open in new tab foreground
> alt shift: nothing happens, should be default action in tab background or
> new window background?
> alt shift ctrl: www.com new tab background
> 
> The name/description of this bug is "Inconsistent "open in new tab"
> shortcuts (Ctrl+Enter for links, but Alt+Enter in address bar and search
> bar)"
> 
> So I think the changes now are useful, but do they solve the original issue?
> Ctrl+Enter still doesn't open a new tab in background, like it does
> everywhere else. I suggest:
> 
> ctrl: open in new tab in background

This behavior is now possible, but it's behind a pref (about:config,
browser.urlbar.ctrlCanonizesURLs), because the outcome of some of the
(long) discussion here was that to remain consistent with Chrome and
IE/Edge, we would continue to keep that as the default (see e.g. comment
#93). Note that AFAIK Chrome uses `ctrl-enter` even on Linux and Mac, so
per the spreadsheet in comment #103 (
https://docs.google.com/spreadsheets/d/1VVEVjyIYRZIFteM71j5bJhENa2xXT82gaikr0WgpKLA/edit#gid=0
) the default there is also to use ctrl-enter. (This is a change on mac,
where it used to be cmd-enter.)

I'll change the summary to more accurately reflect what was changed
here.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Pulsebot
Pushed by gijskruitbo...@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6b31860ce710
allow turning off URL canonization, remove shift support, and move the 
remainder from 'cmd' to 'ctrl' on mac, r=mak

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
Release Note Request (optional, but appreciated)
[Why is this notable]: see comment #121
[Affects Firefox for Android]: no
[Suggested wording]: not sure, maybe: "Changes to URL bar autocomplete 
shortcuts"
[Links (documentation, blog post, etc)]: I'll update 
https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#w_miscellaneous_2
 .


(In reply to Stanley Chan from comment #121)
> It will also require documentation updates (i.e.
> https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-
> tasks-quickly#w_miscellaneous_2 and

I'll submit an update for this after submitting this comment; it'll need
to be approved by the SUMO admins.

> https://blog.mozilla.org/firefox/keyboard-shortcuts-command-qwerty/)

I'll set user-doc-needed here for the above and to get this updated as
well.

> this is literally 15 year old behavior that is changing. It's also been
> blogged about over the years throughout various websites that cater to the
> power user (such as LifeHacker and How-To-Geek), but that's nothing that
> Mozilla controls.

No, I'm afraid if we could never update something that had been
documented anywhere else, we would have long ago stopped making Firefox
because of our inability to change pretty much anything... even our
easter eggs get documented, for better and for worse...

> That being said, can we get about:config options to configure the Ctrl-Shift
> and Shift-Enter shortcuts in the address bar?

There is already for the ctrl-enter case (you can change the suffix via
about:config's browser.fixup.alternate.suffix). We removed the shift
/ctrl-shift option completely because no other browser has those and
they didn't seem useful.

> When this feature was first
> added, .com, .net. and .org were the most popular of TLD suffixes. Today, I
> can see how that is different, and I will admit that I do not complete .net
> and .org domains as often. I agree that not many people used it, but perhaps
> it can be more accessible if a user can configure those prefixes and
> suffixes directly.

I see your point, but can I just point out that:

- shift-click/enter normally opens new windows on all other types of shortcuts 
/ bookmark/history entries etc.
- shift-click/enter is also used for "turning off" switch-to-tab (in order to 
open links that you have open already a second time)
- shift when used with opening new tabs in other places (which uses 'ctrl' on 
Win/Linux) toggles the background/foreground-ness of tabs

so having Yet Another Possible Meaning for the 'shift' modifier here is
neither very user-friendly nor all that maintainable in the codebase we
have. In fact, even removing it caused me a few different headaches
trying to not break any of the other behaviors.

The other thing is the value proposition. You'd want this shortcut to
avoid typing '.' followed by 2-3 other characters (generally... if you
use loads of different '.americanexpress' domains and want to configure
ctrl-shift-enter for those, then I'm very sorry...). Just the
awkwardness of `ctrl-shift-enter` rather than simply typing those 3-4
chars doesn't seem very valuable to me. That's in addition to the fact
that, 15 years since this stuff was implemented, we now autofill history
for domains, so if you've visited the site before you can just hit
'enter' straightaway anyway...

We're also much more reluctant to add more magical about:config switches
that we don't expose in the "regular" options/preferences (and yet more
reluctant to add *more* things to those options).

So on the whole, I'm not excited about adding this back, not even with
configurable suffixes. If my arguments don't seem convincing, please
file a separate bug and we'll discuss there, but with 121 comments here
so far, I don't think this is the best place. :-)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mak77
So, we apparently do:
ctrl => .com
shift => .net
ctrl + shift => .org

First, I'm not convinced .net and .org are more important than the other many 
tlds around, for example in a localized build it would be far more interesting 
to canonize to the local tld (for example .it for italian). I'd totally support 
ctrl+shift to complete to the localized tld rather than .org (though this would 
require localization support).
Second, I'd like if ctrl would be the necessary key to activate canonization in 
general, so all the shortcuts should required ctrl to be pressed. Shift is far 
too common when typing and as I said it's already used by tab/tabshifted, it's 
just confusing.
I understand changing this we could break muscle memory of a minority, but it's 
for a totally undiscoverable feature on less critical tlds than .com. and we're 
changing cmd on Mac already, for which we'll want a relnote.
I'd honestly propose to drop the shift and ctrl+shift behaviors completely.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
https://treeherder.mozilla.org/#/jobs?repo=try=e1ef953500c15e1a86adb2456623e886df479bf8

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
Created attachment 8996717
Bug 237027 - allow turning off URL canonization, remove shift support, and move 
the remainder from 'cmd' to 'ctrl' on mac, r?mak

This isn't convention on macOS or other *nix platforms. Even on Windows,
some people may prefer a different behavior.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to avada from comment #118)
> Not at all. With the quickfind bar you can press enter to open a link, or
> press ctrl+enter to open it in a new tab. But you can not do this with the
> normal findbar.

That is not relevant to this bug, which is about the location bar and
the web search bar and what happens if you press ctrl-enter in that.
Those don't share any code with the find bar, so any changes there would
have to be a different bug, in a different component, and affecting
different code. Your suggestion was discussed in bug 1232096 and
wontfixed there. This bug is not related and therefore not the right
place to ask for reconsideration.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Jnkgee
(In reply to :Gijs (he/him) from comment #96)
> (In reply to Anthony Ramine [:nox] from comment #95)

Was this hidden preference ever implemented?  Is there an undocumented
way to change this behavior?  On MacOs, Chrome and Safari both open a
new tab on Cmd+Enter.  Maintaining an IE behavior on a Mac seems
counter-intuitive.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Bugzilla2007
Does this still cover the original intention of this bug and several duplicates 
that users want an option (ideally on by default) where Ctrl+Enter in location 
bar opens the address in a new tab? It's confusing that sometimes we need to 
press Ctrl and sometimes Alt to open things in a new tab.
Why can't we just make ALT the default canonizer shortcut key?
Otherwise allow user to switch canonization off and have Ctrl+Enter = open in 
new tab behaviour instead.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mak77
(In reply to Thomas D. (currently busy elsewhere) from comment #108)
> Does this still cover the original intention of this bug and several
> duplicates that users want an option (ideally on by default) where
> Ctrl+Enter in location bar opens the address in a new tab? It's confusing
> that sometimes we need to press Ctrl and sometimes Alt to open things in a
> new tab.

It should, yes. Overall the idea is that CTRL will be the canonization key, and 
it should be possible to disable it, as well as it should imo be possible to 
set what to canonize to (if one prefers .it to .com, for example).
Then on Mac, CMD will open in a new tab, rather trying to canonize.

> Why can't we just make ALT the default canonizer shortcut key?

It would not be coherent with any other browser, and we want users to feel home 
when then move to Firefox.
All of the other browsers canonize on CTRL.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Bugzilla2007
(In reply to Marco Bonardo [::mak] (Away 9-26 Aug) from comment #103)
> I made a small sheet to better understand what changes here, please check
> and comment if something doesn't look correct.
> https://docs.google.com/spreadsheets/d/
> 1VVEVjyIYRZIFteM71j5bJhENa2xXT82gaikr0WgpKLA/edit#gid=0
> 
> I didn't test the patch, I just assumed, on IRC Gijs said it's likely
> different.
> Anyway, I added a row with the behavior I'm suggesting, that is pretty much
> the same as Chromium, apart ALT+Enter on the Mac.

Unfortunately, I failed to access that table. Can you make it public?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mak77
(In reply to :Gijs (Not available 3-19 Aug; he/him) from comment #104)
>> Note that the spreadsheet doesn't cover shift-enter, which also canonifies
> today. I left that as-is, though of course that now also comes under the
> pref, and can therefore be turned off (at which point we'll open a new
> window instead).

Ah, I didn't remember shift, why are we doing that exactly? it sounds wrong. 
Nor Edge nor Chrome do that, so it's not a parity reason. And I can see why 
they don't, it's trivial to leave your finger on shift when typing text and 
then we'd try to canonize it. Additionally we also use shift for tab VS 
tabshifted, so this is just adding confusion.
May we file a bug to stop supporting shift and relegate canonize to just CTRL? 
provided we don't want to do that here.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread bibstha
> "Cmd+Enter" not opening a new tab from the address bar has been my
biggest hangup as I attempt to switch from Chrome to Firefox now.

Current Behaviour

1. On Links on a page - Command + Click - Opens up on new tab (As expected)
2. On Browser Back and Forward button - Command + Click - Opens up in new tab 
(As expected)
3. On Address Bar - Command + Enter - Reloads in the same page (Unexpected, 
should Open in new page)

For now, I do Option+Enter, but is inconsistent with the rest of the
behaviour.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Alexander-kern
Hello, can we have alt+return open the page in the background? It's
useful when you want to do something later. If you want to focus the
page immediately, like Firefox does right now for alt+return, you can
just use ctrl+t so I don't understand why alt+return opens in foreground
too since there is already ctrl+t for that.

Before there was the extension background tabs but there is no
Webextension version of that.

Thanks for reading

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to Anthony Ramine [:nox] from comment #95)
> What should I do to get this fixed?

Your patch does:

>   } else if (this.AppConstants.platform == "macosx") {

and

>   this.AppConstants.platform == "macosx") {


It also hardcodes 'accel' to always mean 'ctrl'.

Instead, leave the accel handling as-is, don't check for the OS, but add
a preference line in all.js, e.g. for
"browser.urlbar.accelenter.newtab". Use #ifdefs for that pref and, on
Windows, set it to false, and on everything else, to true.

Then instead of checking the OS in your patch, check the preference, and
use that to decide what to do.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to Marco Bonardo [::mak] from comment #107)
> And, we could make canonize complete to browser.fixup.alternate.prefix and
> browser.fixup.alternate.suffix, so the user can adapt it to his needs.

We already use .suffix, see https://searchfox.org/mozilla-
central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/browser/base/content/urlbarBindings.xml#1048-1055
. I think using prefix can be a follow-up bug, that doesn't seem super
valuable to me (in fact, I would prefer to get rid of the alternate
stuff as it's currently needlessly being mixed in with other bits of URL
fixup in nsDefaultURIFixup, but that's a separate discussion).

I'll remove shift support here because it affects the pref name, and
adding a pref and then renaming it immediately seems stupid.

Try:
https://treeherder.mozilla.org/#/jobs?repo=try=aad17bf2c7fa4acaf46e1d71cf79069d192d5ecd

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread J-nox
So what is blocking this exactly? Why can't we get this fixed? What
should I do to get this fixed? This bug has been reported 14 years ago,
maybe it doesn't need to live through its 15th year, does it?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Josh Duff
"Cmd+Enter" not opening a new tab from the address bar has been my
biggest hangup as I attempt to switch from Chrome to Firefox now.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread avada
(In reply to Marco Bonardo [::mak] from comment #111)
> It should, yes. Overall the idea is that CTRL will be the canonization key,
> and it should be possible to disable it, as well as it should imo be
> possible to set what to canonize to (if one prefers .it to .com, for
> example).
> Then on Mac, CMD will open in a new tab, rather trying to canonize.

Will this finally work with the normal find bar an not just the
quickfind bar?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mak77
I made a small sheet to better understand what changes here, please check and 
comment if something doesn't look correct.
https://docs.google.com/spreadsheets/d/1VVEVjyIYRZIFteM71j5bJhENa2xXT82gaikr0WgpKLA/edit#gid=0

I didn't test the patch, I just assumed, on IRC Gijs said it's likely different.
Anyway, I added a row with the behavior I'm suggesting, that is pretty much the 
same as Chromium, apart ALT+Enter on the Mac.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mak77
It's now public, cheers.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to avada from comment #113)
> (In reply to Marco Bonardo [::mak] from comment #111)
> > It should, yes. Overall the idea is that CTRL will be the canonization key,
> > and it should be possible to disable it, as well as it should imo be
> > possible to set what to canonize to (if one prefers .it to .com, for
> > example).
> > Then on Mac, CMD will open in a new tab, rather trying to canonize.
> 
> Will this finally work with the normal find bar an not just the quickfind
> bar?

I don't understand - this bug has nothing to do with the find bar, it's
about the location bar. The 'search bar' in the summary is about the bar
that searches on your default search engine (e.g. duckduckgo, google,
bing, ...), not the find-in-page feature. Did you mean to comment on a
different bug?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread T-philipp
Seeing that both Chrome and Safari are using Cmd/Ctrl-Enter for opening
something in a new background tab AND that this is also consistent with
our use of Cmd/Ctrl in other contexts, I would support changing it. Re-
opening on that basis. As far as priority goes, this is obviously on the
lower end though...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(but all that is subject to what Philipp says - he reopened the bug in
comment #81 so it's up to him to clarify.)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Florian-queze
(In reply to :Gijs Kruitbosch from comment #83)

> Seems to me from comment 81 that this change should not be OS X -
specific.

So do you think we should remove the maybeCanonizeURL code altogether? I
wasn't sure if we wanted to keep this behavior inherited from Internet
Explorer on at least Windows, so I suggested making the minimal behavior
change for a first patch (I was helping nox understand how this code
works while we were waiting at the airport).

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Alexander-kern
Hi Aaron,
muscle memory is a reasonable point to me. However you could say the same about 
the people who muscle memorized the current function maybe.
Your three listed points all look legit to me. For all of them, opening in new 
*background* tab instead of new tab in focus is actually a better option I 
suppose. Especially your last point
> * reload the same page in a background tab
As it is right now you'd have to wait for the site to finish loading up (or 
switch back to your other tab).
Kind regards

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread T-philipp
OK, so it looks like Edge, IE, Chrome and Firefox on Windows all currently do a 
version of autocompleting to www.$query.com on Ctrl-Enter.
So I agree that doing this per-OS makes sense, since macOS seems to lean more 
heavily towards interpreting Cmd-something as doing things in a new tab.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread aaronbauman
Yes, fair point.
I'm not saying that my muscle memory should take precedence.

I think the points about internally consistent behavior and matching
behavior of other browsers are more compelling.

Maybe upon hitting cmd-enter, FF could detect whether the entry was in
need of .com completion, and perform whatever action accordingly. There
is some logic in place already to determine whether or not to append
".com": when i enter mozilla.org and hit cmd-enter, my request isn't
transformed to mozilla.org.com

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Aryx-bugmail
*** Bug 1339412 has been marked as a duplicate of this bug. ***

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Mak77
Maybe we could telemetry the usage of the canonize feature, while we are
at it. Though, it's likely something that falls into the "pretty much
unused cause it's undiscoverable, but will have a vocal minority of
fans", so not sure if it's worth it.

FWIW, Edge still support CTRL+Enter, but doesn't add www. anymore, only
.com. Maybe we should do the same for consistency if the feature is
intended as an help for users migrating from IE/Edge to Firefox.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gazzawazza-l
As a lowly user (not dev), please can we have some kind of option
regarding ALT+ENTER behaviour? And to summarise my following comments,
options for behaviour for CTRL+ENTER too? It could be just set in
about:config, depending on how popular the alternative behaviours are.
For example, CTRL+ENTER autocomplete vs open address in new tab.

I personally don't use ALT+ENTER for generating a URL in a new tab. In
fact, I can't explain why but I've only just noticed its new tab
behaviour literally today. For example, I use tab mix plus to generate
duplicate pages with history when I need a new tab (using CTRL+T),
except with links, when CTRL+mouseclick works very nicely. I do
appreciate that users develop habits and look for flexibility in usage
between keyboard and mouse actions, so if ALT+ENTER is good for someone,
then that's what they like and why should they change. Having said that,
I haven't ever used ALT+ENTER for that functionality.

I actually use ALT+ENTER with an extension called URL suffix (lovely,
practical add-on IMO), which allows additional keystroke combos (beyond
CTRL+ENTER) to generate additional URL prefixes & suffixes. I've
configured ALT+ENTER to add a www. and .co.uk to a URL. This 'open
address in a new tab' honestly never used to occur (for me), so I sense
something may have changed or has been updated in firefox, relatively
recently, given I do use these keyboard shortcuts for autocompletion.
I've found some references to loss of this behaviour when using tab mix
plus. Most posts are ancient but there was an isolated report in Nov
2015, involving a beta of FF 43. Anyway, ALT+ENTER and firefox led me
here.

I do agree with one contributor that one can't just bung in an option
every time there's a conflict but when one's talking about keystrokes
(both ALT+ENTER and CTRL+ENTER) which directly affect daily
tasks/usability, perhaps there's an argument for considering support for
alternatives. Standardisation is generally speaking good but we've got
usage differences across browsers and platforms, which I can't see being
harmonised easily and, depending on the solution, I would have thought
we're not talking about much in the way of code changes, if we just
added some choices in about:config. Sorry if I'm talking nonsense though
- I'm not a coder.


Regards,

Gary

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to Florian Quèze [:florian] [:flo] from comment #90)
> (In reply to :Gijs Kruitbosch from comment #86)
> > Also, if we're going to change this on only some platforms, given the
> > contention, the most straightforward thing would be to have a pref that we
> > default to different values on Windows - then Windows users who don't care
> > for the IE behaviour can flip it, or vice versa.
> 
> A pref would make sense, especially if we want to be able to test both
> behaviors on all platforms. I didn't suggest it mostly because of comment
> 62, but that comment was arguably more about exposing the pref in the UI
> than about having a pref in the implementation.

Yeah - I don't think we want UI, but if we're going to do different
things per-OS we might as well implement-via-hidden-pref than hardcode
the OS distinctions. There's plenty of precedent for that, e.g.
backspace-for-history.back being a hidden pref
(browser.backspace_action) that's different on Linux vs. elsewhere.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread aaronbauman
Yes, it's true that any change has the potential to interrupt current users.
But, if FF could detect when to append ".com" vs. when to open a new tab based 
on the entered URL, then this is a very minimal change for current users.

The current behavior of ".com-completion in same tab, when applicable" could 
remain in place.
The only behavior that's actually needs to change is from the existing 
"cmd-enter does nothing" to "cmd-enter opens in new tab" when .com-completion 
is not applicable.

Furthermore, with the proliferation of TLDs, it seems like .com-completion has 
become less useful.
Adding a config to change this behavior doesn't seem like an unreasonable 
approach either.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread aaronbauman
> "Also, the current "open in new tab" doesn't really make sense to me."

For me, there are several use cases in my muscle memory for Chrome:
e.g. 
* slight change to existing URL 
"https://bugzilla.mozilla.org/show_bug.cgi?id=237027; to 
"https://bugzilla.mozilla.org/show_bug.cgi?id=12345; 
* open a bunch of variants quickly: 
"example.com/long-annoying-paginated-url?page=1", 
"example.com/long-annoying-paginated-url?page=2", 
"example.com/long-annoying-paginated-url?page=3" etc. -- many fewer keystrokes 
than copy, new tab, paste, then edit, then switch back to original tab and 
repeat.
* reload the same page in a background tab

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread J-nox
Created attachment 8818332
Bug 237027 - Properly handle accel keys in address bar on macOS.

Review commit: https://reviewboard.mozilla.org/r/98432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98432/

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
Comment on attachment 8818332
Bug 237027 - Properly handle accel keys in address bar on macOS.

https://reviewboard.mozilla.org/r/98432/#review98694

Seems to me from comment 81 that this change should not be OS X -
specific.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Florian-queze
(In reply to :Gijs Kruitbosch from comment #86)
> Also, if we're going to change this on only some platforms, given the
> contention, the most straightforward thing would be to have a pref that we
> default to different values on Windows - then Windows users who don't care
> for the IE behaviour can flip it, or vice versa.

A pref would make sense, especially if we want to be able to test both
behaviors on all platforms. I didn't suggest it mostly because of
comment 62, but that comment was arguably more about exposing the pref
in the UI than about having a pref in the implementation.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to :Gijs from comment #96)
> add a preference line in all.js

Err, might need to be in firefox.js - check where the other urlbar
behaviour prefs live. :-)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to Anthony Ramine [:nox] from comment #87)
> :Gijs I don't understand what you mean about a pref on Windows if we only
> change this "on only some platforms", given that platform would be macOS
> where that behaviour is the odd one. Why do a pref?

As I understand comment #84, if we keep this behaviour (ctrl-enter
completing to www..com) at all, it'll be on Windows only. I
don't see how macOS is special - Windows is, and Linux and macOS should
get the 'open in a new tab' behaviour. What I'm saying is that whether
we use the existing canonizeURL behaviour should go be behind a pref
that's true on Windows and false everywhere else (ifdef'd in all.js).

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
Also, if we're going to change this on only some platforms, given the
contention, the most straightforward thing would be to have a pref that
we default to different values on Windows - then Windows users who don't
care for the IE behaviour can flip it, or vice versa.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Cking-4
Change puts a burden on current users.  But if the new way is better,
lets change.

I remember when the ribbon replace menus in Microsoft Office.  The
change meant extra work for those of us used to the old behavior.
However, it looked to me like a couple of people who were not good at
computers were able to learn to use the ribbon more easily than they had
used the menus.  I believe the ribbon is better than the menus, and was
worth having to learn.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread J-nox
:Gijs I don't understand what you mean about a pref on Windows if we
only change this "on only some platforms", given that platform would be
macOS where that behaviour is the odd one. Why do a pref?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Alexander-kern
Hi Christopher, I kinda agree. However the change may be confusing for users 
who use the ctrl+enter to add .com. What is your suggestion for that shortcut? 
Swap it with alt+enter? Also, the current "open in new tab" doesn't really make 
sense to me. If one wants to immediately switch to that tab, one can also just 
use ctrl+t. Maybe then change that behaviour to "open in new background tab" 
just like the extension does? But this may be out of the scope for this issue.
Kind regards

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Gijskruitbosch+bugs
(In reply to Florian Quèze [:florian] [:flo] from comment #84)
> (In reply to :Gijs Kruitbosch from comment #83)
> 
> > Seems to me from comment 81 that this change should not be OS X - specific.
> 
> So do you think we should remove the maybeCanonizeURL code altogether? I
> wasn't sure if we wanted to keep this behavior inherited from Internet
> Explorer on at least Windows, so I suggested making the minimal behavior
> change for a first patch (I was helping nox understand how this code works
> while we were waiting at the airport).

I'm not familiar with the pedigree of maybeCanonizeURL. It looks like
the functionality was originally introduced in 2002 by Hyatt with no bug
number. It does look like IE still does this type of completion.
Philipp, what do you want to do?

(note that "keep matching IE on Windows" != "only change this on OS X";
we should specialcase Windows, not OS X)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Florian-queze
(In reply to :Gavin Sharp [email: ga...@gavinsharp.com] from comment #56)
> Unfortunately fixing this at this point would be disastrous for muscle
> memory/user habits, so it's just not feasible.

This bug still seems to be annoying people. Philipp, do you agree that
the current behavior of accel+enter (adding www. and .com, and loading
in the current tab) has been here for so long that we can't fix it at
this point?

Or given that this behavior was introduced to mimic IE's behavior, would
it be reasonable to implement "accel+enter opens in new tab" for OS X
only, where no other browser has ever supported the www./.com completion
behavior?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Paul Wise (Debian)
Probably just an about:config option would be enough to fix this for
people who want the old behaviour back.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Alexander-kern
Hi all, the extension background tabs works for that purpose. It's also
extra useful because it opens the url you put in in a new background
tab. If you want to open it and also focus you can use ctrl+t.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread Cking-4
I just installed the extension "Background Tabs", and it does just what
I wanted (though I've only used it a few times, so far).  Thanks to
Alexander for pointing this out.  However, I don't think this extension
is a general solution for this issue, because it requires knowing how to
use add-ons, and success in finding this one.  I had searched for such
an add-on, and had failed to find this one.

To make Firefox more intuitive, I still think a good approach would be
to make the behavior of control-click or control-enter in the address
bar be with consistent those key strokes on the page (opening a URL in a
new tab).  For users wanting those keystrokes to do the same thing as in
IE, provide them with an extension or about:config option to do that.

IE has inconsistent behavior with its shortcut keys:  control-enter on a
selected link on a page opens the page in a new tab; the same key
strokes in the address bar open a URL in the current tab.  No need for
Firefox to also be inconsistent.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566]

2018-12-12 Thread aaronbauman
semi-annual post to confirm that this bug persists into latest release,
and this behavior still doesn't make sense.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566] Re: Inconsistent shortcuts for new tab

2018-12-12 Thread Bug Watch Updater
** Changed in: firefox
   Status: Confirmed => Fix Released

** Bug watch added: Mozilla Bugzilla #12345
   https://bugzilla.mozilla.org/show_bug.cgi?id=12345

** Bug watch added: Mozilla Bugzilla #1215061
   https://bugzilla.mozilla.org/show_bug.cgi?id=1215061

** Bug watch added: Mozilla Bugzilla #1506203
   https://bugzilla.mozilla.org/show_bug.cgi?id=1506203

** Bug watch added: Mozilla Bugzilla #1506247
   https://bugzilla.mozilla.org/show_bug.cgi?id=1506247

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 66566] Re: Inconsistent shortcuts for new tab

2016-09-15 Thread Bug Watch Updater
** Changed in: firefox
   Status: Won't Fix => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 66566]

2015-03-28 Thread General-z
Are there any currently-working add-ons that alleviate this bug? The
add-ons mentioned here no longer work as far as I can tell.

Thanks

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 66566]

2015-03-24 Thread aaronbauman
Gavin,
Please reconsider this issue.

Allowing both ctrl- and alt-enter opening a new tab would accommodate
all concerns and reservations expressed in this thread.

Currently ctrl-enter in the address bar has no different effect than
enter by itself, so this change would satisfy all parties.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/66566

Title:
  Inconsistent shortcuts for new tab

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/66566/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


  1   2   >