[Bug 678421] Re: Error message for a faulty ~/.profile script
** Merge proposal linked: https://code.launchpad.net/~canonical-desktop-team/ubuntu/+source/gdm3/+git/gdm3/+merge/349818 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Merge proposal linked: https://code.launchpad.net/~canonical-desktop-team/ubuntu/+source/gdm3/+git/gdm3/+merge/348784 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: gdm Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: gdm Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
This bug was fixed in the package lightdm - 1.12.3-0ubuntu1 --- lightdm (1.12.3-0ubuntu1) utopic; urgency=medium * New upstream release: - Fix pipe file descriptor leak for each greeter session. (LP: #1190344) - Don't attempt generate D-Bus seat/session removal signals on shutdown. * debian/guest-account.sh: - Rename variables to make script compatible with Bash (LP: #1411100) * debian/lightdm-session: - Use bash for the session to improve error handling (LP: #678421) * debian/control: - Depend on bash lightdm (1.12.2-0ubuntu1) utopic; urgency=medium * New upstream release: - Fix pipe file descriptor leak for each session login / authentication (LP: #1190344) - Use correct syntax for DesktopNames key in session files (LP: #1383321) - Mock /run in tests * debian/config-error-dialog.sh: - Show warning dialog instead of interrupted login if syntax error in ~/.profile etc (LP: #678421) -- Robert Ancell robert.anc...@canonical.com Tue, 10 Mar 2015 16:02:44 +1300 ** Changed in: lightdm (Ubuntu Utopic) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I have successfully installed and run lightdm 1.12.3-0ubuntu1 from utopic-proposed. The behavior in case of a syntax error in ~/.profile has changed in accordance with the test case in the bug description. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hello Egon, or anyone else affected, Accepted lightdm into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lightdm/1.12.3-0ubuntu1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Tags removed: verification-done ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Ok, thanks, Daniel. This way I learned something new. :) I think the reason for the confusion is that stderr is already redirected when the code in ~/.profile is run. It's done through this line in /usr/sbin/lightdm-session: . $CONFIG_FILE 2$ERR So if you want it to work as before, you need to modify your redirects (I'm not able to tell exactly how, though). Otherwise things probably don't end up as you expect, even if you were able to avoid the error dialog by moving down the 'set -x' statement. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 678421] Re: Error message for a faulty ~/.profile script
On 25.02.2015 23:42, Gunnar Hjalmarsson wrote: Thanks for your comments! On 2015-02-25 19:56, Daniel Hahler wrote: set -x exec 1$logfile exec 2$logfile Really using the exec command in ~/.profile would stop the execution of the main process (/usr/sbin/lightdm-session), so I suppose your ~/.profile did not literally contain the above lines. To understand if it was a false positive, you need to tell us more. It does not stop the execution / replace the current process, but only redirects the file descriptors when used like this (1 (stdout) and 2 (stderr)). It's fine like it is and expected - just wanted to provide it as feedback nonetheless. Cheers, Daniel. -- http://daniel.hahler.de/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Thanks for working on this! For what it's worth, I've been using the following, and had to move the set -x now below the exec 2$logfile, otherwise this was detected as being an error. 1. I've been using the following in ~/.profile, mainly for debugging purposes: logfile=/tmp/debug-profile-calls.log echo -n Calling .profile (via $0) $logfile date $logfile echo SHELL: $SHELL $logfile set -x exec 1$logfile exec 2$logfile 2. I was confused that kdialog was being used / preferred: I am using some KDE apps, but use awesome WM and the software stack based on Unity/Gnome. Maybe there's a better method to detect a KDE system than just checking if kdialog is installed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hi Daniel, Thanks for your comments! On 2015-02-25 19:56, Daniel Hahler wrote: set -x exec 1$logfile exec 2$logfile Really using the exec command in ~/.profile would stop the execution of the main process (/usr/sbin/lightdm-session), so I suppose your ~/.profile did not literally contain the above lines. To understand if it was a false positive, you need to tell us more. As regards kdialog: Right, just checking if kdialog is installed is certainly not a safe way to detect a KDE system. OTOH, that's not really the intention here. Given that you seem to have kdialog installed, does it matter much if it's used to show the error dialog (in case of an error) instead of xenity? ;) If you want to suggest that the code is changed somehow, I ask you to please file a new bug report, since it would be a little messy to handle it on this already pretty long report. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
This bug was fixed in the package lightdm - 1.10.4-0ubuntu2 --- lightdm (1.10.4-0ubuntu2) trusty; urgency=medium * debian/config-error-dialog.sh: * debian/lightdm-session: - Use bash for the session to improve error handling (LP: #678421) * debian/control: - Depend on bash lightdm (1.10.4-0ubuntu1) trusty; urgency=medium * New upstream release: - Fix pipe file descriptor leak for each session login / authentication (LP: #1190344) - Support DesktopNames key in session files (LP: #1383321) * debian/config-error-dialog.sh: - Show warning dialog instead of interrupted login if syntax error in ~/.profile etc (LP: #678421) -- Robert Ancell robert.anc...@canonical.com Tue, 25 Nov 2014 11:25:23 +1300 ** Changed in: lightdm (Ubuntu Trusty) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
This bug was fixed in the package gdm - 3.10.0.1-0ubuntu7.1 --- gdm (3.10.0.1-0ubuntu7.1) utopic; urgency=medium * debian/patches/ubuntu_config_error_dialog.patch: - Show warning dialog in case of error in ~/.profile etc. and don't let a syntax error make the login fail (LP: #678421). * debian/control.in: - Add bash to Depends. -- Gunnar Hjalmarsson gunna...@ubuntu.com Sun, 14 Dec 2014 17:43:00 +0100 ** Changed in: gdm (Ubuntu Utopic) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I verified gdm on utopic with both a valid and broken .profile, all working as expected -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Thanks Tim, with that all the SRUs have been verified at last. :) ** Tags removed: verification-done-trusty verification-needed-utopic ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
This bug was fixed in the package gdm - 3.10.0.1-0ubuntu3.1 --- gdm (3.10.0.1-0ubuntu3.1) trusty; urgency=medium * debian/patches/ubuntu_config_error_dialog.patch: - Show warning dialog in case of error in ~/.profile etc. and don't let a syntax error make the login fail (LP: #678421). * debian/control.in: - Add bash to Depends. -- Gunnar Hjalmarsson gunna...@ubuntu.com Sun, 14 Dec 2014 17:44:00 +0100 ** Changed in: gdm (Ubuntu Trusty) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Sorry, misunderstanding. I restored the previous tags, which seem to be correct. ** Tags removed: verification-done ** Tags added: verification-done-trusty verification-needed-utopic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Tags removed: verification-done-trusty verification-needed-utopic ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Tags removed: verification-done-utopic-lightdm verification-needed ** Tags added: verification-needed-utopic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
gdm 3.10.0.1-0ubuntu3.1 was successfully installed and run by Magnus Ewert. Magnus confirms that the behavior in case of a syntax error in ~/.profile has changed in accordance with the test case in the bug description. ** Tags added: verification-done-trusty-gdm verification-done-trusty- lightdm verification-done-utopic-lightdm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
@Gunnar - the SRU team tools understand the tags v-done and v-done-$release, but not v-done-$release-$package. ** Tags removed: verification-done-trusty-gdm verification-done-trusty-lightdm ** Tags added: verification-done-trusty -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Thanks for the correction, Brian. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:ubuntu/utopic-proposed/gdm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hello Egon, or anyone else affected, Accepted gdm into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gdm/3.10.0.1-0ubuntu7.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: gdm (Ubuntu Utopic) Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:ubuntu/trusty-proposed/gdm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hello Egon, or anyone else affected, Accepted gdm into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gdm/3.10.0.1-0ubuntu3.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: gdm (Ubuntu Trusty) Status: In Progress = Fix Committed ** Tags removed: verification-done ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: gdm (Debian) Status: Unknown = New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Bug watch added: Debian Bug tracker #774798 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=774798 ** Also affects: gdm (Debian) via http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=774798 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:~gunnarhj/ubuntu/utopic/gdm/config-error-dialog ** Branch linked: lp:~gunnarhj/ubuntu/trusty/gdm/config-error-dialog -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: gdm (Ubuntu Trusty) Status: Triaged = In Progress ** Changed in: gdm (Ubuntu Trusty) Assignee: (unassigned) = Gunnar Hjalmarsson (gunnarhj) ** Changed in: gdm (Ubuntu Utopic) Status: Triaged = In Progress ** Changed in: gdm (Ubuntu Utopic) Assignee: (unassigned) = Gunnar Hjalmarsson (gunnarhj) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch unlinked: lp:lightdm/1.10 ** Branch unlinked: lp:lightdm/1.12 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:ubuntu/vivid-proposed/gdm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
This bug was fixed in the package gdm - 3.14.0-0ubuntu2 --- gdm (3.14.0-0ubuntu2) vivid; urgency=medium * debian/patches/ubuntu_config_error_dialog.patch: - Show warning dialog in case of error in ~/.profile etc. and don't let a syntax error make the login fail (LP: #678421). * debian/control.in: - Add bash to Depends. -- Gunnar Hjalmarsson gunna...@ubuntu.com Tue, 25 Nov 2014 15:55:00 +0100 ** Changed in: gdm (Ubuntu) Status: In Progress = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hello Egon, or anyone else affected, Accepted lightdm into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lightdm/1.10.4-0ubuntu2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: lightdm (Ubuntu Trusty) Status: In Progress = Fix Committed ** Tags removed: verification-done ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:ubuntu/trusty-proposed/lightdm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I have successfully installed and run lightdm 1.10.4-0ubuntu2 from trusty-proposed. The behavior in case of a syntax error in ~/.profile has changed in accordance with the test case in the bug description. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:~gunnarhj/lightdm/config-error-dialog_utopic ** Branch linked: lp:~gunnarhj/lightdm/config-error-dialog_trusty -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:ubuntu/vivid-proposed/lightdm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
This bug was fixed in the package lightdm - 1.13.0-0ubuntu2 --- lightdm (1.13.0-0ubuntu2) vivid; urgency=medium * debian/config-error-dialog.sh: * debian/lightdm-session: - Use bash for the session to improve error handling (LP: #678421) * debian/control: - Depend on bash -- Robert Ancell robert.anc...@canonical.com Tue, 25 Nov 2014 11:28:11 +1300 ** Changed in: lightdm (Ubuntu) Status: In Progress = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Thanks for looking at it, Martin. Actually I may have found a relatively trivial solution using trap(); please see attached diff. ** Patch added: possible-fix.diff https://bugs.launchpad.net/ubuntu/trusty/+source/lightdm/+bug/678421/+attachment/4263541/+files/possible-fix.diff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hah, nice! Works for me, too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:~gunnarhj/lightdm/config-error-dialog -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I filed a merge proposal, where lightdm-session is run under bash and the code for exception handling improved. A vivid build of lightdm, including the proposed changes, is available in my PPA at https://launchpad.net/~gunnarhj/+archive/ubuntu/misc ** Changed in: lightdm (Ubuntu) Status: Fix Released = In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
. $CONFIG_FILE 2$ERR OTOH, I suppose that switching to bash wouldn't be approved just like that. ;) Bash's input redirection simply is way more powerful. Granted, bash takes a tad longer to start up, but any tee or other external program which you call in addition will probably hurt performance just as much. TBH I don't see a better solution either. You might think that something like this should work: . $CONFIG_FILE 21 /dev/null | tee $ERR 2 No, as that would fork off the . into a subprocess, and thus the exports only survive there. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 678421] Re: Error message for a faulty ~/.profile script
On Nov 18, 2014, at 02:41 PM, Martin Pitt wrote: Bash's input redirection simply is way more powerful. Granted, bash takes a tad longer to start up, but any tee or other external program which you call in addition will probably hurt performance just as much. Purely selfishly, switching back to bash would probably solve my original problem since all my (ancient) startup/login scripts are bash syntax. ;) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I have been googling and experimenting a bit. Basically I'd like to change: . $CONFIG_FILE 2$ERR to something along these lines: . $CONFIG_FILE 2 (tee $ERR 2) There is just one tiny problem: It's bash syntax and doesn't work in sh. If I change the shebang line of /usr/sbin/lightdm-session to #!/bin/bash it works like a charm. Actually, it works much better, since it recursively prevents syntax errors in sourced files from causing fatal errors. OTOH, I suppose that switching to bash wouldn't be approved just like that. ;) I got the tip from the first answer at this page: http://stackoverflow.com/questions/692000/how-do-i-write-stderr-to-a -file-while-using-tee-with-a-pipe The answer also includes the equivalent code for sh. I have successfully applied that approach in stand-alone test scripts, but when moved to /usr/sbin/lightdm-session, all my attempts so far have caused buggy behavior. You might think that something like this should work: . $CONFIG_FILE 21 /dev/null | tee $ERR 2 It doesn't. As soon as you add a pipe like that, setting environment variables via the sourced files fails. So I'm stuck. Any help from a shell scripting wizard would be much appreciated. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:ubuntu/lightdm ** Branch linked: lp:ubuntu/utopic-proposed/lightdm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
apt-mark lightdm hold apt-get dist-upgrade reboot Indeed, logins are fine. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hmm, as 1.13.0-0ubuntu1 just showed up in vivid, it broke my login in the follow way. Note that I always try devel channel updates in a VM with a snapshotted disk so I'm able to revert and do some further investigating. Looking at the dist-upgrade packages, I suspect the lightdm changes are affecting me, but I'm going to continue to investigate. So, when I log in, I do get several warnings in a dialog. Most are because I use `source` instead of `.` to source other shell files. What shell is lightdm using these days? Still, even with the warnings, I can log in just fine. Anyway, when I change them all to `.` I still get one warning about my use of shopt, but I'll just ignore that for now. However, logins are now completely broken. I see the screen blank and then I'm thrown back to the login screen. ~/.xsession-errors is empty and I can find no other log file either in $HOME or /var/log that contains any information about what's going wrong. I'm going to pin lightdm and dist-upgrade everything else just to verify that the lightdm update is causing my problems. How can I debug the login crash after I fix my login scripts? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
pay-service crashed, leaving a core file and the following in .xsesssion.old. Not sure if this is related. upstart: pay-service main process (6149) killed by ABRT signal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
For now I'll keep the hold on lightdm, but if Robert or someone else wants to debug in real-time, ping me on irc. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hi Barry!
On 2014-11-14 17:56, Barry Warsaw wrote:
So, when I log in, I do get several warnings in a dialog. Most are
because I use `source` instead of `.` to source other shell files.
What shell is lightdm using these days?
It has always been using Bourne shell, so source is not understood.
You have obliviously been running your system without the configuration
in those other shell files.
Anyway, when I change them all to `.` I still get one warning about
my use of shopt,
Another bash command, not understood by dash.
However, logins are now completely broken. I see the screen blank and
then I'm thrown back to the login screen. ~/.xsession-errors is
empty and I can find no other log file either in $HOME or /var/log
that contains any information about what's going wrong.
This is the code in /usr/sbin/lightdm-session which triggers those
warning dialogs:
code
# temporary storage of error messages
ERR=$(mktemp --tmpdir config-err-XX)
source_with_error_check () {
CONFIG_FILE=$1
if sh -n $CONFIG_FILE 2$ERR; then
echo Loading $CONFIG_FILE;
. $CONFIG_FILE 2$ERR
if [ -s $ERR ]; then
SYNTAX=false
. /usr/lib/lightdm/config-error-dialog.sh
fi
else
SYNTAX=true
. /usr/lib/lightdm/config-error-dialog.sh
fi
cat $ERR /dev/stderr
truncate -s 0 $ERR
}
# Load profile
for file in /etc/profile $HOME/.profile \
/etc/xprofile $HOME/.xprofile; do
if [ -f $file ]; then
source_with_error_check $file
fi
done
/code
I find it hard to believe that that code itself is causing the problem
you describe. Considering that you could log in just fine before you
changed the occurrences of source to ., I would look for the cause
in the code which unlike before is now sourced by lightdm.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/678421
Title:
Error message for a faulty ~/.profile script
To manage notifications about this bug go to:
https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 678421] Re: Error message for a faulty ~/.profile script
Hi Gunnar. On Nov 14, 2014, at 07:07 PM, Gunnar Hjalmarsson wrote: It has always been using Bourne shell, so source is not understood. You have obliviously been running your system without the configuration in those other shell files. Sure, it's entirely possibly that my login has been silently ignoring the non-sh syntax errors, so in that respect, getting notification of them now is a good thing. I still wonder what in my shell code could be causing lightdm to exit back to the login screen and where those errors would be logged so that I can view them and debug them. Cheers. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Being thrown back indicates a syntax error. One thing you could do is testing each one of your sourced files like this: sh -n file The files must pass that test, or else you won't be able to log in. This is what the new lightdm code does, but it does not work recursively... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
On 2014-11-14 20:43, Barry Warsaw wrote: Sure, it's entirely possibly that my login has been silently ignoring the non-sh syntax errors, so in that respect, getting notification of them now is a good thing. The use of commands unknown to sh is one kind of error that was silently ignored. However, that's not a syntax error. Syntax errors was not ignored. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 678421] Re: Error message for a faulty ~/.profile script
On Nov 14, 2014, at 08:15 PM, Gunnar Hjalmarsson wrote: Being thrown back indicates a syntax error. Are those errors logged anywhere permanently? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
On 2014-11-14 21:45, Barry Warsaw wrote: On Nov 14, 2014, at 08:15 PM, Gunnar Hjalmarsson wrote: Being thrown back indicates a syntax error. Are those errors logged anywhere permanently? I don't know. Syntax errors directly in e.g. ~/.profile or /etc/profile are logged in ~/.xsession-errors both with the latest lightdm version and with previous versions, but I don't know whether syntax errors in files which are sourced from those files are logged anywhere. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 678421] Re: Error message for a faulty ~/.profile script
On Nov 14, 2014, at 09:59 PM, Gunnar Hjalmarsson wrote: I don't know. Syntax errors directly in e.g. ~/.profile or /etc/profile are logged in ~/.xsession-errors both with the latest lightdm version and with previous versions, but I don't know whether syntax errors in files which are sourced from those files are logged anywhere. I guess they aren't because ~/.xsession-errors is empty when lightdm exits back to the login screen. :( -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I created the file /etc/profile.d/wrong.sh with a sh syntax error. With lightdm 1.12.1-0ubuntu1 the reason for the login failure is logged in ~/.xsession-errors, but with the latest lightdm version it's not. So there is a regression with the fix of this bug. The reason is that stderr is temporarily redirected to /tmp/config-err- XX. Actually, if you are thrown back to the login screen and log in via a console to investigate the reason, you can find the error message in that /tmp file. OTOH, that's not documented anywhere... Right now I don't know how to best deal with this issue. Any advice appreciated. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 678421] Re: Error message for a faulty ~/.profile script
On Nov 14, 2014, at 11:38 PM, Gunnar Hjalmarsson wrote: Right now I don't know how to best deal with this issue. Any advice appreciated. Probably use tee(1) to get the output both into the temp file and ~/.xsession-errors. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
On 2014-11-15 00:49, Barry Warsaw wrote: On Nov 14, 2014, at 11:38 PM, Gunnar Hjalmarsson wrote: Right now I don't know how to best deal with this issue. Any advice appreciated. Probably use tee(1) to get the output both into the temp file and ~/.xsession-errors. Yeah.. But I fear that would make the code much more complicated. Or do you have an idea, given the current code as shown in comment #33? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hello Egon, or anyone else affected, Accepted lightdm into utopic-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lightdm/1.12.2-0ubuntu1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: lightdm (Ubuntu Utopic) Status: In Progress = Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I have successfully installed and run lightdm 1.12.2-0ubuntu1 from utopic-proposed. The behavior in case of a syntax error in ~/.profile has changed in accordance with the test case in the bug description. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: lightdm Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I've removed the tasks on LightDM (the project) as the fixes for this were all in debian/. ** No longer affects: lightdm/1.12 ** No longer affects: lightdm/1.10 ** No longer affects: lightdm -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
This bug was fixed in the package lightdm - 1.13.0-0ubuntu1 --- lightdm (1.13.0-0ubuntu1) vivid; urgency=medium * New upstream release: - Fix crash when having configuration keys defined in multiple places (LP: #1377373) - Fix pipe file descriptor leak for each session login / authentication (LP: #1190344) - Use correct syntax for DesktopNames key in session files (LP: #1383321) - Match seat configuration with globbing (LP: #1364911) - Allow user switching in multi-seat until bug stopping greeter showing on logout is fixed - Disable log message when AccountsService users change (LP: #1376357) - Update AppArmor scripts, requires AppArmor 2.9 - Update tests to run better on servers * debian/config-error-dialog.sh: - Show warning dialog instead of interrupted login if syntax error in ~/.profile etc (LP: #678421) -- Robert Ancell robert.anc...@canonical.com Thu, 13 Nov 2014 11:08:17 +1300 ** Changed in: lightdm (Ubuntu) Status: In Progress = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:~gunnarhj/ubuntu/vivid/gdm/config-error-dialog -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: gdm (Ubuntu) Status: Triaged = In Progress ** Changed in: gdm (Ubuntu) Assignee: (unassigned) = Gunnar Hjalmarsson (gunnarhj) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:~gunnarhj/lightdm/lp-678421-utopic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Description changed:
+ trusty and utopic SRU requests
+ ==
+
+ [Impact]
+
+ In case of a syntax error in either of ~/.profile or a few other similar
+ files, the Xorg login is interrupted, and the user is taken back to the
+ login screen without an explanation. Debugging this problem may be a
+ time consuming exercise, especially for non-experienced users.
+
+ With the proposed change, lightdm/gdm does not try to load such a file,
+ but shows a warning dialog instead. (A warning dialog is also shown in
+ case of some other type of error, which would not have caused the login
+ to fail.)
+
+ [Test Case]
+
+ To reproduce:
+
+ * Edit ~/.profile and add something bad, e.g. a non-closed parenthesis.
+ * Log out and find that you can't log in to a graphical session.
+
+ After installing the proposed lightdm/gdm version, you'll instead see
+ the dialog and can log in.
+
+ [Regression Potential]
+
+ Since this is only about improved exception handling, it does not at all
+ affect users with correct configuration files. The regression risk ought
+ to be minimal.
+
+ [Original description]
+
Binary package hint: gdm
After adding function AddPath { PATH=$1:$PATH } to $HOME/.profile
made the Xorg startup fail. (At that moment I had already forgotten the
changes made to the .profile). As I had autologin that meant it kept
trying to login and finally showed me the graphics reconfiguration
screen. That sent me to a huge hunt for xorg conf and setup problems.
Anyway finally tracked this down. I had used bash syntax in .profile
file whereas it was run with sh.
This is not a bug per se but I think a user mistake in .profile
shouldn't bring the whole xorg startup to a halt as it does with
autologin. I propose running user .profile and .xprofile scripts so
that Xsession script continues running even if they have errors. I'm not
sure whether this change would have some negative effects as well.
1) Ubuntu Lucid, Linux egon-laptop 2.6.32-25-generic #45-Ubuntu SMP Sat Oct
16 19:48:22 UTC 2010 i686 GNU/Linux
2) gdm 2.30.2.is.2.30.0-0ubuntu4
** Changed in: lightdm
Status: In Progress = Fix Committed
** Changed in: lightdm/1.10
Status: Triaged = In Progress
** Changed in: lightdm/1.12
Status: Triaged = In Progress
** Changed in: lightdm (Ubuntu Trusty)
Status: Triaged = In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/678421
Title:
Error message for a faulty ~/.profile script
To manage notifications about this bug go to:
https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:~gunnarhj/lightdm/lp-678421-trusty -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: lightdm/1.10 Status: In Progress = Fix Committed ** Changed in: lightdm/1.12 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:lightdm/1.10 ** Branch linked: lp:lightdm/1.12 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Bug watch added: GNOME Bug Tracker #738970 https://bugzilla.gnome.org/show_bug.cgi?id=738970 ** Also affects: gdm via https://bugzilla.gnome.org/show_bug.cgi?id=738970 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: gdm Status: Unknown = New ** Changed in: gdm Importance: Unknown = Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Gunnar, Running it through sh -n is definitively a good way how to test a shell script. It of course will miss a lot of errors (variable typos, failing programs in a set -e script, etc.), but it at least will catch obvious syntax errors. So ignoring faulty scripts and showing some error message (in ~/.xsession-errors or even a dialog) seems appropriate to me. Thanks for working on this! I'll review the MP now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: lightdm Milestone: None = 1.13.0 ** Changed in: lightdm Importance: Undecided = Medium ** Changed in: lightdm Importance: Medium = Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Also affects: gdm (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: lightdm (Ubuntu Trusty) Importance: Undecided Status: New ** Also affects: gdm (Ubuntu Utopic) Importance: Low Status: Triaged ** Also affects: lightdm (Ubuntu Utopic) Importance: Low Assignee: Gunnar Hjalmarsson (gunnarhj) Status: In Progress ** Also affects: lightdm/1.12 Importance: Undecided Status: New ** Also affects: lightdm/1.10 Importance: Undecided Status: New ** Changed in: lightdm/1.10 Importance: Undecided = Low ** Changed in: lightdm/1.12 Importance: Undecided = Low ** Changed in: lightdm/1.10 Milestone: None = 1.10.4 ** Changed in: lightdm/1.12 Milestone: None = 1.12.2 ** Changed in: lightdm/1.10 Assignee: (unassigned) = Gunnar Hjalmarsson (gunnarhj) ** Changed in: lightdm/1.12 Assignee: (unassigned) = Gunnar Hjalmarsson (gunnarhj) ** Changed in: lightdm/1.10 Status: New = Triaged ** Changed in: lightdm/1.12 Status: New = Triaged ** Changed in: gdm (Ubuntu Trusty) Status: New = Triaged ** Changed in: lightdm (Ubuntu Trusty) Status: New = Triaged ** Changed in: lightdm (Ubuntu Trusty) Importance: Undecided = Low ** Changed in: gdm (Ubuntu Trusty) Importance: Undecided = Low ** Changed in: lightdm (Ubuntu Trusty) Assignee: (unassigned) = Gunnar Hjalmarsson (gunnarhj) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I made a try. As regards a syntax error, it currently results in an interrupted login, while other types of errors are silently ignored. With my new merge proposal, a zenity/kdialog dialog is shown for all types of errors in ~/.profile and friends, and the login is completed (with a deficient configuration). They are also printed to ~/.xsession- errors. Please feel free to test it by installing lightdm from my PPA at https://launchpad.net/~gunnarhj/+archive/ubuntu/misc -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
It seems it's a good way to fix this bug! Thank you for your help :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hi Gunnar, It would make the file not being loaded in case of a syntax error, and an entry printed to ~/.xsession-errors. I don't know if it's better to ignore this file in case of syntax errors or to refuse to start a new session but for me, the most interesting thing is to notify the user what's wrong. That can be made by adding a line in the ~/.xsession-errors file but I think it's better to display a new dialogue which explains the error. Because if you just ignore this file and print an error in ~/.xsession-errors, I'm not sure that the user will see that there is a problem with his/her ~/.profile file. Personally I don't often read this file :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
I think we would also prefer a dialog, but I will take errors in ~/.xsession-errors over nothing. We can instruct our support staff to look there for these errors; right now there are no errors anywhere and so it is difficult to debug the root cause of the problem. -A -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
And I who thought it was so elegant to fix this bug with a few characters of code. ;) I suppose we could do a solution with zenity/kdialog, but before spending time on such a proposal (involving gettext etc.), I would like to know for sure that sh -n is an acceptable testing method. (Please note that other ideas were rejected previously in this bug report.) @Alec: I think Matthieu meant that if we ignore an erroneous file and let the session start, the user may not be aware that there is an error, and hence has no reason to go reading .xsession-errors. I think he has a point. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Branch linked: lp:~gunnarhj/lightdm/lp-678421 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hi Matthieu, That sh -n option sounds interesting indeed, and I just prepared a merge proposal for lightdm. It would make the file not being loaded in case of a syntax error, and an entry printed to ~/.xsession-errors. ** Changed in: lightdm Status: New = In Progress ** Changed in: lightdm Assignee: (unassigned) = Gunnar Hjalmarsson (gunnarhj) ** Changed in: lightdm (Ubuntu) Status: Triaged = In Progress ** Changed in: lightdm (Ubuntu) Assignee: (unassigned) = Gunnar Hjalmarsson (gunnarhj) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Hello, I also confirm that this bug can still be annoying with the latest versions of GDM and LightDM :-) And it can be an easy way to make some jokes just by modifying the .profile! Then it will be hard for the user to understand why he can no longer start a new session. Is it maybe possible to just add an error message if there are problems with the .profile file? We can easily detect if there are errors in this .profile file as already written before: . ~/.profile || echo ERROR But also without executing any code: sh -n ~/.profile || echo ERROR Thank you for maintaining GDM and LightDM! ** Also affects: lightdm Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/lightdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
Marked bug #1097903 a duplicate of this one, and added a lightdm (ubuntu) task. ** Also affects: lightdm (Ubuntu) Importance: Undecided Status: New ** Changed in: lightdm (Ubuntu) Importance: Undecided = Low ** Changed in: lightdm (Ubuntu) Status: New = Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 678421] Re: Error message for a faulty ~/.profile script
** Changed in: gdm (Ubuntu) Status: Confirmed = Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/678421 Title: Error message for a faulty ~/.profile script To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/678421/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
