[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
Launchpad has imported 3 comments from the remote bug at https://bugzilla.redhat.com/show_bug.cgi?id=661262. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2010-12-08T11:12:05+00:00 Soren wrote: Description of problem: NWFilter code does not discover if required tools are installed after starting the daemon (nor if they are removed). Version-Release number of selected component (if applicable): 0.8.3 at least. How reproducible: Every time. Steps to Reproduce: 1. Uninstall (if already installed) ebtables. 2. Start libvirtd 3. Try to start a guest that uses nwfilters. 4. Watch it fail. 5. Install ebtables and repeat steps 3 and 4. Actual results: It fails to notice that I've now installed ebtables (and gawk and iptables). Expected results: It should notice that these tools are now available. Additional info: The converse is also true: If they tools are present when libvirtd starts, but are removed later, things will fail. Reply at: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/684088/comments/3 On 2016-04-21T21:08:29+00:00 Cole wrote: Patch sent upstream: http://www.redhat.com/archives/libvir-list/2016-April/msg01538.html Reply at: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/684088/comments/6 On 2016-04-23T19:36:40+00:00 Cole wrote: I was wrong, that patch doesn't really change things here, I thought this report was about build time and not run time. There still seems to be some issues here but I don't really see it as worth fixing: iptables/ebtables are so commonly available, and this will only hit cases where people are building by hand and not using distribution packages. So we could extend the code to handle it, but frankly I don't think it's worth the effort of implementing. That said if someone shows up on the list with a simple patch I'm sure it will be accepted Reply at: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/684088/comments/7 ** Changed in: libvirt Status: Unknown => Won't Fix ** Changed in: libvirt Importance: Unknown => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time To manage notifications about this bug go to: https://bugs.launchpad.net/libvirt/+bug/684088/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
I was able to reproduce this bug on precise: 1. Install openstack on precise. 2. Run an instance 3. You should see this in the /var/log/nova/nova-compute.log: 2011-12-06 15:19:24.398: 2355: error : ebtablesCreateRuleInstance:1898 : internal error cannot create rule since ebtables tool is missing. 2011-12-06 15:20:48.154: 2356: error : ebtablesCreateRuleInstance:1898 : internal error cannot create rule since ebtables tool is missing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time To manage notifications about this bug go to: https://bugs.launchpad.net/libvirt/+bug/684088/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
Sure, will do. For the record: ebtables_cmd_path is set at start-up in ebiptablesDriverInit() and then checked for null-ity before use in src/nwfilter/nwfilter_ebiptables_driver.c. An indirection around ebtables_cmd_path would solve that. Alternatively, we could restart libvirt when iptables/ebtables are installed. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to libvirt in ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
https://bugzilla.redhat.com/show_bug.cgi?id=661262 ** Bug watch added: Red Hat Bugzilla #661262 https://bugzilla.redhat.com/show_bug.cgi?id=661262 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to libvirt in ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
** Changed in: libvirt (Ubuntu) Importance: Undecided = Low ** Changed in: libvirt (Ubuntu) Status: Incomplete = Triaged ** Also affects: libvirt via https://bugzilla.redhat.com/show_bug.cgi?id=661262 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to libvirt in ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
Sure, will do. For the record: ebtables_cmd_path is set at start-up in ebiptablesDriverInit() and then checked for null-ity before use in src/nwfilter/nwfilter_ebiptables_driver.c. An indirection around ebtables_cmd_path would solve that. Alternatively, we could restart libvirt when iptables/ebtables are installed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
https://bugzilla.redhat.com/show_bug.cgi?id=661262 ** Bug watch added: Red Hat Bugzilla #661262 https://bugzilla.redhat.com/show_bug.cgi?id=661262 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
** Changed in: libvirt (Ubuntu) Importance: Undecided = Low ** Changed in: libvirt (Ubuntu) Status: Incomplete = Triaged ** Also affects: libvirt via https://bugzilla.redhat.com/show_bug.cgi?id=661262 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
I would assume this is also an issue with upstream libvirt. If so, could you please open the task against upstream libvirt or raise the issue there? Either way, after you've figured that out, please report and set status of the Ubuntu task appropriately. ** Changed in: libvirt (Ubuntu) Status: New = Incomplete -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to libvirt in ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 684088] Re: libvirt should detect the presence of tools at use-time rather than at start-time
I would assume this is also an issue with upstream libvirt. If so, could you please open the task against upstream libvirt or raise the issue there? Either way, after you've figured that out, please report and set status of the Ubuntu task appropriately. ** Changed in: libvirt (Ubuntu) Status: New = Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/684088 Title: libvirt should detect the presence of tools at use-time rather than at start-time -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
