[Bug 691590] Re: libvirt restore exactly the old ownership of images
This bug was fixed in the package libvirt - 6.0.0-0ubuntu8.2 --- libvirt (6.0.0-0ubuntu8.2) focal; urgency=medium * enable attr support to store XATTR labels. Among other things this allows to properly restore file ownership (LP: #691590) - d/control: build depend to libattr1-dev - d/rules: configure --with-attr -- Christian Ehrhardt Mon, 22 Jun 2020 21:30:50 +0200 ** Changed in: libvirt (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
As I was asked to verify behavior on non-xattr systems as well I used one
mounted like:
/dev/nvme0n1p3 on /var/lib/uvtool/libvirt/images type ext4
(rw,relatime,nouser_xattr)
We see that even that isn't a showstopper as it is user_attrs and libvirtd runs
as root.
# getfattr -d -m . /var/lib/uvtool/libvirt/images/focal.qcow
getfattr: Removing leading '/' from absolute path names
# file: var/lib/uvtool/libvirt/images/focal.qcow
trusted.libvirt.security.dac="+0:+100"
trusted.libvirt.security.ref_dac="1"
trusted.libvirt.security.timestamp_dac="1593600755"
I also used an ext2 which might support less attributes
/dev/nvme0n1p3 on /var/lib/uvtool/libvirt/images type ext2
(rw,relatime,nouser_xattr)
But that still can store the xattr.
We don't build kernels without xattr to force it that way.
So finally I took a FS that can't do ownerships well in general.
/dev/nvme0n1p3 on /var/lib/uvtool/libvirt/images type vfat
(rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=iso8859-1,shortname=mixed,errors=remount-ro)
But that isn't able to be used (permission errors) if not at the right group
right away:
-rwxr-xr-x 1 root root 245104640 Jul 16 11:11
/var/lib/uvtool/libvirt/images/focal.qcow*
root@node-horsea:~# virsh start focal
error: Failed to start domain focal
error: internal error: process exited while connecting to monitor:
2020-07-16T11:48:55.976986Z qemu-system-x86_64: -blockdev
{"node-name":"libvirt-2-format","read-only":false,"driver":"qcow2","file":"libvirt-2-storage","backing":"libvirt-3-format"}:
Could not reopen file: Permission denied
id libvirt-qemu
uid=64055(libvirt-qemu) gid=115(kvm)
groups=115(kvm),117(libvirt),64055(libvirt-qemu)
Mounted as the required user we can use it and it is not changing IDs in anyway
(while running at non xattr FS)
/dev/nvme0n1p3 on /var/lib/uvtool/libvirt/images type vfat
(rw,relatime,uid=64055,gid=115,fmask=0022,dmask=0022,codepage=437,iocharset=iso8859-1,shortname=mixed,errors=remount-ro)
root@node-horsea:~# ll /var/lib/uvtool/libvirt/images/focal.qcow
-rwxr-xr-x 1 libvirt-qemu kvm 245104640 Jul 16 11:11
/var/lib/uvtool/libvirt/images/focal.qcow*
root@node-horsea:~# virsh start focal
Domain focal started
root@node-horsea:~# ll /var/lib/uvtool/libvirt/images/focal.qcow
-rwxr-xr-x 1 libvirt-qemu kvm 245104640 Jul 16 11:51
/var/lib/uvtool/libvirt/images/focal.qcow*
root@node-horsea:~# virsh shutdown focal
Domain focal is being shutdown
root@node-horsea:~# ll /var/lib/uvtool/libvirt/images/focal.qcow
-rwxr-xr-x 1 libvirt-qemu kvm 246546432 Jul 16 11:52
/var/lib/uvtool/libvirt/images/focal.qcow*
I think that covers all combinations that come to mind, excluding those only
available in non-Ubuntu kernels.
** Tags removed: verification-needed verification-needed-focal
** Tags added: verification-done verification-done-focal
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/691590
Title:
libvirt restore exactly the old ownership of images
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
Verification: The problem $ sudo chown root:kvm /var/lib/uvtool/libvirt/images/focal-ipxe.qcow [sudo] password for paelzer: [✓]─[paelzer@Keschdeichel ~]──[145208]──[12:57 Do Jul 16]── $ ll /var/lib/uvtool/libvirt/images/focal-ipxe.qcow -rw--- 1 root kvm 2546794496 Jul 16 12:57 /var/lib/uvtool/libvirt/images/focal-ipxe.qcow [✓]─[paelzer@Keschdeichel ~]──[145209]──[12:57 Do Jul 16]── $ virsh start focal-ipxe Domain focal-ipxe started [✓]─[paelzer@Keschdeichel ~]──[145210]──[12:57 Do Jul 16]── $ ll /var/lib/uvtool/libvirt/images/focal-ipxe.qcow -rw--- 1 libvirt-qemu kvm 2546794496 Jul 16 12:57 /var/lib/uvtool/libvirt/images/focal-ipxe.qcow [✓]─[paelzer@Keschdeichel ~]──[145211]──[12:57 Do Jul 16]── $ virsh shutdown focal-ipxe Domain focal-ipxe is being shutdown [✓]─[paelzer@Keschdeichel ~]──[145212]──[13:01 Do Jul 16]── $ ll /var/lib/uvtool/libvirt/images/focal-ipxe.qcow -rw--- 1 root root 2548105216 Jul 16 13:01 /var/lib/uvtool/libvirt/images/focal-ipxe.qcow ^^ didn't restore original ownership. Install upgrade: $ sudo apt install libvirt-daemon-system libvirt-clients Reading package lists... Done Building dependency tree Reading state information... Done The following package was automatically installed and is no longer required: libllvm9 Use 'sudo apt autoremove' to remove it. The following additional packages will be installed: libnss-libvirt libvirt-daemon libvirt-daemon-driver-qemu libvirt-daemon-driver-storage-rbd libvirt0 Suggested packages: libvirt-daemon-driver-lxc libvirt-daemon-driver-vbox libvirt-daemon-driver-xen libvirt-daemon-driver-storage-gluster libvirt-daemon-driver-storage-zfs auditd pm-utils systemtap The following packages will be upgraded: libnss-libvirt libvirt-clients libvirt-daemon libvirt-daemon-driver-qemu libvirt-daemon-driver-storage-rbd libvirt-daemon-system libvirt0 7 upgraded, 0 newly installed, 0 to remove and 129 not upgraded. Need to get 2.907 kB of archives. After this operation, 0 B of additional disk space will be used. Do you want to continue? [Y/n] Y Get:1 http://de.archive.ubuntu.com/ubuntu focal-proposed/universe amd64 libnss-libvirt amd64 6.0.0-0ubuntu8.2 [14,4 kB] Get:2 http://de.archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-daemon-driver-qemu amd64 6.0.0-0ubuntu8.2 [605 kB] Get:3 http://de.archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-daemon-driver-storage-rbd amd64 6.0.0-0ubuntu8.2 [28,3 kB] Get:4 http://de.archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-daemon-system amd64 6.0.0-0ubuntu8.2 [67,5 kB] Get:5 http://de.archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-clients amd64 6.0.0-0ubuntu8.2 [343 kB] Get:6 http://de.archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt0 amd64 6.0.0-0ubuntu8.2 [1.444 kB] Get:7 http://de.archive.ubuntu.com/ubuntu focal-proposed/main amd64 libvirt-daemon amd64 6.0.0-0ubuntu8.2 [404 kB] Fetched 2.907 kB in 2s (1.211 kB/s) The system does not support apt-btrfs-snapshot Preconfiguring packages ... (Reading database ... 384131 files and directories currently installed.) Preparing to unpack .../0-libnss-libvirt_6.0.0-0ubuntu8.2_amd64.deb ... Unpacking libnss-libvirt:amd64 (6.0.0-0ubuntu8.2) over (6.0.0-0ubuntu8.1) ... Preparing to unpack .../1-libvirt-daemon-driver-qemu_6.0.0-0ubuntu8.2_amd64.deb ... Unpacking libvirt-daemon-driver-qemu (6.0.0-0ubuntu8.2) over (6.0.0-0ubuntu8.1) ... Preparing to unpack .../2-libvirt-daemon-driver-storage-rbd_6.0.0-0ubuntu8.2_amd64.deb ... Unpacking libvirt-daemon-driver-storage-rbd (6.0.0-0ubuntu8.2) over (6.0.0-0ubuntu8.1) ... Preparing to unpack .../3-libvirt-daemon-system_6.0.0-0ubuntu8.2_amd64.deb ... Unpacking libvirt-daemon-system (6.0.0-0ubuntu8.2) over (6.0.0-0ubuntu8.1) ... Preparing to unpack .../4-libvirt-clients_6.0.0-0ubuntu8.2_amd64.deb ... Unpacking libvirt-clients (6.0.0-0ubuntu8.2) over (6.0.0-0ubuntu8.1) ... Preparing to unpack .../5-libvirt0_6.0.0-0ubuntu8.2_amd64.deb ... Unpacking libvirt0:amd64 (6.0.0-0ubuntu8.2) over (6.0.0-0ubuntu8.1) ... Preparing to unpack .../6-libvirt-daemon_6.0.0-0ubuntu8.2_amd64.deb ... Unpacking libvirt-daemon (6.0.0-0ubuntu8.2) over (6.0.0-0ubuntu8.1) ... Setting up libvirt0:amd64 (6.0.0-0ubuntu8.2) ... Setting up libvirt-clients (6.0.0-0ubuntu8.2) ... Setting up libnss-libvirt:amd64 (6.0.0-0ubuntu8.2) ... Setting up libvirt-daemon-driver-qemu (6.0.0-0ubuntu8.2) ... Setting up libvirt-daemon (6.0.0-0ubuntu8.2) ... Setting up libvirt-daemon-driver-storage-rbd (6.0.0-0ubuntu8.2) ... Setting up libvirt-daemon-system (6.0.0-0ubuntu8.2) ... Job failed. See "journalctl -xe" for details. virtlockd.service is a disabled or a static unit, not starting it. virtlogd.service is a disabled or a static unit, not starting it. Setting up libvirt-daemon dnsmasq configuration. Processing triggers for libc-bin (2.31-0ubuntu9) ... Processing triggers for man-db (2.9.1-1) ... Testing again: $ sudo chown root:kvm /var/lib/uvtool/libvirt/images/focal-ipxe.qcow
[Bug 691590] Re: libvirt restore exactly the old ownership of images
FYI: Flaky Autopkgtests resolved and good now. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
Hi Robie, about: "Since we're changing behaviour I'm also concerned that this is high risk of regression for some use case we haven't considered where the previous behaviour is being depended upon. Thoughts on how to mitigate this would be appreciated. I appreciate that Christian has already come up with and tested a variety of use cases here - how comprehensive do you think these are when compared to "weird" things users might be doing?" Answer: the current workaround would server there as well, one can tweak in file /etc/libvirt/qemu.conf # Whether libvirt should dynamically change file ownership # to match the configured user/group above. Defaults to 1. # Set to 0 to disable file ownership changes. #dynamic_ownership = 1 Currently this is enabled, changing the file to the runtime perms needed and then back (the bug) to root. If you just chown the files to root and disable this feature it will match the former behavior (which now restores the proper former owner). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
The key SRU user impact justification I wanted I found in Soren's comment 27 - thank you. Can I request that both the "filesystem supporting xattr" and "no filesystem xattr support" cases be verified for expected behaviour please? Since we're changing behaviour I'm also concerned that this is high risk of regression for some use case we haven't considered where the previous behaviour is being depended upon. Thoughts on how to mitigate this would be appreciated. I appreciate that Christian has already come up with and tested a variety of use cases here - how comprehensive do you think these are when compared to "weird" things users might be doing? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
Hello C, or anyone else affected, Accepted libvirt into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/6.0.0-0ubuntu8.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: libvirt (Ubuntu Focal) Status: Triaged => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
Uploaded to focal-unapproved for the SRU team to evaluate and sent to Debian [1]. [1]: https://salsa.debian.org/libvirt-team/libvirt/-/merge_requests/52 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
** Description changed: + [Impact] + + * A rather old bug which could have been solved much sooner. Attr support +was disabled way back in time for triggering some test issues. Since +then the test issues and also many more rough edges of ATTR support have +been fixed. + + * This change shall enable attr support again which allows libvirt to +remember and carry ownership information on image files as extended +attributes. + + [Test Case] + + * Prepare a guest that you can start/stop e.g. with uvtool-libvirt + * Own the image by anything other than root:root + * Start the guest (ownership will change to the user the guest runs as) + * Stop the guest: +- fail: will set root:root to the images effectively stealing them +- correct: remembers the old ownership and restores that + + [Regression Potential] + + * This mostly influences DAC control of files, which is exactly what we +want to fix. There are a few lifecycle tasks which now also have to +carry labels e.g. on any image handling. I don't expect regressions, but +this is the place to look out for. + * The behavior on File systems unable to XATTR matches that of the +formerly disable feature, so on those cases where it has no positive +change it will have no change at all. + + [Other Info] + + * Technically we could backport this into all releases, but while I find +it right to fix in Focal OTOH Bionic and even more so Xenial really are +even "more stable" after their time in the field. Users either have +adapted already or even rely/expect the semi-broken behavior. Therefore +this is only targetting Focal intentionally. + + * (very) worst case one can set the FS the images are on to "nouser_xattr" +as mount option. + + + --- + Natty (and it was also the same on Maverick, IIRC). When you assign an ISO to a VM, libvirt will take over onwership of the ISO. This creates problems if the ISO is updated. For example, I am daily updating the Natty server ISOs, and running tests on them via KVM (all automated). The ISO updates will fail because libvirt chowns them. I see no reason for this: libvirt only needs the ISO as input. WORKAROUND: edit /etc/libvirt/qemu.conf, change 'dynamic_ownership = 0', restart qemu/KVM. ** Also affects: libvirt (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: libvirt (Ubuntu Focal) Importance: Undecided => Medium ** Changed in: libvirt (Ubuntu Focal) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
I think this won't fit for a SRU into a long released release like Bionic. But for Focal I'd think this still makes sense IMHO - it is a behavior change yes, but a wanted one. I'll prepare an upload for Focal ... MP: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/386376 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
This bug was fixed in the package libvirt - 6.0.0-0ubuntu10 --- libvirt (6.0.0-0ubuntu10) groovy; urgency=medium * enable attr support to store XATTR labels. Among other things this allows to properly restore file ownership (LP: #691590) - d/control: build depend to libattr1-dev - d/rules: configure --with-attr -- Christian Ehrhardt Mon, 22 Jun 2020 21:30:50 +0200 ** Changed in: libvirt (Ubuntu) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
Uploaded to groovy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
We are lucky - tests that ran over night LGTM nothing happened. In the meantime MP [1] review by the team also completed. [1]: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/386212 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
** Package changed: libvirt (Baltix) => ubuntu-translations ** No longer affects: ubuntu-translations -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
** Project changed: libvirt => libvirt (Baltix) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/386212 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
I upload to a PPA and test against that when doing bigger changes. Only when everything works there the same thing is uploaded to the -dev release. I agree to the "many small changes" theory in general, except for things that either: - a) are used in many other tests (which means breaking these breaks a lot) or - b) require a rather intensive testing (then there is an efficiency gain to batch to some extend) In this case it is even a+b which makes me be careful. If not for me being away in 10 days for a while I'd not be too concerned as it could be reverted. You know what, I can throw it in a PPA and if magically everything works fine (after all most tests are automated - it is all the special cases that might happen which make this a real effort) without hickups I'll consider an earlier upload. Consider it a favor for your old work :-) I'll let you know how things turn out ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
Gosh. I'd happily forgotten about that video. I was so young and so mumbly. :D I'm not sure I understand. If you're not uploading to groovy, how are you collecting test results? Also, I don't know what sort of test facilities or processes you have available, so I don't know how time consuming or expensive a complete regression test run is, but in general I find that smaller changes are better than larger, batched changes for finding problems and identifying their cause. If something doesn't work after pushing a big batch of changes, it can be really hard to identify which one of the many changes is the culprit. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
Hi Soren, yeah I've seen your old youtube video on what is new in virtualization for Ubuntu since the name felt known :-). The reason to not upload immediately is that I'd want to see if there are any other bad effects of attr being enabled that we might miss. I'd want to see if e.g. migrations on disk images on shared storage run into trouble or something like that. To do so I'd run a bunch of regression tests in addition to what comes to my mind for this case in particular. Those tests need quite some time and allocation of systems - therefore they are most effective if coupled with a bunch of other big changes where the tests will cover "more new code". In addition I'm away for quite some time in July, so if I break things with an upload now I'm not around to clean up my mess. And while the bug feels bad, it was open so long attracting only so few people/reports that while it feels important for the two of us now it might overall be not too urgent to squeeze it in asap. I hope that explains why I have postponed the change to when I get to merge a newer libvirt for groovy anyway. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
To clarify, I meant: Is there any particular reason to not just upload this fix *to Groovy* now? I know an SRU needs validation first. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 691590] Re: libvirt restore exactly the old ownership of images
A non-root process that uses qemu:///system to run virtual machines (which is required for most network configurations) will lose access to its disk images for good as soon as the domain is started. First it'll be changed to libvirt-qemu:kvm and once the domain is terminated it will be set to root:root. As a regular user this is nuisance that can be worked around with "sudo chown" (the vast majority of users have this access), but for a daemon that doesn't run as root and doesn't have a human to take care of it and needs access to *its own* disk images, this makes libvirtd as shipped by ubuntu unusable. I'd highly suggest an SRU for this. I've been away from Ubuntu development for a while. Is there any particular reason not to just upload the fixed version now? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/691590 Title: libvirt restore exactly the old ownership of images To manage notifications about this bug go to: https://bugs.launchpad.net/libvirt/+bug/691590/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
