[Bug 723282] Re: Building fails on postler-accounts.vala
Launchpad has imported 23 comments from the remote bug at https://bugzilla.redhat.com/show_bug.cgi?id=690954. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2011-03-25T22:51:39+00:00 Thomas wrote: Spec URL: http://thm.fedorapeople.org/postler/postler.spec SRPM URL: http://thm.fedorapeople.org/postler/postler-0.1.1-1.fc14.src.rpm Description: Postler aims to be easy, simple, clean, beautiful, and automagic. It handles IMAP beautifully, and provides the user with smart, sensible defaults. Reply at: https://bugs.launchpad.net/postler/+bug/723282/comments/14 On 2011-03-26T16:17:05+00:00 Fabian wrote: Shouldn't libidentify included first? Reply at: https://bugs.launchpad.net/postler/+bug/723282/comments/15 On 2011-03-28T08:44:41+00:00 Thomas wrote: (In reply to comment #1) > Shouldn't libidentify included first? Sorry, a typo on my side. It is libindicate, and I'm currently preparing a package. But it seems not strictly necessary for postler and can be enabled later. (And for various reasons it seems unlikely we can have libindicate in F14.) Reply at: https://bugs.launchpad.net/postler/+bug/723282/comments/16 On 2011-03-28T20:05:32+00:00 Christoph wrote: As libindicate is part of Ayatana I doubt it'll be in Fedora. So no reason to wait for it. Just as in bug 690953 I think the description should not include the word "sexy" and the language doesn't matter to the user either. According to the packaging guidelines you should not build with the included waf copy but with the system's version if possible. The two warnings form desktop-file-validate are bogus: According to the spec "Email" needs either "Office" or "Network" but not both and the latter is in place. The x-scheme-handler/mailto MIME type is required for GNOME3's default applications dialog, see bug 690298. There is no need to contact upstream about the desktop file warnings, I just spoke to him. He and I have no idea about the problems with the debuginfo other than that the paths is wrong. find-debuginfo.sh is looking in postler-0.1.1/_build_/ while it is postler-0.1.1/_build_/default/postler Reply at: https://bugs.launchpad.net/postler/+bug/723282/comments/17 On 2011-03-29T16:24:06+00:00 Christoph wrote: There is a problem with the icon I think: Postler includes internet-mail from elemantary-icon-theme and installs it to %{_datadir}/icons/hicolor/scalable/apps/internet-mail.svg. Themed icons/icons with a generic name should not be in hicolor because we could have another app providing internet-mail as well and we might run into a file conflict. I suggest to install it as postler.svg. It's no longer themable then, but this doesn't really matter because elementary and oxygen are the only packages to include an icon of the name "internet-mail" anyway. Stay tuned for a full review. Reply at: https://bugs.launchpad.net/postler/+bug/723282/comments/18 On 2011-04-03T00:21:33+00:00 Christoph wrote: Review for 4494cd46098d379815e9df41842df4cd postler-0.1.1-1.fc14.src.rpm OK - MUST: $ rpmlint /var/lib/mock/fedora-14-x86_64/result/postler-* postler.src: W: spelling-error %description -l en_US automagic -> automatic, auto magic, auto-magic postler.x86_64: W: spelling-error Summary(en_US) vala -> lava, val, ala postler.x86_64: W: spelling-error %description -l en_US automagic -> automatic, auto magic, auto-magic postler.x86_64: W: no-manual-page-for-binary postler postler.x86_64: W: no-manual-page-for-binary postler-mbsync 3 packages and 0 specfiles checked; 0 errors, 5 warnings. OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package %{name} OK - MUST: package meets the Packaging Guidelines OK - MUST: Fedora approved license and meets the Licensing Guidelines: LGPLv2+ FIX - MUST: License field in spec file does not match the actual license OK - MUST: license file included in %doc OK - MUST: spec is in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by MD5 02e502c9f4a4b92e4ace32d9e268f06d OK - MUST: successfully compiles and builds into binary rpms on x86_64 N/A - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. OK - MUST: all build dependencies are listed in BuildRequires. OK - MUST: handles locales properly with %find_lang N/A
[Bug 723282] Re: Building fails on postler-accounts.vala
the issue should be fixed in the current version ** Changed in: vala (Ubuntu) Status: New = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala To manage notifications about this bug go to: https://bugs.launchpad.net/postler/+bug/723282/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
Same bug for Frugalware: http://frugalware.org/buildlogs/helicon/postler-0.1.1-2-x86_64.log ** Also affects: postler (Frugalware Linux) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
And now also works from the 0.12.x release. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
** Also affects: vala via https://bugzilla.gnome.org/show_bug.cgi?id=643010 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
** Changed in: vala Status: Unknown = Fix Released ** Changed in: vala Importance: Unknown = Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
The build works with Vala from git master now. However there's a grave bug with regard to unread messages, no idea what the problem is. So please refrain from using this to package Postler just yet. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
** Bug watch added: Red Hat Bugzilla #690954 https://bugzilla.redhat.com/show_bug.cgi?id=690954 ** Also affects: postler (Fedora) via https://bugzilla.redhat.com/show_bug.cgi?id=690954 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
I am getting the same error with vala 0.11.7: ../postler/postler-accounts.vala:69.44-69.44: error: Value must be constant And right after it: ../postler/postler-cellrenderertoggle.vala:40.47-40.55: error: Argument 2: Cannot pass value to reference or output parameter -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
Yes, Trash, Sent, Queue and friends. If you create a new account with the above change, those will not be recognised. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
Thank you Christian for your answer. I did it in order to compile Postler. But now, I'm intresting to understand! :) What is special folder recognition? Is one of Inbox, Trash etc... or something else? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
zedtux, thank you for the suggestion. I can confirm this allows Postler to build. Unfortunately you are removing a wrokaround for a bug that breaks special folder recognition. So we can't use this change however I will post this on the upstream bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
Hello all, I'm running Ubuntu natty alpha 3 (with all updates until today), and postler work after a very easy hack ;) I have modified the postler/postler-accounts.vala file like this: $ bzr diff === modified file 'postler/postler-accounts.vala' --- postler/postler-accounts.vala 2011-03-01 12:39:23 + +++ postler/postler-accounts.vala 2011-03-05 09:48:10 + @@ -68,13 +68,13 @@ index is taken in place of the enum value */ const MailFolder[] localized_folders = { { INBOX, STOCK_INBOX, N_(Inbox), null, 0, FolderType.INBOX, 0 }, -{ Sent, STOCK_SENT_MAIL, N_(Sent), sent_folders, sent_folders.length, FolderType.SENT, 1 }, -{ Drafts, null, N_(Drafts), drafts_folders, drafts_folders.length, FolderType.DRAFTS, 2 }, -{ Queue, STOCK_OUTBOX, N_(Outbox), queue_folders, queue_folders.length, FolderType.QUEUE, 3 }, -{ Trash, STOCK_USER_TRASH, N_(Trash), trash_folders, trash_folders.length, FolderType.TRASH, 4 }, -{ Archive, STOCK_ARCHIVE, N_(Archive), archive_folders, archive_folders.length, FolderType.ARCHIVE, 5 }, +{ Sent, STOCK_SENT_MAIL, N_(Sent), sent_folders, 0, FolderType.SENT, 1 }, +{ Drafts, null, N_(Drafts), drafts_folders, 0, FolderType.DRAFTS, 2 }, +{ Queue, STOCK_OUTBOX, N_(Outbox), queue_folders, 0, FolderType.QUEUE, 3 }, +{ Trash, STOCK_USER_TRASH, N_(Trash), trash_folders, 0, FolderType.TRASH, 4 }, +{ Archive, STOCK_ARCHIVE, N_(Archive), archive_folders, 0, FolderType.ARCHIVE, 5 }, /* i18n: Junk, unsolicited bulk mail, spam */ -{ null, null, N_(Junk), junk_folders, junk_folders.length, FolderType.JUNK, 6 }, +{ null, null, N_(Junk), junk_folders, 0, FolderType.JUNK, 6 }, { null, Gtk.STOCK_DIRECTORY, null, null, 0, FolderType.GENERIC, 7 } }; In short words, I have replaced all collection.length by 0 on the 5th position, and now compilation and installation work. I have try to use Postler, and it work with my Yahoo account. I've never used vala, and I did it quickly without searching what's the goal of those .length, but without it works! I hope this will help you to test postler ;) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 723282] Re: Building fails on postler-accounts.vala
** Also affects: vala (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/723282 Title: Building fails on postler-accounts.vala -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs