[Bug 981269] Re: instance_type is still set as a property value of "none" even when flavors cannot be retrieved
The Precise Pangolin has reached end of life, so this bug will not be fixed for that release ** Changed in: horizon (Ubuntu Precise) Status: In Progress => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of "none" even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
Yaguang/Chris I took a look at the proposed patch; currently its a partial backport of the fix applied to folsom; would it be possible to make it a more complete cherry pick including unit tests? This will make things easier in the long run. Thanks -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to horizon in Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
Un-subscribing sponsors for the time being; when ready for review, please re-subscribed ubuntu-sponsors. Thanks -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to horizon in Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
Yaguang/Chris I took a look at the proposed patch; currently its a partial backport of the fix applied to folsom; would it be possible to make it a more complete cherry pick including unit tests? This will make things easier in the long run. Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
Un-subscribing sponsors for the time being; when ready for review, please re-subscribed ubuntu-sponsors. Thanks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
** Tags removed: cts-cloud-review -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to horizon in Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
** Tags removed: cts-cloud-review -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
** Tags added: cts-cloud-review -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to horizon in Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
** Tags added: cts-cloud-review -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
Hi Yaguang Thanks for the patch; right at this moment the latest updates for Openstack Essex are pending processing in the SRU queue so we need to defer uploading this fix for a short while; once 12.04.2 gets out of the door things should free up again. I've un-subscribed ubuntu-sponsors for the time being and added myself. ** Also affects: horizon (Ubuntu) Importance: Undecided Status: New ** Changed in: horizon (Ubuntu) Status: New = Fix Released ** Changed in: horizon (Ubuntu) Importance: Undecided = Medium ** Changed in: horizon (Ubuntu Precise) Importance: Undecided = Medium ** No longer affects: openstack-dashboard (Ubuntu) ** No longer affects: openstack-dashboard (Ubuntu Precise) ** Changed in: horizon (Ubuntu Precise) Status: New = In Progress -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to horizon in Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
** Also affects: openstack-dashboard (Ubuntu Precise) Importance: Undecided Status: New ** Changed in: openstack-dashboard (Ubuntu Precise) Importance: Undecided = Medium ** Changed in: openstack-dashboard (Ubuntu Precise) Status: New = In Progress ** Changed in: openstack-dashboard (Ubuntu) Status: In Progress = Fix Released ** Changed in: openstack-dashboard (Ubuntu Precise) Assignee: (unassigned) = Yaguang Tang (heut2008) ** Changed in: openstack-dashboard (Ubuntu) Assignee: Yaguang Tang (heut2008) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
Hi Yaguang Thanks for the patch; right at this moment the latest updates for Openstack Essex are pending processing in the SRU queue so we need to defer uploading this fix for a short while; once 12.04.2 gets out of the door things should free up again. I've un-subscribed ubuntu-sponsors for the time being and added myself. ** Also affects: horizon (Ubuntu) Importance: Undecided Status: New ** Changed in: horizon (Ubuntu) Status: New = Fix Released ** Changed in: horizon (Ubuntu) Importance: Undecided = Medium ** Changed in: horizon (Ubuntu Precise) Importance: Undecided = Medium ** No longer affects: openstack-dashboard (Ubuntu) ** No longer affects: openstack-dashboard (Ubuntu Precise) ** Changed in: horizon (Ubuntu Precise) Status: New = In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
** Description changed: [Impact] - * horizon throw errors when view horizon/syspanel/instances/ page with deleted -flavor still in use by instances. + * horizon throw errors when view horizon/syspanel/instances/ page with deleted + flavor still in use by instances. - * try to get flavor info through the flavor.get api,this can retrive the deleted -flavor info. + * try to get flavor info through the flavor.get api,this can retrive the deleted + flavor info. [Test Case] - * Launch an instance of flavor m1.tiny -on controller node do: nova flavor-delete m1.tiny, and wait for it to succeed. -on horizon look at the state of the machines, http://horizon-system:port/horizon/ -syspanel/instances/ and wait for it to fail because horizon can not find the flavor -m1.tiny and therefore can not report the status and details of the instance in -question. + * Launch an instance of flavor m1.tiny + on controller node do: nova flavor-delete m1.tiny, and wait for it to succeed. + on horizon look at the state of the machines, http://horizon-system:port/horizon/ + syspanel/instances/ and wait for it to fail because horizon can not find the flavor + m1.tiny and therefore can not report the status and details of the instance in + question. [Regression Potential] - * This is a backport from upstream. + * This is a backport from upstream. - - - In Nova dashboard and Syspanel dashboard if the flavor of an instance cannot be retrieved the property .full_flavor will still be set to None. If there is no error retrieving flavors and a flavor has been deleted, this can cause a large traceback in the table rendering as get_size checks if the instance object hasattr() full_flavor instead of for the individual values to display in the Size column. + In Nova dashboard and Syspanel dashboard if the flavor of an instance + cannot be retrieved the property .full_flavor will still be set to + None. If there is no error retrieving flavors and a flavor has been + deleted, this can cause a large traceback in the table rendering as + get_size checks if the instance object hasattr() full_flavor instead + of for the individual values to display in the Size column. Attached is a potential fix. I have also included an alternate code path that will directly query the API for a flavor's information if it is not present in the full_flavors list(); this can occur if a flavor has been deleted as api.nova.flavors_list() only returns flavors that are not deleted. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
The above patch in #8 is an SRU request for Precise. ** Changed in: openstack-dashboard (Ubuntu) Assignee: (unassigned) = Yaguang Tang (heut2008) ** Changed in: openstack-dashboard (Ubuntu) Importance: Undecided = Medium ** Changed in: openstack-dashboard (Ubuntu) Status: New = In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
** Description changed: - In Nova dashboard and Syspanel dashboard if the flavor of an instance - cannot be retrieved the property .full_flavor will still be set to - None. If there is no error retrieving flavors and a flavor has been - deleted, this can cause a large traceback in the table rendering as - get_size checks if the instance object hasattr() full_flavor instead - of for the individual values to display in the Size column. + [Impact] + + * horizon throw errors when view horizon/syspanel/instances/ page with deleted +flavor still in use by instances. + + * try to get flavor info through the flavor.get api,this can retrive the deleted +flavor info. + + [Test Case] + + * Launch an instance of flavor m1.tiny +on controller node do: nova flavor-delete m1.tiny, and wait for it to succeed. +on horizon look at the state of the machines, http://horizon-system:port/horizon/ +syspanel/instances/ and wait for it to fail because horizon can not find the flavor +m1.tiny and therefore can not report the status and details of the instance in +question. + + [Regression Potential] + + * This is a backport from upstream. + + + + In Nova dashboard and Syspanel dashboard if the flavor of an instance cannot be retrieved the property .full_flavor will still be set to None. If there is no error retrieving flavors and a flavor has been deleted, this can cause a large traceback in the table rendering as get_size checks if the instance object hasattr() full_flavor instead of for the individual values to display in the Size column. Attached is a potential fix. I have also included an alternate code path that will directly query the API for a flavor's information if it is not present in the full_flavors list(); this can occur if a flavor has been deleted as api.nova.flavors_list() only returns flavors that are not deleted. ** Patch added: deleted-flavor-exception.patch https://bugs.launchpad.net/horizon/+bug/981269/+attachment/3483738/+files/deleted-flavor-exception.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
debdiff patch for this ** Patch added: deleted-flavor-exception.patch https://bugs.launchpad.net/horizon/+bug/981269/+attachment/3480045/+files/deleted-flavor-exception.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
the essex horizon cann't get the deleted flavor,this because nova api
can ony return deleted flavor info by using novaclient.flavors.get()
,novaclient.flavors.list() cann't get the deleted flavor info.
in the essex
full_flavors = SortedDict([(str(flavor.id), flavor)
for flavor in flavors])
for instance in instances:
flavor_id = instance.flavor[id]
instance.full_flavor = full_flavors[flavor_id]
except:
msg = _('Unable to retrieve instance size information.')
exceptions.handle(self.request, msg)
folsom
65
66 full_flavors = SortedDict([(f.id, f) for f in flavors])
67 tenant_dict = SortedDict([(t.id, t) for t in tenants])
68 # Loop through instances to get flavor and tenant info.
69 for inst in instances:
70 flavor_id = inst.flavor[id]
71 try:
72 if flavor_id in full_flavors:
73 inst.full_flavor = full_flavors[flavor_id]
74 else:
75 # If the flavor_id is not in full_flavors list,
76 # gets it via nova api.
77 inst.full_flavor = api.nova.flavor_get(
78 self.request, flavor_id)
backport this to stable/horizon
** Also affects: openstack-dashboard (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/981269
Title:
instance_type is still set as a property value of none even when
flavors cannot be retrieved
To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 981269] Re: instance_type is still set as a property value of none even when flavors cannot be retrieved
The attachment patch for handling deleted flavors of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report. [This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/981269 Title: instance_type is still set as a property value of none even when flavors cannot be retrieved To manage notifications about this bug go to: https://bugs.launchpad.net/horizon/+bug/981269/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
