Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

On Tue, Jul 19, 2016 at 05:56:28PM -, Rob Loach wrote:
> Thanks for taking a look, Jelmer. Do you have an idea of a way forward
> with it? William mentioned he was unsure of how to do it properly.
They are the equivalent of testaments, so ideally they should be
converted to those. I don't recall enough about testaments to know
whether that would actually work though.

Alternatively, they could just be stowed in bzr revision properties
and then reimported whenever bzr revisions are converted to git
commits.

Jelmer

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

Ignoring it will cause confusing import errors in incremental pulls for
Launchpad imports as well.

Incremental pulls rely on deltas against full texts recreated from bzr
data including PGP signatures. If even one byte in the full text is
incorrect, that causes incremental pulls to fail.

On 19 July 2016 02:08:31 GMT+02:00, Rob Loach <1084...@bugs.launchpad.net> 
wrote:
>Built ontop of wgrant's feedback, a new patch:
>http://files.robloach.net/bzr-git--gpg.diff
>
>While I understand the best way around this would be to implement the
>GPG signatures in bzr, but this is affecting many projects brought into
>Launchpad through bzr-git. Ignoring it may be the best option until we
>can implement it correctly in the bzr space.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

The cache could also be under the bzr repository somewhere.

On 16 June 2016 19:06:43 BST, Qwerty Chouskie  
wrote:
>I checked ~/.cache, but there was nothing bzr-related there.  I also
>checked ~/.bazzar/, but there was nothing cache-related there.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

It depends on your system. Usually $XDG_CACHE_HOME/bazaar/git I think.

On 16 June 2016 17:50:44 BST, Qwerty Chouskie  
wrote:
>Where is the cache?

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

Are you fetching into a new repository and have you removed the bzr-git
cache?

On 15 June 2016 01:24:10 BST, Qwerty Chouskie  
wrote:
>I made this patch:
>http://jacobspctuneup.tk/bzr-git%20patches/patchtry1.txt
>It looks good, but nothing actually appears in the terminal or
>"~/.bzr.log".  Maybe it only shows up if there is an error?

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

It will break deltas, as bzr-git won't be able to create the original
git object anymore from the bzr data. The object it creates will lack
the gpgsig tag and thus result in a checksum mismatch.

On 13 June 2016 21:29:38 BST, Qwerty Chouskie  
wrote:
>I saw comment #8, but it does not seem like ignoring gpgsig tags should
>break deltas, as the code changes in the commits are the same...

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

It will make things worse. People will get confusing errors (sha1
checksum or delta invalid exceptions), and bzr-git loses the ability to
properly support the gpgsig tag.

On 13 June 2016 22:16:19 BST, Qwerty Chouskie  
wrote:
>Also, the code change will defiantly not make anything worse, and might
>make things better, so it would make sense to merge it as a temporary
>fix...  And, I tested the first section of the diff
>(https://i264933589.restricted.launchpadlibrarian.net/264933589/8e33a154-3111-11e6-9da8-002481e91f22.txt?token=17TdjWddN9v0cBJKTTTsGgMmsb8NjTg8)
>and it worked for branching SuperTuxKart
>(https://github.com/supertuxkart/stk-code.git).

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

That fix is incomplete and possibly corrupts future pulls. See the bug
report for an explanation.

On 13 June 2016 03:45:52 BST, Qwerty Chouskie  
wrote:
>Just found this patched version:
>https://code.launchpad.net/~simon-marchi/bzr-git/devel
>Could this get merged please?  This bug breaks SuperTuxKart daily
>builds, see https://github.com/supertuxkart/stk-code/issues/1415
>towards end.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

Thanks for the replies.

At this point the issue is well documented; please don't add more
examples of broken repositories.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

On Tue, Nov 12, 2013 at 06:55:17PM -, Aron Xu wrote:
 Is there a way that can work around this bug and set up auto-import for
 a git repository that has some historical commits contain gpgsig? It
 seems that I'm not able to push to the branch set up by vcs-import, so
 fast-export/fast-import does not work for this use case.
Unfortunately that's not possible.

You should be able to sue fast-export/fast-import with a new (non-vcs-imports)
branch.

Cheers,

Jelmer

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Jelmer Vernooij]

On Sun, Nov 03, 2013 at 10:07:36AM -, Harald Sitter wrote:
 Making this non-fatal (on launchpad) would be rather helpful since as of
 a couple of days ago this is blocking KDE Frameworks 5 building [1].
 Upstream is less than thrilled.
 
 [1] https://code.launchpad.net/~neon/kde-workspace/master
 
 ** Attachment added: raw commit data of affected commit in kde-workspace

 https://bugs.launchpad.net/ubuntu/+source/bzr-git/+bug/1084403/+attachment/3899038/+files/commit
Unfortunately just ignoring these tags is not possible without
fundamentally breaking various assumptions in bzr-git.

bzr-git does a lossless conversion from git to bzr, so it can later
regenerate the exact same git objects. This is necessary since objects
sent by the server can be sent as deltas against fulltexts that the
server knows the client has.

If these tags are ignored, then bzr-git will be unable to reproduce
git commit objects with the exact same contents, and break.

Jelmer

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1084403] Re: no support for gpgsig tags

[Chris Halse Rogers]

Hm. Given I'm familiar with neither the bzr nor the git internals, that
might be a bit longer for me then.

Don't let me block you from working on it ☺.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1084403

Title:
  no support for gpgsig tags

To manage notifications about this bug go to:
https://bugs.launchpad.net/bzr-git/+bug/1084403/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs