Re: [Bug 1761997] Re: /var/run needs mode 777 in bionic

2018-12-10 Thread Brian Murray
On Sat, Dec 08, 2018 at 07:38:38PM -, Christophe R. Patraldo wrote:
> This still isn't working right, at least not for me. I'm trying to
> upgrade the release from 16.04 to 18.04 installed on Google Compute
> Engine. Is it a different bug or am I missing something?

The fixed version of screen is in the -updates pocket for Ubuntu 18.04.
Do you have -updates enabled for Ubuntu 16.04?

--
Brian Murray

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1761997

Title:
  /var/run needs mode 777 in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/screen/+bug/1761997/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1761997] Re: /var/run needs mode 777 in bionic

2018-07-26 Thread Mark Shuttleworth
\o/ thanks all, glad that one got in for the point release.

Mark

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1761997

Title:
  /var/run needs mode 777 in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/screen/+bug/1761997/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1761997] Re: /var/run needs mode 777 in bionic

2018-07-19 Thread Axel Beckert
Hi Brian,

Brian Murray wrote:
> Alex - I don't think that will work because when the new version of
> screen is unpacked the permissions are 755, so the check would need to
> be for 755, not 2755.

No. I said into _pre_inst, not postinst, so that everything is in
place and fixed when screen has been unpacked, but not configured.

Or did I understand your previous mail about screen in 16.04 being
2755?

Regards, Axel (not Alex)
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1761997

Title:
  /var/run needs mode 777 in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/screen/+bug/1761997/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1761997] Re: /var/run needs mode 777 in bionic

2018-07-19 Thread Axel Beckert
Hi,

Brian Murray wrote:
> Ah I think it (the tmpfile isn't created) because /usr/bin/screen is
> 2755 in Ubuntu 16.04 but 755 in Ubuntu 18.04. Here's the change between
> the two releases.

Ah! That's due to switching to use libutempter. We're getting quite
close to the issue.

I though wonder how to fix that for Bionic in the best way. Maybe
adding something like this to screen.preinst (not postinst):

perms="`stat -c%a /usr/bin/screen`"
override=/etc/tmpfiles.d/screen-cleanup.conf
if [ $perms -eq 2755 ]; then
chmod 0777 /var/run/screen
[ -f $override ] || echo 'd /var/run/screen 0777 root utmp' > $override

I assume that this is nothing which would make sense to add to future
releases of Debian's screen package, or does it?

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1761997

Title:
  /var/run needs mode 777 in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/screen/+bug/1761997/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1761997] Re: /var/run needs mode 777 in bionic

2018-07-19 Thread Axel Beckert
Hi Brian,

Brian Murray wrote:
> /run/screen has the following permissions
> 
> drwxrwxr-x  3 root  utmp60 Jul 19 06:06 screen

Thanks. This is indeed not the expected setting.

> screen-cleanup is a masked service in response to bug 1462692, so the
> permissions of /run/screen are never changed in Ubuntu 16.04.

Hrm, but 4.3.1-2build1 in 16.04 should also already have generated
/etc/tmpfiles.d/screen-cleanup.conf during postinst. (That was fixed
in the same upload as #1462692.)

And 16.04 already had systemd as default if not only init system.

> bdmurray@clean-xenial-amd64:~$ sudo service screen-cleanup status
> [sudo] password for bdmurray: 
> ● screen-cleanup.service
>Loaded: masked (/dev/null; bad)
>Active: inactive (dead)
> bdmurray@clean-xenial-amd64:~$ ls -lh 
> /lib/systemd/system/screen-cleanup.service
> lrwxrwxrwx 1 root root 9 Oct  4  2016 
> /lib/systemd/system/screen-cleanup.service -> /dev/null

Please also check the existence and contents of
/etc/tmpfiles.d/screen-cleanup.conf before and after upgrading.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1761997

Title:
  /var/run needs mode 777 in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/screen/+bug/1761997/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1761997] Re: /var/run needs mode 777 in bionic

2018-07-18 Thread Axel Beckert
Hi Brian,

Brian Murray wrote:
> + 2) rm /etc/cron.daily/mlocate (this'll ensure you get a conffile prompt)
> + 3) ssh to Ubuntu 16.04 system so the release upgrade is run in screen
> + 4) run do-release-upgrade -d
> + 5) wait for the conffile prompt from mlocate
> + 6) ssh to the Ubuntu 16.04 system being upgraded
> + 7) sudo -i
> + 8) run screen -rd
> + 
> + With the version of screen in the release pocket you'll receive the
> + following error:
> + 
> + root@clean-xenial-amd64:~# screen -rd
> + Directory '/run/screen' must have mode 777.

Thanks for the detailed explanations.

This sounds a little bit like screen being already unpacked, but not
yet configured. But there must be more than that…

Can you check what permissions /run/screen actually has at that point?

What I don't understand is: Since screen is already running at that
point, /run/screen should already exist with the proper permissions
from either /etc/tmpfiles.d/screen-cleanup.conf or from
/etc/init.d/screen-cleanup from 16.04's screen package. And according
to the changelog (in Debian at least), nothing in the maintainer
scripts changed between 4.3.1-2 and 4.6.2-1. And git log shows only
two commits since June 2015 (where /etc/tmpfiles.d/ support was
finalized), of which one just renames the files and the other one
replaces /var/run/ with /run/ — which both should be defacto noop with
regards to their logic.

Does any other package modify /run/'s permissions recursively during
dist-upgrade?

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1761997

Title:
  /var/run needs mode 777 in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/screen/+bug/1761997/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1761997] Re: /var/run needs mode 777 in bionic

2018-04-11 Thread Steve Langasek
On Wed, Apr 11, 2018 at 10:21:20AM -, Axel Beckert wrote:
> Steve Langasek wrote:
> > I believe this is a bug in screen.  The postinst script has code to
> > handle the changed requirements for /run/screen permissions, but then
> > immediately afterwards a debhelper code snippet runs which clobbers them
> > again.

> I currently don't see that clobbering, at least not in Debian:

> The maintainer-written code creates
> /etc/tmpfiles.d/screen-cleanup.conf in most cases.

> It also links /lib/systemd/system/screen-cleanup.service to /dev/null.

> debhelper-generated code seems to create
> /usr/lib/tmpfiles.d/screen-cleanup.conf — which is overridden by
> /etc/tmpfiles.d/screen-cleanup.conf if it exists.

Brian has also not been able to reproduce this behavior, and I haven't
reproduced it by installing the package, only by directly running the
command from the postinst which I believe would be run as part of the
upgrade.

I do have /etc/tmpfiles.d/screen-cleanup.conf and it is correct.  My
permissions for /run/screen on boot are correct.  But when I ran that
command, /etc/tmpfiles.d/screen-cleanup.conf seemed to have been ignored.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1761997

Title:
  /var/run needs mode 777 in bionic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/screen/+bug/1761997/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs