Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
What if you have an empty comment, or does it reject that? If it rejects it its probably a bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
On 27 April 2011 19:09, Brian Murray br...@ubuntu.com wrote: Well the api requires a comment when adding an attachment so it doesn't seem that there is a way to modify apport to prevent multiple email messages. Ah, see, here's the problem: Internally `comment` can be either a string or an IMessage, which is how we can theoretically have several attachments linked to one comment. In the declaration for IBug, we see: @operation_parameters( data=Bytes(constraint=attachment_size_constraint), comment=Text(), filename=TextLine(), is_patch=Bool(), content_type=TextLine(), description=Text()) @export_factory_operation(IBugAttachment, []) def addAttachment(owner, data, comment, filename, is_patch=False, content_type=None, description=None): So, the problem is that the API won't let you pass a message in to addAttachment(). If we want to change that we should probably track it elsewhere. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
Wouldn't hangling '' as the commentin the same way the 'add attachment' web form does be sane? Then the web form could be ajaxified too :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/424849 Title: Launchpad should batch attachment notification emails -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
Well, when there are many consecutive comments I have the impression that I get many consecutive e-mails? Is this wrong impression? The idea is that many comments sent in the same block of time don't result in many e-mails. I rarely see something batched. The most common is a status change following or followed by a comment, which result in only one e-mail for both actions. -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
On 6 June 2010 01:46, Deryck Hodge deryck.ho...@canonical.com wrote: Don't we batch in 5 minute (or some such) intervals now? Except for comments and attachments, of course. I thought that was the point of this bug, to enable batching for attachments. We batch in five minute intervals but comments mark the boundaries between batches, so if you make a bunch of changes and add a comment and then someone else makes a bunch of changes you'll get two separate notifications. Attachments cause problems because they each get their own comment, so we send out one notification per attachment. Otherwise our batching is quite sane at the moment. We *might* be able to move to five-minute digests when we've fixed all the Launchpad-fakes-email-addresses bugs. The easy fix to some of those bugs is to start to use $bu...@bugs.launchpad.net as the From address for notifications and if we do that we may be able to change notification emails to look like this: From: Bug $FOO $...@bugs.launchpad.net ... ** Graham Binns (gmb) made the following changes * In Ubuntu: * status Incomplete - Confirmed * Comment added: This new digest thing is the bomb isn't it? ** Deryck Hodge (deryck) made the following changes: * In Malone * status Incomplete - Fix Released * Comment added: Yeah, it's not bad. But I'm not yet convinced that there would be a massive reduction in bug mail traffic if we did that, or at least not a reduction directly related to the batching of attachment notifications. -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 424849] Re: Launchpad should batch attachment notification emails
On 4 June 2010 20:10, Leo leonardo.ro...@gmail.com wrote: Is it simpler to detect and batch attachments than just replacing on- the-fly notifications by 5-minute-interval digests? At this point, yes. The bug notification code (which can be found in lib/canonical/launchpad/mailnotification.py [1] for anyone who wants to take a look) is pretty ugly and is in sore need of refactoring. As part of that work we may look at how batching works and whether we need to do something different, but that's not the first thing on our list of priorities. This bug is causing a lot of noise, so it's better to fix this sooner rather than later. [1] http://bazaar.launchpad.net/~launchpad- pqm/launchpad/devel/files/head:/lib/canonical/launchpad/mailnotification.py -- Launchpad should batch attachment notification emails https://bugs.launchpad.net/bugs/424849 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
